[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2025-02-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #97 from Marcel de Rooy  ---
Thanks David.
Using my signoff now to pass QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2025-02-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

David Cook  changed:

   What|Removed |Added

 Attachment #177614|0   |1
is obsolete||

--- Comment #94 from David Cook  ---
Created attachment 177721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177721&action=edit
Bug 30975: Fix upload plugin

The upload plugin button has no 'buttonDot' class (unlike other plugins
buttons) so its click event were not listened to.
This patch fix the CSS selector in order to listen on click events for
all plugins buttons

Signed-off-by: Marcel de Rooy 
Signed-off-by: David Cook 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2025-02-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

David Cook  changed:

   What|Removed |Added

 Attachment #177616|0   |1
is obsolete||

--- Comment #96 from David Cook  ---
Created attachment 177723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177723&action=edit
Bug 30975: (QA follow-up) Improve copyright and author line

This fundamental improvement may well be reflected in those
lines.

Signed-off-by: Marcel de Rooy 
Signed-off-by: David Cook 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2025-02-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

David Cook  changed:

   What|Removed |Added

 Attachment #177615|0   |1
is obsolete||

--- Comment #95 from David Cook  ---
Created attachment 177722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177722&action=edit
Bug 30975: (QA follow-up) Fix for authorities and upload plugin

Authorities still needed a few tweaks for text2 (obscure name for
plugins).
Upload plugin does not have buttonDot 'mark'. Cloning was still
an issue. Not the most elegant solution but it works. We should
not have this exception for just another icon or so.

Signed-off-by: Marcel de Rooy 
Signed-off-by: David Cook 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2025-02-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

David Cook  changed:

   What|Removed |Added

 Attachment #177612|0   |1
is obsolete||

--- Comment #92 from David Cook  ---
Created attachment 177719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177719&action=edit
Bug 30975: Use event delegation for framework plugins

This is to avoid using private jQuery method _data.
Here's what jQuery 1.8.0 release notes says about it:
"this is not a supported public interface; the actual data structures
may change incompatibly from version to version."
So we should not rely on it.

What this patch does is use event delegation [1].
Events are bound to a parent container, so when elements are added
dynamically inside that container, we don't need to re-attach event
handlers manually

This patch also comes with a bit of cleanup, and introduce "breaking
changes" (they are breaking changes only if you happen to have custom
framework plugins):
1) 'mouseover', 'mousemove', 'keypress' events are no longer listened to
   'mouseover' and 'mousemove' are not used and would trigger too much
   events.
   'keypress' is also not used, and is deprecated
2) Event handlers now takes a single parameter that is an Event object
   It just makes the code a lot less complicated.
3) Event handlers do not pollute the global scope anymore

[1] https://learn.jquery.com/events/event-delegation/

Test plan:
- Go to every page that has a MARC editor and verify that plugins still
  work. This includes addbiblio.pl, additem.pl, authorities.pl,
  neworderempty.pl, orderreceive.pl
- Test plugins that use 'focus' event (for instance barcode.pl), 'blur'
  event (callnumber.pl) and 'click' event (almost all the others)
- Test that plugins work on cloned fields/subfields

Rebased-by: Victor Grousset/tuxayo 

Signed-off-by: Marcel de Rooy 
Signed-off-by: David Cook 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2025-02-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

David Cook  changed:

   What|Removed |Added

 Attachment #177613|0   |1
is obsolete||

--- Comment #93 from David Cook  ---
Created attachment 177720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177720&action=edit
Bug 30975: Fix framework plugins on acqui/neworderempty.pl

Test plan:
- Activate UseACQFrameworkForBiblioRecords
- Make sure you have an ACQ cataloguing framework that uses at least one
  plugin
- Create a new basket, create an order from 'new'
- Verify that framework plugins work

Signed-off-by: Marcel de Rooy 
Signed-off-by: David Cook 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2025-02-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

David Cook  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2025-02-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #91 from David Cook  ---
I'll take a look shortly especially on 'acquisition
(neworderempty/orderreceive) and batchmod'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2025-02-07 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #175437|0   |1
is obsolete||

--- Comment #87 from Marcel de Rooy  ---
Created attachment 177614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177614&action=edit
Bug 30975: Fix upload plugin

The upload plugin button has no 'buttonDot' class (unlike other plugins
buttons) so its click event were not listened to.
This patch fix the CSS selector in order to listen on click events for
all plugins buttons

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2025-02-07 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #90 from Marcel de Rooy  ---
This looks really good but I concentrated most on biblio (incl upload), items
and authorities.
I would like someone to still test acquisition (neworderempty/orderreceive) and
batchmod.

Victor, David or Martin: Could you add your signoff especially for the
mentioned areas? With that signoff I will pass QA.

We need to get this further now. It is waiting much too long..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2025-02-07 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #89 from Marcel de Rooy  ---
Created attachment 177616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177616&action=edit
Bug 30975: (QA follow-up) Improve copyright and author line

This fundamental improvement may well be reflected in those
lines.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2025-02-07 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #88 from Marcel de Rooy  ---
Created attachment 177615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177615&action=edit
Bug 30975: (QA follow-up) Fix for authorities and upload plugin

Authorities still needed a few tweaks for text2 (obscure name for
plugins).
Upload plugin does not have buttonDot 'mark'. Cloning was still
an issue. Not the most elegant solution but it works. We should
not have this exception for just another icon or so.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2025-02-07 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #175436|0   |1
is obsolete||

--- Comment #86 from Marcel de Rooy  ---
Created attachment 177613
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177613&action=edit
Bug 30975: Fix framework plugins on acqui/neworderempty.pl

Test plan:
- Activate UseACQFrameworkForBiblioRecords
- Make sure you have an ACQ cataloguing framework that uses at least one
  plugin
- Create a new basket, create an order from 'new'
- Verify that framework plugins work

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2025-02-07 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Marcel de Rooy  changed:

   What|Removed |Added

 Attachment #175435|0   |1
is obsolete||

--- Comment #85 from Marcel de Rooy  ---
Created attachment 177612
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177612&action=edit
Bug 30975: Use event delegation for framework plugins

This is to avoid using private jQuery method _data.
Here's what jQuery 1.8.0 release notes says about it:
"this is not a supported public interface; the actual data structures
may change incompatibly from version to version."
So we should not rely on it.

What this patch does is use event delegation [1].
Events are bound to a parent container, so when elements are added
dynamically inside that container, we don't need to re-attach event
handlers manually

This patch also comes with a bit of cleanup, and introduce "breaking
changes" (they are breaking changes only if you happen to have custom
framework plugins):
1) 'mouseover', 'mousemove', 'keypress' events are no longer listened to
   'mouseover' and 'mousemove' are not used and would trigger too much
   events.
   'keypress' is also not used, and is deprecated
2) Event handlers now takes a single parameter that is an Event object
   It just makes the code a lot less complicated.
3) Event handlers do not pollute the global scope anymore

[1] https://learn.jquery.com/events/event-delegation/

Test plan:
- Go to every page that has a MARC editor and verify that plugins still
  work. This includes addbiblio.pl, additem.pl, authorities.pl,
  neworderempty.pl, orderreceive.pl
- Test plugins that use 'focus' event (for instance barcode.pl), 'blur'
  event (callnumber.pl) and 'click' event (almost all the others)
- Test that plugins work on cloned fields/subfields

Rebased-by: Victor Grousset/tuxayo 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2025-02-07 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2025-02-07 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #84 from Marcel de Rooy  ---
(In reply to Julian Maurice from comment #83)
> (In reply to Victor Grousset/tuxayo from comment #82)
> > Is there something to test that will be fixed by these patches? Or is this
> > strictly a refactoring/cleanup?
> At the beginning this was about a bug but the bugfix was moved to bug 33744.
> Now only the refactoring remains.

Looking here again. We really should get this in now..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-12-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #83 from Julian Maurice  ---
(In reply to Victor Grousset/tuxayo from comment #82)
> Is there something to test that will be fixed by these patches? Or is this
> strictly a refactoring/cleanup?
At the beginning this was about a bug but the bugfix was moved to bug 33744.
Now only the refactoring remains.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-12-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #82 from Victor Grousset/tuxayo  ---
(In reply to Julian Maurice from comment #0)
> Since bug 29155 (Upgrade jquery version to 3.6.0) framework plugins do not
> work on a cloned field/subfield.
> [...] but it's possible it continued to work after that thanks to
> jQuery Migrate)

Is there something to test that will be fixed by these patches? Or is this
strictly a refactoring/cleanup?
It seems framework plugins did not work at some point but then they worked?

Or is there still a scenario where the jquery upgrade caused a regression?

On main. I found a field that had a plugin and both the original and a clone
worked.
Removing jquery migrate prevents the editor from loading so I couldn't go
further this way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #81 from Julian Maurice  ---
Patches rebased + fix added for upload plugin + reworded the first commit
message(In reply to Martin Renvoize (ashimema) from comment #74)

> Any more needed here?
It only needs a signoff now ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Julian Maurice  changed:

   What|Removed |Added

 Attachment #175434|0   |1
is obsolete||

--- Comment #80 from Julian Maurice  ---
Created attachment 175437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175437&action=edit
Bug 30975: Fix upload plugin

The upload plugin button has no 'buttonDot' class (unlike other plugins
buttons) so its click event were not listened to.
This patch fix the CSS selector in order to listen on click events for
all plugins buttons

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Julian Maurice  changed:

   What|Removed |Added

 Attachment #175433|0   |1
is obsolete||

--- Comment #79 from Julian Maurice  ---
Created attachment 175436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175436&action=edit
Bug 30975: Fix framework plugins on acqui/neworderempty.pl

Test plan:
- Activate UseACQFrameworkForBiblioRecords
- Make sure you have an ACQ cataloguing framework that uses at least one
  plugin
- Create a new basket, create an order from 'new'
- Verify that framework plugins work

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Julian Maurice  changed:

   What|Removed |Added

 Attachment #175432|0   |1
is obsolete||

--- Comment #78 from Julian Maurice  ---
Created attachment 175435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175435&action=edit
Bug 30975: Use event delegation for framework plugins

This is to avoid using private jQuery method _data.
Here's what jQuery 1.8.0 release notes says about it:
"this is not a supported public interface; the actual data structures
may change incompatibly from version to version."
So we should not rely on it.

What this patch does is use event delegation [1].
Events are bound to a parent container, so when elements are added
dynamically inside that container, we don't need to re-attach event
handlers manually

This patch also comes with a bit of cleanup, and introduce "breaking
changes" (they are breaking changes only if you happen to have custom
framework plugins):
1) 'mouseover', 'mousemove', 'keypress' events are no longer listened to
   'mouseover' and 'mousemove' are not used and would trigger too much
   events.
   'keypress' is also not used, and is deprecated
2) Event handlers now takes a single parameter that is an Event object
   It just makes the code a lot less complicated.
3) Event handlers do not pollute the global scope anymore

[1] https://learn.jquery.com/events/event-delegation/

Test plan:
- Go to every page that has a MARC editor and verify that plugins still
  work. This includes addbiblio.pl, additem.pl, authorities.pl,
  neworderempty.pl, orderreceive.pl
- Test plugins that use 'focus' event (for instance barcode.pl), 'blur'
  event (callnumber.pl) and 'click' event (almost all the others)
- Test that plugins work on cloned fields/subfields

Rebased-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #77 from Julian Maurice  ---
Created attachment 175434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175434&action=edit
Bug 30975: Fix upload plugin

The upload plugin button has no 'buttonDot' class (unlike other plugins
buttons) so its click event were not listened to.
This patch fix the CSS selector in order to listen on click events for
all plugins buttons

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Julian Maurice  changed:

   What|Removed |Added

 Attachment #171514|0   |1
is obsolete||

--- Comment #76 from Julian Maurice  ---
Created attachment 175433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175433&action=edit
Bug 30975: Fix framework plugins on acqui/neworderempty.pl

Test plan:
- Activate UseACQFrameworkForBiblioRecords
- Make sure you have an ACQ cataloguing framework that uses at least one
  plugin
- Create a new basket, create an order from 'new'
- Verify that framework plugins work

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Julian Maurice  changed:

   What|Removed |Added

 Attachment #171513|0   |1
is obsolete||

--- Comment #75 from Julian Maurice  ---
Created attachment 175432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175432&action=edit
Bug 30975: Fix framework plugins not working on cloned fields/subfields

Since bug 29155 (Upgrade jquery version to 3.6.0) framework plugins do
not work on a cloned field/subfield.
That is because we rely on jQuery's `.data('events')` to clone event
handlers to the cloned elements, and that was removed in jQuery 1.8.0
(I did not confirm but it's possible it continued to work after that
thanks to jQuery Migrate)

It is apparently still possible to access these event handlers by using
`jQuery._data(element, "events")` but here's what jQuery 1.8.0 release
notes says about it:
"this is not a supported public interface; the actual data structures
may change incompatibly from version to version."
So we should not rely on it.

Instead, what this patch does is use event delegation [1].
Events are bound to a parent container, so when elements are added
dynamically inside that container, we don't need to re-attach event
handlers manually

This patch also comes with a bit of cleanup, and introduce "breaking
changes" (they are breaking changes only if you happen to have custom
framework plugins):
1) 'mouseover', 'mousemove', 'keypress' events are no longer listened to
   'mouseover' and 'mousemove' are not used and would trigger too much
   events.
   'keypress' is also not used, and is deprecated
2) Event handlers now takes a single parameter that is an Event object
   It just makes the code a lot less complicated.
3) Event handlers do not pollute the global scope anymore

[1] https://learn.jquery.com/events/event-delegation/

Test plan:
- Go to every page that has a MARC editor and verify that plugins still
  work. This includes addbiblio.pl, additem.pl, authorities.pl,
  neworderempty.pl, orderreceive.pl
- Test plugins that use 'focus' event (for instance barcode.pl), 'blur'
  event (callnumber.pl) and 'click' event (almost all the others)
- Test that plugins work on cloned fields/subfields

Rebased-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-12-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #74 from Martin Renvoize (ashimema) 
 ---
Any more needed here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-10-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #73 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #72)
> A few quick observations:
> 
> 856$u Upload does not respond anymore
> 
> Had some issues with dateaccessioned and cloning it in the normal editor
> (unusual of course).

Ping Julian

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-10-18 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #72 from Marcel de Rooy  ---
A few quick observations:

856$u Upload does not respond anymore

Had some issues with dateaccessioned and cloning it in the normal editor
(unusual of course).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-10-18 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #71 from Marcel de Rooy  ---
Looking here now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-09-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #70 from Victor Grousset/tuxayo  ---
Rebase to fix a minor conflict

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-09-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #170500|0   |1
is obsolete||

--- Comment #69 from Victor Grousset/tuxayo  ---
Created attachment 171514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171514&action=edit
Bug 30975: Fix framework plugins on acqui/neworderempty.pl

Test plan:
- Activate UseACQFrameworkForBiblioRecords
- Make sure you have an ACQ cataloguing framework that uses at least one
  plugin
- Create a new basket, create an order from 'new'
- Verify that framework plugins work

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-09-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #170499|0   |1
is obsolete||

--- Comment #68 from Victor Grousset/tuxayo  ---
Created attachment 171513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171513&action=edit
Bug 30975: Fix framework plugins not working on cloned fields/subfields

Since bug 29155 (Upgrade jquery version to 3.6.0) framework plugins do
not work on a cloned field/subfield.
That is because we rely on jQuery's `.data('events')` to clone event
handlers to the cloned elements, and that was removed in jQuery 1.8.0
(I did not confirm but it's possible it continued to work after that
thanks to jQuery Migrate)

It is apparently still possible to access these event handlers by using
`jQuery._data(element, "events")` but here's what jQuery 1.8.0 release
notes says about it:
"this is not a supported public interface; the actual data structures
may change incompatibly from version to version."
So we should not rely on it.

Instead, what this patch does is use event delegation [1].
Events are bound to a parent container, so when elements are added
dynamically inside that container, we don't need to re-attach event
handlers manually

This patch also comes with a bit of cleanup, and introduce "breaking
changes" (they are breaking changes only if you happen to have custom
framework plugins):
1) 'mouseover', 'mousemove', 'keypress' events are no longer listened to
   'mouseover' and 'mousemove' are not used and would trigger too much
   events.
   'keypress' is also not used, and is deprecated
2) Event handlers now takes a single parameter that is an Event object
   It just makes the code a lot less complicated.
3) Event handlers do not pollute the global scope anymore

[1] https://learn.jquery.com/events/event-delegation/

Test plan:
- Go to every page that has a MARC editor and verify that plugins still
  work. This includes addbiblio.pl, additem.pl, authorities.pl,
  neworderempty.pl, orderreceive.pl
- Test plugins that use 'focus' event (for instance barcode.pl), 'blur'
  event (callnumber.pl) and 'click' event (almost all the others)
- Test that plugins work on cloned fields/subfields

Rebased-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-08-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #67 from Martin Renvoize  ---
Great to see this one rebased, thank Julian.

Hopefully Marcel will find a moment soon to give it a final QA stamp.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-08-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #66 from Julian Maurice  ---
Patch rebased + fix for comment 51
Back to NSO

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-08-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #65 from Julian Maurice  ---
Created attachment 170500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170500&action=edit
Bug 30975: Fix framework plugins on acqui/neworderempty.pl

Test plan:
- Activate UseACQFrameworkForBiblioRecords
- Make sure you have an ACQ cataloguing framework that uses at least one
  plugin
- Create a new basket, create an order from 'new'
- Verify that framework plugins work

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-08-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Julian Maurice  changed:

   What|Removed |Added

 Attachment #158064|0   |1
is obsolete||

--- Comment #64 from Julian Maurice  ---
Created attachment 170499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170499&action=edit
Bug 30975: Fix framework plugins not working on cloned fields/subfields

Since bug 29155 (Upgrade jquery version to 3.6.0) framework plugins do
not work on a cloned field/subfield.
That is because we rely on jQuery's `.data('events')` to clone event
handlers to the cloned elements, and that was removed in jQuery 1.8.0
(I did not confirm but it's possible it continued to work after that
thanks to jQuery Migrate)

It is apparently still possible to access these event handlers by using
`jQuery._data(element, "events")` but here's what jQuery 1.8.0 release
notes says about it:
"this is not a supported public interface; the actual data structures
may change incompatibly from version to version."
So we should not rely on it.

Instead, what this patch does is use event delegation [1].
Events are bound to a parent container, so when elements are added
dynamically inside that container, we don't need to re-attach event
handlers manually

This patch also comes with a bit of cleanup, and introduce "breaking
changes" (they are breaking changes only if you happen to have custom
framework plugins):
1) 'mouseover', 'mousemove', 'keypress' events are no longer listened to
   'mouseover' and 'mousemove' are not used and would trigger too much
   events.
   'keypress' is also not used, and is deprecated
2) Event handlers now takes a single parameter that is an Event object
   It just makes the code a lot less complicated.
3) Event handlers do not pollute the global scope anymore

[1] https://learn.jquery.com/events/event-delegation/

Test plan:
- Go to every page that has a MARC editor and verify that plugins still
  work. This includes addbiblio.pl, additem.pl, authorities.pl,
  neworderempty.pl, orderreceive.pl
- Test plugins that use 'focus' event (for instance barcode.pl), 'blur'
  event (callnumber.pl) and 'click' event (almost all the others)
- Test that plugins work on cloned fields/subfields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-05-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Koha collecto  changed:

   What|Removed |Added

 CC||k...@collecto.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #63 from Julian Maurice  ---
The bug found by Katrin in comment 51 needs to be fixed too

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #62 from Marcel de Rooy  ---
It needs a rebase from Julian. And my final QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #61 from Martin Renvoize  ---
I'm confused.. what's the current state of this.. what needs doing to get it
over the finish line?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2023-11-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #60 from Pablo López Liotti  ---
(In reply to Victor Grousset/tuxayo from comment #59)
> Hi :)
> 
> (In reply to Pablo López Liotti from comment #58)
> > This enhancemente will be most useful for many people. 
> 
> Here is the place to open a new ticket:
> https://bugs.koha-community.org/bugzilla3/enter_bug.cgi
> 
> Here is documentation about opening tickets, mostly centered on proper bugs
> (stuff broken) but still has some info about enhancements/new feature
> requests:
> https://wiki.koha-community.org/wiki/Bug_Reporting_Guidelines

Thks so much Victor.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2023-11-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #59 from Victor Grousset/tuxayo  ---
Hi :)

(In reply to Pablo López Liotti from comment #58)
> This enhancemente will be most useful for many people. 

Here is the place to open a new ticket:
https://bugs.koha-community.org/bugzilla3/enter_bug.cgi

Here is documentation about opening tickets, mostly centered on proper bugs
(stuff broken) but still has some info about enhancements/new feature requests:
https://wiki.koha-community.org/wiki/Bug_Reporting_Guidelines

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #58 from Pablo López Liotti  ---
(In reply to Katrin Fischer from comment #57)
> (In reply to Pablo López Liotti from comment #56)
> > Hi, i need use the callnumber.pl to auto-complete 952$o with 080$a and 092$a
> > marc fields to make a full item call number.
> > 
> > The ITEMCALLNUMBER syspref holds '080a,092a' value.
> > The 952$o subfield in BKS framework have plugin->callmunber.pl value.
> > I make a biblio record with 080$a = '025' and 092$a = 'T 345' values.
> > 
> > Executing additems.pl only it shows '025' in the form.
> > 
> > Any ideas?
> > 
> > Thks
> > Pablo
> 
> Hi Pablo, this bug is not related to your problem. When in doubt: ask on the
> mailing list or in the IRC chat first :) But: as stated in the system
> preference description, only the first field listed with a value will be
> used. So the preference is behaving as expected. You can currently not
> combine contents from different fields. You could file a new and separate
> enhancement request bug for this.

Thks Katrin, yes, I continued testing many times and understand that take only
a field. 
For the call number as we make (with 2 fields), don´t be useful. 
Maybe works for us if we put UDC in 080$a and complete call number (UDC +
Cutter for topographic) in 092$a. It´s a repetition but by the moment...
The other way is complete the item form in 952$o subfield.
As I understand many libraries (in Latin Américas at least) use that
combination . 
This enhancemente will be most useful for many people. 

Thks again, cheers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

--- Comment #57 from Katrin Fischer  ---
(In reply to Pablo López Liotti from comment #56)
> Hi, i need use the callnumber.pl to auto-complete 952$o with 080$a and 092$a
> marc fields to make a full item call number.
> 
> The ITEMCALLNUMBER syspref holds '080a,092a' value.
> The 952$o subfield in BKS framework have plugin->callmunber.pl value.
> I make a biblio record with 080$a = '025' and 092$a = 'T 345' values.
> 
> Executing additems.pl only it shows '025' in the form.
> 
> Any ideas?
> 
> Thks
> Pablo

Hi Pablo, this bug is not related to your problem. When in doubt: ask on the
mailing list or in the IRC chat first :) But: as stated in the system
preference description, only the first field listed with a value will be used.
So the preference is behaving as expected. You can currently not combine
contents from different fields. You could file a new and separate enhancement
request bug for this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2023-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Pablo López Liotti  changed:

   What|Removed |Added

 CC||palio...@mdp.edu.ar

--- Comment #56 from Pablo López Liotti  ---
Hi, i need use the callnumber.pl to auto-complete 952$o with 080$a and 092$a
marc fields to make a full item call number.

The ITEMCALLNUMBER syspref holds '080a,092a' value.
The 952$o subfield in BKS framework have plugin->callmunber.pl value.
I make a biblio record with 080$a = '025' and 092$a = 'T 345' values.

Executing additems.pl only it shows '025' in the form.

Any ideas?

Thks
Pablo

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2023-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 30975] Use event delegation for framework plugins to avoid using private jQuery method _data

2023-11-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30975

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Use event delegation for|Use event delegation for
   |framework plugins to avoid  |framework plugins to avoid
   |using private jQuery method |using private jQuery method
   ||_data

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/