[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Needs documenting CC||[email protected] ||m --- Comment #62 from Fridolin Somers --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Emily Lamancusa (emlam) changed: What|Removed |Added Blocks||35717 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35717 [Bug 35717] Link suggestions to orders by adding ordernumber to suggestions table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 --- Comment #61 from Paul Derscheid --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Paul Derscheid changed: What|Removed |Added Status|Pushed to main |Pushed to stable Version(s)|25.11.00|25.11.00,25.05.02 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Lucas Gass (lukeg) changed: What|Removed |Added Keywords|roadmap_24_11 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 --- Comment #60 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Lucas Gass (lukeg) changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Aleisha Amohia changed: What|Removed |Added Attachment #183335|0 |1 is obsolete|| --- Comment #54 from Aleisha Amohia --- Created attachment 183480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183480&action=edit Bug 31632: Link a suggestion to an existing order This enhancement allows library staff to link an order (in an unclosed basket, or a standing order) to an accepted suggestion. To test: 1) In the staff interface, go to Suggestions and create at least two suggestions. 2) Mark at least two suggestions as Accepted. 3) Go to Acquisitions, create a vendor if you don't have one already. 4) Have or create two baskets - one should be standing, and one not standing (normal). 5) In the normal basket (not standing), add an order from any source but NOT from a suggestion. 6) When you save the order, there should be a new link in the Modify column of the Orders table - "Search for suggestion to link". Click this. 7) Choose one of your suggestions to link to the order. 8) You should be redirected back to the basket. Confirm your order has been correctly linked to the suggestion. Confirm there is no link to "Search for suggestion to link" for this order now that a suggestion has already been linked. 9) Add another order to this basket from any source but NOT from a suggestion. 10) Close the basket. Confirm there is no link to "Search for suggestion to link" because the basket is closed, but you could reopen the basket to link the order if you wanted to. 11) Go to Baskets in the left navigation so you can find your standing basket. 12) Add an order to your standing basket from any source but NOT from a suggestion. 13) Go to the vendor and Receive shipments. Receive your standing order and finish receiving. 14) Go to the standing basket. There should be a new unreceived standing order for the record you just received, with a link to "Search for suggestion to link". Click this. 15) Choose a suggestion to link to the order. 16) You should be redirected back to the basket. Confirm your orders for this record have been correctly linked to the suggestion. Sponsored-by: Pymble Ladies' College Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste Henry Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 --- Comment #59 from Aleisha Amohia --- (In reply to Lucas Gass (lukeg) from comment #53) > Can the following files be tidied? > > [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt >FAIL tidiness > File is not tidy, please run `perl misc/devel/tidy.pl > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt` > [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt >FAIL tidiness > File is not tidy, please run `perl misc/devel/tidy.pl > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt` Done and set status back to Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Aleisha Amohia changed: What|Removed |Added Attachment #183338|0 |1 is obsolete|| --- Comment #57 from Aleisha Amohia --- Created attachment 183483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183483&action=edit Bug 31632: (QA follow-up) Adjust TT filters and remove extra form-submit.js Signed-off-by: Emily Lamancusa Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Aleisha Amohia changed: What|Removed |Added Attachment #183339|0 |1 is obsolete|| --- Comment #58 from Aleisha Amohia --- Created attachment 183484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183484&action=edit Bug 31632: (QA follow-up) Align behavior with order from suggestion If an order is added from a suggestion in the first place, the suggestion automatically changes status to ORDERED, and a notice is sent out to the patron. If a suggestion is linked to the order after the fact, it should move to ORDERED and notify the patron as well. Signed-off-by: Emily Lamancusa Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Aleisha Amohia changed: What|Removed |Added Attachment #183337|0 |1 is obsolete|| --- Comment #56 from Aleisha Amohia --- Created attachment 183482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183482&action=edit Bug 31632: (follow-up) CSRF protection for linking order to suggestion Signed-off-by: Andrew Fuerste Henry Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Aleisha Amohia changed: What|Removed |Added Attachment #183336|0 |1 is obsolete|| --- Comment #55 from Aleisha Amohia --- Created attachment 183481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183481&action=edit Bug 31632: (follow-up) Simplify link text Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste Henry Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Lucas Gass (lukeg) changed: What|Removed |Added Status|Passed QA |Failed QA CC||[email protected] --- Comment #53 from Lucas Gass (lukeg) --- Can the following files be tidied? [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt` [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Emily Lamancusa (emlam) changed: What|Removed |Added Attachment #179962|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Emily Lamancusa (emlam) changed: What|Removed |Added Status|Patch doesn't apply |Passed QA --- Comment #52 from Emily Lamancusa (emlam) --- Rebased for the current main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Emily Lamancusa (emlam) changed: What|Removed |Added Attachment #179961|0 |1 is obsolete|| --- Comment #51 from Emily Lamancusa (emlam) --- Created attachment 183339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183339&action=edit Bug 31632: (QA follow-up) Align behavior with order from suggestion If an order is added from a suggestion in the first place, the suggestion automatically changes status to ORDERED, and a notice is sent out to the patron. If a suggestion is linked to the order after the fact, it should move to ORDERED and notify the patron as well. Signed-off-by: Emily Lamancusa Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Emily Lamancusa (emlam) changed: What|Removed |Added Attachment #179958|0 |1 is obsolete|| --- Comment #48 from Emily Lamancusa (emlam) --- Created attachment 183336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183336&action=edit Bug 31632: (follow-up) Simplify link text Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste Henry Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Emily Lamancusa (emlam) changed: What|Removed |Added Attachment #179960|0 |1 is obsolete|| --- Comment #50 from Emily Lamancusa (emlam) --- Created attachment 183338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183338&action=edit Bug 31632: (QA follow-up) Adjust TT filters and remove extra form-submit.js Signed-off-by: Emily Lamancusa Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Emily Lamancusa (emlam) changed: What|Removed |Added Attachment #179959|0 |1 is obsolete|| --- Comment #49 from Emily Lamancusa (emlam) --- Created attachment 183337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183337&action=edit Bug 31632: (follow-up) CSRF protection for linking order to suggestion Signed-off-by: Andrew Fuerste Henry Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Emily Lamancusa (emlam) changed: What|Removed |Added Attachment #179957|0 |1 is obsolete|| --- Comment #47 from Emily Lamancusa (emlam) --- Created attachment 183335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183335&action=edit Bug 31632: Link a suggestion to an existing order This enhancement allows library staff to link an order (in an unclosed basket, or a standing order) to an accepted suggestion. To test: 1) In the staff interface, go to Suggestions and create at least two suggestions. 2) Mark at least two suggestions as Accepted. 3) Go to Acquisitions, create a vendor if you don't have one already. 4) Have or create two baskets - one should be standing, and one not standing (normal). 5) In the normal basket (not standing), add an order from any source but NOT from a suggestion. 6) When you save the order, there should be a new link in the Modify column of the Orders table - "Search for suggestion to link". Click this. 7) Choose one of your suggestions to link to the order. 8) You should be redirected back to the basket. Confirm your order has been correctly linked to the suggestion. Confirm there is no link to "Search for suggestion to link" for this order now that a suggestion has already been linked. 9) Add another order to this basket from any source but NOT from a suggestion. 10) Close the basket. Confirm there is no link to "Search for suggestion to link" because the basket is closed, but you could reopen the basket to link the order if you wanted to. 11) Go to Baskets in the left navigation so you can find your standing basket. 12) Add an order to your standing basket from any source but NOT from a suggestion. 13) Go to the vendor and Receive shipments. Receive your standing order and finish receiving. 14) Go to the standing basket. There should be a new unreceived standing order for the record you just received, with a link to "Search for suggestion to link". Click this. 15) Choose a suggestion to link to the order. 16) You should be redirected back to the basket. Confirm your orders for this record have been correctly linked to the suggestion. Sponsored-by: Pymble Ladies' College Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste Henry Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Katrin Fischer changed: What|Removed |Added Keywords|rel_25_05_candidate | --- Comment #46 from Katrin Fischer --- We are after hard feature freeze now, so removing the keyword. Hope to see this happening next cycle. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Patch doesn't apply Keywords||rel_25_05_candidate --- Comment #45 from Katrin Fischer --- (In reply to Katrin Fischer from comment #38) > I am sorry, but this didn't cleanly auto_rebase - can you please rebase and > send it back to my queue? I will get to it ASAP. Hi Aleisha, I am really sorry I failed to keep this promise. I wanted to have a quiet moment for testing this well... I guess you can tell it didn't quite work out. Now the patch sadly doesn't apply and all the whitespace changes in the first patch made it hard to resolve/see what needed to be added/changed. I hope it will be easier for someone who has worked on this before. I am adding rel_25_05_candidate which means this will still be considered after soft feature freeze. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #176282|0 |1 is obsolete|| --- Comment #43 from Nick Clemens (kidclamp) --- Created attachment 179961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179961&action=edit Bug 31632: (QA follow-up) Align behavior with order from suggestion If an order is added from a suggestion in the first place, the suggestion automatically changes status to ORDERED, and a notice is sent out to the patron. If a suggestion is linked to the order after the fact, it should move to ORDERED and notify the patron as well. Signed-off-by: Emily Lamancusa Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #175622|0 |1 is obsolete|| --- Comment #41 from Nick Clemens (kidclamp) --- Created attachment 179959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179959&action=edit Bug 31632: (follow-up) CSRF protection for linking order to suggestion Signed-off-by: Andrew Fuerste Henry Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #175620|0 |1 is obsolete|| --- Comment #39 from Nick Clemens (kidclamp) --- Created attachment 179957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179957&action=edit Bug 31632: Link a suggestion to an existing order This enhancement allows library staff to link an order (in an unclosed basket, or a standing order) to an accepted suggestion. To test: 1) In the staff interface, go to Suggestions and create at least two suggestions. 2) Mark at least two suggestions as Accepted. 3) Go to Acquisitions, create a vendor if you don't have one already. 4) Have or create two baskets - one should be standing, and one not standing (normal). 5) In the normal basket (not standing), add an order from any source but NOT from a suggestion. 6) When you save the order, there should be a new link in the Modify column of the Orders table - "Search for suggestion to link". Click this. 7) Choose one of your suggestions to link to the order. 8) You should be redirected back to the basket. Confirm your order has been correctly linked to the suggestion. Confirm there is no link to "Search for suggestion to link" for this order now that a suggestion has already been linked. 9) Add another order to this basket from any source but NOT from a suggestion. 10) Close the basket. Confirm there is no link to "Search for suggestion to link" because the basket is closed, but you could reopen the basket to link the order if you wanted to. 11) Go to Baskets in the left navigation so you can find your standing basket. 12) Add an order to your standing basket from any source but NOT from a suggestion. 13) Go to the vendor and Receive shipments. Receive your standing order and finish receiving. 14) Go to the standing basket. There should be a new unreceived standing order for the record you just received, with a link to "Search for suggestion to link". Click this. 15) Choose a suggestion to link to the order. 16) You should be redirected back to the basket. Confirm your orders for this record have been correctly linked to the suggestion. Sponsored-by: Pymble Ladies' College Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste Henry Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Nick Clemens (kidclamp) changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #175621|0 |1 is obsolete|| --- Comment #40 from Nick Clemens (kidclamp) --- Created attachment 179958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179958&action=edit Bug 31632: (follow-up) Simplify link text Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste Henry Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 --- Comment #44 from Nick Clemens (kidclamp) --- Created attachment 179962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179962&action=edit Bug 31632: (QA follow-up) Tidy after rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #176281|0 |1 is obsolete|| --- Comment #42 from Nick Clemens (kidclamp) --- Created attachment 179960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179960&action=edit Bug 31632: (QA follow-up) Adjust TT filters and remove extra form-submit.js Signed-off-by: Emily Lamancusa Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Patch doesn't apply --- Comment #38 from Katrin Fischer --- I am sorry, but this didn't cleanly auto_rebase - can you please rebase and send it back to my queue? I will get to it ASAP. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Emily Lamancusa (emlam) changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #37 from Emily Lamancusa (emlam) --- Thanks, Aleisha! Setting to PQA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Juliet Heltibridle changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 --- Comment #36 from Aleisha Amohia --- (In reply to Emily Lamancusa (emlam) from comment #32) > This generally looks good! > > Just one other thing - when an order is placed from a suggestion, the > suggestion is automatically marked as ORDERED and the patron is notified. > The same behavior should occur when a suggestion is linked to an order after > the fact, otherwise it will be confusing for staff and likely lead to > customers missing notifications. > > I went ahead and attached a follow-up patch for this, since it was trivial > to do while I had the existing code up anyway to check for any other > inconsistent behaviors. Aleisha, can you take a look at the last patch and > let me know if you agree with it? If so, I'm ready to mark this PQA Sorry it took a while for me to revisit this, Emily! Happy with your final two patches. Please PQA when you're ready. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Aleisha Amohia changed: What|Removed |Added Attachment #175624|0 |1 is obsolete|| --- Comment #35 from Aleisha Amohia --- Created attachment 176282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176282&action=edit Bug 31632: (QA follow-up) Align behavior with order from suggestion If an order is added from a suggestion in the first place, the suggestion automatically changes status to ORDERED, and a notice is sent out to the patron. If a suggestion is linked to the order after the fact, it should move to ORDERED and notify the patron as well. Signed-off-by: Emily Lamancusa Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Aleisha Amohia changed: What|Removed |Added Attachment #175623|0 |1 is obsolete|| --- Comment #34 from Aleisha Amohia --- Created attachment 176281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176281&action=edit Bug 31632: (QA follow-up) Adjust TT filters and remove extra form-submit.js Signed-off-by: Emily Lamancusa Signed-off-by: Aleisha Amohia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Emily Lamancusa (emlam) changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #33 from Emily Lamancusa (emlam) --- Setting FQA for feedback -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 --- Comment #32 from Emily Lamancusa (emlam) --- This generally looks good! Just one other thing - when an order is placed from a suggestion, the suggestion is automatically marked as ORDERED and the patron is notified. The same behavior should occur when a suggestion is linked to an order after the fact, otherwise it will be confusing for staff and likely lead to customers missing notifications. I went ahead and attached a follow-up patch for this, since it was trivial to do while I had the existing code up anyway to check for any other inconsistent behaviors. Aleisha, can you take a look at the last patch and let me know if you agree with it? If so, I'm ready to mark this PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 --- Comment #31 from Emily Lamancusa (emlam) --- Created attachment 175624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175624&action=edit Bug 31632: (QA follow-up) Align behavior with order from suggestion If an order is added from a suggestion in the first place, the suggestion automatically changes status to ORDERED, and a notice is sent out to the patron. If a suggestion is linked to the order after the fact, it should move to ORDERED and notify the patron as well. Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 --- Comment #30 from Emily Lamancusa (emlam) --- Created attachment 175623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175623&action=edit Bug 31632: (QA follow-up) Adjust TT filters and remove extra form-submit.js Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Emily Lamancusa (emlam) changed: What|Removed |Added Attachment #174416|0 |1 is obsolete|| --- Comment #28 from Emily Lamancusa (emlam) --- Created attachment 175621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175621&action=edit Bug 31632: (follow-up) Simplify link text Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste Henry Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Emily Lamancusa (emlam) changed: What|Removed |Added Attachment #174417|0 |1 is obsolete|| --- Comment #29 from Emily Lamancusa (emlam) --- Created attachment 175622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175622&action=edit Bug 31632: (follow-up) CSRF protection for linking order to suggestion Signed-off-by: Andrew Fuerste Henry Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Emily Lamancusa (emlam) changed: What|Removed |Added Attachment #174415|0 |1 is obsolete|| --- Comment #27 from Emily Lamancusa (emlam) --- Created attachment 175620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175620&action=edit Bug 31632: Link a suggestion to an existing order This enhancement allows library staff to link an order (in an unclosed basket, or a standing order) to an accepted suggestion. To test: 1) In the staff interface, go to Suggestions and create at least two suggestions. 2) Mark at least two suggestions as Accepted. 3) Go to Acquisitions, create a vendor if you don't have one already. 4) Have or create two baskets - one should be standing, and one not standing (normal). 5) In the normal basket (not standing), add an order from any source but NOT from a suggestion. 6) When you save the order, there should be a new link in the Modify column of the Orders table - "Search for suggestion to link". Click this. 7) Choose one of your suggestions to link to the order. 8) You should be redirected back to the basket. Confirm your order has been correctly linked to the suggestion. Confirm there is no link to "Search for suggestion to link" for this order now that a suggestion has already been linked. 9) Add another order to this basket from any source but NOT from a suggestion. 10) Close the basket. Confirm there is no link to "Search for suggestion to link" because the basket is closed, but you could reopen the basket to link the order if you wanted to. 11) Go to Baskets in the left navigation so you can find your standing basket. 12) Add an order to your standing basket from any source but NOT from a suggestion. 13) Go to the vendor and Receive shipments. Receive your standing order and finish receiving. 14) Go to the standing basket. There should be a new unreceived standing order for the record you just received, with a link to "Search for suggestion to link". Click this. 15) Choose a suggestion to link to the order. 16) You should be redirected back to the basket. Confirm your orders for this record have been correctly linked to the suggestion. Sponsored-by: Pymble Ladies' College Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste Henry Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #174395|0 |1 is obsolete|| --- Comment #26 from Andrew Fuerste-Henry --- Created attachment 174417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174417&action=edit Bug 31632: (follow-up) CSRF protection for linking order to suggestion Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #174394|0 |1 is obsolete|| --- Comment #25 from Andrew Fuerste-Henry --- Created attachment 174416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174416&action=edit Bug 31632: (follow-up) Simplify link text Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #174393|0 |1 is obsolete|| --- Comment #24 from Andrew Fuerste-Henry --- Created attachment 174415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174415&action=edit Bug 31632: Link a suggestion to an existing order This enhancement allows library staff to link an order (in an unclosed basket, or a standing order) to an accepted suggestion. To test: 1) In the staff interface, go to Suggestions and create at least two suggestions. 2) Mark at least two suggestions as Accepted. 3) Go to Acquisitions, create a vendor if you don't have one already. 4) Have or create two baskets - one should be standing, and one not standing (normal). 5) In the normal basket (not standing), add an order from any source but NOT from a suggestion. 6) When you save the order, there should be a new link in the Modify column of the Orders table - "Search for suggestion to link". Click this. 7) Choose one of your suggestions to link to the order. 8) You should be redirected back to the basket. Confirm your order has been correctly linked to the suggestion. Confirm there is no link to "Search for suggestion to link" for this order now that a suggestion has already been linked. 9) Add another order to this basket from any source but NOT from a suggestion. 10) Close the basket. Confirm there is no link to "Search for suggestion to link" because the basket is closed, but you could reopen the basket to link the order if you wanted to. 11) Go to Baskets in the left navigation so you can find your standing basket. 12) Add an order to your standing basket from any source but NOT from a suggestion. 13) Go to the vendor and Receive shipments. Receive your standing order and finish receiving. 14) Go to the standing basket. There should be a new unreceived standing order for the record you just received, with a link to "Search for suggestion to link". Click this. 15) Choose a suggestion to link to the order. 16) You should be redirected back to the basket. Confirm your orders for this record have been correctly linked to the suggestion. Sponsored-by: Pymble Ladies' College Signed-off-by: Tomas Cohen Arazi Signed-off-by: Andrew Fuerste Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Aleisha Amohia changed: What|Removed |Added Attachment #170148|0 |1 is obsolete|| --- Comment #22 from Aleisha Amohia --- Created attachment 174394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174394&action=edit Bug 31632: (follow-up) Simplify link text Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Aleisha Amohia changed: What|Removed |Added Attachment #170953|0 |1 is obsolete|| --- Comment #23 from Aleisha Amohia --- Created attachment 174395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174395&action=edit Bug 31632: (follow-up) CSRF protection for linking order to suggestion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Aleisha Amohia changed: What|Removed |Added Attachment #170147|0 |1 is obsolete|| --- Comment #21 from Aleisha Amohia --- Created attachment 174393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174393&action=edit Bug 31632: Link a suggestion to an existing order This enhancement allows library staff to link an order (in an unclosed basket, or a standing order) to an accepted suggestion. To test: 1) In the staff interface, go to Suggestions and create at least two suggestions. 2) Mark at least two suggestions as Accepted. 3) Go to Acquisitions, create a vendor if you don't have one already. 4) Have or create two baskets - one should be standing, and one not standing (normal). 5) In the normal basket (not standing), add an order from any source but NOT from a suggestion. 6) When you save the order, there should be a new link in the Modify column of the Orders table - "Search for suggestion to link". Click this. 7) Choose one of your suggestions to link to the order. 8) You should be redirected back to the basket. Confirm your order has been correctly linked to the suggestion. Confirm there is no link to "Search for suggestion to link" for this order now that a suggestion has already been linked. 9) Add another order to this basket from any source but NOT from a suggestion. 10) Close the basket. Confirm there is no link to "Search for suggestion to link" because the basket is closed, but you could reopen the basket to link the order if you wanted to. 11) Go to Baskets in the left navigation so you can find your standing basket. 12) Add an order to your standing basket from any source but NOT from a suggestion. 13) Go to the vendor and Receive shipments. Receive your standing order and finish receiving. 14) Go to the standing basket. There should be a new unreceived standing order for the record you just received, with a link to "Search for suggestion to link". Click this. 15) Choose a suggestion to link to the order. 16) You should be redirected back to the basket. Confirm your orders for this record have been correctly linked to the suggestion. Sponsored-by: Pymble Ladies' College Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Andrew Fuerste-Henry changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Martin Renvoize (ashimema) changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Keywords||roadmap_24_11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Bug 31632 depends on bug 36246, which changed state. Bug 36246 Summary: Have a centralized method for submitting a form via a link https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36246 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 --- Comment #20 from Aleisha Amohia --- (In reply to Jonathan Druart from comment #19) > There are already bug 28844 and bug 31632. Can you explain the direction of > this one please? This enhancement allows a library to link an order to a suggestion after the order is created. Useful if: - the librarian forgot to link to an existing suggestion - the librarian didn't know there was a suggestion at the time of creating the order and discovered it after - a user made a suggestion, not knowing the record was already on order It's just another way to have an order linked to a suggestion. I don't see it clashing with Bug 35717 at all. My patch wasn't intended to allow linking multiple suggestions to one order - Nick's might have been that, but mine went in a different direction. Hope that explains. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35717, ||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28844 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Jonathan Druart changed: What|Removed |Added CC||[email protected] --- Comment #19 from Jonathan Druart --- There are already bug 28844 and bug 31632. Can you explain the direction of this one please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 --- Comment #18 from Aleisha Amohia --- Created attachment 170953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170953&action=edit Bug 31632: (follow-up) CSRF protection for linking order to suggestion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff Depends on||36246 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36246 [Bug 36246] Have a centralized method for submitting a form via a link -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov Status|Signed Off |Failed QA QA Contact|[email protected] |emily.lamancusa@montgomeryc |y.org |ountymd.gov --- Comment #17 from Emily Lamancusa --- This is a really nice workflow! Just one thing - The link_order op needs to follow the CSRF protection coding guidelines, since it triggers an update action. Seems like a good use case for the form submission pattern in https://wiki.koha-community.org/wiki/Coding_Guidelines#JS16:_JavaScript_form_submission_via_links -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 --- Comment #16 from Aleisha Amohia --- (In reply to Tomás Cohen Arazi from comment #15) > Not a blocker, but I wonder what you didn't like about Nick's modal. And if > we could reintroduce it (here or on a follow-up). I honestly didn't look at it! I just saw that the patches were a couple of years old and figured it would've needed some reworking just because of that. I also had an approved plan by the sponsoring library, which is how my patch took its shape. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 --- Comment #15 from Tomás Cohen Arazi --- (In reply to Aleisha Amohia from comment #14) > (In reply to Tomás Cohen Arazi from comment #13) > > The behavior matches the description and seems correct. QA scripts happy. > > I would only change the link text to simplify it. Feel free to obsolete if > > disagree. > > Naming things is the hardest part! Happy with your amendment :) Not a blocker, but I wonder what you didn't like about Nick's modal. And if we could reintroduce it (here or on a follow-up). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 --- Comment #14 from Aleisha Amohia --- (In reply to Tomás Cohen Arazi from comment #13) > The behavior matches the description and seems correct. QA scripts happy. > I would only change the link text to simplify it. Feel free to obsolete if > disagree. Naming things is the hardest part! Happy with your amendment :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Tomás Cohen Arazi changed: What|Removed |Added CC||[email protected] --- Comment #13 from Tomás Cohen Arazi --- The behavior matches the description and seems correct. QA scripts happy. I would only change the link text to simplify it. Feel free to obsolete if disagree. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 170148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170148&action=edit Bug 31632: (follow-up) Simplify link text Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Tomás Cohen Arazi changed: What|Removed |Added Attachment #169391|0 |1 is obsolete|| --- Comment #11 from Tomás Cohen Arazi --- Created attachment 170147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170147&action=edit Bug 31632: Link a suggestion to an existing order This enhancement allows library staff to link an order (in an unclosed basket, or a standing order) to an accepted suggestion. To test: 1) In the staff interface, go to Suggestions and create at least two suggestions. 2) Mark at least two suggestions as Accepted. 3) Go to Acquisitions, create a vendor if you don't have one already. 4) Have or create two baskets - one should be standing, and one not standing (normal). 5) In the normal basket (not standing), add an order from any source but NOT from a suggestion. 6) When you save the order, there should be a new link in the Modify column of the Orders table - "Search for suggestion to link". Click this. 7) Choose one of your suggestions to link to the order. 8) You should be redirected back to the basket. Confirm your order has been correctly linked to the suggestion. Confirm there is no link to "Search for suggestion to link" for this order now that a suggestion has already been linked. 9) Add another order to this basket from any source but NOT from a suggestion. 10) Close the basket. Confirm there is no link to "Search for suggestion to link" because the basket is closed, but you could reopen the basket to link the order if you wanted to. 11) Go to Baskets in the left navigation so you can find your standing basket. 12) Add an order to your standing basket from any source but NOT from a suggestion. 13) Go to the vendor and Receive shipments. Receive your standing order and finish receiving. 14) Go to the standing basket. There should be a new unreceived standing order for the record you just received, with a link to "Search for suggestion to link". Click this. 15) Choose a suggestion to link to the order. 16) You should be redirected back to the basket. Confirm your orders for this record have been correctly linked to the suggestion. Sponsored-by: Pymble Ladies' College Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Aleisha Amohia changed: What|Removed |Added Assignee|[email protected] |[email protected] Text to go in the||This enhancement allows release notes||library staff to link an ||order (in an unclosed ||basket, or a standing ||order) to an accepted ||suggestion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Aleisha Amohia changed: What|Removed |Added Attachment #141028|0 |1 is obsolete|| Attachment #141029|0 |1 is obsolete|| Attachment #141030|0 |1 is obsolete|| --- Comment #10 from Aleisha Amohia --- Created attachment 169391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169391&action=edit Bug 31632: Link a suggestion to an existing order This enhancement allows library staff to link an order (in an unclosed basket, or a standing order) to an accepted suggestion. To test: 1) In the staff interface, go to Suggestions and create at least two suggestions. 2) Mark at least two suggestions as Accepted. 3) Go to Acquisitions, create a vendor if you don't have one already. 4) Have or create two baskets - one should be standing, and one not standing (normal). 5) In the normal basket (not standing), add an order from any source but NOT from a suggestion. 6) When you save the order, there should be a new link in the Modify column of the Orders table - "Search for suggestion to link". Click this. 7) Choose one of your suggestions to link to the order. 8) You should be redirected back to the basket. Confirm your order has been correctly linked to the suggestion. Confirm there is no link to "Search for suggestion to link" for this order now that a suggestion has already been linked. 9) Add another order to this basket from any source but NOT from a suggestion. 10) Close the basket. Confirm there is no link to "Search for suggestion to link" because the basket is closed, but you could reopen the basket to link the order if you wanted to. 11) Go to Baskets in the left navigation so you can find your standing basket. 12) Add an order to your standing basket from any source but NOT from a suggestion. 13) Go to the vendor and Receive shipments. Receive your standing order and finish receiving. 14) Go to the standing basket. There should be a new unreceived standing order for the record you just received, with a link to "Search for suggestion to link". Click this. 15) Choose a suggestion to link to the order. 16) You should be redirected back to the basket. Confirm your orders for this record have been correctly linked to the suggestion. Sponsored-by: Pymble Ladies' College -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Aleisha Amohia changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Katie Bliss changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Aleisha Amohia changed: What|Removed |Added CC||[email protected] --- Comment #9 from Aleisha Amohia --- *** Bug 35367 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Séverine Queune changed: What|Removed |Added CC||[email protected] ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Nick Clemens changed: What|Removed |Added Blocks||19358 --- Comment #8 from Nick Clemens --- (In reply to Katrin Fischer from comment #7) > Is this a (partial) duplicate of bug 19358? It's a step towards that one, adding depends/blocks Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19358 [Bug 19358] Purchase suggestions - enhancements to linking to orders -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 --- Comment #7 from Katrin Fischer --- Is this a (partial) duplicate of bug 19358? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 --- Comment #6 from Katrin Fischer --- (In reply to Nick Clemens from comment #5) > (In reply to Katrin Fischer from comment #1) > > +1 Having a direct link from suggestion to order would be great. > > This is really 'link to biblio' during ordering - maybe another bug to add > suggestion_id to aqorders table? I think it already exists, but couldn't find it. The current approach is problematic, because you might end up emailing the 'wrong' users. Also: We'd need suggestions.ordernumber, because you might have several people suggesting the same popular item at the same time, less likely to have multiple orders for one suggestion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 --- Comment #5 from Nick Clemens --- (In reply to Katrin Fischer from comment #1) > +1 Having a direct link from suggestion to order would be great. This is really 'link to biblio' during ordering - maybe another bug to add suggestion_id to aqorders table? Still need to cleanup and add to neworderempty - but attaching WIP to clarify -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 --- Comment #4 from Nick Clemens --- Created attachment 141030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141030&action=edit Bug 31632: Display multiple suggestions for record in basket In case suggestions are duplicated, allow several to be attached and display them all To test: 1 - Follow plan in previous patch to attach 2 suggestions when adding order 2 - Confirm both suggestions display after record added to basket -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 --- Comment #3 from Nick Clemens --- Created attachment 141029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141029&action=edit Bug 31632: Add ability to link orders to suggestions when adding to basket from a file This patch adds a new include for suggestions searching, and adds JS on the addorderiso2907 page to allow linking new orders to suggestions while importing into a basket To test: 1 - Export or find a file of bibs 2 - Stage the file using Tools->Stage MARC for Import 3 - Find or create an open basket in acquisitions 4 - Add to basket from the staged file 5 - Select/check a record 6 - Note new 'Suggestions' area 7 - Click 'Link suggestions' 8 - Search for suggestions - click 'Select' 9 - Select button is gone 10 - Dismiss modal 11 - Suggestion is listed for this record 12 - Click 'Link suggestions' 13 - Confirm the suggestion cannot be chosen again 14 - Add another 15 - Dismiss the modal 16 - Click 'Remove' on the first suggestion 17 - Confirm it is removed 18 - Confirm you can now link it again 19 - Select budget etc and submit 20 - Confirm record linked to suggestions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 --- Comment #2 from Nick Clemens --- Created attachment 141028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141028&action=edit Bug 31632: Add missing suggestion statuses to API -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 --- Comment #1 from Katrin Fischer --- +1 Having a direct link from suggestion to order would be great. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Nick Clemens changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31632] Add ability to manually link orders to suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31632 Katrin Fischer changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
