[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Blocks||41880 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41880 [Bug 41880] Logs for moved holds don't indicate original bib number/item number -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Sara Brown changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=41880 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Sara Brown changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=41879 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||41727 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41727 [Bug 41727] When moving a hold to a new biblio, allow selection of biblio via item barcode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Kimberly changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Text to go in the|This enhancement allows for |This enhancement allows for release notes|staff to move item level|staff to move item level |holds to new items and |holds to new items and |record level holds to new |record level holds to new |records. From the holds |records. From the holds |list page ( |list page ( |reserve/request.pl ) staff |reserve/request.pl ) staff |will now see the option to |will now see the option to |"Move selected holds" if|"Move selected holds" if |they have the |they have the |alter_hold_target |alter_hold_target |permission. When the button |permission. When the button |is clicked a modal will be |is clicked a modal will be |presented allowing staff to |presented allowing staff to |choose a new record target |choose a new record target |for record level holds or a |for record level holds or a |new item target for item|new item target for item |level holds. |level holds. | | |This patch also adds the|This patch also adds the |new permission that is |new permission that is |required to move holds, |required to move holds, |alter_hold_target. |alter_hold_target. || ||Sponsored by: Cuyahoga ||County Public Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Jessie Zairo changed: What|Removed |Added CC||[email protected] Comma delimited||Cuyahoga County Public list of Sponsors||Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Status|RESOLVED|Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Status|Pushed to main |RESOLVED Resolution|--- |FIXED --- Comment #128 from Lucas Gass (lukeg) --- (In reply to Anneli Österman from comment #127) > We'd be interested about the possibility of backporting this to 25.05 too. New features should not be backported. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Anneli Österman changed: What|Removed |Added CC||anneli.osterman@koha-suomi. ||fi --- Comment #127 from Anneli Österman --- We'd be interested about the possibility of backporting this to 25.05 too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||41124 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41124 [Bug 41124] Add search options for moving hold to new biblio record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Miranda Nero changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 [email protected] changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Text to go in the|*** Sponsored by Cuyahoga |This enhancement allows for release notes|County Public Library *** |staff to move item level ||holds to new items and ||record level holds to new ||records. From the holds ||list page ( ||reserve/request.pl ) staff ||will now see the option to ||"Move selected holds" if ||they have the ||alter_hold_target ||permission. When the button ||is clicked a modal will be ||presented allowing staff to ||choose a new record target ||for record level holds or a ||new item target for item ||level holds. || ||This patch also adds the ||new permission that is ||required to move holds, ||alter_hold_target. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #126 from Kristi Krueger --- This is great news! So happy to see this. Any chance for backports on this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #125 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #124 from Lucas Gass (lukeg) --- Created attachment 186247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186247&action=edit Bug 31698: Add alter_hold_targets to t/Koha/Auth/Permissions.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim changed: What|Removed |Added Attachment #186105|0 |1 is obsolete|| --- Comment #123 from Pedro Amorim --- Created attachment 186115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186115&action=edit Bug 31698: Make strings in holds.js translatable Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #121 from Lucas Gass (lukeg) --- Created attachment 186105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186105&action=edit Bug 31698: Make strings in holds.js translatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698
--- Comment #122 from Lucas Gass (lukeg) ---
(In reply to Pedro Amorim from comment #120)
> Hi Lucas:
> 1) I've added a follow-up. Please check if you agree.
> 2) Passing QA as all my observations were addressed (thank you!) and QA
> script is happy, however
> 3) Can you please ensure that all the new code in holds.js is translatable
> e.g.:
>
> $("#itemResultMessage").html(`
> No item found with barcode:
> ${externalID}.
> );
I agree with your follow-up, thanks! I have also supplied a follow to make the
string translatable.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim changed: What|Removed |Added Attachment #185771|0 |1 is obsolete|| --- Comment #112 from Pedro Amorim --- Created attachment 186091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186091&action=edit Bug 31698: Ensure searches for biblio records return only unique bibs Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim changed: What|Removed |Added Attachment #185767|0 |1 is obsolete|| --- Comment #108 from Pedro Amorim --- Created attachment 186087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186087&action=edit Bug 31698: Fix modals for item level moves Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim changed: What|Removed |Added Attachment #185768|0 |1 is obsolete|| --- Comment #109 from Pedro Amorim --- Created attachment 186088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186088&action=edit Bug 31698: Fix modals for biblio level moves Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698
--- Comment #120 from Pedro Amorim ---
Hi Lucas:
1) I've added a follow-up. Please check if you agree.
2) Passing QA as all my observations were addressed (thank you!) and QA script
is happy, however
3) Can you please ensure that all the new code in holds.js is translatable
e.g.:
$("#itemResultMessage").html(`
No item found with barcode:
${externalID}.
);
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #119 from Pedro Amorim --- Created attachment 186098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186098&action=edit Bug 31698: (QA follow-up): Prevent display 'NaN' UI error message If the input is not a number, display an appropriate error message. Additionally, don't make an API call unless the input is a number. Test by doing the following: 1) Step 19: Moving record level holds, the modal says 'Enter the biblionumber of new hold target', but if you enter 'xyz' and then search, the error shown is 'No item found with barcode: NaN'. This patch fixes that. Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim changed: What|Removed |Added Attachment #185834|0 |1 is obsolete|| --- Comment #118 from Pedro Amorim --- Created attachment 186097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186097&action=edit Bug 31698: Move reamining JS to hold.js Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim changed: What|Removed |Added Attachment #185776|0 |1 is obsolete|| --- Comment #117 from Pedro Amorim --- Created attachment 186096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186096&action=edit Bug 31698: Move request.tt JS to hold.js Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim changed: What|Removed |Added Attachment #185775|0 |1 is obsolete|| --- Comment #116 from Pedro Amorim --- Created attachment 186095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186095&action=edit Bug 31698: Report errors and failures back to request.tt Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim changed: What|Removed |Added Attachment #185774|0 |1 is obsolete|| --- Comment #115 from Pedro Amorim --- Created attachment 186094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186094&action=edit Bug 31698: Make searches return only exact matches for barcode/biblionumber Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim changed: What|Removed |Added Attachment #185773|0 |1 is obsolete|| --- Comment #114 from Pedro Amorim --- Created attachment 186093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186093&action=edit Bug 31698: Style move selected button and disable when nothing is selected Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim changed: What|Removed |Added Attachment #185772|0 |1 is obsolete|| --- Comment #113 from Pedro Amorim --- Created attachment 186092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186092&action=edit Bug 31698: (QA follow-up): Query biblios endpoint when searching biblios Instead of filtering response on the client. Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim changed: What|Removed |Added Attachment #185770|0 |1 is obsolete|| --- Comment #111 from Pedro Amorim --- Created attachment 186090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186090&action=edit Bug 31698: Disallow moving waiting or intransit holds Signed-off-by: kristi Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim changed: What|Removed |Added Attachment #185769|0 |1 is obsolete|| --- Comment #110 from Pedro Amorim --- Created attachment 186089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186089&action=edit Bug 31698: Add unit tests Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim changed: What|Removed |Added Attachment #185765|0 |1 is obsolete|| --- Comment #106 from Pedro Amorim --- Created attachment 186085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186085&action=edit Bug 31698: Add alter_hold_targets permission Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim changed: What|Removed |Added Attachment #185766|0 |1 is obsolete|| --- Comment #107 from Pedro Amorim --- Created attachment 186086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186086&action=edit Bug 31698: Add ability to move holds to new items or new records Test plan: 1. APPLY PATCH, updatedatabase, restart_all 2. Have two staff members. 1. Superlibrarian, 2. Staff with new permission to `alter_hold_targets` 3. Now place some holds on different record, you'll want some item level holds and some record level holds. 4. After placing some holds go to a record with some holds on it. 5. Go to the holds tab (reserve/request.p) 6. You should notice a disabled 'Move selected (0)' button, next to 'Cancel selected (0)' 7. Select some holds to move, ensure that the number updates accordingly. ( Move selected (2) ) 8. When you click the button you should see 2 options, 'Item level holds to a different item' and 'Record level holds to a different record' 9. Clicking on either should bring up a modal with information about the holds you selected to move. 10. If you have item level holds and you select 'Item level holds to a different item' those holds should appear pre-checked. 11. If you have item level holds and you select 'Record level holds to a different record' those holds checkboxes should be disabled by default, you should see the 'Problem' as 'Cannot move a waiting or record level hold' 12. If you are moving a item level hold you should see a searchbar labeled 'Enter the item barcode of new hold target:'. 13. Enter a full or partial barcode and click search 14. You should see your item, if it exists. 15. Check 'Move all selected item level holds to this item', once you do so the yellow 'Move selected holds' button should be enabled. 16. Click 'Move selected holds', the hold should be moved. 17. You should see a message like " Moved the following holds: Hold ID: 1854 - Moved from The Arden edition of the works of William Shakespeare. to The Arden edition of the works of William Shakespeare." 19. Do steps 12 - 17 again, but with a record level hold. 20. Now make or have many holds on a specific target record to test priority. Make note of the current priority 21. Now move a hold on to that record, testing both item and record level holds. 22. Now on the target record review the priority. The holds originally on the record should not have changed. The hold you move should now have the lowest priority on the record. 23. Check the original record, if a hold was moved all other priority should have been adjusted correctly. FOr example, if the hold you moved was 3 of 4 then the others should have adjusted priority of 1 2 3 now. 24. Turn on HoldsLog if it is disabled. 25. Move some holds, both item and record ones, and review the logs after each one. There should be a correct MODIFY entry for each move. 26. Make an item with a hold on it as damaged and turn on AllowHoldsOnDamagedItems. Try to move the hold, you should get an error telling you that the target item is damaged. 27. Now login as the non-superlibrarian patron from step 2. If they have the `alter_hold_targets` permission they should see the 'Move selected' button. 28. Revoke the `alter_hold_targets` permission. The button should not appear now. Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #105 from Lucas Gass (lukeg) --- Created attachment 185834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185834&action=edit Bug 31698: Move reamining JS to hold.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185763|0 |1 is obsolete|| --- Comment #104 from Lucas Gass (lukeg) --- Created attachment 185776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185776&action=edit Bug 31698: Move request.tt JS to hold.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185764|0 |1 is obsolete|| --- Comment #103 from Lucas Gass (lukeg) --- Created attachment 185775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185775&action=edit Bug 31698: Report errors and failures back to request.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185762|0 |1 is obsolete|| --- Comment #102 from Lucas Gass (lukeg) --- Created attachment 185774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185774&action=edit Bug 31698: Make searches return only exact matches for barcode/biblionumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185761|0 |1 is obsolete|| --- Comment #101 from Lucas Gass (lukeg) --- Created attachment 185773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185773&action=edit Bug 31698: Style move selected button and disable when nothing is selected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185760|0 |1 is obsolete|| --- Comment #100 from Lucas Gass (lukeg) --- Created attachment 185772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185772&action=edit Bug 31698: (QA follow-up): Query biblios endpoint when searching biblios Instead of filtering response on the client. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185759|0 |1 is obsolete|| --- Comment #99 from Lucas Gass (lukeg) --- Created attachment 185771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185771&action=edit Bug 31698: Ensure searches for biblio records return only unique bibs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185758|0 |1 is obsolete|| --- Comment #98 from Lucas Gass (lukeg) --- Created attachment 185770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185770&action=edit Bug 31698: Disallow moving waiting or intransit holds Signed-off-by: kristi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185757|0 |1 is obsolete|| --- Comment #97 from Lucas Gass (lukeg) --- Created attachment 185769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185769&action=edit Bug 31698: Add unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185756|0 |1 is obsolete|| --- Comment #96 from Lucas Gass (lukeg) --- Created attachment 185768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185768&action=edit Bug 31698: Fix modals for biblio level moves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185755|0 |1 is obsolete|| --- Comment #95 from Lucas Gass (lukeg) --- Created attachment 185767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185767&action=edit Bug 31698: Fix modals for item level moves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185754|0 |1 is obsolete|| --- Comment #94 from Lucas Gass (lukeg) --- Created attachment 185766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185766&action=edit Bug 31698: Add ability to move holds to new items or new records Test plan: 1. APPLY PATCH, updatedatabase, restart_all 2. Have two staff members. 1. Superlibrarian, 2. Staff with new permission to `alter_hold_targets` 3. Now place some holds on different record, you'll want some item level holds and some record level holds. 4. After placing some holds go to a record with some holds on it. 5. Go to the holds tab (reserve/request.p) 6. You should notice a disabled 'Move selected (0)' button, next to 'Cancel selected (0)' 7. Select some holds to move, ensure that the number updates accordingly. ( Move selected (2) ) 8. When you click the button you should see 2 options, 'Item level holds to a different item' and 'Record level holds to a different record' 9. Clicking on either should bring up a modal with information about the holds you selected to move. 10. If you have item level holds and you select 'Item level holds to a different item' those holds should appear pre-checked. 11. If you have item level holds and you select 'Record level holds to a different record' those holds checkboxes should be disabled by default, you should see the 'Problem' as 'Cannot move a waiting or record level hold' 12. If you are moving a item level hold you should see a searchbar labeled 'Enter the item barcode of new hold target:'. 13. Enter a full or partial barcode and click search 14. You should see your item, if it exists. 15. Check 'Move all selected item level holds to this item', once you do so the yellow 'Move selected holds' button should be enabled. 16. Click 'Move selected holds', the hold should be moved. 17. You should see a message like " Moved the following holds: Hold ID: 1854 - Moved from The Arden edition of the works of William Shakespeare. to The Arden edition of the works of William Shakespeare." 19. Do steps 12 - 17 again, but with a record level hold. 20. Now make or have many holds on a specific target record to test priority. Make note of the current priority 21. Now move a hold on to that record, testing both item and record level holds. 22. Now on the target record review the priority. The holds originally on the record should not have changed. The hold you move should now have the lowest priority on the record. 23. Check the original record, if a hold was moved all other priority should have been adjusted correctly. FOr example, if the hold you moved was 3 of 4 then the others should have adjusted priority of 1 2 3 now. 24. Turn on HoldsLog if it is disabled. 25. Move some holds, both item and record ones, and review the logs after each one. There should be a correct MODIFY entry for each move. 26. Make an item with a hold on it as damaged and turn on AllowHoldsOnDamagedItems. Try to move the hold, you should get an error telling you that the target item is damaged. 27. Now login as the non-superlibrarian patron from step 2. If they have the `alter_hold_targets` permission they should see the 'Move selected' button. 28. Revoke the `alter_hold_targets` permission. The button should not appear now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185753|0 |1 is obsolete|| --- Comment #93 from Lucas Gass (lukeg) --- Created attachment 185765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185765&action=edit Bug 31698: Add alter_hold_targets permission -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #92 from Lucas Gass (lukeg) --- Created attachment 185764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185764&action=edit Bug 31698: Report errors and failures back to request.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #179290|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #179290|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #91 from Lucas Gass (lukeg) --- Created attachment 185763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185763&action=edit Bug 31698: Move request.tt JS to hold.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185616|0 |1 is obsolete|| --- Comment #90 from Lucas Gass (lukeg) --- Created attachment 185762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185762&action=edit Bug 31698: Make searches return only exact matches for barcode/biblionumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185615|0 |1 is obsolete|| --- Comment #89 from Lucas Gass (lukeg) --- Created attachment 185761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185761&action=edit Bug 31698: Style move selected button and disable when nothing is selected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185614|0 |1 is obsolete|| --- Comment #88 from Lucas Gass (lukeg) --- Created attachment 185760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185760&action=edit Bug 31698: (QA follow-up): Query biblios endpoint when searching biblios Instead of filtering response on the client. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185613|0 |1 is obsolete|| --- Comment #87 from Lucas Gass (lukeg) --- Created attachment 185759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185759&action=edit Bug 31698: Ensure searches for biblio records return only unique bibs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185612|0 |1 is obsolete|| --- Comment #86 from Lucas Gass (lukeg) --- Created attachment 185758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185758&action=edit Bug 31698: Disallow moving waiting or intransit holds Signed-off-by: kristi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185611|0 |1 is obsolete|| --- Comment #85 from Lucas Gass (lukeg) --- Created attachment 185757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185757&action=edit Bug 31698: Add unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185610|0 |1 is obsolete|| --- Comment #84 from Lucas Gass (lukeg) --- Created attachment 185756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185756&action=edit Bug 31698: Fix modals for biblio level moves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185609|0 |1 is obsolete|| --- Comment #83 from Lucas Gass (lukeg) --- Created attachment 185755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185755&action=edit Bug 31698: Fix modals for item level moves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185608|0 |1 is obsolete|| --- Comment #82 from Lucas Gass (lukeg) --- Created attachment 185754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185754&action=edit Bug 31698: Add ability to move holds to new items or new records Test plan: 1. APPLY PATCH, updatedatabase, restart_all 2. Have two staff members. 1. Superlibrarian, 2. Staff with new permission to `alter_hold_targets` 3. Now place some holds on different record, you'll want some item level holds and some record level holds. 4. After placing some holds go to a record with some holds on it. 5. Go to the holds tab (reserve/request.p) 6. You should notice a disabled 'Move selected (0)' button, next to 'Cancel selected (0)' 7. Select some holds to move, ensure that the number updates accordingly. ( Move selected (2) ) 8. When you click the button you should see 2 options, 'Item level holds to a different item' and 'Record level holds to a different record' 9. Clicking on either should bring up a modal with information about the holds you selected to move. 10. If you have item level holds and you select 'Item level holds to a different item' those holds should appear pre-checked. 11. If you have item level holds and you select 'Record level holds to a different record' those holds checkboxes should be disabled by default, you should see the 'Problem' as 'Cannot move a waiting or record level hold' 12. If you are moving a item level hold you should see a searchbar labeled 'Enter the item barcode of new hold target:'. 13. Enter a full or partial barcode and click search 14. You should see your item, if it exists. 15. Check 'Move all selected item level holds to this item', once you do so the yellow 'Move selected holds' button should be enabled. 16. Click 'Move selected holds', the hold should be moved. 17. You should see a message like " Moved the following holds: Hold ID: 1854 - Moved from The Arden edition of the works of William Shakespeare. to The Arden edition of the works of William Shakespeare." 19. Do steps 12 - 17 again, but with a record level hold. 20. Now make or have many holds on a specific target record to test priority. Make note of the current priority 21. Now move a hold on to that record, testing both item and record level holds. 22. Now on the target record review the priority. The holds originally on the record should not have changed. The hold you move should now have the lowest priority on the record. 23. Check the original record, if a hold was moved all other priority should have been adjusted correctly. FOr example, if the hold you moved was 3 of 4 then the others should have adjusted priority of 1 2 3 now. 24. Turn on HoldsLog if it is disabled. 25. Move some holds, both item and record ones, and review the logs after each one. There should be a correct MODIFY entry for each move. 26. Make an item with a hold on it as damaged and turn on AllowHoldsOnDamagedItems. Try to move the hold, you should get an error telling you that the target item is damaged. 27. Now login as the non-superlibrarian patron from step 2. If they have the `alter_hold_targets` permission they should see the 'Move selected' button. 28. Revoke the `alter_hold_targets` permission. The button should not appear now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185607|0 |1 is obsolete|| --- Comment #81 from Lucas Gass (lukeg) --- Created attachment 185753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185753&action=edit Bug 31698: Add alter_hold_targets permission -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185066|0 |1 is obsolete|| --- Comment #73 from Lucas Gass (lukeg) --- Created attachment 185609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185609&action=edit Bug 31698: Fix modals for item level moves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185070|0 |1 is obsolete|| --- Comment #77 from Lucas Gass (lukeg) --- Created attachment 185613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185613&action=edit Bug 31698: Ensure searches for biblio records return only unique bibs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185380|0 |1 is obsolete|| --- Comment #80 from Lucas Gass (lukeg) --- Created attachment 185616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185616&action=edit Bug 31698: Make searches return only exact matches for barcode/biblionumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185121|0 |1 is obsolete|| --- Comment #78 from Lucas Gass (lukeg) --- Created attachment 185614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185614&action=edit Bug 31698: (QA follow-up): Query biblios endpoint when searching biblios Instead of filtering response on the client. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185379|0 |1 is obsolete|| --- Comment #79 from Lucas Gass (lukeg) --- Created attachment 185615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185615&action=edit Bug 31698: Style move selected button and disable when nothing is selected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185069|0 |1 is obsolete|| --- Comment #76 from Lucas Gass (lukeg) --- Created attachment 185612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185612&action=edit Bug 31698: Disallow moving waiting or intransit holds Signed-off-by: kristi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185068|0 |1 is obsolete|| --- Comment #75 from Lucas Gass (lukeg) --- Created attachment 185611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185611&action=edit Bug 31698: Add unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185067|0 |1 is obsolete|| --- Comment #74 from Lucas Gass (lukeg) --- Created attachment 185610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185610&action=edit Bug 31698: Fix modals for biblio level moves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185065|0 |1 is obsolete|| --- Comment #72 from Lucas Gass (lukeg) --- Created attachment 185608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185608&action=edit Bug 31698: Add ability to move holds to new items or new records Test plan: 1. APPLY PATCH, updatedatabase, restart_all 2. Have two staff members. 1. Superlibrarian, 2. Staff with new permission to `alter_hold_targets` 3. Now place some holds on different record, you'll want some item level holds and some record level holds. 4. After placing some holds go to a record with some holds on it. 5. Go to the holds tab (reserve/request.p) 6. You should notice a disabled 'Move selected (0)' button, next to 'Cancel selected (0)' 7. Select some holds to move, ensure that the number updates accordingly. ( Move selected (2) ) 8. When you click the button you should see 2 options, 'Item level holds to a different item' and 'Record level holds to a different record' 9. Clicking on either should bring up a modal with information about the holds you selected to move. 10. If you have item level holds and you select 'Item level holds to a different item' those holds should appear pre-checked. 11. If you have item level holds and you select 'Record level holds to a different record' those holds checkboxes should be disabled by default, you should see the 'Problem' as 'Cannot move a waiting or record level hold' 12. If you are moving a item level hold you should see a searchbar labeled 'Enter the item barcode of new hold target:'. 13. Enter a full or partial barcode and click search 14. You should see your item, if it exists. 15. Check 'Move all selected item level holds to this item', once you do so the yellow 'Move selected holds' button should be enabled. 16. Click 'Move selected holds', the hold should be moved. 17. You should see a message like " Moved the following holds: Hold ID: 1854 - Moved from The Arden edition of the works of William Shakespeare. to The Arden edition of the works of William Shakespeare." 19. Do steps 12 - 17 again, but with a record level hold. 20. Now make or have many holds on a specific target record to test priority. Make note of the current priority 21. Now move a hold on to that record, testing both item and record level holds. 22. Now on the target record review the priority. The holds originally on the record should not have changed. The hold you move should now have the lowest priority on the record. 23. Check the original record, if a hold was moved all other priority should have been adjusted correctly. FOr example, if the hold you moved was 3 of 4 then the others should have adjusted priority of 1 2 3 now. 24. Turn on HoldsLog if it is disabled. 25. Move some holds, both item and record ones, and review the logs after each one. There should be a correct MODIFY entry for each move. 26. Make an item with a hold on it as damaged and turn on AllowHoldsOnDamagedItems. Try to move the hold, you should get an error telling you that the target item is damaged. 27. Now login as the non-superlibrarian patron from step 2. If they have the `alter_hold_targets` permission they should see the 'Move selected' button. 28. Revoke the `alter_hold_targets` permission. The button should not appear now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185064|0 |1 is obsolete|| --- Comment #71 from Lucas Gass (lukeg) --- Created attachment 185607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185607&action=edit Bug 31698: Add alter_hold_targets permission -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #70 from Lucas Gass (lukeg) --- Created attachment 185380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185380&action=edit Bug 31698: Make searches return only exact matches for barcode/biblionumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #69 from Lucas Gass (lukeg) --- Created attachment 185379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185379&action=edit Bug 31698: Style move selected button and disable when nothing is selected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 David Cook changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #68 from Pedro Amorim --- Lucas I added a follow-up that implements your last patch differently, querying the biblios endpoint directly instead of using the items endpoint and then filtering on the client side. I've tested it myself to ensure it works, of course, but if my patch introduces issues or it's not worth it please feel free to obsolete! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #67 from Pedro Amorim --- Created attachment 185121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185121&action=edit Bug 31698: (QA follow-up): Query biblios endpoint when searching biblios Instead of filtering response on the client. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #66 from Pedro Amorim --- Hey all, nice feature! From my testing everything appears to be working nicely, but I have some comments: A) Step 6: The 'Move selected (0)' button is not disabled. It's styled differently to the 'Cancel selected (0)' button. It still expands options when clicked even if no holds are selected. My suggestion would be to style it the same as 'Cancel selected (0)' and not expand options if no holds are selected. Ideally using the 'disabled' CSS class but may be out of scope (?). B) Step 13: If you enter a partial barcode like '76', 20 hits are returned (I believe only limited by the default paging of 20 from the REST API). I don't know if this needs addressing or not, but I wonder if an exact match for barcode here makes more sense. C) Step 15: Clicking 'Move all selected item level holds to this item' does enable the 'Move selected holds' button and the checkbox column under the 'Review holds to move' is ticked by default. If you untick the latter, and keep the top 'Move all...' checkbox ticked, then click 'Move selected holds', the page redirects as if something happened, but no holds were moved (because none were selected, in the modal). My suggestion would be to have this button disabled if no 'holds to move' are ticked. D) Step 17: After moving the hold(s), it's nice that a message is shown 'Moved from X to Y', but the URL becomes '/cgi-bin/koha/reserve/request.pl'. This causes clicks on any of the links on the left side menu to result on a 404 (or 500) errors. My suggestion would be to have this URL '/cgi-bin/koha/reserve/request.pl?biblionumber=X' with the original record's biblionumber (the 'moved from' record). E) Step 19: Moving record level holds, the modal says 'Enter the biblionumber of new hold target', but if you enter 'xyz' and then search, the error shown is 'No item found with barcode: xyz'. This error message should refer to the biblionumber e.g. 'Biblionumber 'xyz' not found.' I think these are all very minor, with the exception perhaps of D) that I'd consider a bit more of a blocker. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #184750|0 |1 is obsolete|| --- Comment #65 from Lucas Gass (lukeg) --- Created attachment 185070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185070&action=edit Bug 31698: Ensure searches for biblio records return only unique bibs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #182639|0 |1 is obsolete|| --- Comment #64 from Lucas Gass (lukeg) --- Created attachment 185069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185069&action=edit Bug 31698: Disallow moving waiting or intransit holds Signed-off-by: kristi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #181961|0 |1 is obsolete|| --- Comment #63 from Lucas Gass (lukeg) --- Created attachment 185068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185068&action=edit Bug 31698: Add unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #181960|0 |1 is obsolete|| --- Comment #62 from Lucas Gass (lukeg) --- Created attachment 185067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185067&action=edit Bug 31698: Fix modals for biblio level moves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #181959|0 |1 is obsolete|| --- Comment #61 from Lucas Gass (lukeg) --- Created attachment 185066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185066&action=edit Bug 31698: Fix modals for item level moves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #181958|0 |1 is obsolete|| --- Comment #60 from Lucas Gass (lukeg) --- Created attachment 185065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185065&action=edit Bug 31698: Add ability to move holds to new items or new records Test plan: 1. APPLY PATCH, updatedatabase, restart_all 2. Have two staff members. 1. Superlibrarian, 2. Staff with new permission to `alter_hold_targets` 3. Now place some holds on different record, you'll want some item level holds and some record level holds. 4. After placing some holds go to a record with some holds on it. 5. Go to the holds tab (reserve/request.p) 6. You should notice a disabled 'Move selected (0)' button, next to 'Cancel selected (0)' 7. Select some holds to move, ensure that the number updates accordingly. ( Move selected (2) ) 8. When you click the button you should see 2 options, 'Item level holds to a different item' and 'Record level holds to a different record' 9. Clicking on either should bring up a modal with information about the holds you selected to move. 10. If you have item level holds and you select 'Item level holds to a different item' those holds should appear pre-checked. 11. If you have item level holds and you select 'Record level holds to a different record' those holds checkboxes should be disabled by default, you should see the 'Problem' as 'Cannot move a waiting or record level hold' 12. If you are moving a item level hold you should see a searchbar labeled 'Enter the item barcode of new hold target:'. 13. Enter a full or partial barcode and click search 14. You should see your item, if it exists. 15. Check 'Move all selected item level holds to this item', once you do so the yellow 'Move selected holds' button should be enabled. 16. Click 'Move selected holds', the hold should be moved. 17. You should see a message like " Moved the following holds: Hold ID: 1854 - Moved from The Arden edition of the works of William Shakespeare. to The Arden edition of the works of William Shakespeare." 19. Do steps 12 - 17 again, but with a record level hold. 20. Now make or have many holds on a specific target record to test priority. Make note of the current priority 21. Now move a hold on to that record, testing both item and record level holds. 22. Now on the target record review the priority. The holds originally on the record should not have changed. The hold you move should now have the lowest priority on the record. 23. Check the original record, if a hold was moved all other priority should have been adjusted correctly. FOr example, if the hold you moved was 3 of 4 then the others should have adjusted priority of 1 2 3 now. 24. Turn on HoldsLog if it is disabled. 25. Move some holds, both item and record ones, and review the logs after each one. There should be a correct MODIFY entry for each move. 26. Make an item with a hold on it as damaged and turn on AllowHoldsOnDamagedItems. Try to move the hold, you should get an error telling you that the target item is damaged. 27. Now login as the non-superlibrarian patron from step 2. If they have the `alter_hold_targets` permission they should see the 'Move selected' button. 28. Revoke the `alter_hold_targets` permission. The button should not appear now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #181957|0 |1 is obsolete|| --- Comment #59 from Lucas Gass (lukeg) --- Created attachment 185064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185064&action=edit Bug 31698: Add alter_hold_targets permission -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #185050|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #58 from Lucas Gass (lukeg) --- Created attachment 185050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185050&action=edit Bug 31698: Adjust number of tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Pedro Amorim changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org |k CC||[email protected] ||k Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #57 from Lucas Gass (lukeg) --- > Re: Step 26, I think this was supposed to be set AllowHoldsOnDamagedItems to > "don't allow" If this is correct, then the error message shows as expected > (see attached screenshot). If it is indeed supposed to be a turn on, that is > Allow for this system preference, there is no error message. Yes, this is a mistake in the test plan. > One final thing, sometimes on moving record level holds, it shows the > checkbox/"Move all selected record level holds..." message twice (see > attached RecordLevel_ListTwice.PNG) I didn't think this was big enough not > to sign off, but I wanted to call it out. I have added a patch that should fix this problem. Thanks for testing! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 --- Comment #56 from Lucas Gass (lukeg) --- Created attachment 184750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184750&action=edit Bug 31698: Ensure searches for biblio records return only unique bibs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Laura O'Neil changed: What|Removed |Added Text to go in the||*** Sponsored by Cuyahoga release notes||County Public Library *** CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 31698] Add ability to move a hold to a new bibliographic record/item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31698 Lucas Gass (lukeg) changed: What|Removed |Added Depends on|23269 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23269 [Bug 23269] Long hold queues are slowing the service -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
