[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 Arthur Suzuki changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=41768 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 Danyon Sewell changed: What|Removed |Added Resolution|--- |FIXED CC||[email protected] ||z Status|Pushed to stable|RESOLVED --- Comment #13 from Danyon Sewell --- Not backporting for 21.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 Lucas Gass changed: What|Removed |Added CC||[email protected] Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.14 released in|| --- Comment #12 from Lucas Gass --- Backported to 22.05.x for upcoming 22.05.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 --- Comment #11 from Matt Blenkinsop --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 Matt Blenkinsop changed: What|Removed |Added Version(s)|23.05.00|23.05.00,22.11.06 released in|| Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 --- Comment #10 from Tomás Cohen Arazi --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 --- Comment #9 from Katrin Fischer --- I tried to make the error messages a little more user friendly - please feel free to drop the patch if you don't like it! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 --- Comment #8 from Katrin Fischer --- Created attachment 150668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150668&action=edit Bug 33302: (QA follow-up) Rephrase errors to be more user friendly These error message will show within the patron account. The goal of this patch is to make them a little more user friendly avoiding 'patron' and 'hold group' terminology :) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 Katrin Fischer changed: What|Removed |Added Attachment #149123|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 150667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150667&action=edit Bug 33302: Send and display errors when a hold cannot be placed on the OPAC This patch changes opac-reserve.pl to return the error(s) when placing a hold as a pipe delimited list which is then translated to a message for the user To test: 1 - Find a record with items available on the opac 2 - Click 'place hold' and set things up, but do not confirm 3 - In staff client, do something to make hold invalid: - Make item damaged - Make library not a pickup location - Place other holds for patron up to limit - etc. 4 - Confirm hold on OPAC 5 - You are sent to patron's account, hold is not placed 6 - There is little or no message to explain why 7 - Apply patch 8 - Repeat 9 - Now errors are clear Signed-off-by: Andrew Auld Signed-off-by: Michaela Sieber Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 Katrin Fischer changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 --- Comment #6 from Nick Clemens --- (In reply to Katrin Fischer from comment #5) > This will need backporting - should it go in first? Yes, I made it block the other -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 --- Comment #5 from Katrin Fischer --- This will need backporting - should it go in first? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 Nick Clemens changed: What|Removed |Added Blocks||30860 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30860 [Bug 30860] Add option for CanBookBeReserved to return all item values -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #4 from Jonathan Druart --- Nick, this will conflict with bug 30860. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 ByWater Sandboxes changed: What|Removed |Added Attachment #148896|0 |1 is obsolete|| --- Comment #3 from ByWater Sandboxes --- Created attachment 149123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149123&action=edit Bug 33302: Send and display errors when a hold cannot be placed on the OPAC This patch changes opac-reserve.pl to return the error(s) when placing a hold as a pipe delimited list which is then translated to a message for the user To test: 1 - Find a record with items available on the opac 2 - Click 'place hold' and set things up, but do not confirm 3 - In staff client, do something to make hold invalid: - Make item damaged - Make library not a pickup location - Place other holds for patron up to limit - etc. 4 - Confirm hold on OPAC 5 - You are sent to patron's account, hold is not placed 6 - There is little or no message to explain why 7 - Apply patch 8 - Repeat 9 - Now errors are clear Signed-off-by: Andrew Auld Signed-off-by: Michaela Sieber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 Michaela Sieber changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 Andrew Auld changed: What|Removed |Added CC||[email protected] Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 Biblibre Sandboxes changed: What|Removed |Added Attachment #148813|0 |1 is obsolete|| --- Comment #2 from Biblibre Sandboxes --- Created attachment 148896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148896&action=edit Bug 33302: Send and display errors when a hold cannot be placed on the OPAC This patch changes opac-reserve.pl to return the error(s) when placing a hold as a pipe delimited list which is then translated to a message for the user To test: 1 - Find a record with items available on the opac 2 - Click 'place hold' and set things up, but do not confirm 3 - In staff client, do something to make hold invalid: - Make item damaged - Make library not a pickup location - Place other holds for patron up to limit - etc. 4 - Confirm hold on OPAC 5 - You are sent to patron's account, hold is not placed 6 - There is little or no message to explain why 7 - Apply patch 8 - Repeat 9 - Now errors are clear Signed-off-by: Andrew Auld -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 Nick Clemens changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org | CC||[email protected] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 --- Comment #1 from Nick Clemens --- Created attachment 148813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148813&action=edit Bug 33302: Send and display errors when a hold cannot be placed on the OPAC This patch changes opac-reserve.pl to return the error(s) when placing a hold as a pipe delimited list which is then translated to a message for the user To test: 1 - Find a record with items available on the opac 2 - Click 'place hold' and set things up, but do not confirm 3 - In staff client, do something to make hold invalid: - Make item damaged - Make library not a pickup location - Place other holds for patron up to limit - etc. 4 - Confirm hold on OPAC 5 - You are sent to patron's account, hold is not placed 6 - There is little or no message to explain why 7 - Apply patch 8 - Repeat 9 - Now errors are clear -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33302] Placing item level holds in OPAC allows to pick forbidden pick-up locations, but then places no hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33302 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
