[Koha-bugs] [Bug 34829] Cash register report reverts to "All libraries" after every search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34829 Laura Escamilla changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=39952 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34829] Cash register report reverts to "All libraries" after every search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34829
--- Comment #8 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #4)
> my $branch = $input->param("branch");
> my $manager_branchcode = $input->param("branch") ||
> C4::Context->userenv->{'branch'};
> This does not look good.
You added $branch here, but we already have $manager_branchcode using the same
CGI parameter. We should not do that. It will create confusion. If you need to
know the branch code passed, use the existing variable. Change that etc. Do not
clone it.
> And this looks bad:
> -All
> Script still has it:
> if ($manager_branchcode ne 'ALL') {
In the template you remove the ALL value of a combo box. You replace it by:
+All libraries
But the script still contains reference to the old value ALL. You should also
solve those references.
HTH
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34829] Cash register report reverts to "All libraries" after every search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34829 --- Comment #7 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #6) > I am not an expert programmer, I am happy to change things around, but I > need a little bit more insight in why you think something is wrong. I will try. Should not be very hard? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34829] Cash register report reverts to "All libraries" after every search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34829 --- Comment #6 from Katrin Fischer --- I am not an expert programmer, I am happy to change things around, but I need a little bit more insight in why you think something is wrong. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34829] Cash register report reverts to "All libraries" after every search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34829
--- Comment #5 from Katrin Fischer ---
(In reply to Marcel de Rooy from comment #4)
> my $branch = $input->param("branch");
> my $manager_branchcode = $input->param("branch") ||
> C4::Context->userenv->{'branch'};
> This does not look good.
I am sorry, but this is not constructive. Especially since I didn't change this
line. It only appears in the patch because of the perltidy.
>
>
> And this looks bad:
> -All
> Script still has it:
> if ($manager_branchcode ne 'ALL') {
Still, no explanation.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34829] Cash register report reverts to "All libraries" after every search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34829 Marcel de Rooy changed: What|Removed |Added Severity|trivial |minor QA Contact|[email protected] |[email protected] |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34829] Cash register report reverts to "All libraries" after every search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34829 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA CC||[email protected] --- Comment #4 from Marcel de Rooy --- my $branch = $input->param("branch"); my $manager_branchcode = $input->param("branch") || C4::Context->userenv->{'branch'}; This does not look good. And this looks bad: -All Script still has it: if ($manager_branchcode ne 'ALL') { -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34829] Cash register report reverts to "All libraries" after every search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34829 Katrin Fischer changed: What|Removed |Added Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34829] Cash register report reverts to "All libraries" after every search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34829 --- Comment #3 from Laura Escamilla --- Works as described! Thanks for the patch, Katrin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34829] Cash register report reverts to "All libraries" after every search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34829 Laura Escamilla changed: What|Removed |Added Attachment #155915|0 |1 is obsolete|| --- Comment #2 from Laura Escamilla --- Created attachment 155950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155950&action=edit Bug 34829: Cash register report reverts to 'All libraries' after every search To test: 1. Have at least two libraries (Library A & Library B) and at least two patrons. One patron for Library A & one for Library B. 2. Create a manual fee for both patrons and write them off. 3. Go to the cash register statistics report and change the transaction type to "Write off" and your transaction library to Library A. 4. Notice that when you submit the report the transaction library defaults back to "All" and shows both patrons instead of just the patron from Library A. 5. Apply patch 6. Verify that the library chosen now remains selected Note: the export format is faulty, but this is unrelated to this patch. Signed-off-by: Laura Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34829] Cash register report reverts to "All libraries" after every search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34829 Laura Escamilla changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34829] Cash register report reverts to "All libraries" after every search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34829 Katrin Fischer changed: What|Removed |Added Summary|Cash register report is |Cash register report |reverting to All Libraries |reverts to "All libraries" |when viewing the Writeoff |after every search |report | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
