[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 David Nind changed: What|Removed |Added Text to go in the||This enhancement adds an release notes||"Appear in position" field ||for patron attribute types. ||In the patron attribute ||types table, there is a new ||column, "Display order". || ||This lets you set the order ||that patron attributes ||appear on the patron add ||and edit forms, including ||self-registration. || ||Before this, patron ||attributes were sorted by ||the patron attribute type ||code. --- Comment #94 from David Nind --- Just a small thing, but on the edit form the field is labelled "Appear in position", but for the patron attribute types table the column header is "Display order". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #93 from David Nind --- Created attachment 192660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192660&action=edit Bug 35145: Fix patron attribute type ordering Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #92 from David Nind --- Created attachment 192659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192659&action=edit Bug 35145: (follow-up) Corrected pattern for adding a column Corrected the pattern to add a column in the update file. Signed-off-by: David Nind Signed-off-by: Laura_Escamilla Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #91 from David Nind --- Created attachment 192658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192658&action=edit Bug 35145: (follow-up) Tidy DBUpdate Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Laura_Escamilla Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #90 from David Nind --- Created attachment 192657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192657&action=edit Bug 35145: Added missing import Added missing import Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Laura_Escamilla Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #89 from David Nind --- Created attachment 192656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192656&action=edit Bug 35145: Add ability to order patron attribute types Here is a summary of the changes: - Added the new column 'display_order' to 'borrower_attribute_types' table ---> Created an atomic update file (bug_35145_order_patron_attributes.pl) ---> Updated the kohastructure.sql file - Added the new column 'Display order' for '/cgi-bin/koha/admin/patron-attr-types.pl' table ---> The table now defaults to sorting based on the 'display_order' column - Added the field 'Appear in position' in the patron attribute types create/edit form - Changed the order of patron attribute types in the patron create/edit form (OPAC and staff interfcce) so it's now sorted by the assigned display_order TEST PLAN 1) Go to 'Koha administration > Patron attribute types > + New patron attribute type' 2) Fill out the form ---> Code: Enter any code, for example 'WEIGHT' ---> Description: Enter any description ---> Display in OPAC: Check ---> Editable in OPAC: Check ---> Class: Keep it empty 3) Click 'Save' 4) Repeat to add a second code with a code alphabetically before the previous one, for example SURNAME 5) Optionally, add more to really view the order 6) Go to 'Koha administration > System preferences' 7) Search for 'selfreg' 8) Set 'PatronSelfRegistration' to 'Allow' 9) Set a category in 'PatronSelfRegistrationDefaultCategory' 10) Click on the 'Save all OPAC preferences' button 11) Go to the OPAC and click on the 'Create an account' button 12) Go to the bottom of the form ---> Note that the patron attribute fields are presented in alphabetical order of code 13) Apply the patch 14) Perform an atomic update (./installer/data/mysql/updatedatabase.pl) 15) Return to 'Koha administration > Patron attribute types' ---> Notice the new 'Display order' column in the tables 16) Choose one of the attribute types you created earlier and click on the 'edit' button ---> You should now see the 'Appear in position' field 17) Enter a number in the 'Appear in position' field and click on 'Save' 18) Repeat the last two steps for each attribute type you created ---> Notice that the patron attribute types tables are sorted by display_order by default 19) In the staff interface, go to 'Patrons > + New patron' ---> In the 'Additional attributes and identifiers' section, notice that the fields are in the given number order 20) In the OPAC, return to the patron creation form (step 11) ---> At the end of the form, notice that the fields are in the given number order Signed-off-by: Anneli Österman Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Laura_Escamilla Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #88 from David Nind --- Created attachment 192655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192655&action=edit Bug 35145: Database updates Signed-off-by: Anneli Österman Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Laura_Escamilla Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #87 from David Nind --- Created attachment 192654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192654&action=edit Bug 35145: Schema file Signed-off-by: Anneli Österman Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Laura_Escamilla Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 David Nind changed: What|Removed |Added Attachment #192411|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 David Nind changed: What|Removed |Added Attachment #192410|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 David Nind changed: What|Removed |Added Attachment #192409|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 David Nind changed: What|Removed |Added Attachment #192408|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 David Nind changed: What|Removed |Added Attachment #192407|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 David Nind changed: What|Removed |Added Attachment #192406|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 David Nind changed: What|Removed |Added Attachment #192405|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #86 from Ayoub Glizi-Vicioso --- Created attachment 192411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192411&action=edit Bug 35145: Fix patron attribute type ordering -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Ayoub Glizi-Vicioso changed: What|Removed |Added Attachment #192404|0 |1 is obsolete|| --- Comment #85 from Ayoub Glizi-Vicioso --- Created attachment 192410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192410&action=edit Bug 35145: (follow-up) Corrected pattern for adding a column Corrected the pattern to add a column in the update file. Signed-off-by: David Nind Signed-off-by: Laura_Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Ayoub Glizi-Vicioso changed: What|Removed |Added Attachment #192403|0 |1 is obsolete|| --- Comment #84 from Ayoub Glizi-Vicioso --- Created attachment 192409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192409&action=edit Bug 35145: (follow-up) Tidy DBUpdate Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Laura_Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Ayoub Glizi-Vicioso changed: What|Removed |Added Attachment #192402|0 |1 is obsolete|| --- Comment #83 from Ayoub Glizi-Vicioso --- Created attachment 192408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192408&action=edit Bug 35145: Added missing import Added missing import Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Laura_Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Ayoub Glizi-Vicioso changed: What|Removed |Added Attachment #192401|0 |1 is obsolete|| --- Comment #82 from Ayoub Glizi-Vicioso --- Created attachment 192407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192407&action=edit Bug 35145: Add ability to order patron attribute types Here is a summary of the changes: - Added the new column 'display_order' to 'borrower_attribute_types' table ---> Created an atomic update file (bug_35145_order_patron_attributes.pl) ---> Updated the kohastructure.sql file - Added the new column 'Display order' for '/cgi-bin/koha/admin/patron-attr-types.pl' table ---> The table now defaults to sorting based on the 'display_order' column - Added the field 'Appear in position' in the patron attribute types create/edit form - Changed the order of patron attribute types in the patron create/edit form (OPAC and staff interfcce) so it's now sorted by the assigned display_order TEST PLAN 1) Go to 'Koha administration > Patron attribute types > + New patron attribute type' 2) Fill out the form ---> Code: Enter any code, for example 'WEIGHT' ---> Description: Enter any description ---> Display in OPAC: Check ---> Editable in OPAC: Check ---> Class: Keep it empty 3) Click 'Save' 4) Repeat to add a second code with a code alphabetically before the previous one, for example SURNAME 5) Optionally, add more to really view the order 6) Go to 'Koha administration > System preferences' 7) Search for 'selfreg' 8) Set 'PatronSelfRegistration' to 'Allow' 9) Set a category in 'PatronSelfRegistrationDefaultCategory' 10) Click on the 'Save all OPAC preferences' button 11) Go to the OPAC and click on the 'Create an account' button 12) Go to the bottom of the form ---> Note that the patron attribute fields are presented in alphabetical order of code 13) Apply the patch 14) Perform an atomic update (./installer/data/mysql/updatedatabase.pl) 15) Return to 'Koha administration > Patron attribute types' ---> Notice the new 'Display order' column in the tables 16) Choose one of the attribute types you created earlier and click on the 'edit' button ---> You should now see the 'Appear in position' field 17) Enter a number in the 'Appear in position' field and click on 'Save' 18) Repeat the last two steps for each attribute type you created ---> Notice that the patron attribute types tables are sorted by display_order by default 19) In the staff interface, go to 'Patrons > + New patron' ---> In the 'Additional attributes and identifiers' section, notice that the fields are in the given number order 20) In the OPAC, return to the patron creation form (step 11) ---> At the end of the form, notice that the fields are in the given number order Signed-off-by: Anneli Österman Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Laura_Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Ayoub Glizi-Vicioso changed: What|Removed |Added Attachment #192400|0 |1 is obsolete|| --- Comment #81 from Ayoub Glizi-Vicioso --- Created attachment 192406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192406&action=edit Bug 35145: Database updates Signed-off-by: Anneli Österman Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Laura_Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Ayoub Glizi-Vicioso changed: What|Removed |Added Attachment #192399|0 |1 is obsolete|| --- Comment #80 from Ayoub Glizi-Vicioso --- Created attachment 192405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192405&action=edit Bug 35145: Schema file Fix attribute display order Signed-off-by: Anneli Österman Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Laura_Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Ayoub Glizi-Vicioso changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Ayoub Glizi-Vicioso changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||ayoub.glizi-vicioso@inLibro ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Ayoub Glizi-Vicioso changed: What|Removed |Added Attachment #189177|0 |1 is obsolete|| --- Comment #79 from Ayoub Glizi-Vicioso --- Created attachment 192404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192404&action=edit Bug 35145: (follow-up) Corrected pattern for adding a column Corrected the pattern to add a column in the update file. Signed-off-by: David Nind Signed-off-by: Laura_Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Ayoub Glizi-Vicioso changed: What|Removed |Added Attachment #189176|0 |1 is obsolete|| --- Comment #78 from Ayoub Glizi-Vicioso --- Created attachment 192403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192403&action=edit Bug 35145: (follow-up) Tidy DBUpdate Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Laura_Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Ayoub Glizi-Vicioso changed: What|Removed |Added Attachment #189175|0 |1 is obsolete|| --- Comment #77 from Ayoub Glizi-Vicioso --- Created attachment 192402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192402&action=edit Bug 35145: Added missing import Added missing import Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Laura_Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Ayoub Glizi-Vicioso changed: What|Removed |Added Attachment #189174|0 |1 is obsolete|| --- Comment #76 from Ayoub Glizi-Vicioso --- Created attachment 192401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192401&action=edit Bug 35145: Add ability to order patron attribute types Here is a summary of the changes: - Added the new column 'display_order' to 'borrower_attribute_types' table ---> Created an atomic update file (bug_35145_order_patron_attributes.pl) ---> Updated the kohastructure.sql file - Added the new column 'Display order' for '/cgi-bin/koha/admin/patron-attr-types.pl' table ---> The table now defaults to sorting based on the 'display_order' column - Added the field 'Appear in position' in the patron attribute types create/edit form - Changed the order of patron attribute types in the patron create/edit form (OPAC and staff interfcce) so it's now sorted by the assigned display_order TEST PLAN 1) Go to 'Koha administration > Patron attribute types > + New patron attribute type' 2) Fill out the form ---> Code: Enter any code, for example 'WEIGHT' ---> Description: Enter any description ---> Display in OPAC: Check ---> Editable in OPAC: Check ---> Class: Keep it empty 3) Click 'Save' 4) Repeat to add a second code with a code alphabetically before the previous one, for example SURNAME 5) Optionally, add more to really view the order 6) Go to 'Koha administration > System preferences' 7) Search for 'selfreg' 8) Set 'PatronSelfRegistration' to 'Allow' 9) Set a category in 'PatronSelfRegistrationDefaultCategory' 10) Click on the 'Save all OPAC preferences' button 11) Go to the OPAC and click on the 'Create an account' button 12) Go to the bottom of the form ---> Note that the patron attribute fields are presented in alphabetical order of code 13) Apply the patch 14) Perform an atomic update (./installer/data/mysql/updatedatabase.pl) 15) Return to 'Koha administration > Patron attribute types' ---> Notice the new 'Display order' column in the tables 16) Choose one of the attribute types you created earlier and click on the 'edit' button ---> You should now see the 'Appear in position' field 17) Enter a number in the 'Appear in position' field and click on 'Save' 18) Repeat the last two steps for each attribute type you created ---> Notice that the patron attribute types tables are sorted by display_order by default 19) In the staff interface, go to 'Patrons > + New patron' ---> In the 'Additional attributes and identifiers' section, notice that the fields are in the given number order 20) In the OPAC, return to the patron creation form (step 11) ---> At the end of the form, notice that the fields are in the given number order Signed-off-by: Anneli Österman Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Laura_Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Ayoub Glizi-Vicioso changed: What|Removed |Added Attachment #189173|0 |1 is obsolete|| --- Comment #75 from Ayoub Glizi-Vicioso --- Created attachment 192400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192400&action=edit Bug 35145: Database updates Signed-off-by: Anneli Österman Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Laura_Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Ayoub Glizi-Vicioso changed: What|Removed |Added Attachment #189172|0 |1 is obsolete|| --- Comment #74 from Ayoub Glizi-Vicioso --- Created attachment 192399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192399&action=edit Bug 35145: Schema file Signed-off-by: Anneli Österman Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Laura_Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Ayoub Glizi-Vicioso changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Lucas Gass (lukeg) changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #73 from Lucas Gass (lukeg) --- In the DB UPdate: ALTER TABLE borrower_attribute_types ADD COLUMN display_order INT(11) DEFAULT NULL COMMENT 'the order in which this attribute type appears in patron form' AFTER `mandatory` but in kohastructure.sql you put it after opac_mandatory -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Lucas Gass (lukeg) changed: What|Removed |Added Keywords||rel_26_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Laura Escamilla changed: What|Removed |Added QA Contact|[email protected] |Laura.escamilla@bywatersolu ||tions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Laura Escamilla changed: What|Removed |Added CC||Laura.escamilla@bywatersolu ||tions.com Attachment #182241|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Laura Escamilla changed: What|Removed |Added Attachment #182246|0 |1 is obsolete|| --- Comment #72 from Laura Escamilla --- Created attachment 189177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189177&action=edit Bug 35145: (follow-up) Corrected pattern for adding a column Corrected the pattern to add a column in the update file. Signed-off-by: David Nind Signed-off-by: Laura_Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Laura Escamilla changed: What|Removed |Added Attachment #182245|0 |1 is obsolete|| --- Comment #71 from Laura Escamilla --- Created attachment 189176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189176&action=edit Bug 35145: (follow-up) Tidy DBUpdate Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Laura_Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Laura Escamilla changed: What|Removed |Added Attachment #182244|0 |1 is obsolete|| --- Comment #70 from Laura Escamilla --- Created attachment 189175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189175&action=edit Bug 35145: Added missing import Added missing import Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Laura_Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Laura Escamilla changed: What|Removed |Added Attachment #182243|0 |1 is obsolete|| --- Comment #69 from Laura Escamilla --- Created attachment 189174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189174&action=edit Bug 35145: Add ability to order patron attribute types Here is a summary of the changes: - Added the new column 'display_order' to 'borrower_attribute_types' table ---> Created an atomic update file (bug_35145_order_patron_attributes.pl) ---> Updated the kohastructure.sql file - Added the new column 'Display order' for '/cgi-bin/koha/admin/patron-attr-types.pl' table ---> The table now defaults to sorting based on the 'display_order' column - Added the field 'Appear in position' in the patron attribute types create/edit form - Changed the order of patron attribute types in the patron create/edit form (OPAC and staff interfcce) so it's now sorted by the assigned display_order TEST PLAN 1) Go to 'Koha administration > Patron attribute types > + New patron attribute type' 2) Fill out the form ---> Code: Enter any code, for example 'WEIGHT' ---> Description: Enter any description ---> Display in OPAC: Check ---> Editable in OPAC: Check ---> Class: Keep it empty 3) Click 'Save' 4) Repeat to add a second code with a code alphabetically before the previous one, for example SURNAME 5) Optionally, add more to really view the order 6) Go to 'Koha administration > System preferences' 7) Search for 'selfreg' 8) Set 'PatronSelfRegistration' to 'Allow' 9) Set a category in 'PatronSelfRegistrationDefaultCategory' 10) Click on the 'Save all OPAC preferences' button 11) Go to the OPAC and click on the 'Create an account' button 12) Go to the bottom of the form ---> Note that the patron attribute fields are presented in alphabetical order of code 13) Apply the patch 14) Perform an atomic update (./installer/data/mysql/updatedatabase.pl) 15) Return to 'Koha administration > Patron attribute types' ---> Notice the new 'Display order' column in the tables 16) Choose one of the attribute types you created earlier and click on the 'edit' button ---> You should now see the 'Appear in position' field 17) Enter a number in the 'Appear in position' field and click on 'Save' 18) Repeat the last two steps for each attribute type you created ---> Notice that the patron attribute types tables are sorted by display_order by default 19) In the staff interface, go to 'Patrons > + New patron' ---> In the 'Additional attributes and identifiers' section, notice that the fields are in the given number order 20) In the OPAC, return to the patron creation form (step 11) ---> At the end of the form, notice that the fields are in the given number order Signed-off-by: Anneli Österman Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Laura_Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Laura Escamilla changed: What|Removed |Added Attachment #182242|0 |1 is obsolete|| --- Comment #68 from Laura Escamilla --- Created attachment 189173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189173&action=edit Bug 35145: Database updates Signed-off-by: Anneli Österman Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Laura_Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #67 from Laura Escamilla --- Created attachment 189172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189172&action=edit Bug 35145: Schema file Signed-off-by: Anneli Österman Signed-off-by: Lucas Gass Signed-off-by: David Nind Signed-off-by: Laura_Escamilla -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Laura Escamilla changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 David Nind changed: What|Removed |Added CC||[email protected] --- Comment #66 from David Nind --- Testing notes (using KTD): 1. I added four patron attributes: STAT, TEST01, TEST04, TEST05 2. After the patch, and if no order is set for any attributes, they display in code order (alphabetical) for the self-registration form. 3. For the patron details page, and if no order is set for any attributes, they display in the same order. 4. For the patron edit form, they show in this order (I can't work out the order used): - TEST01 - STAT - SHOW_BARCODE - TEST05 - TEST04 5. If a patron is logged in, on the details page they are displayed either in the display order, or alphabetical (A-Z). 6. Using the "Appear in position" field works as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 David Nind changed: What|Removed |Added Attachment #181890|0 |1 is obsolete|| --- Comment #65 from David Nind --- Created attachment 182246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182246&action=edit Bug 35145: (follow-up) Corrected pattern for adding a column Corrected the pattern to add a column in the update file. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 David Nind changed: What|Removed |Added Attachment #181889|0 |1 is obsolete|| --- Comment #64 from David Nind --- Created attachment 182245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182245&action=edit Bug 35145: (follow-up) Tidy DBUpdate Signed-off-by: Lucas Gass Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 David Nind changed: What|Removed |Added Attachment #181888|0 |1 is obsolete|| --- Comment #63 from David Nind --- Created attachment 182244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182244&action=edit Bug 35145: Added missing import Added missing import Signed-off-by: Lucas Gass Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 David Nind changed: What|Removed |Added Attachment #181887|0 |1 is obsolete|| --- Comment #62 from David Nind --- Created attachment 182243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182243&action=edit Bug 35145: Add ability to order patron attribute types Here is a summary of the changes: - Added the new column 'display_order' to 'borrower_attribute_types' table ---> Created an atomic update file (bug_35145_order_patron_attributes.pl) ---> Updated the kohastructure.sql file - Added the new column 'Display order' for '/cgi-bin/koha/admin/patron-attr-types.pl' table ---> The table now defaults to sorting based on the 'display_order' column - Added the field 'Appear in position' in the patron attribute types create/edit form - Changed the order of patron attribute types in the patron create/edit form (OPAC and staff interfcce) so it's now sorted by the assigned display_order TEST PLAN 1) Go to 'Koha administration > Patron attribute types > + New patron attribute type' 2) Fill out the form ---> Code: Enter any code, for example 'WEIGHT' ---> Description: Enter any description ---> Display in OPAC: Check ---> Editable in OPAC: Check ---> Class: Keep it empty 3) Click 'Save' 4) Repeat to add a second code with a code alphabetically before the previous one, for example SURNAME 5) Optionally, add more to really view the order 6) Go to 'Koha administration > System preferences' 7) Search for 'selfreg' 8) Set 'PatronSelfRegistration' to 'Allow' 9) Set a category in 'PatronSelfRegistrationDefaultCategory' 10) Click on the 'Save all OPAC preferences' button 11) Go to the OPAC and click on the 'Create an account' button 12) Go to the bottom of the form ---> Note that the patron attribute fields are presented in alphabetical order of code 13) Apply the patch 14) Perform an atomic update (./installer/data/mysql/updatedatabase.pl) 15) Return to 'Koha administration > Patron attribute types' ---> Notice the new 'Display order' column in the tables 16) Choose one of the attribute types you created earlier and click on the 'edit' button ---> You should now see the 'Appear in position' field 17) Enter a number in the 'Appear in position' field and click on 'Save' 18) Repeat the last two steps for each attribute type you created ---> Notice that the patron attribute types tables are sorted by display_order by default 19) In the staff interface, go to 'Patrons > + New patron' ---> In the 'Additional attributes and identifiers' section, notice that the fields are in the given number order 20) In the OPAC, return to the patron creation form (step 11) ---> At the end of the form, notice that the fields are in the given number order Signed-off-by: Anneli Österman Signed-off-by: Lucas Gass Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 David Nind changed: What|Removed |Added Attachment #181886|0 |1 is obsolete|| --- Comment #61 from David Nind --- Created attachment 182242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182242&action=edit Bug 35145: Database updates Signed-off-by: Anneli Österman Signed-off-by: Lucas Gass Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 David Nind changed: What|Removed |Added Attachment #181885|0 |1 is obsolete|| --- Comment #60 from David Nind --- Created attachment 182241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182241&action=edit Bug 35145: Schema file Signed-off-by: Anneli Österman Signed-off-by: Lucas Gass Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Hammat wele changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Hammat wele changed: What|Removed |Added Attachment #177119|0 |1 is obsolete|| --- Comment #59 from Hammat wele --- Created attachment 181890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181890&action=edit Bug 35145: (follow-up) Corrected pattern for adding a column Corrected the pattern to add a column in the update file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Hammat wele changed: What|Removed |Added Attachment #176765|0 |1 is obsolete|| --- Comment #58 from Hammat wele --- Created attachment 181889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181889&action=edit Bug 35145: (follow-up) Tidy DBUpdate Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Hammat wele changed: What|Removed |Added Attachment #176764|0 |1 is obsolete|| --- Comment #57 from Hammat wele --- Created attachment 181888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181888&action=edit Bug 35145: Added missing import Added missing import Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Hammat wele changed: What|Removed |Added Attachment #176763|0 |1 is obsolete|| --- Comment #56 from Hammat wele --- Created attachment 181887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181887&action=edit Bug 35145: Add ability to order patron attribute types Here is a summary of the changes: - Added the new column 'display_order' to 'borrower_attribute_types' table ---> Created an atomic update file (bug_35145_order_patron_attributes.pl) ---> Updated the kohastructure.sql file - Added the new column 'Display order' for '/cgi-bin/koha/admin/patron-attr-types.pl' table ---> The table now defaults to sorting based on the 'display_order' column - Added the field 'Appear in position' in the patron attribute types create/edit form - Changed the order of patron attribute types in the patron create/edit form (OPAC and staff interfcce) so it's now sorted by the assigned display_order TEST PLAN 1) Go to 'Koha administration > Patron attribute types > + New patron attribute type' 2) Fill out the form ---> Code: Enter any code, for example 'WEIGHT' ---> Description: Enter any description ---> Display in OPAC: Check ---> Editable in OPAC: Check ---> Class: Keep it empty 3) Click 'Save' 4) Repeat to add a second code with a code alphabetically before the previous one, for example SURNAME 5) Optionally, add more to really view the order 6) Go to 'Koha administration > System preferences' 7) Search for 'selfreg' 8) Set 'PatronSelfRegistration' to 'Allow' 9) Set a category in 'PatronSelfRegistrationDefaultCategory' 10) Click on the 'Save all OPAC preferences' button 11) Go to the OPAC and click on the 'Create an account' button 12) Go to the bottom of the form ---> Note that the patron attribute fields are presented in alphabetical order of code 13) Apply the patch 14) Perform an atomic update (./installer/data/mysql/updatedatabase.pl) 15) Return to 'Koha administration > Patron attribute types' ---> Notice the new 'Display order' column in the tables 16) Choose one of the attribute types you created earlier and click on the 'edit' button ---> You should now see the 'Appear in position' field 17) Enter a number in the 'Appear in position' field and click on 'Save' 18) Repeat the last two steps for each attribute type you created ---> Notice that the patron attribute types tables are sorted by display_order by default 19) In the staff interface, go to 'Patrons > + New patron' ---> In the 'Additional attributes and identifiers' section, notice that the fields are in the given number order 20) In the OPAC, return to the patron creation form (step 11) ---> At the end of the form, notice that the fields are in the given number order Signed-off-by: Anneli Österman Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Hammat wele changed: What|Removed |Added Attachment #176761|0 |1 is obsolete|| --- Comment #54 from Hammat wele --- Created attachment 181885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181885&action=edit Bug 35145: Schema file Signed-off-by: Anneli Österman Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Hammat wele changed: What|Removed |Added Attachment #176762|0 |1 is obsolete|| --- Comment #55 from Hammat wele --- Created attachment 181886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181886&action=edit Bug 35145: Database updates Signed-off-by: Anneli Österman Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #53 from Caroline Cyr La Rose --- (In reply to Caroline Cyr La Rose from comment #52) > (In reply to Jonathan Druart from comment #48) > > > 2. There is absolutely no logic on the value we enter. > > Should we enforce it? Like it start with 1 and there is no gap and no > > duplicate. > > > > IMO It would be better to have a drag and drop solution to order them, and > > easily see the order. > > I would consider this outside the scope of this bug. This currently offers > something consistent with what is done elsewhere in Koha. If we want a drag > and drop option, it should be in another bug and it should change all the > places where an order is set (news/additional content, serial numbering, > item groups). I created bug 39753 for finding an alternative to Display order/Appear in position. I selected drag and drop bc I find this is the easiest for the end user, but feel free to comment with alternatives. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Caroline Cyr La Rose changed: What|Removed |Added Status|Failed QA |Patch doesn't apply --- Comment #52 from Caroline Cyr La Rose --- (In reply to Jonathan Druart from comment #48) > 2. There is absolutely no logic on the value we enter. > Should we enforce it? Like it start with 1 and there is no gap and no > duplicate. > > IMO It would be better to have a drag and drop solution to order them, and > easily see the order. I would consider this outside the scope of this bug. This currently offers something consistent with what is done elsewhere in Koha. If we want a drag and drop option, it should be in another bug and it should change all the places where an order is set (news/additional content, serial numbering, item groups). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #51 from William Lavoie --- Created attachment 177119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177119&action=edit Bug 35145: (follow-up) Corrected pattern for adding a column Corrected the pattern to add a column in the update file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #50 from Jonathan Druart --- (In reply to Kyle M Hall (khall) from comment #49) > > IMO It would be better to have a drag and drop solution to order them, and > > easily see the order. > > Drag and drop is great right up to when the list is longer than the screen ;) Do you think the proposed solution is good enough? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #49 from Kyle M Hall (khall) --- > IMO It would be better to have a drag and drop solution to order them, and > easily see the order. Drag and drop is great right up to when the list is longer than the screen ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #48 from Jonathan Druart ---
1.
The correct pattern to add a new column in an atomic update file is:
unless ( column_exists('table', 'column') ) {
$dbh->do(q{ALTER QUERY HERE});
say_success("your success message");
}
2. There is absolutely no logic on the value we enter.
Should we enforce it? Like it start with 1 and there is no gap and no
duplicate.
IMO It would be better to have a drag and drop solution to order them, and
easily see the order.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #46 from Lucas Gass (lukeg) --- Created attachment 176765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176765&action=edit Bug 35145: (follow-up) Tidy DBUpdate Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #47 from Lucas Gass (lukeg) --- Your DB update was not tidy, I provided a follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #176760|0 |1 is obsolete|| --- Comment #45 from Lucas Gass (lukeg) --- Created attachment 176764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176764&action=edit Bug 35145: Added missing import Added missing import Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #176758|0 |1 is obsolete|| --- Comment #44 from Lucas Gass (lukeg) --- Created attachment 176763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176763&action=edit Bug 35145: Add ability to order patron attribute types Here is a summary of the changes: - Added the new column 'display_order' to 'borrower_attribute_types' table ---> Created an atomic update file (bug_35145_order_patron_attributes.pl) ---> Updated the kohastructure.sql file - Added the new column 'Display order' for '/cgi-bin/koha/admin/patron-attr-types.pl' table ---> The table now defaults to sorting based on the 'display_order' column - Added the field 'Appear in position' in the patron attribute types create/edit form - Changed the order of patron attribute types in the patron create/edit form (OPAC and staff interfcce) so it's now sorted by the assigned display_order TEST PLAN 1) Go to 'Koha administration > Patron attribute types > + New patron attribute type' 2) Fill out the form ---> Code: Enter any code, for example 'WEIGHT' ---> Description: Enter any description ---> Display in OPAC: Check ---> Editable in OPAC: Check ---> Class: Keep it empty 3) Click 'Save' 4) Repeat to add a second code with a code alphabetically before the previous one, for example SURNAME 5) Optionally, add more to really view the order 6) Go to 'Koha administration > System preferences' 7) Search for 'selfreg' 8) Set 'PatronSelfRegistration' to 'Allow' 9) Set a category in 'PatronSelfRegistrationDefaultCategory' 10) Click on the 'Save all OPAC preferences' button 11) Go to the OPAC and click on the 'Create an account' button 12) Go to the bottom of the form ---> Note that the patron attribute fields are presented in alphabetical order of code 13) Apply the patch 14) Perform an atomic update (./installer/data/mysql/updatedatabase.pl) 15) Return to 'Koha administration > Patron attribute types' ---> Notice the new 'Display order' column in the tables 16) Choose one of the attribute types you created earlier and click on the 'edit' button ---> You should now see the 'Appear in position' field 17) Enter a number in the 'Appear in position' field and click on 'Save' 18) Repeat the last two steps for each attribute type you created ---> Notice that the patron attribute types tables are sorted by display_order by default 19) In the staff interface, go to 'Patrons > + New patron' ---> In the 'Additional attributes and identifiers' section, notice that the fields are in the given number order 20) In the OPAC, return to the patron creation form (step 11) ---> At the end of the form, notice that the fields are in the given number order Signed-off-by: Anneli Österman Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #176757|0 |1 is obsolete|| --- Comment #43 from Lucas Gass (lukeg) --- Created attachment 176762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176762&action=edit Bug 35145: Database updates Signed-off-by: Anneli Österman Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #176756|0 |1 is obsolete|| --- Comment #42 from Lucas Gass (lukeg) --- Created attachment 176761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176761&action=edit Bug 35145: Schema file Signed-off-by: Anneli Österman Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Lucas Gass (lukeg) changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 William Lavoie changed: What|Removed |Added CC||[email protected] Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #41 from William Lavoie --- Created attachment 176760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176760&action=edit Bug 35145: Added missing import Added missing import -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 William Lavoie changed: What|Removed |Added Attachment #170628|0 |1 is obsolete|| --- Comment #39 from William Lavoie --- Created attachment 176757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176757&action=edit Bug 35145: Database updates Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 William Lavoie changed: What|Removed |Added Attachment #170629|0 |1 is obsolete|| --- Comment #40 from William Lavoie --- Created attachment 176758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176758&action=edit Bug 35145: Add ability to order patron attribute types Here is a summary of the changes: - Added the new column 'display_order' to 'borrower_attribute_types' table ---> Created an atomic update file (bug_35145_order_patron_attributes.pl) ---> Updated the kohastructure.sql file - Added the new column 'Display order' for '/cgi-bin/koha/admin/patron-attr-types.pl' table ---> The table now defaults to sorting based on the 'display_order' column - Added the field 'Appear in position' in the patron attribute types create/edit form - Changed the order of patron attribute types in the patron create/edit form (OPAC and staff interfcce) so it's now sorted by the assigned display_order TEST PLAN 1) Go to 'Koha administration > Patron attribute types > + New patron attribute type' 2) Fill out the form ---> Code: Enter any code, for example 'WEIGHT' ---> Description: Enter any description ---> Display in OPAC: Check ---> Editable in OPAC: Check ---> Class: Keep it empty 3) Click 'Save' 4) Repeat to add a second code with a code alphabetically before the previous one, for example SURNAME 5) Optionally, add more to really view the order 6) Go to 'Koha administration > System preferences' 7) Search for 'selfreg' 8) Set 'PatronSelfRegistration' to 'Allow' 9) Set a category in 'PatronSelfRegistrationDefaultCategory' 10) Click on the 'Save all OPAC preferences' button 11) Go to the OPAC and click on the 'Create an account' button 12) Go to the bottom of the form ---> Note that the patron attribute fields are presented in alphabetical order of code 13) Apply the patch 14) Perform an atomic update (./installer/data/mysql/updatedatabase.pl) 15) Return to 'Koha administration > Patron attribute types' ---> Notice the new 'Display order' column in the tables 16) Choose one of the attribute types you created earlier and click on the 'edit' button ---> You should now see the 'Appear in position' field 17) Enter a number in the 'Appear in position' field and click on 'Save' 18) Repeat the last two steps for each attribute type you created ---> Notice that the patron attribute types tables are sorted by display_order by default 19) In the staff interface, go to 'Patrons > + New patron' ---> In the 'Additional attributes and identifiers' section, notice that the fields are in the given number order 20) In the OPAC, return to the patron creation form (step 11) ---> At the end of the form, notice that the fields are in the given number order Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 William Lavoie changed: What|Removed |Added Attachment #170627|0 |1 is obsolete|| --- Comment #38 from William Lavoie --- Created attachment 176756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176756&action=edit Bug 35145: Schema file Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145
Lucas Gass (lukeg) changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #37 from Lucas Gass (lukeg) ---
Database update fails:
ERROR: {UNKNOWN}: Undefined subroutine &C4::Installer::say_success
called at
/kohadevbox/koha/installer/data/mysql/atomicupdate/bug_35145_order_patron_attributes.pl
line 21. at /kohadevbox/koha/C4/Installer.pm line 743
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Anneli Österman changed: What|Removed |Added CC||anneli.osterman@koha-suomi. ||fi Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Biblibre Sandboxes changed: What|Removed |Added Attachment #170332|0 |1 is obsolete|| --- Comment #36 from Biblibre Sandboxes --- Created attachment 170629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170629&action=edit Bug 35145: Add ability to order patron attribute types Here is a summary of the changes: - Added the new column 'display_order' to 'borrower_attribute_types' table ---> Created an atomic update file (bug_35145_order_patron_attributes.pl) ---> Updated the kohastructure.sql file - Added the new column 'Display order' for '/cgi-bin/koha/admin/patron-attr-types.pl' table ---> The table now defaults to sorting based on the 'display_order' column - Added the field 'Appear in position' in the patron attribute types create/edit form - Changed the order of patron attribute types in the patron create/edit form (OPAC and staff interfcce) so it's now sorted by the assigned display_order TEST PLAN 1) Go to 'Koha administration > Patron attribute types > + New patron attribute type' 2) Fill out the form ---> Code: Enter any code, for example 'WEIGHT' ---> Description: Enter any description ---> Display in OPAC: Check ---> Editable in OPAC: Check ---> Class: Keep it empty 3) Click 'Save' 4) Repeat to add a second code with a code alphabetically before the previous one, for example SURNAME 5) Optionally, add more to really view the order 6) Go to 'Koha administration > System preferences' 7) Search for 'selfreg' 8) Set 'PatronSelfRegistration' to 'Allow' 9) Set a category in 'PatronSelfRegistrationDefaultCategory' 10) Click on the 'Save all OPAC preferences' button 11) Go to the OPAC and click on the 'Create an account' button 12) Go to the bottom of the form ---> Note that the patron attribute fields are presented in alphabetical order of code 13) Apply the patch 14) Perform an atomic update (./installer/data/mysql/updatedatabase.pl) 15) Return to 'Koha administration > Patron attribute types' ---> Notice the new 'Display order' column in the tables 16) Choose one of the attribute types you created earlier and click on the 'edit' button ---> You should now see the 'Appear in position' field 17) Enter a number in the 'Appear in position' field and click on 'Save' 18) Repeat the last two steps for each attribute type you created ---> Notice that the patron attribute types tables are sorted by display_order by default 19) In the staff interface, go to 'Patrons > + New patron' ---> In the 'Additional attributes and identifiers' section, notice that the fields are in the given number order 20) In the OPAC, return to the patron creation form (step 11) ---> At the end of the form, notice that the fields are in the given number order Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Biblibre Sandboxes changed: What|Removed |Added Attachment #170331|0 |1 is obsolete|| --- Comment #35 from Biblibre Sandboxes --- Created attachment 170628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170628&action=edit Bug 35145: Database updates Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Biblibre Sandboxes changed: What|Removed |Added Attachment #170330|0 |1 is obsolete|| --- Comment #34 from Biblibre Sandboxes --- Created attachment 170627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170627&action=edit Bug 35145: Schema file Signed-off-by: Anneli Österman -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Hammat wele changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #33 from Caroline Cyr La Rose --- (In reply to Kelly McElligott from comment #32) > Testing this bug, if I don't add a "Display Order" in the Patron Attribute > setup, that patron attribute will show up first. I added three patron > attributes, 2 of them I added a display order, but the third one did not get > a display order. Is that what should happen? I think that is the way it works in other places where there are display orders. For example, in news, if you don't put a display order, the news appears in first place (equivalent to 0). Same with serial frequencies and numbering patterns. In all those cases, an empty display order is considered the same as 0, which is the first place. Then 1, 2, 3, etc. It's consistent with the regular behaviour. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Kelly McElligott changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Kelly McElligott changed: What|Removed |Added CC||[email protected] --- Comment #32 from Kelly McElligott --- Testing this bug, if I don't add a "Display Order" in the Patron Attribute setup, that patron attribute will show up first. I added three patron attributes, 2 of them I added a display order, but the third one did not get a display order. Is that what should happen? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Hammat wele changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #31 from Hammat wele --- Created attachment 170332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170332&action=edit Bug 35145: Add ability to order patron attribute types Here is a summary of the changes: - Added the new column 'display_order' to 'borrower_attribute_types' table ---> Created an atomic update file (bug_35145_order_patron_attributes.pl) ---> Updated the kohastructure.sql file - Added the new column 'Display order' for '/cgi-bin/koha/admin/patron-attr-types.pl' table ---> The table now defaults to sorting based on the 'display_order' column - Added the field 'Appear in position' in the patron attribute types create/edit form - Changed the order of patron attribute types in the patron create/edit form (OPAC and staff interfcce) so it's now sorted by the assigned display_order TEST PLAN 1) Go to 'Koha administration > Patron attribute types > + New patron attribute type' 2) Fill out the form ---> Code: Enter any code, for example 'WEIGHT' ---> Description: Enter any description ---> Display in OPAC: Check ---> Editable in OPAC: Check ---> Class: Keep it empty 3) Click 'Save' 4) Repeat to add a second code with a code alphabetically before the previous one, for example SURNAME 5) Optionally, add more to really view the order 6) Go to 'Koha administration > System preferences' 7) Search for 'selfreg' 8) Set 'PatronSelfRegistration' to 'Allow' 9) Set a category in 'PatronSelfRegistrationDefaultCategory' 10) Click on the 'Save all OPAC preferences' button 11) Go to the OPAC and click on the 'Create an account' button 12) Go to the bottom of the form ---> Note that the patron attribute fields are presented in alphabetical order of code 13) Apply the patch 14) Perform an atomic update (./installer/data/mysql/updatedatabase.pl) 15) Return to 'Koha administration > Patron attribute types' ---> Notice the new 'Display order' column in the tables 16) Choose one of the attribute types you created earlier and click on the 'edit' button ---> You should now see the 'Appear in position' field 17) Enter a number in the 'Appear in position' field and click on 'Save' 18) Repeat the last two steps for each attribute type you created ---> Notice that the patron attribute types tables are sorted by display_order by default 19) In the staff interface, go to 'Patrons > + New patron' ---> In the 'Additional attributes and identifiers' section, notice that the fields are in the given number order 20) In the OPAC, return to the patron creation form (step 11) ---> At the end of the form, notice that the fields are in the given number order -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #30 from Hammat wele --- Created attachment 170331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170331&action=edit Bug 35145: Database updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #29 from Hammat wele --- Created attachment 170330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170330&action=edit Bug 35145: Schema file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Hammat wele changed: What|Removed |Added Attachment #169256|0 |1 is obsolete|| Attachment #169256|0 |1 is patch|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Hammat wele changed: What|Removed |Added Attachment #169258|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Hammat wele changed: What|Removed |Added Attachment #169257|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Hammat wele changed: What|Removed |Added Attachment #169256|1 |0 is patch|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Caroline Cyr La Rose changed: What|Removed |Added Assignee|emily-rose.francoeur@inLibr |[email protected] |o.com | CC|emily-rose.francoeur@inLibr | |o.com, | |[email protected] | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #28 from Katrin Fischer --- 1) Please keep schema changes separate, so I can generate the files for main (avoids conflicts later). I can't just leave the first patch out as the last patch also touches it. 2) Please add AFTER mandatory to the database update statement, so we ensure the same sequence. 3) Please use say_success in the database update (wiki and skeleton.pl updates will be done soon, but you can peek at the other database updates 2406* 4) Please check if we are missing a change to moremember.pl to also display the attributes in right sequence there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com QA Contact|[email protected] |[email protected] |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #27 from Kyle M Hall --- Created attachment 169258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169258&action=edit Bug 35145: (follow-up) Fix atomicupdate file and display_order's data type PA amended: Added DEFAULT NULL COMMENT 'the order in which this attribute type appears in patron form' to column entry to match what's in kohastructure.sql Signed-off-by: Pedro Amorim Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 --- Comment #26 from Kyle M Hall --- Created attachment 169257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169257&action=edit Bug 35145: (follow-up) Rename number to display_order PA amended: Fix commit title Signed-off-by: Pedro Amorim Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Kyle M Hall changed: What|Removed |Added Attachment #166519|0 |1 is obsolete|| Attachment #166520|0 |1 is obsolete|| Attachment #166521|0 |1 is obsolete|| --- Comment #25 from Kyle M Hall --- Created attachment 169256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169256&action=edit Bug 35145: Schema file PA amended: Fix commit title Signed-off-by: Pedro Amorim Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35145] Add ability to order patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
