[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks|35937 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35937 [Bug 35937] Add hourly support to bookings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks|36936 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36936 [Bug 36936] api/v1/bookings.t generates warnings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks||39916 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39916 [Bug 39916] The 'Place booking' modal should have cypress tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Bug 35248 depends on bug 35788, which changed state. Bug 35788 Summary: Remove Koha::Template::Plugin::Biblio::BookingsCount https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Blocks||36936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36936 [Bug 36936] api/v1/bookings.t generates warnings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Katrin Fischer changed: What|Removed |Added Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Thibaud Guillot changed: What|Removed |Added Blocks|36271 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 [Bug 36271] Bookings should respect circulation rules for max loan periods -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Lucas Gass changed: What|Removed |Added CC||[email protected] Resolution|--- |FIXED Status|Pushed to stable|RESOLVED --- Comment #75 from Lucas Gass --- Missing 23.05.x dependencies, no backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Fridolin Somers changed: What|Removed |Added Version(s)|24.05.00|24.05.00,23.11.04 released in|| Status|Pushed to master|Pushed to stable --- Comment #74 from Fridolin Somers --- Pushed to 23.11.x for 23.11.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #73 from Martin Renvoize --- This should apply happily for 23.11.x Fridolin. The dependency was there to ensure we pushed in the right order for master and to discourage others working on bookings code prior to the tests being present. We aren't testing the code removed in the dependency bugs, but I think that's OK for 23.11.x at this stage. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Fridolin Somers changed: What|Removed |Added CC||[email protected] ||m --- Comment #72 from Fridolin Somers --- Sure about dependancy with Bug 35788 ? Can this be backported to 23.11.x ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #71 from Katrin Fischer --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||24.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #70 from Katrin Fischer --- The last patch wouldn't apply or more, it doesn't appear to be needed anymore: M koha-tmpl/intranet-tmpl/prog/js/place_booking_modal.js Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/place_booking_modal.js No changes -- Patch already applied. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #69 from Martin Renvoize --- Seems we're having sha1 issues.. branch pushed to https://github.com/PTFS-Europe/koha/tree/bug_35248 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added URL||https://github.com/PTFS-Eur ||ope/koha/tree/bug_35248 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #68 from Katrin Fischer --- I looked into this again: my problem is a "could not build fake ancestor" on bug 35782 right at the top of this tree. As it all still applies for you, maybe you could reattach the patches there for me? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #67 from Martin Renvoize --- I just applied the whole tree this morning against the current master and it was seamless.. not sure what problems your facing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #66 from Katrin Fischer --- Some trouble with applying the dependencies here - will revisit later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Blocks||36271 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 [Bug 36271] Bookings should respect circulation rules for max loan periods -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Blocks|36040 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36040 [Bug 36040] CanBookBeRenewed should take bookings into account. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Blocks|35946 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35946 [Bug 35946] If an item has future bookings on it and it is marked as lost we should highlight this to the librarian -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Blocks|34440 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440 [Bug 34440] Add warm-up and cool-down periods to bookings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Blocks||34440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440 [Bug 34440] Add warm-up and cool-down periods to bookings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Blocks||36120 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36120 [Bug 36120] Add pickup locations to Bookings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Blocks||36040 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36040 [Bug 36040] CanBookBeRenewed should take bookings into account. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Blocks||35946 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35946 [Bug 35946] If an item has future bookings on it and it is marked as lost we should highlight this to the librarian -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Blocks||35944 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35944 [Bug 35944] Bookings is not taken into account in CanBookBeRenewed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Blocks||35937 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35937 [Bug 35937] Add hourly support to Bookings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Nick Clemens changed: What|Removed |Added Attachment #161897|0 |1 is obsolete|| --- Comment #65 from Nick Clemens --- Created attachment 161912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161912&action=edit Bug 35248: Whitespace clean Jonathan highlighted some trailing whitespace.. I only see a few cases where a line only contains whitespace and I didn't see these caught by the QA script at the time of submission. Anyway, this removes the spaces Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Nick Clemens changed: What|Removed |Added Attachment #161896|0 |1 is obsolete|| --- Comment #64 from Nick Clemens --- Created attachment 161911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161911&action=edit Bug 35248: Add tests for Koha::Booking->_assign_item_for_booking Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Nick Clemens changed: What|Removed |Added Attachment #161894|0 |1 is obsolete|| --- Comment #63 from Nick Clemens --- Created attachment 161910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161910&action=edit Bug 35248: Refactor - Move assign_item_for_booking This routine really belongs inside Koha::Booking rather than Koha::Biblio. This patch moves it there, renames with _ to highlight it's private nature. Test plan 1) Confirm that t/db_dependant/Koha/Booking.t still passes, specifically the 'store' test. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Nick Clemens changed: What|Removed |Added Attachment #161893|0 |1 is obsolete|| --- Comment #62 from Nick Clemens --- Created attachment 161909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161909&action=edit Bug 35248: Add tests for Koha::Booking->store This patch adds tests for the Koha::Booking->store method. Test plan 1) Run t/db_dependent/Koha/Booking.t and confirm they all pass Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Nick Clemens changed: What|Removed |Added Attachment #161871|0 |1 is obsolete|| --- Comment #61 from Nick Clemens --- Created attachment 161908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161908&action=edit Bug 35248: Add unit tests for Koha::Bibilio->bookable_items This patch adds basic unit tests for Koha::Biblio->bookable_items Test plan 1) Run t/db_dependent/Koha/Biblio.t Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Nick Clemens changed: What|Removed |Added Attachment #161870|0 |1 is obsolete|| --- Comment #60 from Nick Clemens --- Created attachment 161907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161907&action=edit Bug 35248: Add unit tests for Koha::Bibilio->check_booking This patch adds basic unit tests for Koha::Biblio->check_booking Test plan 1) Run t/db_dependent/Koha/Biblio.t Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Nick Clemens changed: What|Removed |Added Attachment #161869|0 |1 is obsolete|| --- Comment #59 from Nick Clemens --- Created attachment 161906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161906&action=edit Bug 35248: Add Koha::Biblio->bookings unit test This patch adds unit tests for the bookings relationship accessor on Koha::Biblio objects. Test plan 1) Run t/db_dependant/Koha/Biblio.t Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Nick Clemens changed: What|Removed |Added Attachment #161868|0 |1 is obsolete|| --- Comment #58 from Nick Clemens --- Created attachment 161905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161905&action=edit Bug 35248: Add unit tests for Koha::Booking relations This patch adds unit tests for the relations introduced in the new Koha::Booking class. Test plan 1) Run t/db_dependent/Koha/Booking.t Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Nick Clemens changed: What|Removed |Added Attachment #161867|0 |1 is obsolete|| --- Comment #57 from Nick Clemens --- Created attachment 161904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161904&action=edit Bug 35248: Remove Koha::Booking->intersects Another method left behind from an earlier iteration.. not actually called anywhere in the final submission in Koha. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Nick Clemens changed: What|Removed |Added Attachment #161866|0 |1 is obsolete|| --- Comment #56 from Nick Clemens --- Created attachment 161903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161903&action=edit Bug 35248: Add test for Koha::Exceptions::Booking Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Nick Clemens changed: What|Removed |Added Attachment #161865|0 |1 is obsolete|| --- Comment #55 from Nick Clemens --- Created attachment 161902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161902&action=edit Bug 35248: Drop ->place_booking These methods were introduced and used in an earlier iteration of the code, they are no longer called from anywhere (the code in Koha::Booking->store handles all cases instead) and thus I choose to remove them rather than add unit tests for them.. They are simple methods that could be re-introduced as required at a future date. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Nick Clemens changed: What|Removed |Added Attachment #161864|0 |1 is obsolete|| --- Comment #54 from Nick Clemens --- Created attachment 161901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161901&action=edit Bug 35248: Add unit tests for Koha::Item->check_booking This patch adds basic unit tests for the Koha::Item->check_booking method. Test plan 1) Run t/db_dependant/Koha/Item.t Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Nick Clemens changed: What|Removed |Added Attachment #161863|0 |1 is obsolete|| --- Comment #53 from Nick Clemens --- Created attachment 161900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161900&action=edit Bug 35248: Unit tests for CanBookBeIssued Whilst writing the test, I found a minor flaw in the logic and fixed that in CanBookBeIssued at the same time. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Nick Clemens changed: What|Removed |Added Attachment #161862|0 |1 is obsolete|| --- Comment #52 from Nick Clemens --- Created attachment 161899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161899&action=edit Bug 35248: Add unit tests for Koha::Item->find_booking This patch adds basic unit tests for the Koha::Item->find_booking method. Test plan 1) Run t/db_dependant/Koha/Item.t Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Nick Clemens changed: What|Removed |Added Attachment #161861|0 |1 is obsolete|| --- Comment #51 from Nick Clemens --- Created attachment 161898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161898&action=edit Bug 35248: Add unit test for Koha::Item->bookings relation This patch adds a simple unit test for the 'bookings' relation accessor added to Koha::Item. Test plan 1) Run t/db_dependant/Koha/Item.t Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #50 from Martin Renvoize --- Created attachment 161897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161897&action=edit Bug 35248: Whitespace clean Jonathan highlighted some trailing whitespace.. I only see a few cases where a line only contains whitespace and I didn't see these caught by the QA script at the time of submission. Anyway, this removes the spaces -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Attachment #161895|0 |1 is obsolete|| --- Comment #49 from Martin Renvoize --- Created attachment 161896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161896&action=edit Bug 35248: Add tests for Koha::Booking->_assign_item_for_booking -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #48 from Martin Renvoize --- Created attachment 161895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161895&action=edit Bug 35248: Add tests for Koha::Booking->_assign_item_for_booking -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Attachment #161891|0 |1 is obsolete|| --- Comment #47 from Martin Renvoize --- Created attachment 161894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161894&action=edit Bug 35248: Refactor - Move assign_item_for_booking This routine really belongs inside Koha::Booking rather than Koha::Biblio. This patch moves it there, renames with _ to highlight it's private nature. Test plan 1) Confirm that t/db_dependant/Koha/Booking.t still passes, specifically the 'store' test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Attachment #161890|0 |1 is obsolete|| --- Comment #46 from Martin Renvoize --- Created attachment 161893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161893&action=edit Bug 35248: Add tests for Koha::Booking->store This patch adds tests for the Koha::Booking->store method. Test plan 1) Run t/db_dependent/Koha/Booking.t and confirm they all pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #45 from Martin Renvoize --- Thanks David, that's great :) I've added a couple of further patches on top now too.. and there's one last one outstanding that I'm working on today.. resetting to assigned whilst I get that one done.. the more you look the more you see aye. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #44 from Martin Renvoize --- Created attachment 161891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161891&action=edit Bug 35248: Refactor - Move assign_item_for_booking This routine really belongs inside Koha::Booking rather than Koha::Biblio. This patch moves it there, renames with _ to highlight it's private nature. Test plan 1) Confirm that t/db_dependant/Koha/Booking.t still passes, specifically the 'store' test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #43 from Martin Renvoize --- Created attachment 161890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161890&action=edit Bug 35248: Add tests for Koha::Booking->store This patch adds tests for the Koha::Booking->store method. Test plan 1) Run t/db_dependent/Koha/Booking.t and confirm they all pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 David Nind changed: What|Removed |Added CC||[email protected] --- Comment #42 from David Nind --- I ran the tests before and after the patches were applied. I hope that is sufficient for testing. Testing notes using koha-testing-docker: 1. Tests pass before and after patches applied: prove t/db_dependent/Circulation.t prove t/Koha/Exceptions.t prove t/db_dependent/Koha/Item.t prove t/db_dependent/Koha/Booking.t (new tests) prove t/db_dependent/Koha/Biblio.t 2. Note: path to run the tests is t/db_dependent/Koha/Item.t (not db_dependant) for these patches: - Add unit test for Koha::Item->bookings relation - Add unit tests for Koha::Item->find_booking - Add unit tests for Koha::Item->check_booking - Add Koha::Biblio->bookings unit test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 David Nind changed: What|Removed |Added Attachment #161831|0 |1 is obsolete|| --- Comment #41 from David Nind --- Created attachment 161871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161871&action=edit Bug 35248: Add unit tests for Koha::Bibilio->bookable_items This patch adds basic unit tests for Koha::Biblio->bookable_items Test plan 1) Run t/db_dependent/Koha/Biblio.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 David Nind changed: What|Removed |Added Attachment #161830|0 |1 is obsolete|| --- Comment #40 from David Nind --- Created attachment 161870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161870&action=edit Bug 35248: Add unit tests for Koha::Bibilio->check_booking This patch adds basic unit tests for Koha::Biblio->check_booking Test plan 1) Run t/db_dependent/Koha/Biblio.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 David Nind changed: What|Removed |Added Attachment #161829|0 |1 is obsolete|| --- Comment #39 from David Nind --- Created attachment 161869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161869&action=edit Bug 35248: Add Koha::Biblio->bookings unit test This patch adds unit tests for the bookings relationship accessor on Koha::Biblio objects. Test plan 1) Run t/db_dependant/Koha/Biblio.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 David Nind changed: What|Removed |Added Attachment #161828|0 |1 is obsolete|| --- Comment #38 from David Nind --- Created attachment 161868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161868&action=edit Bug 35248: Add unit tests for Koha::Booking relations This patch adds unit tests for the relations introduced in the new Koha::Booking class. Test plan 1) Run t/db_dependent/Koha/Booking.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 David Nind changed: What|Removed |Added Attachment #161827|0 |1 is obsolete|| --- Comment #37 from David Nind --- Created attachment 161867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161867&action=edit Bug 35248: Remove Koha::Booking->intersects Another method left behind from an earlier iteration.. not actually called anywhere in the final submission in Koha. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 David Nind changed: What|Removed |Added Attachment #161826|0 |1 is obsolete|| --- Comment #36 from David Nind --- Created attachment 161866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161866&action=edit Bug 35248: Add test for Koha::Exceptions::Booking Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 David Nind changed: What|Removed |Added Attachment #161825|0 |1 is obsolete|| --- Comment #35 from David Nind --- Created attachment 161865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161865&action=edit Bug 35248: Drop ->place_booking These methods were introduced and used in an earlier iteration of the code, they are no longer called from anywhere (the code in Koha::Booking->store handles all cases instead) and thus I choose to remove them rather than add unit tests for them.. They are simple methods that could be re-introduced as required at a future date. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 David Nind changed: What|Removed |Added Attachment #161824|0 |1 is obsolete|| --- Comment #34 from David Nind --- Created attachment 161864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161864&action=edit Bug 35248: Add unit tests for Koha::Item->check_booking This patch adds basic unit tests for the Koha::Item->check_booking method. Test plan 1) Run t/db_dependant/Koha/Item.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 David Nind changed: What|Removed |Added Attachment #161823|0 |1 is obsolete|| --- Comment #33 from David Nind --- Created attachment 161863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161863&action=edit Bug 35248: Unit tests for CanBookBeIssued Whilst writing the test, I found a minor flaw in the logic and fixed that in CanBookBeIssued at the same time. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 David Nind changed: What|Removed |Added Attachment #161822|0 |1 is obsolete|| --- Comment #32 from David Nind --- Created attachment 161862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161862&action=edit Bug 35248: Add unit tests for Koha::Item->find_booking This patch adds basic unit tests for the Koha::Item->find_booking method. Test plan 1) Run t/db_dependant/Koha/Item.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 David Nind changed: What|Removed |Added Attachment #161821|0 |1 is obsolete|| --- Comment #31 from David Nind --- Created attachment 161861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161861&action=edit Bug 35248: Add unit test for Koha::Item->bookings relation This patch adds a simple unit test for the 'bookings' relation accessor added to Koha::Item. Test plan 1) Run t/db_dependant/Koha/Item.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #30 from Martin Renvoize --- Created attachment 161831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161831&action=edit Bug 35248: Add unit tests for Koha::Bibilio->bookable_items This patch adds basic unit tests for Koha::Biblio->bookable_items Test plan 1) Run t/db_dependent/Koha/Biblio.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Attachment #161660|0 |1 is obsolete|| --- Comment #29 from Martin Renvoize --- Created attachment 161830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161830&action=edit Bug 35248: Add unit tests for Koha::Bibilio->check_booking This patch adds basic unit tests for Koha::Biblio->check_booking Test plan 1) Run t/db_dependent/Koha/Biblio.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Attachment #161659|0 |1 is obsolete|| --- Comment #28 from Martin Renvoize --- Created attachment 161829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161829&action=edit Bug 35248: Add Koha::Biblio->bookings unit test This patch adds unit tests for the bookings relationship accessor on Koha::Biblio objects. Test plan 1) Run t/db_dependant/Koha/Biblio.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Attachment #161658|0 |1 is obsolete|| --- Comment #27 from Martin Renvoize --- Created attachment 161828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161828&action=edit Bug 35248: Add unit tests for Koha::Booking relations This patch adds unit tests for the relations introduced in the new Koha::Booking class. Test plan 1) Run t/db_dependent/Koha/Booking.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Attachment #161657|0 |1 is obsolete|| --- Comment #26 from Martin Renvoize --- Created attachment 161827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161827&action=edit Bug 35248: Remove Koha::Booking->intersects Another method left behind from an earlier iteration.. not actually called anywhere in the final submission in Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Attachment #161656|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 161826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161826&action=edit Bug 35248: Add test for Koha::Exceptions::Booking -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Attachment #161655|0 |1 is obsolete|| --- Comment #24 from Martin Renvoize --- Created attachment 161825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161825&action=edit Bug 35248: Drop ->place_booking These methods were introduced and used in an earlier iteration of the code, they are no longer called from anywhere (the code in Koha::Booking->store handles all cases instead) and thus I choose to remove them rather than add unit tests for them.. They are simple methods that could be re-introduced as required at a future date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Attachment #161654|0 |1 is obsolete|| --- Comment #23 from Martin Renvoize --- Created attachment 161824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161824&action=edit Bug 35248: Add unit tests for Koha::Item->check_booking This patch adds basic unit tests for the Koha::Item->check_booking method. Test plan 1) Run t/db_dependant/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Attachment #161653|0 |1 is obsolete|| --- Comment #22 from Martin Renvoize --- Created attachment 161823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161823&action=edit Bug 35248: Unit tests for CanBookBeIssued Whilst writing the test, I found a minor flaw in the logic and fixed that in CanBookBeIssued at the same time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Attachment #161652|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 161822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161822&action=edit Bug 35248: Add unit tests for Koha::Item->find_booking This patch adds basic unit tests for the Koha::Item->find_booking method. Test plan 1) Run t/db_dependant/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Attachment #161651|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize --- Created attachment 161821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161821&action=edit Bug 35248: Add unit test for Koha::Item->bookings relation This patch adds a simple unit test for the 'bookings' relation accessor added to Koha::Item. Test plan 1) Run t/db_dependant/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Depends on|29002 |35788 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35788 [Bug 35788] Remove Koha::Template::Plugin::Biblio::BookingsCount -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Blocks||35906 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 [Bug 35906] Add bookable option on itemtypes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #19 from Martin Renvoize --- There's still more to come here.. but I really think as people are starting to enhance and expand on bookings now we need these in sooner rather than later... setting to NSO to start getting eyes and I'll keep throwing more tests into further bugs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #18 from Martin Renvoize --- Created attachment 161660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161660&action=edit Bug 35248: Add unit tests for Koha::Bibilio->check_booking This patch adds basic unit tests for Koha::Biblio->check_booking Test plan 1) Run t/db_dependent/Koha/Biblio.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #17 from Martin Renvoize --- Created attachment 161659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161659&action=edit Bug 35248: Add Koha::Biblio->bookings unit test This patch adds unit tests for the bookings relationship accessor on Koha::Biblio objects. Test plan 1) Run t/db_dependant/Koha/Biblio.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Attachment #161636|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize --- Created attachment 161658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161658&action=edit Bug 35248: Add unit tests for Koha::Booking relations This patch adds unit tests for the relations introduced in the new Koha::Booking class. Test plan 1) Run t/db_dependent/Koha/Booking.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Attachment #161632|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 161657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161657&action=edit Bug 35248: Remove Koha::Booking->intersects Another method left behind from an earlier iteration.. not actually called anywhere in the final submission in Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Attachment #161621|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 161656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161656&action=edit Bug 35248: Add test for Koha::Exceptions::Booking -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Attachment #161620|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 161655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161655&action=edit Bug 35248: Drop ->place_booking These methods were introduced and used in an earlier iteration of the code, they are no longer called from anywhere (the code in Koha::Booking->store handles all cases instead) and thus I choose to remove them rather than add unit tests for them.. They are simple methods that could be re-introduced as required at a future date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Attachment #161611|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 161654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161654&action=edit Bug 35248: Add unit tests for Koha::Item->check_booking This patch adds basic unit tests for the Koha::Item->check_booking method. Test plan 1) Run t/db_dependant/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Attachment #161608|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 161653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161653&action=edit Bug 35248: Unit tests for CanBookBeIssued Whilst writing the test, I found a minor flaw in the logic and fixed that in CanBookBeIssued at the same time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Attachment #161062|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 161652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161652&action=edit Bug 35248: Add unit tests for Koha::Item->find_booking This patch adds basic unit tests for the Koha::Item->find_booking method. Test plan 1) Run t/db_dependant/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 Martin Renvoize changed: What|Removed |Added Attachment #161061|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 161651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161651&action=edit Bug 35248: Add unit test for Koha::Item->bookings relation This patch adds a simple unit test for the 'bookings' relation accessor added to Koha::Item. Test plan 1) Run t/db_dependant/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #8 from Martin Renvoize --- Created attachment 161636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161636&action=edit Bug 35248: Add unit tests for Koha::Booking relations This patch adds unit tests for the relations introduced in the new Koha::Booking class. Test plan 1) Run t/db_dependent/Koha/Booking.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #7 from Martin Renvoize --- Created attachment 161632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161632&action=edit Bug 35248: Remove Koha::Booking->intersects Another method left behind from an earlier iteration.. not actually called anywhere in the final submission in Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #6 from Martin Renvoize --- Created attachment 161621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161621&action=edit Bug 35248: Add test for Koha::Exceptions::Booking -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #5 from Martin Renvoize --- Created attachment 161620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161620&action=edit Bug 35248: Drop ->place_booking These methods were introduced and used in an earlier iteration of the code, they are no longer called from anywhere (the code in Koha::Booking->store handles all cases instead) and thus I choose to remove them rather than add unit tests for them.. They are simple methods that could be re-introduced as required at a future date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #4 from Martin Renvoize --- Created attachment 161611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161611&action=edit Bug 35248: Add unit tests for Koha::Item->check_booking This patch adds basic unit tests for the Koha::Item->check_booking method. Test plan 1) Run t/db_dependant/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #3 from Martin Renvoize --- Created attachment 161608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161608&action=edit Bug 35248: Unit tests for CanBookBeIssued Whilst writing the test, I found a minor flaw in the logic and fixed that in CanBookBeIssued at the same time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #2 from Martin Renvoize --- Created attachment 161062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161062&action=edit Bug 35248: Add unit tests for Koha::Item->find_booking This patch adds basic unit tests for the Koha::Item->find_booking method. Test plan 1) Run t/db_dependant/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35248] Bookings needs unit tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35248 --- Comment #1 from Martin Renvoize --- Created attachment 161061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161061&action=edit Bug 35248: Add unit test for Koha::Item->bookings relation This patch adds a simple unit test for the 'bookings' relation accessor added to Koha::Item. Test plan 1) Run t/db_dependant/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
