[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-04-17 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #202 from Lucas Gass (lukeg)  ---
Please add release notes for this one!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-04-17 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #201 from Lucas Gass (lukeg)  ---
Nice work everyone!

Pushed to main for 26.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-04-17 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Version(s)||26.05.00
released in||
 Status|Passed QA   |Pushed to main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-04-17 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Jonathan Druart  changed:

   What|Removed |Added

 CC||[email protected]

--- Comment #200 from Jonathan Druart  ---
Don't ignore tidy errors, it will break Jenkins ;)

If something cannot be parsed by prettier you need to flag it with
prettier-ignore to ignore. See previous patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-04-17 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #199 from Jonathan Druart  ---
Created attachment 197692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197692&action=edit
Bug 35267: Ignore style tags with TT tags

Patch from commit c5767f8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-04-17 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Lucas Gass (lukeg)  changed:

   What|Removed |Added

   Keywords|roadmap_25_05   |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-04-16 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-04-16 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #198 from Martin Renvoize (ashimema) 
 ---
Created attachment 197501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197501&action=edit
Bug 35267: (follow-up) Add POD coverage for private subroutines

Add POD documentation for private subroutines in C4/Letters.pm and
fix the POD heading for _type in Koha/Notice/Message.pm to satisfy
the pod_coverage QA check.

Also fixes a typo in the existing _add_attachments POD heading
(_add_attachements → _add_attachments).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-04-16 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #197 from Thomas Klausner  ---
I agree that that's a false error reported by the tidyer, and have mentioned
this in comment#182
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267#c182 before
setting PassQA.

So I think we can set the status again to PassQA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-04-16 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #196 from Martin Renvoize (ashimema) 
 ---
The tidy script runs Prettier on the template, and Prettier's CSS parser chokes
on:

  [% all_notice_css | $raw %]

It tries to parse [% all_notice_css | $raw %] as CSS and fails with
CssSyntaxError: Unknown word. This is a Template Toolkit variable being
injected as raw CSS — Prettier fundamentally cannot parse this. The tidy tool
itself confirms "Some files cannot be tidied" and exits with the same error.

This is a false catch in the QA script in my opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-04-15 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #195 from Lucas Gass (lukeg)  ---
There is some stuff that is not tidy in print-notices.tt. I would just make a
tidy commit and continue here. But when I do so:

kohadev-koha@kohadevbox:koha(main)$ perl misc/devel/tidy.pl
koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt
Tidying file 1/1
(koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt)
[error] wN54SkWCa9.tt: SyntaxError: CssSyntaxError: Unknown word [ (1:1)
[error] > 1 | [% all_notice_css | $raw %]
[error] | ^ at misc/devel/tidy.pl line 108.

Some files cannot be tidied:
* koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt
[error] wN54SkWCa9.tt: SyntaxError: CssSyntaxError: Unknown word [ (1:1)
[error] > 1 | [% all_notice_css | $raw %]
[error] | ^

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #194 from Thomas Klausner  ---
Created attachment 196495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196495&action=edit
Bug 35267: (follow-up) Adapt atomicupdate to new DB schema

and add a missing newline

Signed-off-by: Thomas Klausner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #193 from Thomas Klausner  ---
Created attachment 196494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196494&action=edit
Bug 35267: (follow-up) Fix PrintSlipCSS accordion and CSS in HTML output

- Add missing PrintSlipCSS accordion panel to the notice editor
- Pass AllNoticeCSS and PrintNoticeCSS to gather_print_notices.pl HTML output
- Include inline

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #192 from Thomas Klausner  ---
Created attachment 196493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196493&action=edit
Bug 35267: (follow-up) More comprehensive and db agnostic tests

This patch updates our unit tests to be more agnostic to prior database
state during testing by mocking more of the preferences.

We also add more tests to ensure we fully cover the new preferences and
their options.

Signed-off-by: Marion Durand 
Signed-off-by: Thomas Klausner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #191 from Thomas Klausner  ---
Created attachment 196492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196492&action=edit
Bug 35267: (follow-up) Remove 'apply to all' from format

With the introduction of more granular global preferences for notice CSS
we no longer need the somewhat confusing per notice but apply to all
format checkbox. As suggested by Lucas, this patch removes that option.

This is safe to remove at this stage as the feature in question isn't
really working given the second bug implimenting most of the
functionality to expose it is still in the queue.

Sponsored-by: Open Fifth 
Signed-off-by: Marion Durand 
Signed-off-by: Thomas Klausner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #190 from Thomas Klausner  ---
Created attachment 196491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196491&action=edit
Bug 35267: (follow-up) Add explanatory note to CSS displays

This patch adds a simple explanatory note to each of the Notice CSS
display options in the notices template editor page

Signed-off-by: Marion Durand 
Signed-off-by: Thomas Klausner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #189 from Thomas Klausner  ---
Created attachment 196490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196490&action=edit
Bug 35267: Update unit tests

This patch simply updates the existing unit tests to rename NoticeCSS to
AllNoticesStylesheet as per the rest of the patchset.

Sponsored-by: Open Fifth 
Signed-off-by: Marion Durand 
Signed-off-by: Thomas Klausner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #188 from Thomas Klausner  ---
Created attachment 196489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196489&action=edit
Bug 35267: Migrate accounts_summary to printslip

This patch migrates the 'slip' printing for the ACCOUNTS_SUMMARY slip to
circ/printslip as this is a slip rather than a notice.

Sponsored-by: Open Fifth 
Signed-off-by: Marion Durand 
Signed-off-by: Thomas Klausner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #187 from Thomas Klausner  ---
Created attachment 196488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196488&action=edit
Bug 35267: Move JS to bottom in printslip

Sponsored-by: Open Fifth 
Signed-off-by: Marion Durand 
Signed-off-by: Thomas Klausner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #186 from Thomas Klausner  ---
Created attachment 196487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196487&action=edit
Bug 35267: Apply preferences to preview and mailing

This patch applies the new style preferences to the preview display and
email sending code.

Sponsored-by: Open Fifth 
Signed-off-by: Marion Durand 
Signed-off-by: Thomas Klausner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #185 from Thomas Klausner  ---
Created attachment 196486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196486&action=edit
Bug 35267: Expose style preferences in template editor

Sponsored-by: Open Fifth 
Signed-off-by: Marion Durand 
Signed-off-by: Thomas Klausner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #184 from Thomas Klausner  ---
Created attachment 196485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196485&action=edit
Bug 35267: Add preferences to UI

Sponsored-by: Open Fifth 
Signed-off-by: Marion Durand 
Signed-off-by: Thomas Klausner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #183 from Thomas Klausner  ---
Created attachment 196484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196484&action=edit
Bug 35267: Add and Update Notice CSS system preferences

This patch clarifies the system level notice css preferences.

We rename NoticeCSS to EmailNoticeStylesheet
We rename SlipCSS to PrintSlipStylesheet
We add AllNoticeStylesheet
We add AllNoticeCSS to contain inline CSS for all html notices
We add EmailNoticeCSS to contain inline CSS for Email notices
We add PrintNoticeCSS to contain inline CSS for Print notices
We add PrintSlipCSS to contain inline CSS for Print slips

Sponsored-by: Open Fifth 
Signed-off-by: Marion Durand 
Signed-off-by: Thomas Klausner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Thomas Klausner  changed:

   What|Removed |Added

 Attachment #196365|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Thomas Klausner  changed:

   What|Removed |Added

 Attachment #196300|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Thomas Klausner  changed:

   What|Removed |Added

 Attachment #196299|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Thomas Klausner  changed:

   What|Removed |Added

 Attachment #196298|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Thomas Klausner  changed:

   What|Removed |Added

 Attachment #196297|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Thomas Klausner  changed:

   What|Removed |Added

 Attachment #196296|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Thomas Klausner  changed:

   What|Removed |Added

 Attachment #196295|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Thomas Klausner  changed:

   What|Removed |Added

 Attachment #196294|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Thomas Klausner  changed:

   What|Removed |Added

 Attachment #196293|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Thomas Klausner  changed:

   What|Removed |Added

 Attachment #196292|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Thomas Klausner  changed:

   What|Removed |Added

 Attachment #196291|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Thomas Klausner  changed:

   What|Removed |Added

 Attachment #196290|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Thomas Klausner  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-27 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #182 from Thomas Klausner  ---
The QA script complains in three places, but I guess we can ignore these:

There are pod_coverage errors for internal functions (i.e. starting with _,
like C4/Letters.pm, _add_attachments

And koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt is not tidy,
but the tidier cannot tidy:

Tidying file 1/1
(koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt)
[error] ImOA_AyQEd.tt: SyntaxError: CssSyntaxError: Unknown word [ (1:1)
[error] > 1 | [% all_notice_css | $raw %]
[error] | ^ at misc/devel/tidy.pl line 108.

So I will ignore these complaints

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Thomas Klausner  changed:

   What|Removed |Added

 QA Contact|[email protected]  |[email protected]
 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #181 from Thomas Klausner  ---
Created attachment 196365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196365&action=edit
Bug 35267: (follow-up) Adapt atomicupdate to new DB schema

and add a missing newline

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #172 from Marion Durand  ---
Created attachment 196293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196293&action=edit
Bug 35267: Apply preferences to preview and mailing

This patch applies the new style preferences to the preview display and
email sending code.

Sponsored-by: Open Fifth 
Signed-off-by: Marion Durand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #173 from Marion Durand  ---
Created attachment 196294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196294&action=edit
Bug 35267: Move JS to bottom in printslip

Sponsored-by: Open Fifth 
Signed-off-by: Marion Durand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #180 from Marion Durand  ---
I just did a quick rebase and tested again.

It worked perfectly. Thank you everyone !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #179 from Marion Durand  ---
Created attachment 196300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196300&action=edit
Bug 35267: (follow-up) Fix PrintSlipCSS accordion and CSS in HTML output

- Add missing PrintSlipCSS accordion panel to the notice editor
- Pass AllNoticeCSS and PrintNoticeCSS to gather_print_notices.pl HTML output
- Include inline

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #178 from Marion Durand  ---
Created attachment 196299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196299&action=edit
Bug 35267: (follow-up) More comprehensive and db agnostic tests

This patch updates our unit tests to be more agnostic to prior database
state during testing by mocking more of the preferences.

We also add more tests to ensure we fully cover the new preferences and
their options.

Signed-off-by: Marion Durand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #177 from Marion Durand  ---
Created attachment 196298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196298&action=edit
Bug 35267: (follow-up) Remove 'apply to all' from format

With the introduction of more granular global preferences for notice CSS
we no longer need the somewhat confusing per notice but apply to all
format checkbox. As suggested by Lucas, this patch removes that option.

This is safe to remove at this stage as the feature in question isn't
really working given the second bug implimenting most of the
functionality to expose it is still in the queue.

Sponsored-by: Open Fifth 
Signed-off-by: Marion Durand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #176 from Marion Durand  ---
Created attachment 196297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196297&action=edit
Bug 35267: (follow-up) Add explanatory note to CSS displays

This patch adds a simple explanatory note to each of the Notice CSS
display options in the notices template editor page

Signed-off-by: Marion Durand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #175 from Marion Durand  ---
Created attachment 196296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196296&action=edit
Bug 35267: Update unit tests

This patch simply updates the existing unit tests to rename NoticeCSS to
AllNoticesStylesheet as per the rest of the patchset.

Sponsored-by: Open Fifth 
Signed-off-by: Marion Durand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #174 from Marion Durand  ---
Created attachment 196295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196295&action=edit
Bug 35267: Migrate accounts_summary to printslip

This patch migrates the 'slip' printing for the ACCOUNTS_SUMMARY slip to
circ/printslip as this is a slip rather than a notice.

Sponsored-by: Open Fifth 
Signed-off-by: Marion Durand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #169 from Marion Durand  ---
Created attachment 196290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196290&action=edit
Bug 35267: Add and Update Notice CSS system preferences

This patch clarifies the system level notice css preferences.

We rename NoticeCSS to EmailNoticeStylesheet
We rename SlipCSS to PrintSlipStylesheet
We add AllNoticeStylesheet
We add AllNoticeCSS to contain inline CSS for all html notices
We add EmailNoticeCSS to contain inline CSS for Email notices
We add PrintNoticeCSS to contain inline CSS for Print notices
We add PrintSlipCSS to contain inline CSS for Print slips

Sponsored-by: Open Fifth 
Signed-off-by: Marion Durand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #171 from Marion Durand  ---
Created attachment 196292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196292&action=edit
Bug 35267: Expose style preferences in template editor

Sponsored-by: Open Fifth 
Signed-off-by: Marion Durand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #170 from Marion Durand  ---
Created attachment 196291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196291&action=edit
Bug 35267: Add preferences to UI

Sponsored-by: Open Fifth 
Signed-off-by: Marion Durand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Attachment #196289|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Attachment #196285|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Attachment #196288|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Attachment #196287|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Attachment #196286|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Attachment #196281|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Attachment #196284|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Attachment #196283|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Attachment #196282|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Attachment #196280|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Attachment #196279|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #168 from Marion Durand  ---
I'm testing now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #167 from Marion Durand  ---
trivial rebase needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #166 from Marion Durand  ---
Created attachment 196289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196289&action=edit
Bug 35267: (follow-up) Fix PrintSlipCSS accordion and CSS in HTML output

- Add missing PrintSlipCSS accordion panel to the notice editor
- Pass AllNoticeCSS and PrintNoticeCSS to gather_print_notices.pl HTML output
- Include inline

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #165 from Marion Durand  ---
Created attachment 196288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196288&action=edit
Bug 35267: (follow-up) More comprehensive and db agnostic tests

This patch updates our unit tests to be more agnostic to prior database
state during testing by mocking more of the preferences.

We also add more tests to ensure we fully cover the new preferences and
their options.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #164 from Marion Durand  ---
Created attachment 196287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196287&action=edit
Bug 35267: (follow-up) Remove 'apply to all' from format

With the introduction of more granular global preferences for notice CSS
we no longer need the somewhat confusing per notice but apply to all
format checkbox. As suggested by Lucas, this patch removes that option.

This is safe to remove at this stage as the feature in question isn't
really working given the second bug implimenting most of the
functionality to expose it is still in the queue.

Sponsored-by: Open Fifth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #163 from Marion Durand  ---
Created attachment 196286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196286&action=edit
Bug 35267: (follow-up) Add explanatory note to CSS displays

This patch adds a simple explanatory note to each of the Notice CSS
display options in the notices template editor page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #162 from Marion Durand  ---
Created attachment 196285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196285&action=edit
Bug 35267: Update unit tests

This patch simply updates the existing unit tests to rename NoticeCSS to
AllNoticesStylesheet as per the rest of the patchset.

Sponsored-by: Open Fifth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #161 from Marion Durand  ---
Created attachment 196284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196284&action=edit
Bug 35267: Migrate accounts_summary to printslip

This patch migrates the 'slip' printing for the ACCOUNTS_SUMMARY slip to
circ/printslip as this is a slip rather than a notice.

Sponsored-by: Open Fifth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #160 from Marion Durand  ---
Created attachment 196283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196283&action=edit
Bug 35267: Move JS to bottom in printslip

Sponsored-by: Open Fifth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #159 from Marion Durand  ---
Created attachment 196282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196282&action=edit
Bug 35267: Apply preferences to preview and mailing

This patch applies the new style preferences to the preview display and
email sending code.

Sponsored-by: Open Fifth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #158 from Marion Durand  ---
Created attachment 196281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196281&action=edit
Bug 35267: Expose style preferences in template editor

Sponsored-by: Open Fifth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #157 from Marion Durand  ---
Created attachment 196280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196280&action=edit
Bug 35267: Add preferences to UI

Sponsored-by: Open Fifth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #156 from Marion Durand  ---
Created attachment 196279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196279&action=edit
Bug 35267: Add and Update Notice CSS system preferences

This patch clarifies the system level notice css preferences.

We rename NoticeCSS to EmailNoticeStylesheet
We rename SlipCSS to PrintSlipStylesheet
We add AllNoticeStylesheet
We add AllNoticeCSS to contain inline CSS for all html notices
We add EmailNoticeCSS to contain inline CSS for Email notices
We add PrintNoticeCSS to contain inline CSS for Print notices
We add PrintSlipCSS to contain inline CSS for Print slips

Sponsored-by: Open Fifth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Attachment #196239|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Attachment #196238|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Attachment #196237|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Attachment #196236|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Attachment #196235|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Attachment #196234|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Attachment #196232|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Attachment #196233|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Attachment #196231|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Attachment #196230|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

Marion Durand  changed:

   What|Removed |Added

 Attachment #196229|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #155 from Martin Renvoize (ashimema) 
 ---
Have you got that last patch applied.. the one that fixes this?

I just ran through the test plan again myself to check, I see the CSS blocks
near the top of the generated file in the .

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #154 from Emmanuel Bétemps  ---
The 3rd and 4th steps "gather_print_notices.pl — HTML output" don't work
-> we did not see any of the 2 blocks containing the AllNoticeCSS or
PrintNoticeCSS rules.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #153 from Martin Renvoize (ashimema) 
 ---
Thankyou for all the testing.. I've updated the test plan a little, but it's
mostly the same.. just removing some of the historical bits.

I've also added a final patch to address your testing result.. seems we lost
some bits over the years fo rebases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #152 from Martin Renvoize (ashimema) 
 ---
  Updated Test Plan

  # Test plan

  ## Setup
  1) Apply patches and run database updates
  2) Verify that 'NoticeCSS' and 'SlipCSS' have been renamed to
 'EmailNoticeStylesheet' and 'PrintSlipStylesheet' in
 Admin > System preferences > Tools > Notices and slips
  3) Confirm that 'AllNoticeCSS', 'EmailNoticeCSS', 'PrintNoticeCSS'
 and 'PrintSlipCSS' are present in the same location

  ## UI — Accordion display
  1) Go to Tools > Notices and Slips, edit any notice
  2) Confirm a 'Global HTML Notice Styles' section is present near
 the top with four collapsible panels:
 - All Notice CSS
 - Email Notice CSS
 - Print Notice CSS
 - Print Slip CSS
  3) Each empty panel should show "None defined"
  4) If you have syspref admin rights, each panel should show an
 'Edit' shortcut link

  ## Adding styles
  1) Add to 'AllNoticeCSS':   .alltest { color: red }
  2) Add to 'EmailNoticeCSS': .emailtest { color: green }
  3) Add to 'PrintNoticeCSS': .printtest { color: orange }
  4) Confirm all four accordion panels now show their CSS content

  ## Notice template
  Edit the WELCOME notice HTML template to include:
  ```html
  
This is a notice for testing
All message transport types should display this
red
Only email notices should display this
green
Only print notices should display this
orange
All done
  

  Queuing test notices (using patron 'Henry A')

  1. Remove Henry's email address; queue a Welcome print notice via
  More > Send welcome
  2. Add a primary email for Henry; queue a Welcome email notice via
  More > Send welcome
  3. On Henry's Notices tab, click the print notice title — confirm
  red and orange text are shown, green is not
  4. Click the email notice title — confirm red and green text are
  shown, orange is not

  gather_print_notices.pl — HTML output

  1. Run: gather_print_notices.pl --output html
  2. Open the generated HTML file
  3. Confirm a  block containing the AllNoticeCSS rules is
  present in the
  4. Confirm a  block containing the PrintNoticeCSS rules is
  present in the
  5. Confirm the notice content renders with the correct colors
  (red for .alltest, orange for .printtest)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #151 from Martin Renvoize (ashimema) 
 ---
Created attachment 196239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196239&action=edit
Bug 35267: (follow-up) Fix PrintSlipCSS accordion and CSS in HTML output

- Add missing PrintSlipCSS accordion panel to the notice editor
- Pass AllNoticeCSS and PrintNoticeCSS to gather_print_notices.pl HTML output
- Include inline

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #150 from Martin Renvoize (ashimema) 
 ---
Created attachment 196238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196238&action=edit
Bug 35267: (follow-up) More comprehensive and db agnostic tests

This patch updates our unit tests to be more agnostic to prior database
state during testing by mocking more of the preferences.

We also add more tests to ensure we fully cover the new preferences and
their options.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #149 from Martin Renvoize (ashimema) 
 ---
Created attachment 196237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196237&action=edit
Bug 35267: (follow-up) Remove 'apply to all' from format

With the introduction of more granular global preferences for notice CSS
we no longer need the somewhat confusing per notice but apply to all
format checkbox. As suggested by Lucas, this patch removes that option.

This is safe to remove at this stage as the feature in question isn't
really working given the second bug implimenting most of the
functionality to expose it is still in the queue.

Sponsored-by: Open Fifth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #148 from Martin Renvoize (ashimema) 
 ---
Created attachment 196236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196236&action=edit
Bug 35267: (follow-up) Add explanatory note to CSS displays

This patch adds a simple explanatory note to each of the Notice CSS
display options in the notices template editor page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #147 from Martin Renvoize (ashimema) 
 ---
Created attachment 196235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196235&action=edit
Bug 35267: Update unit tests

This patch simply updates the existing unit tests to rename NoticeCSS to
AllNoticesStylesheet as per the rest of the patchset.

Sponsored-by: Open Fifth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #146 from Martin Renvoize (ashimema) 
 ---
Created attachment 196234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196234&action=edit
Bug 35267: Migrate accounts_summary to printslip

This patch migrates the 'slip' printing for the ACCOUNTS_SUMMARY slip to
circ/printslip as this is a slip rather than a notice.

Sponsored-by: Open Fifth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #145 from Martin Renvoize (ashimema) 
 ---
Created attachment 196233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196233&action=edit
Bug 35267: Move JS to bottom in printslip

Sponsored-by: Open Fifth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #144 from Martin Renvoize (ashimema) 
 ---
Created attachment 196232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196232&action=edit
Bug 35267: Apply preferences to preview and mailing

This patch applies the new style preferences to the preview display and
email sending code.

Sponsored-by: Open Fifth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 35267] Clarify CSS options for Notices

2026-03-26 Thread bugzilla-daemon--- via Koha-bugs 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35267

--- Comment #143 from Martin Renvoize (ashimema) 
 ---
Created attachment 196231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196231&action=edit
Bug 35267: Expose style preferences in template editor

Sponsored-by: Open Fifth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

  1   2   3   >