[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-05-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Katrin Fischer  changed:

   What|Removed |Added

   Keywords|additional_work_needed, |
   |release-notes-needed|

--- Comment #145 from Katrin Fischer  ---
Another missed kitten, picked up for main now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

  Text to go in the||With this new feature
  release notes||enabled, users no longer
   ||need to select a backend
   ||when submitting an ILL
   ||request. Instead, the
   ||Standard form is always
   ||displayed, and Koha
   ||automatically determines
   ||the best backend to use
   ||based on availability and
   ||priority settings. For
   ||staff, a "Confirm request"
   ||screen is displayed to
   ||verify the suggested
   ||backend.
   ||Compatible
   ||backends must implement the
   ||provides_backend_availabili
   ||ty_check capability and
   ||implement the
   ||availability_check_info
   ||method.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-18 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604
Bug 35604 depends on bug 36662, which changed state.

Bug 36662 Summary: ILL - t/db_dependent/Illrequest should not exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36662

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #144 from Pedro Amorim  ---
Created attachment 180956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180956&action=edit
Bug 35604: (QA follow-up): Update UI message if feature cannot be utilized

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #143 from Katrin Fischer  ---
(In reply to Pedro Amorim from comment #142)
> (In reply to Katrin Fischer from comment #140)
> > 2) The new system preference now shows: "No available backends". I have been
> > wondering if it would be clearer to say: Only one backend available. (when
> > only standard is there) (not blocker)
> 
> 
> Only the Standard backend is available. Additional backends are required to
> use this feature.
> 
> 
> Would you agree to the above?

I think that would be a very helpful message :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #141 from Katrin Fischer  ---
Pushed for 25.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #142 from Pedro Amorim  ---
(In reply to Katrin Fischer from comment #140)
> 2) The new system preference now shows: "No available backends". I have been
> wondering if it would be clearer to say: Only one backend available. (when
> only standard is there) (not blocker)


Only the Standard backend is available. Additional backends are required to use
this feature.


Would you agree to the above?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to main
 Version(s)||25.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Katrin Fischer  changed:

   What|Removed |Added

   Keywords|rel_25_05_candidate |additional_work_needed

--- Comment #140 from Katrin Fischer  ---
1) I double checked the file, but this seems to be a false positive? Can you
please check as well just in case?

 FAIL   installer/data/mysql/mandatory/sysprefs.sql
   FAIL   semicolon
simicolon found instead of comma at line 881

(also spelling error: simicolon)

2) The new system preference now shows: "No available backends". I have been
wondering if it would be clearer to say: Only one backend available. (when only
standard is there) (not blocker)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #117 from Pedro Amorim  ---
Created attachment 179698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179698&action=edit
Bug 35604: Multiple QA followups

Multiple fixes:
- File permmissions
- Capitalization
- Translatability
- Use of console.log
- Atomic update description typo fix

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Tomás Cohen Arazi (tcohen)  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #138 from Tomás Cohen Arazi (tcohen)  ---
Great job, team. Thanks for promptly following up on things we talked about!
Hope you agree with the follow-up. Happy to discuss if required.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #119 from Pedro Amorim  ---
(In reply to Katrin Fischer from comment #116)
> 3) System preference 
> 
> - Availability checking is mentioned the first time in the pref description,
> but not in other places.
> - type is given as ILLBackends in kohastructure.sql, but as ill-backends in
> the yaml.
> 
> If I understand correctly the preference won't work with only Standard. You
> need at least 2 backends installed and you need the availability check
> plugin/capability implemented in backend for these, is that correct? 

Thank you so much for looking Katrin. The pref will work with at least 1
installed backend, and the backend must provide the
provides_backend_availability_check capability and implement the
availability_check_info method, that's correct.

Examples can be found here:
https://github.com/PTFS-Europe/koha-ill-libkey-lending-tool/blob/main/Koha/Plugin/Com/PTFSEurope/IncDocs.pm#L142
https://github.com/PTFS-Europe/koha-ill-reprintsdesk/blob/pluginify%2B%2B/Koha/Plugin/Com/PTFSEurope/ReprintsDesk.pm#L225

If only one supporting backend is installed, and the syspref is enabled with
that single backend, the automatic backend screen will first check that
backend, recommend it if the document being queried is available in it, or
default to Standard otherwise, effectivelly making the choice for the Staff
member of which backend should be used a particular ILL request.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #124 from Tomás Cohen Arazi (tcohen)  ---
Created attachment 180452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180452&action=edit
Bug 35604: New 'ill-backends' syspref type

UI rendering of sortable ILL backends

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #127 from Tomás Cohen Arazi (tcohen)  ---
Created attachment 180455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180455&action=edit
Bug 35604: ILL request creation with AutoILLBackendPriority enabled

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #125 from Tomás Cohen Arazi (tcohen)  ---
Created attachment 180453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180453&action=edit
Bug 35604: New AutoILLBackendPriority sys prefs

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Tomás Cohen Arazi (tcohen)  changed:

   What|Removed |Added

 Attachment #178707|0   |1
is obsolete||
 Attachment #178708|0   |1
is obsolete||
 Attachment #178709|0   |1
is obsolete||
 Attachment #178710|0   |1
is obsolete||
 Attachment #178711|0   |1
is obsolete||
 Attachment #178712|0   |1
is obsolete||
 Attachment #178713|0   |1
is obsolete||
 Attachment #178714|0   |1
is obsolete||
 Attachment #178715|0   |1
is obsolete||
 Attachment #178716|0   |1
is obsolete||
 Attachment #178717|0   |1
is obsolete||
 Attachment #178718|0   |1
is obsolete||
 Attachment #179721|0   |1
is obsolete||
 Attachment #180335|0   |1
is obsolete||

--- Comment #123 from Tomás Cohen Arazi (tcohen)  ---
Created attachment 180451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180451&action=edit
Bug 35604: New Backends.pm class. installed_backends method

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #135 from Tomás Cohen Arazi (tcohen)  ---
Created attachment 180463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180463&action=edit
Bug 35604: Multiple QA followups

Multiple fixes:
- File permmissions
- Capitalization
- Translatability
- Use of console.log
- Atomic update description typo fix
- Remove occurrences of 'auto' and 'automatic':
  User testing reported that making a UI distinction between 'regular' and
'automatic' ILL requests is redundant.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #139 from Pedro Amorim  ---
(In reply to Tomás Cohen Arazi (tcohen) from comment #138)
> Hope you agree with the follow-up. Happy to discuss if required.

Fully on board. Thank you very much!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #136 from Tomás Cohen Arazi (tcohen)  ---
Created attachment 180464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180464&action=edit
Bug 35604: (QA follow-up): Remove remaining 'automatic' occurrences

From Hackfest QA session

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #134 from Tomás Cohen Arazi (tcohen)  ---
Created attachment 180462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180462&action=edit
Bug 35604: (QA follow-up): Prevent more than one 'op' in form

This may happen if for example getting to the automatic backend screen from the
ILL availability screen.
'op' is already being added, skip it if already exists in ported metadata

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #128 from Tomás Cohen Arazi (tcohen)  ---
Created attachment 180456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180456&action=edit
Bug 35604: ConfirmAuto workflow stage

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Tomás Cohen Arazi (tcohen)  changed:

   What|Removed |Added

 QA Contact|martin.renvoize@openfifth.c |tomasco...@gmail.com
   |o.uk|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #137 from Tomás Cohen Arazi (tcohen)  ---
Created attachment 180465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180465&action=edit
Bug 35604: Move available_backends() to Koha::ILL::Request::Config

This patch removes the the Koha::ILL::Backends class as it is not
actually a Koha::Objects-based class as it claims, and also internally
instantiates the config class, which could just hold the only defined
method.

This method is only used in the preferences.pl page, and its occurence
is fixed by this patch.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #133 from Tomás Cohen Arazi (tcohen)  ---
Created attachment 180461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180461&action=edit
Bug 35604: (QA follow-up): Fix find-missing-op-in-forms.t

prove xt/find-missing-op-in-forms.t

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #132 from Tomás Cohen Arazi (tcohen)  ---
Created attachment 180460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180460&action=edit
Bug 35604: (QA follow-up): Cosmetic improvements

These are improvements to the confirm auto backend stage screen on the Staff
UI.
Result of a chat with Tomas about this development.

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #131 from Tomás Cohen Arazi (tcohen)  ---
Created attachment 180459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180459&action=edit
Bug 35604: Display success message

Consider success message from backend and present it.
Add btn-primary class to auto ILL screen

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #130 from Tomás Cohen Arazi (tcohen)  ---
Created attachment 180458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180458&action=edit
Bug 35604: Add tests

Test plan:
Apply patches

Staff:
1) Visit the ILL sysprefs page:
/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans
2) Enable ILLModule
3) Check the new AutoILLBackendPriority syspref. Notice it shows "No available
backends"
4) Install 2 backend plugins from here:
https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.5
https://github.com/PTFS-Europe/koha-ill-reprintsdesk/releases/tag/rc-v3.0.0
5) Repeat 1. Notice the backends now show.
6) Enable both for AutoILLBackendPriority by ticking each respective checkbox.
Save.
7) Visit ILL requests:
http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl
8) Press "New auto ILL request"
9) You are presented the "Standard" create form. Pick type "journal" and put
'123' on DOI. Enter '42' on cardnumber and pick a library. Click Create.
10) Notice you are now shown the "Confirm auto backend" stage screen.
11) PluginBackend has a 50% chance of being available or not for testing
purposes. If it is, it'll suggest PluginBackend, if not, it'll default to
Standard. ReprintsDesk will always error because it's missing credentials.
12) Pick any of the backends or accept the suggested one, click 'Create'. The
request has been placed in that specific backend.

OPAC:
1) Following from the previous test plan, visit OPAC ill requests:
http://localhost:8080/cgi-bin/koha/opac-illrequests.pl
2) Click "Create a new auto request" and repeat the same inputs as before.
Click 'Create'.
3) Notice you're directed to "Confirming your request" screen. It's doing the
same as it does in the Staff UI, except it does not allow the patron to pick a
different backend, it'll always selected the first available backend in the
priority.
4) Create more requests, you'll notice some of them will land on PluginBackend,
others will land on 'Standard' because PluginBackend will sometimes be
available and others not.

Do more testing:
- Reorder the backends in the AutoILLBackendPriority syspref and save, notice
they're shown and suggested accordingly after creating a request.
- Disable all backends from AutoILLBackendPriority. Notice the original
behaviour of requiring the user to select a backend before creating the request
is restored on both opac and staff.

Run unit tests:
prove t/db_dependent/Illrequest/ConfirmAuto.t
prove t/db_dependent/Koha/ILL/Backends.t

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #129 from Tomás Cohen Arazi (tcohen)  ---
Created attachment 180457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180457&action=edit
Bug 35604: Update 'Make an ILL request' link in OPAC search results page

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #126 from Tomás Cohen Arazi (tcohen)  ---
Created attachment 180454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180454&action=edit
Bug 35604: atomicupdate

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-04-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #122 from Pedro Amorim  ---
Created attachment 180335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180335&action=edit
Bug 35604: (QA follow-up): Remove remaining 'automatic' occurrences

From Hackfest QA session

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #179720|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #121 from Pedro Amorim  ---
Created attachment 179721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179721&action=edit
Bug 35604: Multiple QA followups

Multiple fixes:
- File permmissions
- Capitalization
- Translatability
- Use of console.log
- Atomic update description typo fix
- Remove occurrences of 'auto' and 'automatic':
  User testing reported that making a UI distinction between 'regular' and
'automatic' ILL requests is redundant.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #179699|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-03-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #120 from Pedro Amorim  ---
Created attachment 179720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179720&action=edit
Bug 35604: (QA follow-up): Remove occurrences of 'auto' and 'automatic'

User testing reported that making a UI distinction between 'regular' and
'automatic' ILL requests is redundant.
This patch reverts it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-03-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #179698|0   |1
is obsolete||

--- Comment #118 from Pedro Amorim  ---
Created attachment 179699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179699&action=edit
Bug 35604: Multiple QA followups

Multiple fixes:
- File permmissions
- Capitalization
- Translatability
- Use of console.log
- Atomic update description typo fix

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #116 from Katrin Fischer  ---
Starting with a first code review (always got to start somewhere :))

0) QA script

I am aware that some might be false positives, but I believe there are some
that need fixing as well:

 FAIL   installer/data/mysql/atomicupdate/bug_35604.pl
   FAIL   file permissions
File must have the exec flag

 FAIL   installer/data/mysql/mandatory/sysprefs.sql
   FAIL   semicolon
simicolon found instead of comma at line 879

 FAIL   koha-tmpl/intranet-tmpl/prog/js/ill-autobackend.js
   FAIL   forbidden patterns
forbidden pattern: console.log (line 68)

 FAIL   koha-tmpl/opac-tmpl/bootstrap/js/ill-autobackend.js
   FAIL   forbidden patterns
forbidden pattern: console.log (line 68)

 FAIL   t/db_dependent/Koha/ILL/Backends.t
   FAIL   file permissions
File must have the exec flag

 FAIL   t/db_dependent/Koha/ILL/Request/Workflow/ConfirmAuto.t
   FAIL   file permissions
File must have the exec flag

1) Koha/ILL/Request/Workflow/ConfirmAuto.pm

From the code comments this looks like display components handled in a module?
Maybe we can talk things through a bit, when I got a little deeper into the
feature set.

2) Tiny typo

+description => "Add new AutoILLBackendPriority system preferences",

We only add one :)

3) System preference 

- Availability checking is mentioned the first time in the pref description,
but not in other places.
- type is given as ILLBackends in kohastructure.sql, but as ill-backends in the
yaml.

If I understand correctly the preference won't work with only Standard. You
need at least 2 backends installed and you need the availability check
plugin/capability implemented in backend for these, is that correct? 

4) Capitalization

a)
+Make an automatic Interlibrary
loan request

Also wrong in the old part of the code: 
 Make an Interlibrary loan
request

5) Translatability

+let message = "Error";

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #178315|0   |1
is obsolete||

--- Comment #114 from Pedro Amorim  ---
Created attachment 178717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178717&action=edit
Bug 35604: (QA follow-up): Fix find-missing-op-in-forms.t

prove xt/find-missing-op-in-forms.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #178312|0   |1
is obsolete||

--- Comment #111 from Pedro Amorim  ---
Created attachment 178714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178714&action=edit
Bug 35604: Add tests

Test plan:
Apply patches

Staff:
1) Visit the ILL sysprefs page:
/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans
2) Enable ILLModule
3) Check the new AutoILLBackendPriority syspref. Notice it shows "No available
backends"
4) Install 2 backend plugins from here:
https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.5
https://github.com/PTFS-Europe/koha-ill-reprintsdesk/releases/tag/rc-v3.0.0
5) Repeat 1. Notice the backends now show.
6) Enable both for AutoILLBackendPriority by ticking each respective checkbox.
Save.
7) Visit ILL requests:
http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl
8) Press "New auto ILL request"
9) You are presented the "Standard" create form. Pick type "journal" and put
'123' on DOI. Enter '42' on cardnumber and pick a library. Click Create.
10) Notice you are now shown the "Confirm auto backend" stage screen.
11) PluginBackend has a 50% chance of being available or not for testing
purposes. If it is, it'll suggest PluginBackend, if not, it'll default to
Standard. ReprintsDesk will always error because it's missing credentials.
12) Pick any of the backends or accept the suggested one, click 'Create'. The
request has been placed in that specific backend.

OPAC:
1) Following from the previous test plan, visit OPAC ill requests:
http://localhost:8080/cgi-bin/koha/opac-illrequests.pl
2) Click "Create a new auto request" and repeat the same inputs as before.
Click 'Create'.
3) Notice you're directed to "Confirming your request" screen. It's doing the
same as it does in the Staff UI, except it does not allow the patron to pick a
different backend, it'll always selected the first available backend in the
priority.
4) Create more requests, you'll notice some of them will land on PluginBackend,
others will land on 'Standard' because PluginBackend will sometimes be
available and others not.

Do more testing:
- Reorder the backends in the AutoILLBackendPriority syspref and save, notice
they're shown and suggested accordingly after creating a request.
- Disable all backends from AutoILLBackendPriority. Notice the original
behaviour of requiring the user to select a backend before creating the request
is restored on both opac and staff.

Run unit tests:
prove t/db_dependent/Illrequest/ConfirmAuto.t
prove t/db_dependent/Koha/ILL/Backends.t

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #178316|0   |1
is obsolete||

--- Comment #115 from Pedro Amorim  ---
Created attachment 178718
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178718&action=edit
Bug 35604: (QA follow-up): Prevent more than one 'op' in form

This may happen if for example getting to the automatic backend screen from the
ILL availability screen.
'op' is already being added, skip it if already exists in ported metadata

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #178314|0   |1
is obsolete||

--- Comment #113 from Pedro Amorim  ---
Created attachment 178716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178716&action=edit
Bug 35604: (QA follow-up): Cosmetic improvements

These are improvements to the confirm auto backend stage screen on the Staff
UI.
Result of a chat with Tomas about this development.

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #178313|0   |1
is obsolete||

--- Comment #112 from Pedro Amorim  ---
Created attachment 178715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178715&action=edit
Bug 35604: Follow-up

Consider success message from backend and present it.
Add btn-primary class to auto ILL screen

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #178311|0   |1
is obsolete||

--- Comment #110 from Pedro Amorim  ---
Created attachment 178713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178713&action=edit
Bug 35604: Update 'Make an ILL request' link in OPAC search results page

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #178310|0   |1
is obsolete||

--- Comment #109 from Pedro Amorim  ---
Created attachment 178712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178712&action=edit
Bug 35604: ConfirmAuto workflow stage

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #178309|0   |1
is obsolete||

--- Comment #108 from Pedro Amorim  ---
Created attachment 178711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178711&action=edit
Bug 35604: ILL request creation with AutoILLBackendPriority enabled

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #178308|0   |1
is obsolete||

--- Comment #107 from Pedro Amorim  ---
Created attachment 178710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178710&action=edit
Bug 35604: atomicupdate

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #178306|0   |1
is obsolete||

--- Comment #105 from Pedro Amorim  ---
Created attachment 178708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178708&action=edit
Bug 35604: New 'ill-backends' syspref type

UI rendering of sortable ILL backends

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #178307|0   |1
is obsolete||

--- Comment #106 from Pedro Amorim  ---
Created attachment 178709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178709&action=edit
Bug 35604: New AutoILLBackendPriority sys prefs

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #178305|0   |1
is obsolete||

--- Comment #104 from Pedro Amorim  ---
Created attachment 178707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178707&action=edit
Bug 35604: New Backends.pm class. installed_backends method

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
 Status|Passed QA   |Patch doesn't apply

--- Comment #103 from Lucas Gass (lukeg)  ---
A very simple rebase is needed here now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176688|0   |1
is obsolete||

--- Comment #97 from Pedro Amorim  ---
Created attachment 178312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178312&action=edit
Bug 35604: Add tests

Test plan:
Apply patches

Staff:
1) Visit the ILL sysprefs page:
/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans
2) Enable ILLModule
3) Check the new AutoILLBackendPriority syspref. Notice it shows "No available
backends"
4) Install 2 backend plugins from here:
https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.5
https://github.com/PTFS-Europe/koha-ill-reprintsdesk/releases/tag/rc-v3.0.0
5) Repeat 1. Notice the backends now show.
6) Enable both for AutoILLBackendPriority by ticking each respective checkbox.
Save.
7) Visit ILL requests:
http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl
8) Press "New auto ILL request"
9) You are presented the "Standard" create form. Pick type "journal" and put
'123' on DOI. Enter '42' on cardnumber and pick a library. Click Create.
10) Notice you are now shown the "Confirm auto backend" stage screen.
11) PluginBackend has a 50% chance of being available or not for testing
purposes. If it is, it'll suggest PluginBackend, if not, it'll default to
Standard. ReprintsDesk will always error because it's missing credentials.
12) Pick any of the backends or accept the suggested one, click 'Create'. The
request has been placed in that specific backend.

OPAC:
1) Following from the previous test plan, visit OPAC ill requests:
http://localhost:8080/cgi-bin/koha/opac-illrequests.pl
2) Click "Create a new auto request" and repeat the same inputs as before.
Click 'Create'.
3) Notice you're directed to "Confirming your request" screen. It's doing the
same as it does in the Staff UI, except it does not allow the patron to pick a
different backend, it'll always selected the first available backend in the
priority.
4) Create more requests, you'll notice some of them will land on PluginBackend,
others will land on 'Standard' because PluginBackend will sometimes be
available and others not.

Do more testing:
- Reorder the backends in the AutoILLBackendPriority syspref and save, notice
they're shown and suggested accordingly after creating a request.
- Disable all backends from AutoILLBackendPriority. Notice the original
behaviour of requiring the user to select a backend before creating the request
is restored on both opac and staff.

Run unit tests:
prove t/db_dependent/Illrequest/ConfirmAuto.t
prove t/db_dependent/Koha/ILL/Backends.t

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #102 from Pedro Amorim  ---
Patches rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176692|0   |1
is obsolete||

--- Comment #101 from Pedro Amorim  ---
Created attachment 178316
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178316&action=edit
Bug 35604: (QA follow-up): Prevent more than one 'op' in form

This may happen if for example getting to the automatic backend screen from the
ILL availability screen.
'op' is already being added, skip it if already exists in ported metadata

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176691|0   |1
is obsolete||

--- Comment #100 from Pedro Amorim  ---
Created attachment 178315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178315&action=edit
Bug 35604: (QA follow-up): Fix find-missing-op-in-forms.t

prove xt/find-missing-op-in-forms.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176690|0   |1
is obsolete||

--- Comment #99 from Pedro Amorim  ---
Created attachment 178314
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178314&action=edit
Bug 35604: (QA follow-up): Cosmetic improvements

These are improvements to the confirm auto backend stage screen on the Staff
UI.
Result of a chat with Tomas about this development.

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176689|0   |1
is obsolete||

--- Comment #98 from Pedro Amorim  ---
Created attachment 178313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178313&action=edit
Bug 35604: Follow-up

Consider success message from backend and present it.
Add btn-primary class to auto ILL screen

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176687|0   |1
is obsolete||

--- Comment #96 from Pedro Amorim  ---
Created attachment 178311
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178311&action=edit
Bug 35604: Update 'Make an ILL request' link in OPAC search results page

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176686|0   |1
is obsolete||

--- Comment #95 from Pedro Amorim  ---
Created attachment 178310
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178310&action=edit
Bug 35604: ConfirmAuto workflow stage

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176685|0   |1
is obsolete||

--- Comment #94 from Pedro Amorim  ---
Created attachment 178309
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178309&action=edit
Bug 35604: ILL request creation with AutoILLBackendPriority enabled

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176684|0   |1
is obsolete||

--- Comment #93 from Pedro Amorim  ---
Created attachment 178308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178308&action=edit
Bug 35604: atomicupdate

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176683|0   |1
is obsolete||

--- Comment #92 from Pedro Amorim  ---
Created attachment 178307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178307&action=edit
Bug 35604: New AutoILLBackendPriority sys prefs

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176682|0   |1
is obsolete||

--- Comment #91 from Pedro Amorim  ---
Created attachment 178306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178306&action=edit
Bug 35604: New 'ill-backends' syspref type

UI rendering of sortable ILL backends

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176681|0   |1
is obsolete||

--- Comment #90 from Pedro Amorim  ---
Created attachment 178305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178305&action=edit
Bug 35604: New Backends.pm class. installed_backends method

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Tomás Cohen Arazi (tcohen)  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #89 from Tomás Cohen Arazi (tcohen)  ---
I didn't manage to rebase it using the `auto_rebaser.pl` tool.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Tomás Cohen Arazi (tcohen)  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-02-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Tomás Cohen Arazi (tcohen)  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176662|0   |1
is obsolete||

--- Comment #88 from Pedro Amorim  ---
Created attachment 176692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176692&action=edit
Bug 35604: (QA follow-up): Prevent more than one 'op' in form

This may happen if for example getting to the automatic backend screen from the
ILL availability screen.
'op' is already being added, skip it if already exists in ported metadata

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176572|0   |1
is obsolete||

--- Comment #87 from Pedro Amorim  ---
Created attachment 176691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176691&action=edit
Bug 35604: (QA follow-up): Fix find-missing-op-in-forms.t

prove xt/find-missing-op-in-forms.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176270|0   |1
is obsolete||

--- Comment #86 from Pedro Amorim  ---
Created attachment 176690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176690&action=edit
Bug 35604: (QA follow-up): Cosmetic improvements

These are improvements to the confirm auto backend stage screen on the Staff
UI.
Result of a chat with Tomas about this development.

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176269|0   |1
is obsolete||

--- Comment #85 from Pedro Amorim  ---
Created attachment 176689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176689&action=edit
Bug 35604: Follow-up

Consider success message from backend and present it.
Add btn-primary class to auto ILL screen

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176268|0   |1
is obsolete||

--- Comment #84 from Pedro Amorim  ---
Created attachment 176688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176688&action=edit
Bug 35604: Add tests

Test plan:
Apply patches

Staff:
1) Visit the ILL sysprefs page:
/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans
2) Enable ILLModule
3) Check the new AutoILLBackendPriority syspref. Notice it shows "No available
backends"
4) Install 2 backend plugins from here:
https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.5
https://github.com/PTFS-Europe/koha-ill-reprintsdesk/releases/tag/rc-v3.0.0
5) Repeat 1. Notice the backends now show.
6) Enable both for AutoILLBackendPriority by ticking each respective checkbox.
Save.
7) Visit ILL requests:
http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl
8) Press "New auto ILL request"
9) You are presented the "Standard" create form. Pick type "journal" and put
'123' on DOI. Enter '42' on cardnumber and pick a library. Click Create.
10) Notice you are now shown the "Confirm auto backend" stage screen.
11) PluginBackend has a 50% chance of being available or not for testing
purposes. If it is, it'll suggest PluginBackend, if not, it'll default to
Standard. ReprintsDesk will always error because it's missing credentials.
12) Pick any of the backends or accept the suggested one, click 'Create'. The
request has been placed in that specific backend.

OPAC:
1) Following from the previous test plan, visit OPAC ill requests:
http://localhost:8080/cgi-bin/koha/opac-illrequests.pl
2) Click "Create a new auto request" and repeat the same inputs as before.
Click 'Create'.
3) Notice you're directed to "Confirming your request" screen. It's doing the
same as it does in the Staff UI, except it does not allow the patron to pick a
different backend, it'll always selected the first available backend in the
priority.
4) Create more requests, you'll notice some of them will land on PluginBackend,
others will land on 'Standard' because PluginBackend will sometimes be
available and others not.

Do more testing:
- Reorder the backends in the AutoILLBackendPriority syspref and save, notice
they're shown and suggested accordingly after creating a request.
- Disable all backends from AutoILLBackendPriority. Notice the original
behaviour of requiring the user to select a backend before creating the request
is restored on both opac and staff.

Run unit tests:
prove t/db_dependent/Illrequest/ConfirmAuto.t
prove t/db_dependent/Koha/ILL/Backends.t

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176267|0   |1
is obsolete||

--- Comment #83 from Pedro Amorim  ---
Created attachment 176687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176687&action=edit
Bug 35604: Update 'Make an ILL request' link in OPAC search results page

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176266|0   |1
is obsolete||

--- Comment #82 from Pedro Amorim  ---
Created attachment 176686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176686&action=edit
Bug 35604: ConfirmAuto workflow stage

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176265|0   |1
is obsolete||

--- Comment #81 from Pedro Amorim  ---
Created attachment 176685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176685&action=edit
Bug 35604: ILL request creation with AutoILLBackendPriority enabled

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176264|0   |1
is obsolete||

--- Comment #80 from Pedro Amorim  ---
Created attachment 176684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176684&action=edit
Bug 35604: atomicupdate

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176263|0   |1
is obsolete||

--- Comment #79 from Pedro Amorim  ---
Created attachment 176683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176683&action=edit
Bug 35604: New AutoILLBackendPriority sys prefs

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176261|0   |1
is obsolete||

--- Comment #77 from Pedro Amorim  ---
Created attachment 176681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176681&action=edit
Bug 35604: New Backends.pm class. installed_backends method

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #176262|0   |1
is obsolete||

--- Comment #78 from Pedro Amorim  ---
Created attachment 176682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176682&action=edit
Bug 35604: New 'ill-backends' syspref type

UI rendering of sortable ILL backends

Sponsored-by: NHS England
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #76 from Pedro Amorim  ---
Created attachment 176662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176662&action=edit
Bug 35604: (QA follow-up): Prevent more than one 'op' in form

This may happen if for example getting to the automatic backend screen from the
ILL availability screen.
'op' is already being added, skip it if already exists in ported metadata

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #75 from Pedro Amorim  ---
Created attachment 176572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176572&action=edit
Bug 35604: (QA follow-up): Fix find-missing-op-in-forms.t

prove xt/find-missing-op-in-forms.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 QA Contact|tomasco...@gmail.com|martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #175836|0   |1
is obsolete||

--- Comment #73 from Martin Renvoize (ashimema) 
 ---
Created attachment 176269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176269&action=edit
Bug 35604: Follow-up

Consider success message from backend and present it.
Add btn-primary class to auto ILL screen

Sponsored-by: UKHSA - UK Health Security Agency
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #176036|0   |1
is obsolete||

--- Comment #74 from Martin Renvoize (ashimema) 
 ---
Created attachment 176270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176270&action=edit
Bug 35604: (QA follow-up): Cosmetic improvements

These are improvements to the confirm auto backend stage screen on the Staff
UI.
Result of a chat with Tomas about this development.

Sponsored-by: UKHSA - UK Health Security Agency
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #175835|0   |1
is obsolete||

--- Comment #72 from Martin Renvoize (ashimema) 
 ---
Created attachment 176268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176268&action=edit
Bug 35604: Add tests

Test plan:
Apply patches

Staff:
1) Visit the ILL sysprefs page:
/cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans
2) Enable ILLModule
3) Check the new AutoILLBackendPriority syspref. Notice it shows "No available
backends"
4) Install 2 backend plugins from here:
https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.5
https://github.com/PTFS-Europe/koha-ill-reprintsdesk/releases/tag/rc-v3.0.0
5) Repeat 1. Notice the backends now show.
6) Enable both for AutoILLBackendPriority by ticking each respective checkbox.
Save.
7) Visit ILL requests:
http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl
8) Press "New auto ILL request"
9) You are presented the "Standard" create form. Pick type "journal" and put
'123' on DOI. Enter '42' on cardnumber and pick a library. Click Create.
10) Notice you are now shown the "Confirm auto backend" stage screen.
11) PluginBackend has a 50% chance of being available or not for testing
purposes. If it is, it'll suggest PluginBackend, if not, it'll default to
Standard. ReprintsDesk will always error because it's missing credentials.
12) Pick any of the backends or accept the suggested one, click 'Create'. The
request has been placed in that specific backend.

OPAC:
1) Following from the previous test plan, visit OPAC ill requests:
http://localhost:8080/cgi-bin/koha/opac-illrequests.pl
2) Click "Create a new auto request" and repeat the same inputs as before.
Click 'Create'.
3) Notice you're directed to "Confirming your request" screen. It's doing the
same as it does in the Staff UI, except it does not allow the patron to pick a
different backend, it'll always selected the first available backend in the
priority.
4) Create more requests, you'll notice some of them will land on PluginBackend,
others will land on 'Standard' because PluginBackend will sometimes be
available and others not.

Do more testing:
- Reorder the backends in the AutoILLBackendPriority syspref and save, notice
they're shown and suggested accordingly after creating a request.
- Disable all backends from AutoILLBackendPriority. Notice the original
behaviour of requiring the user to select a backend before creating the request
is restored on both opac and staff.

Run unit tests:
prove t/db_dependent/Illrequest/ConfirmAuto.t
prove t/db_dependent/Koha/ILL/Backends.t

Sponsored-by: UKHSA - UK Health Security Agency
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #175834|0   |1
is obsolete||

--- Comment #71 from Martin Renvoize (ashimema) 
 ---
Created attachment 176267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176267&action=edit
Bug 35604: Update 'Make an ILL request' link in OPAC search results page

Sponsored-by: UKHSA - UK Health Security Agency
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #175833|0   |1
is obsolete||

--- Comment #70 from Martin Renvoize (ashimema) 
 ---
Created attachment 176266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176266&action=edit
Bug 35604: ConfirmAuto workflow stage

Sponsored-by: UKHSA - UK Health Security Agency
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #175832|0   |1
is obsolete||

--- Comment #69 from Martin Renvoize (ashimema) 
 ---
Created attachment 176265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176265&action=edit
Bug 35604: ILL request creation with AutoILLBackendPriority enabled

Sponsored-by: UKHSA - UK Health Security Agency
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #175831|0   |1
is obsolete||

--- Comment #68 from Martin Renvoize (ashimema) 
 ---
Created attachment 176264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176264&action=edit
Bug 35604: atomicupdate

Sponsored-by: UKHSA - UK Health Security Agency
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #175830|0   |1
is obsolete||

--- Comment #67 from Martin Renvoize (ashimema) 
 ---
Created attachment 176263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176263&action=edit
Bug 35604: New AutoILLBackendPriority sys prefs

Sponsored-by: UKHSA - UK Health Security Agency
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #175829|0   |1
is obsolete||

--- Comment #66 from Martin Renvoize (ashimema) 
 ---
Created attachment 176262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176262&action=edit
Bug 35604: New 'ill-backends' syspref type

UI rendering of sortable ILL backends

Sponsored-by: UKHSA - UK Health Security Agency
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2025-01-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #175828|0   |1
is obsolete||

--- Comment #65 from Martin Renvoize (ashimema) 
 ---
Created attachment 176261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176261&action=edit
Bug 35604: New Backends.pm class. installed_backends method

Sponsored-by: UKHSA - UK Health Security Agency
Sponsored-by: PTFS Europe Ltd
Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2024-12-31 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

--- Comment #64 from Pedro Amorim  ---
Created attachment 176036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176036&action=edit
Bug 35604: (QA follow-up): Cosmetic improvements

These are improvements to the confirm auto backend stage screen on the Staff
UI.
Result of a chat with Tomas about this development.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2024-12-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Blocks||38761
 Depends on|38761   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38761
[Bug 38761] Backend plugins that are disabled remain visible
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2024-12-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Tomás Cohen Arazi (tcohen)  changed:

   What|Removed |Added

 QA Contact||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 35604] ILL - Allow for automatic backend selection

2024-12-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35604

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #174520|0   |1
is obsolete||

--- Comment #60 from Pedro Amorim  ---
Created attachment 175833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175833&action=edit
Bug 35604: ConfirmAuto workflow stage

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >