[Koha-bugs] [Bug 35947] Accounting transactions do not show managing librarian if HidePatronName is set to yes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35947] Accounting transactions do not show managing librarian if HidePatronName is set to yes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA CC||m.de.r...@rijksmuseum.nl --- Comment #4 from Marcel de Rooy --- -[%- IF hide_patron_infos_if_needed AND ( display_patron_name OR display_cardnumber ) -%] +[%- IF ( display_patron_name OR display_cardnumber ) -%] -[%- IF hide_patron_infos_if_needed AND ( display_patron_name OR display_cardnumber ) -%] +[%- IF ( display_patron_name OR display_cardnumber ) -%] Changes in patron-title.inc affect a lot of places. So removing that check here seems wrong. Please prove me wrong. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35947] Accounting transactions do not show managing librarian if HidePatronName is set to yes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 Laura O'Neil changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35947] Accounting transactions do not show managing librarian if HidePatronName is set to yes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 Laura O'Neil changed: What|Removed |Added Status|NEW |Needs Signoff CC||la...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35947] Accounting transactions do not show managing librarian if HidePatronName is set to yes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 ByWater Sandboxes changed: What|Removed |Added Attachment #167673|0 |1 is obsolete|| --- Comment #3 from ByWater Sandboxes --- Created attachment 173802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173802&action=edit Bug 35947: Show managing librarian in accounting transaction regardless of HidePatronName status This patch removes the 'hide_patron_infos_if_needed => 1' passing into 'patron-title.inc' from 'accountline-details.tt'. Doing so allows for the managing librarian to be shown in the accounting details. In order to correctly link to this librarian, necessary changes were also made to the 'patron-title.inc' 1) Set 'HidePatronName' sys. pref. to 'Don't show' 2) Go to a patron's page 3) Click on the accounting tab 4) Select 'Create manual invoice', put in an amount and press save. 5) In the transactions tab, click on the details of that specifc transaction 6) Note that in the "Details of debit" table, the Librarian is set to 'a patron from X branch' 7) Apply patch, restart_all 8) Go to the same transaction, notice that now it says the actual librarian who was in charge of creating transaction. 9) Click on this name and make sure the link works 10) Go back to accounting section and now make a payment. 11) View details of this transaction and ensure the librarian is present Signed-off-by: Laura ONeil -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35947] Accounting transactions do not show managing librarian if HidePatronName is set to yes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35947] Accounting transactions do not show managing librarian if HidePatronName is set to yes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 Sam Lau changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |sama...@gmail.com |ity.org | CC||sama...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35947] Accounting transactions do not show managing librarian if HidePatronName is set to yes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 --- Comment #2 from Sam Lau --- Created attachment 167673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167673&action=edit Bug 35947: Show managing librarian in accounting transaction regardless of HidePatronName status This patch removes the 'hide_patron_infos_if_needed => 1' passing into 'patron-title.inc' from 'accountline-details.tt'. Doing so allows for the managing librarian to be shown in the accounting details. In order to correctly link to this librarian, necessary changes were also made to the 'patron-title.inc' 1) Set 'HidePatronName' sys. pref. to 'Don't show' 2) Go to a patron's page 3) Click on the accounting tab 4) Select 'Create manual invoice', put in an amount and press save. 5) In the transactions tab, click on the details of that specifc transaction 6) Note that in the "Details of debit" table, the Librarian is set to 'a patron from X branch' 7) Apply patch, restart_all 8) Go to the same transaction, notice that now it says the actual librarian who was in charge of creating transaction. 9) Click on this name and make sure the link works 10) Go back to accounting section and now make a payment. 11) View details of this transaction and ensure the librarian is present -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35947] Accounting transactions do not show managing librarian if HidePatronName is set to yes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35947 --- Comment #1 from Kelly McElligott --- Sorry, I meant if the library has the system preference, HidePatronName, set to Don't Show. ^^ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
