[Koha-bugs] [Bug 36110] Port default OVERDUES_SLIP to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36110 --- Comment #13 from Katrin Fischer --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36110] Port default OVERDUES_SLIP to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36110 Katrin Fischer changed: What|Removed |Added Version(s)||25.05.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36110] Port default OVERDUES_SLIP to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36110 --- Comment #12 from Katrin Fischer --- Finally! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36110] Port default OVERDUES_SLIP to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36110 Lucas Gass (lukeg) changed: What|Removed |Added Text to go in the||This enhancement replaces release notes||the default OVERDUES_SLIP ||syntax, converting it from ||Koha's bespoke syntax to ||the more standard Template ||Toolkit syntax. QA Contact|testo...@bugs.koha-communit |lu...@bywatersolutions.com |y.org | Patch complexity|--- |Small patch CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36110] Port default OVERDUES_SLIP to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36110 Lucas Gass (lukeg) changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36110] Port default OVERDUES_SLIP to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36110 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #180979|0 |1 is obsolete|| --- Comment #11 from Lucas Gass (lukeg) --- Created attachment 181186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181186&action=edit Bug 36110: (follow-up) Adjust OVERDUES_SLIP to use Template Toolkit Signed-off-by: Emmanuel Bétemps Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36110] Port default OVERDUES_SLIP to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36110 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #180978|0 |1 is obsolete|| --- Comment #10 from Lucas Gass (lukeg) --- Created attachment 181185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181185&action=edit Bug 36110: Adjust OVERDUES_SLIP to use Template Toolkit To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Set system preferences finesMode to Calculate and charge 4. Edit default circulation rule so that fines will be calculated: Unit - Days Fine amount - 0.50 Fine charging interval - 1 When to charge - Start of interval 5. Check 2 items out to a patron with a custom due date of a few days in the past 6. On the patron's account page, click Print > Print overdues --> Look at the print preview of the slip, and confirm that the item information is displayed and formatted correctly 7. In another tab, edit the 2 items to add a call number (if they don't already have one) 8. Print overdues again --> Confirm the slip still looks good 9. Run the fines cronjob to generate some overdue fines ktd --shell misc/cronjobs/fines.pl -v -c 10. Print overdues again --> Confirm the fines are included and slip still looks good 11. Check in one of the overdue items 12. Print overdues again --> Confirm slip now says "item is" instead of "items are" Signed-off-by: Emmanuel Bétemps Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36110] Port default OVERDUES_SLIP to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36110 --- Comment #9 from Emily Lamancusa (emlam) --- (In reply to Emmanuel Bétemps from comment #8) > Hi, > > after running 'misc/cronjobs/fines.pl -v -c', I got 'Unknown option: c' but > everything else was ok ! > > Manu. My bad, I must have assumed fines.pl had a -c / confirm flag when it doesn't! Thank you for testing! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36110] Port default OVERDUES_SLIP to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36110 Emmanuel Bétemps changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||e.bete...@gmail.com --- Comment #8 from Emmanuel Bétemps --- Hi, after running 'misc/cronjobs/fines.pl -v -c', I got 'Unknown option: c' but everything else was ok ! Manu. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36110] Port default OVERDUES_SLIP to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36110 Emmanuel Bétemps changed: What|Removed |Added Attachment #180573|0 |1 is obsolete|| --- Comment #7 from Emmanuel Bétemps --- Created attachment 180979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180979&action=edit Bug 36110: (follow-up) Adjust OVERDUES_SLIP to use Template Toolkit Signed-off-by: Emmanuel Bétemps -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36110] Port default OVERDUES_SLIP to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36110 Emmanuel Bétemps changed: What|Removed |Added Attachment #175657|0 |1 is obsolete|| --- Comment #6 from Emmanuel Bétemps --- Created attachment 180978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180978&action=edit Bug 36110: Adjust OVERDUES_SLIP to use Template Toolkit To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Set system preferences finesMode to Calculate and charge 4. Edit default circulation rule so that fines will be calculated: Unit - Days Fine amount - 0.50 Fine charging interval - 1 When to charge - Start of interval 5. Check 2 items out to a patron with a custom due date of a few days in the past 6. On the patron's account page, click Print > Print overdues --> Look at the print preview of the slip, and confirm that the item information is displayed and formatted correctly 7. In another tab, edit the 2 items to add a call number (if they don't already have one) 8. Print overdues again --> Confirm the slip still looks good 9. Run the fines cronjob to generate some overdue fines ktd --shell misc/cronjobs/fines.pl -v -c 10. Print overdues again --> Confirm the fines are included and slip still looks good 11. Check in one of the overdue items 12. Print overdues again --> Confirm slip now says "item is" instead of "items are" Signed-off-by: Emmanuel Bétemps -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36110] Port default OVERDUES_SLIP to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36110 --- Comment #5 from Marion Durand --- Created attachment 180573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180573&action=edit Bug 36110: (follow-up) Adjust OVERDUES_SLIP to use Template Toolkit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36110] Port default OVERDUES_SLIP to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36110 Marion Durand changed: What|Removed |Added CC||marion.dur...@biblibre.com --- Comment #4 from Marion Durand --- The test plan failed at point 12. Even if I have only 1 item checked out it still display "items are". We need to use overdues.count() and not just overdues I will to submit a follow up shortly to fix this point. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36110] Port default OVERDUES_SLIP to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36110 Emily Lamancusa (emlam) changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |emily.lamancusa@montgomeryc |ity.org |ountymd.gov -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36110] Port default OVERDUES_SLIP to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36110 --- Comment #3 from Emily Lamancusa (emlam) --- Created attachment 175657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175657&action=edit Bug 36110: Adjust OVERDUES_SLIP to use Template Toolkit To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Set system preferences finesMode to Calculate and charge 4. Edit default circulation rule so that fines will be calculated: Unit - Days Fine amount - 0.50 Fine charging interval - 1 When to charge - Start of interval 5. Check 2 items out to a patron with a custom due date of a few days in the past 6. On the patron's account page, click Print > Print overdues --> Look at the print preview of the slip, and confirm that the item information is displayed and formatted correctly 7. In another tab, edit the 2 items to add a call number (if they don't already have one) 8. Print overdues again --> Confirm the slip still looks good 9. Run the fines cronjob to generate some overdue fines ktd --shell misc/cronjobs/fines.pl -v -c 10. Print overdues again --> Confirm the fines are included and slip still looks good 11. Check in one of the overdue items 12. Print overdues again --> Confirm slip now says "item is" instead of "items are" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36110] Port default OVERDUES_SLIP to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36110 Emily Lamancusa (emlam) changed: What|Removed |Added Status|BLOCKED |NEW --- Comment #2 from Emily Lamancusa (emlam) --- Bug 17976 is now PQA, so this is no longer blocked -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36110] Port default OVERDUES_SLIP to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36110 Emily Lamancusa changed: What|Removed |Added Keywords|Academy, roadmap_24_05 | Depends on||17976 Status|NEW |BLOCKED --- Comment #1 from Emily Lamancusa --- This one cannot be updated until we have a TT equivalent for <>. bug 17976 was filed for this a while back, but it is still in the NEW status. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17976 [Bug 17976] TT syntax for notices - Add an equivalence for items.fine -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36110] Port default OVERDUES_SLIP to Template Toolkit syntax
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36110 Emily Lamancusa changed: What|Removed |Added Keywords||Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
