[Koha-bugs] [Bug 37020] bulkmarcimport gets killed when inserting large files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37020 Jonathan Druart changed: What|Removed |Added Blocks||41681 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41681 [Bug 41681] bulkmarcimport.pl reports an incorrect number of MARC records processed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37020] bulkmarcimport gets killed when inserting large files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37020 Jonathan Druart changed: What|Removed |Added Blocks||42782 --- Comment #79 from Jonathan Druart --- (In reply to Pedro Amorim (ammopt) from comment #78) > Alexander, Joubu, if there is a bug here please file a separate report, > removing additional_work_needed. Looking at the code yes, it's still wrong. Opened bug 42782. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42782 [Bug 42782] bulkmarkimport does not increment correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37020] bulkmarcimport gets killed when inserting large files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37020 Pedro Amorim (ammopt) changed: What|Removed |Added CC||[email protected] ||k Keywords|additional_work_needed | --- Comment #78 from Pedro Amorim (ammopt) --- Alexander, Joubu, if there is a bug here please file a separate report, removing additional_work_needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37020] bulkmarcimport gets killed when inserting large files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37020 Wainui Witika-Park changed: What|Removed |Added Status|Pushed to stable|Needs documenting CC||[email protected] ||et.nz --- Comment #77 from Wainui Witika-Park --- Not backporting to 22.11.x Setting to "Needs Documenting" to get it off my list but please feel free to change status if additional work is needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37020] bulkmarcimport gets killed when inserting large files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37020 Fridolin Somers changed: What|Removed |Added CC||[email protected] ||m --- Comment #76 from Fridolin Somers --- Still additional_work_needed ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37020] bulkmarcimport gets killed when inserting large files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37020 Bug 37020 depends on bug 29440, which changed state. Bug 29440 Summary: Refactor/clean up bulkmarcimport.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29440 What|Removed |Added Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37020] bulkmarcimport gets killed when inserting large files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37020 Alexander Wagner changed: What|Removed |Added CC||[email protected] --- Comment #75 from Alexander Wagner --- If I get the code right, the number of records ingested is still doubled. AFAIS `$record_number++;` is called twice within the loop. Jan mentioned that he ingested 1 record and got notified about 3, I also obeserved a result of 5 while I had only two (valid) records in the import file. Might be a minor issue compared to all the rest but can be quite confusing if your catalogue migration turns out to hold way more records that you expected. (Koha 25.05.00 ga) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37020] bulkmarcimport gets killed when inserting large files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37020
Jonathan Druart changed:
What|Removed |Added
Keywords||additional_work_needed
--- Comment #74 from Jonathan Druart ---
Current version in main:
329 RECORD: while () {
330
331 my $record;
332 $record_number++;
333
334 # get record
335 eval { $record = $batch->next() };
336 if ($@) {
337 print "Bad MARC record $record_number: $@ skipped\n";
338
339 # FIXME - because MARC::Batch->next() combines grabbing the next
340 # blob and parsing it into one operation, a correctable condition
341 # such as a MARC-8 record claiming that it's UTF-8 can't be
recovered
342 # from because we don't have access to the original blob. Note
343 # that the staging import can deal with this condition (via
344 # C4::Charset::MarcToUTF8Record) because it doesn't use
MARC::Batch.
345 next;
346 }
347 if ($record) {
348 $record_number++;
349
This is wrong.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37020] bulkmarcimport gets killed when inserting large files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37020 --- Comment #73 from Jonathan Druart --- record_number is still incremented twice, is this because of a conflict fix problem? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37020] bulkmarcimport gets killed when inserting large files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37020 Jesse Maseto changed: What|Removed |Added CC||[email protected] --- Comment #72 from Jesse Maseto --- Merge conflicts with 24.05.x, please rebase if needed in 24.05.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37020] bulkmarcimport gets killed when inserting large files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37020 Paul Derscheid changed: What|Removed |Added Version(s)|25.05.00|25.05.00,24.11.05 released in|| Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37020] bulkmarcimport gets killed when inserting large files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37020 Paul Derscheid changed: What|Removed |Added CC||[email protected] Keywords|rel_24_11_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37020] bulkmarcimport gets killed when inserting large files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37020 --- Comment #71 from Paul Derscheid --- Nice work everyone! Pushed to 24.11.x for 24.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37020] bulkmarcimport gets killed when inserting large files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37020 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.05.00 released in|| --- Comment #70 from Katrin Fischer --- Worked perfectly with the remote branch. Pushed to main, thanks! https://git.koha-community.org/Koha-community/Koha/commits/branch/main/search?q=37020&all= -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37020] bulkmarcimport gets killed when inserting large files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37020 Katrin Fischer changed: What|Removed |Added Status|Patch doesn't apply |Passed QA --- Comment #69 from Katrin Fischer --- (In reply to Thomas Klausner from comment #68) > I think two of my fixed got somehow merged into one commit. So yes, all OK > (esp as the actual main patch by David Gustafsson is properly credited) I just noticed that this had the wrong status :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37020] bulkmarcimport gets killed when inserting large files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37020 --- Comment #68 from Thomas Klausner --- I think two of my fixed got somehow merged into one commit. So yes, all OK (esp as the actual main patch by David Gustafsson is properly credited) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37020] bulkmarcimport gets killed when inserting large files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37020 --- Comment #67 from Katrin Fischer --- Patches applied without issue from remote branch now. But noting: Here we have 4 patches, on the branch there were 3. Squashed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37020] bulkmarcimport gets killed when inserting large files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37020 Katrin Fischer changed: What|Removed |Added Summary|bulkmarcimport gets killed |bulkmarcimport gets killed |after update to 24.05 when |when inserting large files |inserting large files | Keywords|RM_priority |rel_24_05_candidate, ||rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
