[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #36 from Jonathan Druart --- None should be backportesbackported here, you need the second parch from bug 38164. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #37 from Jonathan Druart --- Stupid phone -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #34 from Pedro Amorim --- Hi guys will this be backported to 23.11 or not advisable? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 Katrin Fischer changed: What|Removed |Added Status|Pushed to stable|CLOSED Resolution|--- |FIXED --- Comment #35 from Katrin Fischer --- (In reply to Pedro Amorim from comment #34) > Hi guys will this be backported to 23.11 or not advisable? No, please don't backport these patches. I think the second patch from bug 38164 could be good for backporting, but I'd like Joubu or Julian to confirm. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Blocks||38179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38179 [Bug 38179] koha-common runtime dependency on yarn -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #33 from Tomás Cohen Arazi (tcohen) --- (In reply to Victor Grousset/tuxayo from comment #32) > Continuation is in Bug 38164 Only for stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #32 from Victor Grousset/tuxayo --- Continuation is in Bug 38164 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 Victor Grousset/tuxayo changed: What|Removed |Added Blocks||38164 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38164 [Bug 38164] Translation process in stable releases is broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #31 from Katrin Fischer --- (In reply to Tomás Cohen Arazi (tcohen) from comment #30) > (In reply to Julian Maurice from comment #5) > > Can't we add a "next if $po->fuzzy" in misc/translator/po2json ? It looks > > easier > > ^^ we need to rollback and do what Julian proposes. > > Adding nodejs and yarn as dependencies for production is not > straight-forward. > > I know MTJ has ben looking at Debian's `node-po2json` package. But shouldn't > we revert in stable until we have a proper/tested solution? That makes sense to me. Could you provide a patch for Julian's suggestion? I am not sure yet if these patches will revert cleanly, if not we might also need a patch to do it (or someone to give me a hint) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #30 from Tomás Cohen Arazi (tcohen) --- (In reply to Julian Maurice from comment #5) > Can't we add a "next if $po->fuzzy" in misc/translator/po2json ? It looks > easier ^^ we need to rollback and do what Julian proposes. Adding nodejs and yarn as dependencies for production is not straight-forward. I know MTJ has ben looking at Debian's `node-po2json` package. But shouldn't we revert in stable until we have a proper/tested solution? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #29 from Katrin Fischer --- (In reply to Tomás Cohen Arazi (tcohen) from comment #27) > > Should we do the same in prod env? Or simply install yarnpkg from apt? > > The problem is yarn versions vary and it was not working. Do we need Yarn in > production now? It looks like we need it in order to be able to install and update languages (also see email to the koha mailing list) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #28 from Tomás Cohen Arazi (tcohen) --- Having looked at the change... It feels like adding `yarnpkg` to the dependencies should be enough. That said: * `yarn run po2json` is going to fetch the library from the internet in runtime, right? * The problem with node libraries is not the *Yarn* version but *Node.js* itself. Some libraries will not work on some versions of Node. That's why we make sure every KTD image has the exact version we are expecting from *Node.js*. In some cases we are pinning the version because the OS provides a newer than desired one. For Yarn we are pulling the latest available all the time and should not be problematic. We really need to try on the supported OSes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #27 from Tomás Cohen Arazi (tcohen) --- (In reply to Jonathan Druart from comment #26) > Mason, we need yarn in production to generate the translation. > For ktd we are installing it using their repo > https://gitlab.com/koha-community/koha-testing-docker/-/blob/main/dists/ > bookworm/Dockerfile?ref_type=heads#L114 > I don't remember why but I guess it is to get the same version across the > OS, and have an up-to-date version. > > Should we do the same in prod env? Or simply install yarnpkg from apt? The problem is yarn versions vary and it was not working. Do we need Yarn in production now? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 Jonathan Druart changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #26 from Jonathan Druart --- Mason, we need yarn in production to generate the translation. For ktd we are installing it using their repo https://gitlab.com/koha-community/koha-testing-docker/-/blob/main/dists/bookworm/Dockerfile?ref_type=heads#L114 I don't remember why but I guess it is to get the same version across the OS, and have an up-to-date version. Should we do the same in prod env? Or simply install yarnpkg from apt? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #25 from Jonathan Druart --- https://chat.koha-community.org/koha-community/pl/19zg9oqccj8u3pkxjqrqctayow -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #24 from Jonathan Druart --- yarn is now mandatory it seems, should we make it a dependency? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #23 from Jonathan Druart --- (In reply to Martin Renvoize (ashimema) from comment #22) > https://www.npmjs.com/package/@myrotvorets/po2json is that any good as a > more maintained option? It's not well documented which worries me, but it > does appear to have more recent commits. It's not doing anything useful. https://github.com/myrotvorets/po2json/blob/master/po2json.js vs the one we use: https://github.com/mikeedwards/po2json/blob/master/lib/parse.js And commits are only bots (but at least there are releases). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #22 from Martin Renvoize (ashimema) --- https://www.npmjs.com/package/@myrotvorets/po2json is that any good as a more maintained option? It's not well documented which worries me, but it does appear to have more recent commits. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #21 from Jonathan Druart --- A quick note for here, nomnom has been removed in the 1.0.0-alpha https://github.com/mikeedwards/po2json/releases/tag/1.0.0-alpha Looks like gettext is using it: https://github.com/guillaumepotier/gettext.js/pull/61 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 Jonathan Druart changed: What|Removed |Added Blocks||38031 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38031 [Bug 38031] po2json not found -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #20 from Fridolin Somers --- Conflicts on backport to 23.11.x Please provide rebased patches if possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 Lucas Gass changed: What|Removed |Added Version(s)|24.11.00|24.11.00,24.05.04 released in|| CC||lu...@bywatersolutions.com Status|Pushed to main |Pushed to stable --- Comment #19 from Lucas Gass --- Backported to 24.05.x for upcoming 24.05.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #18 from Katrin Fischer --- I have pushed Mason's follow-up to main. I think there was some discussion about using a different module/dependency maybe, but felt that would fix things for now while we dig deeper - maybe on a separate bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #17 from Mason James --- Created attachment 169975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169975&action=edit Bug 37303: Update yarn.lock after adding new dependency to packages.json use ./xt/verify-yarnlock.t test in BZ 37490 to confirm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 Mason James changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=37490 CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #16 from David Nind --- I'm not sure if this error message is related to this bug when trying to install a language in KTD: koha-translate --install de-DE --dev kohadev error Command "po2json" not found. read_file '/tmp/de-DE-messages.po' - open: No such file or directory at /kohadevbox/koha/misc/translator/LangInstaller.pm line 461. (Assuming that this is still the correct way to just install a language for testing, not update or test any other language changes.) This is on the current main, with KTD all up to date (git pull and ktd pull), and po on main and up to date as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #15 from Martin Renvoize --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 Martin Renvoize changed: What|Removed |Added Version(s)||24.11.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #14 from Martin Renvoize --- Thanks for the work here guys.. all looking good from my side. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303
Martin Renvoize changed:
What|Removed |Added
Attachment #169536|0 |1
is obsolete||
--- Comment #13 from Martin Renvoize ---
Created attachment 169718
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169718&action=edit
Bug 37303: Replace po2json with a JS version
When using __() (ie. Gettext.js) we are seeing the translations that are marked
as fuzzy.
This is definitely not the expected behaviour.
It happens because (our version of) po2json are old and no longer maintained,
and just embed them.
It seems that the bin we have has been upgraded to a JS version
(different authors).
Test plan:
(replace LANG with your language code)
0. Do not apply this patch
Edit misc/translator/po/LANG-messages-js.po
Mark a string as fuzzy
Edit ./intranet-main.tt and add the following lines inside $(document).ready
console.log(_("Your string"));
console.log(__("Your string"));
Replace "Your string" with the string you are actually testing.
Update the templates: `koha-translate --update LANG --dev kohadev &&
restart_all`
Go to the Koha home page, open the console.
=> Notice that the second log in the console is displaying the fuzzy string.
1. Apply this patch
Install the new version of po2json using `yarn install`
Repeat the previous steps.
=> With this patch applied both logs show the English version of the
string.
Remove fuzzy, update the templates and try again.
Signed-off-by: Julian Maurice
Signed-off-by: Victor Grousset/tuxayo
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 Matt Blenkinsop changed: What|Removed |Added Blocks||37472 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37472 [Bug 37472] Make plugins translatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Needs Signoff |Signed Off --- Comment #12 from Victor Grousset/tuxayo --- It works! :) commit: > It happens because (our version of) po2json are old and no longer maintained, > and just embed them. (In reply to Jonathan Druart from comment #6) > (In reply to Julian Maurice from comment #5) > > Can't we add a "next if $po->fuzzy" in misc/translator/po2json ? It looks > > easier > > Maybe, but I thought it was better to rely on a maintained library and > remove the binary we embedded. About that... The latest version is from 2016 ^^" https://github.com/mikeedwards/po2json/tags And the dates of the alpha version suggest the efforts for the next version have stalled :( That causes worries about the dependencies of po2json https://github.com/mikeedwards/po2json/issues/101 That nomnom dependency was last published 10 years ago and is officially abandoned: https://www.npmjs.com/package/nomnom (still 424 180 Weekly Downloads 💀) And it depends on underscore 1.6.0 which has the security vulnerability mentioned in the po2json ticket. But nomnom seems to be just to parse command line arguments for po2json so it should be okay. Though it shows the need to look at the rest of the dependency tree. That would be bad if malicious translations could be used to remotely execute code at the packaging step. Or on devs machines. Though that's still a worry with the perl po2json. It uses a 2014 version of Locale::PO to read the .po files and a 2011 version of JSON to generate JSON. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #168713|0 |1
is obsolete||
--- Comment #11 from Victor Grousset/tuxayo ---
Created attachment 169536
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169536&action=edit
Bug 37303: Replace po2json with a JS version
When using __() (ie. Gettext.js) we are seeing the translations that are marked
as fuzzy.
This is definitely not the expected behaviour.
It happens because (our version of) po2json are old and no longer maintained,
and just embed them.
It seems that the bin we have has been upgraded to a JS version
(different authors).
Test plan:
(replace LANG with your language code)
0. Do not apply this patch
Edit misc/translator/po/LANG-messages-js.po
Mark a string as fuzzy
Edit ./intranet-main.tt and add the following lines inside $(document).ready
console.log(_("Your string"));
console.log(__("Your string"));
Replace "Your string" with the string you are actually testing.
Update the templates: `koha-translate --update LANG --dev kohadev &&
restart_all`
Go to the Koha home page, open the console.
=> Notice that the second log in the console is displaying the fuzzy string.
1. Apply this patch
Install the new version of po2json using `yarn install`
Repeat the previous steps.
=> With this patch applied both logs show the English version of the
string.
Remove fuzzy, update the templates and try again.
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 Pedro Amorim changed: What|Removed |Added CC||pedro.amo...@ptfs-europe.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #10 from Julian Maurice --- (In reply to Julian Maurice from comment #9) > Other than that they are identical And other than the fact that fuzzy messages are not included, obviously :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #9 from Julian Maurice --- I compared locale_data.js before and after the patch: with the patch: * keys are not sorted (does not matter) * header keys are lowercase (should not matter but needs to be tested) * header values are trimmed (good) Other than that they are identical -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #8 from Jonathan Druart --- There is a deprecation warning that should be removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303
Jonathan Druart changed:
What|Removed |Added
Attachment #168712|0 |1
is obsolete||
--- Comment #7 from Jonathan Druart ---
Created attachment 168713
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168713&action=edit
Bug 37303: Replace po2json with a JS version
When using __() (ie. Gettext.js) we are seeing the translations that are marked
as fuzzy.
This is definitely not the expected behaviour.
It happens because (our version of) po2json are old and no longer maintained,
and just embed them.
It seems that the bin we have has been upgraded to a JS version
(different authors).
Test plan:
(replace LANG with your language code)
0. Do not apply this patch
Edit misc/translator/po/LANG-messages-js.po
Mark a string as fuzzy
Edit ./intranet-main.tt and add the following lines inside $(document).ready
console.log(_("Your string"));
console.log(__("Your string"));
Replace "Your string" with the string you are actually testing.
Update the templates: `koha-translate --update LANG --dev kohadev &&
restart_all`
Go to the Koha home page, open the console.
=> Notice that the second log in the console is displaying the fuzzy string.
1. Apply this patch
Install the new version of po2json using `yarn install`
Repeat the previous steps.
=> With this patch applied both logs show the English version of the
string.
Remove fuzzy, update the templates and try again.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #6 from Jonathan Druart --- (In reply to Julian Maurice from comment #5) > Can't we add a "next if $po->fuzzy" in misc/translator/po2json ? It looks > easier Maybe, but I thought it was better to rely on a maintained library and remove the binary we embedded. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #5 from Julian Maurice --- Can't we add a "next if $po->fuzzy" in misc/translator/po2json ? It looks easier -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 Julian Maurice changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303
--- Comment #4 from Julian Maurice ---
Patch does not work for me. po2json expects 2 arguments ( ) and
we only give one.
So the resulting locale_data.json looks like this:
var json_locale_data = {"Koha":yarn run v1.22.20
>>$ /home/koha/koha/node_modules/.bin/po2json
>>/home/koha/koha/misc/translator/po/fr-FR-messages-js.po
>>output argument is required
>>Usage: po2json [options]
[... full of usage ...]
};
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #3 from Aude Charillon --- I guess it only affects languages where not everything is translated - either due to lack of translators or because it's English to English (so no translation needed, in most cases). Speaking for the en-GB translation crew, we simply assumed it was our fault; that we'd messed up our file at some point in the past! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 --- Comment #2 from Jonathan Druart --- This seems bad, how didn't we catch that before? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 Jonathan Druart changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303
--- Comment #1 from Jonathan Druart ---
Created attachment 168712
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168712&action=edit
Bug 37303: Replace po2json with a JS version
When using __() (ie. Gettext.js) we are seeing the translations that are marked
as fuzzy.
This is definitely not the expected behaviour.
It happens because (our version of) po2json are old and no longer maintained,
and just embed them.
It seems that the bin we have has been upgraded to a JS version
(different authors).
Test plan:
(replace LANG with your language code)
0. Do not apply this patch
Edit misc/translator/po/LANG-messages-js.po
Mark a string as fuzzy
Edit ./intranet-main.tt and add the following lines inside $(document).ready
console.log(_("Your string"));
console.log(__("Your string"));
Replace "Your string" with the string you are actually testing.
Update the templates: `koha-translate --update LANG --dev kohadev &&
restart_all`
Go to the Koha home page, open the console.
=> Notice that the second log in the console is displaying the fuzzy string.
1. Apply this patch
Install the new version of po2json using `yarn install`
Repeat the previous steps.
=> With this patch applied both logs show the English version of the
string.
Remove fuzzy, update the templates and try again.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37303] Fuzzy translations displayed on the UI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37303 Jonathan Druart changed: What|Removed |Added CC||aude.charillon@ptfs-europe. ||com, ||julian.maur...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
