[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Jesse Maseto changed: What|Removed |Added CC||[email protected] --- Comment #30 from Jesse Maseto --- Merge conflicts with 24.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 --- Comment #29 from David Nind --- Thanks for the release note Martin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Martin Renvoize (ashimema) changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Martin Renvoize (ashimema) changed: What|Removed |Added Text to go in the|**Sponsored by** *PTFS |Enhancement: Improved release notes|Europe* |handling of publication and ||title information in ||773$d/t for analytic ||records || ||The logic for extracting ||publication information now ||considers both MARC fields ||264 and 260, ensuring ||better compatibility with ||RDA records using 264. The ||system prefers the 264 ||field with first indicator ||“3” (current/latest ||publication) when ||available, falling back to ||the first 264 or 260 ||otherwise. || ||The extraction of title ||information from field 245 ||has been expanded to ||include subfields $n and $p ||in addition to $a and $b. ||This ensures multi-part ||works are properly ||distinguished by including ||part/section numbers and ||titles in the analytic ||entry. || ||These improvements help ||ensure more accurate and ||complete linking of ||analytic records to their ||host records, especially ||for multipart works and RDA ||cataloguing practices. || ||**Sponsored by** *PTFS ||Europe* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 David Nind changed: What|Removed |Added CC||[email protected] Keywords||release-notes-needed --- Comment #28 from David Nind --- I looked at created a release note for this bug, but this is too complicated for me 8-). Could someone write a release note for this change, that will hopefully make sense for library staff and cataloguers. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 --- Comment #27 from Paul Derscheid --- Nice work everyone! Pushed to 25.05.x for 25.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|25.11.00,25.05.01 |25.11.00,25.05.01,24.11.06 released in|| --- Comment #26 from Fridolin Somers --- Pushed to 24.11.x for 24.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Fridolin Somers changed: What|Removed |Added CC||[email protected] ||m Version(s)|25.11.00|25.11.00,25.05.01 released in|| Status|Pushed to main |Pushed to stable --- Comment #25 from Fridolin Somers --- I see in 25.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 --- Comment #24 from Katrin Fischer --- Thanks all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 --- Comment #23 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Lucas Gass (lukeg) changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Marcel de Rooy changed: What|Removed |Added Attachment #182398|0 |1 is obsolete|| --- Comment #20 from Marcel de Rooy --- Created attachment 182852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182852&action=edit Bug 37364: Unit tests This patch adds unit tests to confirm that the 773 record created by Koha::Biblio now takes account of RDA updates and subfield ordering. Test plan 1. Apply patch 2. Run `prove ./t/db_dependent/Koha/Biblio.t`. 3. Test fails. 4. Apply next patch in series 5. Run `prove ./t/db_dependent/Koha/Biblio.t`. 6. All tests pass. Signed-off-by: Lin Wei Li Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Marcel de Rooy changed: What|Removed |Added Attachment #182399|0 |1 is obsolete|| --- Comment #21 from Marcel de Rooy --- Created attachment 182853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182853&action=edit Bug 37364: Add requested RDA handling to generate_marc_host_field This patch adds handling for the 264 field in precedence to the 260 for the generate_marc_host_field method and also adds subfields n and p to the 245 handling. Test plan 1) The routine is currently only called during bundle linking so... 1a) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Ensure the 'Add MARC link' checkbox is checked to create 773 links and trigger the code above 2) Inspect the MARC record for the host biblio and confirm the 773 has been built. 3) Run unit tests to confirm they now pass Signed-off-by: Lin Wei Li Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364
--- Comment #22 from Marcel de Rooy ---
QA Comment
Never give up! Thx for patching.
+# Use first entry unless we find a preferred indicator1 = 3
+if ( $index == 0 ) {
+my $s = $host_field->as_string('abc');
+if ($s) {
+$sfd{d} = $s;
+}
+$index++;
+}
+if ( $host_field->indicator(1) && ( $host_field->indicator(1) eq
'3' ) ) {
+my $s = $host_field->as_string('abc');
+if ($s) {
+$sfd{d} = $s;
+}
+last;
}
Theoretical objection only: If $s is empty in case1 or case2, you should
probably not do index++ or last. So those should be moved actually into the
inner if statement. But the host field would be invalid data surely.
Passing QA nevertheless.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED QA Contact|[email protected] |[email protected] |y.org | --- Comment #19 from Marcel de Rooy --- Looking here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Martin Renvoize (ashimema) changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 --- Comment #16 from Lin Wei --- No worries, glad I could help :) # Test Results - Unit tests pass. - Test plan was executed successfully. -> Technically, there is an issue with adding records created via Fast Cataloging to a Bundle/Collection. -> But, Fast Cataloging should not be used, so I am not going to disregard this issue. -> See below for details. # Test Execution 1. Apply 182393. 2. Run `prove ./t/db_dependent/Koha/Biblio.t`. 3. Tests fails (see [Prove Output] below). -> I realize this is normal as the tests are fixed in the following commit. 4. Reset with `git reset --hard origin/main`. 5. Run `prove ./t/db_dependent/Koha/Biblio.t`. 6. Tests pass. 7. Apply both 182393 and 182394. 8. Run `prove ./t/db_dependent/Koha/Biblio.t`. 9. Tests pass. -> Here is where I realize it. 10. Create new 'collection' record. 11. Add new item to this bib record. 12. Holdings > Item I just created > Manage bundle. 13. Add to bundle (Add MARC link = true): 1234, 0001, 0002, 0003, 0004 (barcodes of my test records). 14. Inspect MARC records: - 1234: missing 773 t - 0001: 773 t [title of my collection] - 0002: missing 773 t - 0003: 773 t [title of my collection] -> see [Additional Notes] below regarding the missing MARC tags 15. Create new test record. 16. Create new item for it with barcode = 0004. 17. Add to bundle (Add MARC link = true): 0004. 18: Inspect MARC record: - 0004: 773 t [title of my collection] # Additional Notes Test books are fake books created for testing and have a lot of data missing. Real books are, well, real books with real data. 1234: test book, created via Fast Cataloging 0001: real book, imported from Library of Congress 0002: test book, created via Fast Cataloging 0003: real book, imported from Library of Congress 0004: test book, created via New Record Note that the results, when considering these Additional Notes, show that the patch behaves as expected, except for records created via Fast Cataloging: - These records created via Fast Cataloging show up under: Holdings > Manage bundle. - But, their MARC do not contain a 773 tag. I was informed that users should never use Fast Cataloging, so I am considering this discrepancy as "irrelevant" since the feature works both on real data and properly created fake data. In conclusion, I will be signing off on this patch. Good work! # Prove Output prove ./t/db_dependent/Koha/Biblio.t ./t/db_dependent/Koha/Biblio.t .. 15/41 # Failed test 'MARC::Field->subfield(d) returns content from 264 in preference to 260' # at ./t/db_dependent/Koha/Biblio.t line 1049. # got: 'Publication 260' # expected: 'Publication 264' # Failed test 'MARC::Field->subfield(d) returns content from 264 with indicator 1 = 3 in preference to 264 without' # at ./t/db_dependent/Koha/Biblio.t line 1061. # got: 'Publication 260' # expected: 'Publication 264 Preferred' # Looks like you failed 2 tests of 24. # Failed test 'generate_marc_host_field' # at ./t/db_dependent/Koha/Biblio.t line 1099. ./t/db_dependent/Koha/Biblio.t .. 40/41 # Looks like you failed 1 test of 41. ./t/db_dependent/Koha/Biblio.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/41 subtests Test Summary Report --- ./t/db_dependent/Koha/Biblio.t (Wstat: 256 (exited 1) Tests: 41 Failed: 1) Failed test: 17 Non-zero exit status: 1 Files=1, Tests=41, 18 wallclock secs ( 0.04 usr 0.01 sys + 12.20 cusr 1.91 csys = 14.16 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Lin Wei changed: What|Removed |Added Attachment #182394|0 |1 is obsolete|| --- Comment #18 from Lin Wei --- Created attachment 182399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182399&action=edit Bug 37364: Add requested RDA handling to generate_marc_host_field This patch adds handling for the 264 field in precedence to the 260 for the generate_marc_host_field method and also adds subfields n and p to the 245 handling. Test plan 1) The routine is currently only called during bundle linking so... 1a) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Ensure the 'Add MARC link' checkbox is checked to create 773 links and trigger the code above 2) Inspect the MARC record for the host biblio and confirm the 773 has been built. 3) Run unit tests to confirm they now pass Signed-off-by: Lin Wei Li -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Lin Wei changed: What|Removed |Added Attachment #182393|0 |1 is obsolete|| --- Comment #17 from Lin Wei --- Created attachment 182398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182398&action=edit Bug 37364: Unit tests This patch adds unit tests to confirm that the 773 record created by Koha::Biblio now takes account of RDA updates and subfield ordering. Test plan 1. Apply patch 2. Run `prove ./t/db_dependent/Koha/Biblio.t`. 3. Test fails. 4. Apply next patch in series 5. Run `prove ./t/db_dependent/Koha/Biblio.t`. 6. All tests pass. Signed-off-by: Lin Wei Li -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Lin Wei changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #181978|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize (ashimema) --- Created attachment 182394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182394&action=edit Bug 37364: Add requested RDA handling to generate_marc_host_field This patch adds handling for the 264 field in precedence to the 260 for the generate_marc_host_field method and also adds subfields n and p to the 245 handling. Test plan 1) The routine is currently only called during bundle linking so... 1a) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Ensure the 'Add MARC link' checkbox is checked to create 773 links and trigger the code above 2) Inspect the MARC record for the host biblio and confirm the 773 has been built. 3) Run unit tests to confirm they now pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 --- Comment #15 from Martin Renvoize (ashimema) --- Thanks for taking a look Lin Wei. My apologies for the curtness.. not my best day. The comment was really for Katrin as she asked for the follow-up here in another bug and I did the work on the same day hoping she'd take a look. Anyway, I should know better and apologise. As for the bug itself, I've improved the test plan and fixed a small bug you highlighted, thanks! Perl is always fun when it comes to `==` vs `eq` especially when MARC::Field->indicator() returns a string even though the content is an integer. All should be working now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #181979|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize (ashimema) --- Created attachment 182393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182393&action=edit Bug 37364: Unit tests This patch adds unit tests to confirm that the 773 record created by Koha::Biblio now takes account of RDA updates and subfield ordering. Test plan 1. Apply patch 2. Run `prove ./t/db_dependent/Koha/Biblio.t`. 3. Test fails. 4. Apply next patch in series 5. Run `prove ./t/db_dependent/Koha/Biblio.t`. 6. All tests pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Lin Wei changed: What|Removed |Added CC||[email protected] Status|Needs Signoff |Failed QA --- Comment #12 from Lin Wei --- # Personal Note First of all, I'd like to say I'm sorry that your work was ignored for so long. That's definitely not fun. I am new to this, but I still tried to take a look at it. To be honest, I am not at all familiar with the MARC format, so it's hard for me to sign off on the feature, but I did run your unit tests and I've provided the results below. If I may, I have one small piece of advice that might help: I recommend you provide a clear test plan. Otherwise, it's difficult to know how to test the patch/what needs to be tested, which usually limits potential testers to either people who are already involved in the patch or people who have the time and expertise to read and understand the entire discussion. # Test Results Unit tests do not pass. # Test Execution 1. Apply patch 2. Run `prove ./t/db_dependent/Koha/Biblio.t`. 3. Test fails. See [Prove Output] below. 4. Remove patch with `git reset --hard origin/main`. 5. Run `prove ./t/db_dependent/Koha/Biblio.t`. 6. All tests pass. # Prove Output prove ./t/db_dependent/Koha/Biblio.t ./t/db_dependent/Koha/Biblio.t .. 39/41 # Failed test 'no warnings' # at /usr/local/share/perl/5.38.2/Test/Builder.pm line 187. # There were 4 warning(s) # Previous test 0 '' # Argument " " isn't numeric in numeric eq (==) at /inlibro/git/koha-master-dev-linwei/Koha/Biblio.pm line 1960. # at /inlibro/git/koha-master-dev-linwei/Koha/Biblio.pm line 1960. # Koha::Biblio::generate_marc_host_field(Koha::Biblio=HASH(0x60810b9c8cc8)) called at ./t/db_dependent/Koha/Biblio.t line 1022 # main::__ANON__() called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # eval {...} called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # Test::Builder::subtest(Test::Builder=HASH(0x60810057c040), "generate_marc_host_field", CODE(0x6081003df578)) called at /usr/local/share/perl/5.38.2/Test/More.pm line 831 # Test::More::subtest("generate_marc_host_field", CODE(0x6081003df578)) called at ./t/db_dependent/Koha/Biblio.t line 1099 # # -- # Previous test 10 'MARC::Field->subfield(w) returns undef when "UseControlNumber" is disabled' # Argument " " isn't numeric in numeric eq (==) at /inlibro/git/koha-master-dev-linwei/Koha/Biblio.pm line 1960. # at /inlibro/git/koha-master-dev-linwei/Koha/Biblio.pm line 1960. # Koha::Biblio::generate_marc_host_field(Koha::Biblio=HASH(0x60810b9c8cc8)) called at ./t/db_dependent/Koha/Biblio.t line 1036 # main::__ANON__() called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # eval {...} called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # Test::Builder::subtest(Test::Builder=HASH(0x60810057c040), "generate_marc_host_field", CODE(0x6081003df578)) called at /usr/local/share/perl/5.38.2/Test/More.pm line 831 # Test::More::subtest("generate_marc_host_field", CODE(0x6081003df578)) called at ./t/db_dependent/Koha/Biblio.t line 1099 # # -- # Previous test 11 'MARC::Field->subfield(w) returns content from 003 and 001 when "UseControlNumber" is enabled' # Argument " " isn't numeric in numeric eq (==) at /inlibro/git/koha-master-dev-linwei/Koha/Biblio.pm line 1960. # at /inlibro/git/koha-master-dev-linwei/Koha/Biblio.pm line 1960. # Koha::Biblio::generate_marc_host_field(Koha::Biblio=HASH(0x60810b95d570)) called at ./t/db_dependent/Koha/Biblio.t line 1048 # main::__ANON__() called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # eval {...} called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # Test::Builder::subtest(Test::Builder=HASH(0x60810057c040), "generate_marc_host_field", CODE(0x6081003df578)) called at /usr/local/share/perl/5.38.2/Test/More.pm line 831 # Test::More::subtest("generate_marc_host_field", CODE(0x6081003df578)) called at ./t/db_dependent/Koha/Biblio.t line 1099 # # -- # Previous test 12 'MARC::Field->subfield(d) returns content from 264 in prefernce to 260' # Argument " " isn't numeric in numeric eq (==) at /inlibro/git/koha-master-dev-linwei/Koha/Biblio.pm line 1960. # at /inlibro/git/koha-master-dev-linwei/Koha/Biblio.pm line 1960. # Koha::Biblio::generate_marc_host_field(Koha::Biblio=HASH(0x60810ba88e68)) called at ./t/db_dependent/Koha/Biblio.t line 1060 # main::__ANON__() called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # eval {...} called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # Test::Builder::subtest(Test::Builder=HASH(0x60810057c040), "generate_marc_host_field", CODE(0x6081003df578)) called at /usr
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Martin Renvoize (ashimema) changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Martin Renvoize (ashimema) changed: What|Removed |Added CC||baptiste.wojtkowski@biblibr ||e.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 --- Comment #11 from Martin Renvoize (ashimema) --- I really wish people would come back to things when you immediately work on them for them ;) It's been nearly a year and a bunch of other people have now done work in the same area's and this bug got no attention at all. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #169077|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize (ashimema) --- Created attachment 181979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181979&action=edit Bug 37364: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #169076|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize (ashimema) --- Created attachment 181978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181978&action=edit Bug 37364: Add requested RDA handling to generate_marc_host_field This patch adds handling for the 264 field in precedence to the 260 for the generate_marc_host_field method and also adds subfields n and p to the 245 handling. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Martin Renvoize (ashimema) changed: What|Removed |Added Text to go in the||**Sponsored by** *PTFS release notes||Europe* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Esther Melander changed: What|Removed |Added CC||esther.melander@bywatersolu ||tions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Martin Renvoize changed: What|Removed |Added Blocks||37305 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37305 [Bug 37305] Remove C4::Biblio::prepare_marc_host and use Koha::Biblio->generate_marc_host_field in preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 --- Comment #8 from Martin Renvoize --- Created attachment 169077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169077&action=edit Bug 37364: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Martin Renvoize changed: What|Removed |Added Attachment #169075|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize --- Created attachment 169076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169076&action=edit Bug 37364: Add requested RDA handling to generate_marc_host_field This patch adds handling for the 264 field in precedence to the 260 for the generate_marc_host_field method and also adds subfields n and p to the 245 handling. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 --- Comment #6 from Martin Renvoize --- Created attachment 169075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169075&action=edit Bug 37364: Add requested RDA handling to generate_marc_host_field This patch adds handling for the 264 field in precedence to the 260 for the generate_marc_host_field method and also adds subfields n and p to the 245 handling. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 --- Comment #5 from Martin Renvoize --- Ooohh.. ordering is already correct: > as_string( [$subfields] [, $delimiter] ) >Returns a string of all subfields run together. A space is added to the result >between each subfield, unless the delimiter parameter is passed. The tag >number and subfield character are not included. >Subfields appear in the output string in the order in which they occur in the >field. >If $subfields is specified, then only those subfields will be included. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 --- Comment #4 from Katrin Fischer --- I think as Koha at the moment expects the punctuation to be there, you only need to make sure that we have a space between the subfields and otherwise the string can be unchanged. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 --- Comment #3 from Martin Renvoize --- I've got a patch for the 260/264 stuff and I'm working on the 245 now. Order could be fun, need to also take punctuation into consideration given recent chat's. I can maintain order fairly trivially I think, though repeats and punctuation add a little extra challenge. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 --- Comment #2 from Katrin Fischer --- Hi Heather, I forgot that n and p are also repeatable... Not sure if keeping sequence is hard/easy, but we can at least ask for it :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 --- Comment #1 from Heather --- > 773$d is not repeatable, so we should avoid to create 2 entries. Maybe check > for existence of 264 first and then fallback to 260 if the first is not > found? This should work! > 260 and 264 are both repeatable. I assume this either uses the first or last > entry - can you tell? Yes--both the 260 and the 264 would have first indicator = 3 for "current, latest." > Ideally it might be good to prefer the entry with first indicator = 3 > (current/latest), if it exists... Yes--this would work. Examples are here, on p.43: https://www.loc.gov/aba/pcc/conser/CCM/module35.pdf E.g.: 264 #1 $3 1990-1994: $a Salem, N.H. : $b Butterworth Legal Publishers 264 21 $3 1995-<1996>: $a Charlottesville, VA : $b Michie 264 21 $3 <1998>-1999: $a Charlottesville, VA : $b LEXIS Law Pub. 264 31 $3 2000- : $a Huntington, NY : $b Juris Pub., $c c1990- > 2) This should take $n$p into account as well, as otherwise a multi-part > work will not be distinguishable from the title: Yes!!! > I think this could just be changed to: abnp for the subfield list. This order can be different in the 245, so IMO should be preserved in the 773, otherwise the title will make no sense, e.g. this 245's order is apnpb (from the MARC21 standard): 245 00$aDeutsche Bibliographie.$pWöchentliches Verzeichnis.$nReihe B,$pBeilage, Erscheinungen ausserhalb des Verlagsbuchhandels :$bAmtsblatt der Deutschen Bibliothek. So can the order of the subfields in the 245 be preserved in the created 773? --h2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Martin Renvoize changed: What|Removed |Added Assignee|[email protected] |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37364] Improve creation of 773 fields for item bundles regarding MARC21 245 and 264
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364 Martin Renvoize changed: What|Removed |Added CC||[email protected], ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
