[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 Marcel de Rooy changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment #26 from Marcel de Rooy --- Moving back to SO queue. Any thoughts, Nick? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 --- Comment #25 from Marcel de Rooy --- (In reply to Nick Clemens (kidclamp) from comment #24) > I am not convinced this is a desired behavior change for all libraries. When > they decided to set the pref, it explicitly said "does not affect" several > things > > Would you be open to a second setting within the pref: > > CircConfirmFutureHolds (at checkin, at renewal, at checkout - multi select?) > starting no later then XX days Hi Nick. Thanks for looking here ! The description "But it does not interfere with issuing, renewing or transferring items" is not the most lucky one. I might have added it myself long ago ;) Note also that we are talking about a feature that say over 90% of the libraries is not using. (HEA: 1040 AllowHoldDateinFuture 728 OPACAllowHoldDateInFuture ) Lets look at the processes mentioned. (When writing this patch, I reviewed all occurrences of current_holds btw.) Checkout AddIssue already calls MoveReserve and that does check ConfirmFutureHolds. So this is an "existing interference". The description was wrong. Renew CanBookBeRenewed calls current_holds. This is a "new interference". If a library allows future holds and wants to confirm them within a few days specified by ConfirmFutureHolds, currently this is ignored by CanBookBeRenewed. So the book is renewed although there is a hold for it on tomorrow. Not sure if we should write code for that? Probably most do not want to renew here. Transfer transferbook calls CheckReserves without lookahead days. So it does not block a transfer for a future hold (when not ignoring them altogether). Feels like a bug to me that could be solved on another report :) So there is currently no interference here. Discussion elsewhere? Checkin This is not relevant here. ConfirmFutureHolds already affects checkin (especially the popup). And this is already advertized accordingly. In conclusion, the new extra preference should only pertain to renewals. This would imo be a rather ugly exception. I would advise against it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 Nick Clemens (kidclamp) changed: What|Removed |Added Status|Signed Off |In Discussion CC||n...@bywatersolutions.com --- Comment #24 from Nick Clemens (kidclamp) --- I am not convinced this is a desired behavior change for all libraries. When they decided to set the pref, it explicitly said "does not affect" several things Would you be open to a second setting within the pref: CircConfirmFutureHolds (at checkin, at renewal, at checkout - multi select?) starting no later then XX days -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 --- Comment #23 from Marcel de Rooy --- Rebased on tidied codebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 Marcel de Rooy changed: What|Removed |Added Attachment #177372|0 |1 is obsolete|| --- Comment #22 from Marcel de Rooy --- Created attachment 178329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178329&action=edit Bug 37651: (QA follow-up) Rewording for pref ConfirmFutureHolds As requested by QA. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 Marcel de Rooy changed: What|Removed |Added Attachment #176811|0 |1 is obsolete|| --- Comment #21 from Marcel de Rooy --- Created attachment 178328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178328&action=edit Bug 37651: (QA follow-up) Add POD for Biblio method We were missing POD here. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 Marcel de Rooy changed: What|Removed |Added Attachment #176809|0 |1 is obsolete|| --- Comment #19 from Marcel de Rooy --- Created attachment 178326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178326&action=edit Bug 37651: Add ConfirmFutureHolds to biblio->current_holds Test plan: Easy way is to run the unit tests in the next patch. One call of biblio->current_holds is hidden in acqui/parcel.pl. The table column "Item holds / Total holds" should now make a difference for an order referring to an item having future holds. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 Marcel de Rooy changed: What|Removed |Added Attachment #176810|0 |1 is obsolete|| --- Comment #20 from Marcel de Rooy --- Created attachment 178327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178327&action=edit Bug 37651: Unit tests Test plan: Run t/db_dependent/Holds.t (Without previous patches, it would fail.) Run t/db_dependent/Koha/Biblios.t Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 Marcel de Rooy changed: What|Removed |Added Attachment #176808|0 |1 is obsolete|| --- Comment #18 from Marcel de Rooy --- Created attachment 178325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178325&action=edit Bug 37651: Add ConfirmFutureHolds to item->current_holds Test plan: Add future item level hold for another branch. Check in. Confirm and transfer. Note that without this patch, there is no patron info for the column On hold for on transferstoreceive. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 --- Comment #17 from Marcel de Rooy --- Created attachment 177372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177372&action=edit Bug 37651: (QA follow-up) Rewording for pref ConfirmFutureHolds As requested by QA. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 --- Comment #16 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #15) > This feels wrong to me. > > The pref description: "Note that this number of days will be used too in > calculating the default end date for the Holds to pull-report. But it does > not interfere with issuing, renewing or transferring items." > > It seems that we need a filter_by method, and use it only where it needs > this pref to be taken into account. You are right. We should adjust the wording of that pref. Will add a follow-up. The filter_by comment is valid too. But I dont think that it should be done here. It is an improvement on its own. There are more methods that could be reworked into filter_by constructs. Like for instance: Koha/Biblio.pm current_checkouts Koha/Acquisition/Order.pm current_item_level_holds The point of this report is refine the existing two current_holds methods where the pref should be taken into account. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@gmail.com --- Comment #15 from Jonathan Druart --- This feels wrong to me. The pref description: "Note that this number of days will be used too in calculating the default end date for the Holds to pull-report. But it does not interfere with issuing, renewing or transferring items." It seems that we need a filter_by method, and use it only where it needs this pref to be taken into account. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 --- Comment #14 from Marcel de Rooy --- (In reply to Martin Renvoize (ashimema) from comment #12) > Signed-off-by: Martin Renvoize Thx ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 --- Comment #13 from Martin Renvoize (ashimema) --- This is a fun one.. current_holds is called in a fair number of places; thus, whilst this is a small and clear patch, it could have some wide-reaching effects. I'm signing off and will seek some QA opinions. My gut says it makes sense and is a step toward being able to deprecate C4::Reserves::CheckReserve. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 --- Comment #12 from Martin Renvoize (ashimema) --- Created attachment 176811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176811&action=edit Bug 37651: (QA follow-up) Add POD for Biblio method We were missing POD here. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #176656|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize (ashimema) --- Created attachment 176810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176810&action=edit Bug 37651: Unit tests Test plan: Run t/db_dependent/Holds.t (Without previous patches, it would fail.) Run t/db_dependent/Koha/Biblios.t Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #176655|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize (ashimema) --- Created attachment 176809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176809&action=edit Bug 37651: Add ConfirmFutureHolds to biblio->current_holds Test plan: Easy way is to run the unit tests in the next patch. One call of biblio->current_holds is hidden in acqui/parcel.pl. The table column "Item holds / Total holds" should now make a difference for an order referring to an item having future holds. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #176654|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize (ashimema) --- Created attachment 176808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176808&action=edit Bug 37651: Add ConfirmFutureHolds to item->current_holds Test plan: Add future item level hold for another branch. Check in. Confirm and transfer. Note that without this patch, there is no patron info for the column On hold for on transferstoreceive. Signed-off-by: Marcel de Rooy Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 --- Comment #8 from Marcel de Rooy --- Rebased. Waiting since September.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 Marcel de Rooy changed: What|Removed |Added Attachment #171250|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy --- Created attachment 176656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176656&action=edit Bug 37651: Unit tests Test plan: Run t/db_dependent/Holds.t (Without previous patches, it would fail.) Run t/db_dependent/Koha/Biblios.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 Marcel de Rooy changed: What|Removed |Added Attachment #171248|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 176655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176655&action=edit Bug 37651: Add ConfirmFutureHolds to biblio->current_holds Test plan: Easy way is to run the unit tests in the next patch. One call of biblio->current_holds is hidden in acqui/parcel.pl. The table column "Item holds / Total holds" should now make a difference for an order referring to an item having future holds. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 Marcel de Rooy changed: What|Removed |Added Attachment #171247|0 |1 is obsolete|| --- Comment #5 from Marcel de Rooy --- Created attachment 176654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176654&action=edit Bug 37651: Add ConfirmFutureHolds to item->current_holds Test plan: Add future item level hold for another branch. Check in. Confirm and transfer. Note that without this patch, there is no patron info for the column On hold for on transferstoreceive. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 --- Comment #2 from Marcel de Rooy --- Created attachment 171248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171248&action=edit Bug 37651: Add ConfirmFutureHolds to biblio->current_holds Test plan: Easy way is to run the unit tests in the next patch. One call of biblio->current_holds is hidden in acqui/parcel.pl. The table column "Item holds / Total holds" should now make a difference for an order referring to an item having future holds. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 Marcel de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 Marcel de Rooy changed: What|Removed |Added Attachment #171249|0 |1 is obsolete|| --- Comment #4 from Marcel de Rooy --- Created attachment 171250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171250&action=edit Bug 37651: Unit tests Test plan: Run t/db_dependent/Holds.t (Without previous patches, it would fail.) Run t/db_dependent/Koha/Biblios.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 --- Comment #3 from Marcel de Rooy --- Created attachment 171249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171249&action=edit Bug 37651: Unit tests Test plan: Run t/db_dependent/Holds.t (Without previous patches, it would fail.) Run t/db_dependent/Koha/Biblios.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 --- Comment #1 from Marcel de Rooy --- Created attachment 171247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171247&action=edit Bug 37651: Add ConfirmFutureHolds to item->current_holds Test plan: Add future item level hold for another branch. Check in. Confirm and transfer. Note that without this patch, there is no patron info for the column On hold for on transferstoreceive. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37651] biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37651 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=37650 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
