[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Bug 37893 depends on bug 38201, which changed state. Bug 38201 Summary: VueJS architecture rethink https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38201 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Bug 37893 depends on bug 39091, which changed state. Bug 39091 Summary: Cash registers should have a list API endpoint https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39091 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Katie Bliss changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Jonathan Druart changed: What|Removed |Added Blocks||41357 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41357 [Bug 41357] New SIP2 module is broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Kyle M Hall (khall) changed: What|Removed |Added Blocks||41311 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41311 [Bug 41311] Add ability for SIP to send patron home library ( branchcode ) in AO field -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #78 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Lucas Gass (lukeg) changed: What|Removed |Added Keywords|additional_work_needed | Status|Passed QA |Pushed to main --- Comment #77 from Lucas Gass (lukeg) --- follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Pushed to main |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Lucas Gass (lukeg) changed: What|Removed |Added Version(s)||25.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #76 from Pedro Amorim --- Created attachment 189908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189908&action=edit Bug 37893: Handle SIPconfig.xml not found / unreadable prove t/db_dependent/Koha/SIP2/SIP2ModuleMigration.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Pedro Amorim changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Andrii Nugged changed: What|Removed |Added CC||[email protected] --- Comment #75 from Andrii Nugged --- In case there are no SIPs one some configurations/instances, Koha allows not to have SIPconfig.xml, quietly accepts that. But atomic update does not checks for that, and breaks update (making some servers require more advanced restoration, then just middle level sysadmin skills). Sample error: BugUpgrade to 25.06.00.035 [06:55:22]: Bug 37893 - Move SIPconfig.xml to database Reading SIPconfig.xml for kohatest located at /etc/koha/sites/kohatest/SIPconfig.xml ERROR: {UNKNOWN}: File does not exist: /etc/koha/sites/kohatest/SIPconfig.xml at /usr/share/koha/lib/C4/SIP/Sip/Configuration.pm line 55. at /usr/share/koha/lib/C4/Installer.pm line 825 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Pedro Amorim changed: What|Removed |Added Blocks||41271 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41271 [Bug 41271] pod_coverage.t unintentionally attempts to launch a SIP server when checking SIPServer.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893
--- Comment #74 from Pedro Amorim ---
(In reply to Jonathan Druart from comment #73)
> Comment on attachment 189711 [details] [review]
> Bug 37893: (QA follow-up): Fix pod_coverage.t
>
> Review of attachment 189711 [details] [review]:
> -
>
> ::: C4/SIP/Sip/Configuration.pm
> @@ +56,4 @@
> > } else {
> > $cfg = $current_config;
> > }
> > +die unless $cfg;
>
> this seems wrong.
See bug 41271. I'm open to alternative solutions, of course.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893
--- Comment #73 from Jonathan Druart ---
Comment on attachment 189711
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189711
Bug 37893: (QA follow-up): Fix pod_coverage.t
Review of attachment 189711:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=37893&attachment=189711)
-
::: C4/SIP/Sip/Configuration.pm
@@ +56,4 @@
> } else {
> $cfg = $current_config;
> }
> +die unless $cfg;
this seems wrong.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Lucas Gass (lukeg) changed: What|Removed |Added Keywords|additional_work_needed, | |release-notes-needed| --- Comment #72 from Lucas Gass (lukeg) --- follow-ups pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #71 from Pedro Amorim --- Created attachment 189712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189712&action=edit Bug 37893: (QA follow-up): Fix TestBuilder.t To test, run: prove t/db_dependent/TestBuilder.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #70 from Pedro Amorim --- Created attachment 189711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189711&action=edit Bug 37893: (QA follow-up): Fix pod_coverage.t To test: prove -v /kohadevbox/koha/xt/author/pod_coverage.t The changes to Schema files are fixes that were overlooked originally. The 'die' line in C4/SIP/Sip/Configuration.pm is to force the script to die if SIP configuration does not exist, which only happens when running pod_coverage.t The original code (prior to 37893) did not consider the possibiliy of a config_file being invalid or undef, parser->XMLin(config_file) died silently, but because pod_coverage.t skips over files that die, it didn't fail. See bug 41271. Now, with the changes from bug 37893, if a config_file doesnt exist the code falls back to whats in the cache, so it doesn't try to XMLin load an invalid config_file anymore, and fails verbosely. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #69 from Lucas Gass (lukeg) --- xt/author/pod_coverage.t is failing after this was pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Pedro Amorim changed: What|Removed |Added Text to go in the||This update introduces a release notes||new SIP2 module that allows ||staff members with the new ||sip2 permission to manage ||SIP2 institutions, ||accounts, and system ||preference overrides ||directly in the UI. When ||upgrading to 25.11, the ||relevant SIPConfig.xml ||settings are automatically ||migrated into the database. ||These settings can then be ||edited in the UI, and the ||SIP server will pick up any ||changes immediately without ||needing a restart. This ||makes configuring SIP2 ||easier, removing the need ||for server access to edit ||XML files or restart the ||SIP server for these ||settings. ||Server params and listeners ||are intentionally not ||included in this work and ||must still be configured in ||the SIPConfig.xml file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Lucas Gass (lukeg) changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Lucas Gass (lukeg) changed: What|Removed |Added Keywords||release-notes-needed --- Comment #68 from Lucas Gass (lukeg) --- we will need release notes here. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Lucas Gass (lukeg) changed: What|Removed |Added Keywords|rel_25_11_candidate,| |RM_priority | Status|Passed QA |Pushed to main --- Comment #67 from Lucas Gass (lukeg) --- Pushed to main to for 25.11.00, nice work all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #66 from David Cook --- (In reply to Pedro Amorim from comment #61) > > (In reply to Jonathan Druart from comment #59) > > > 11. Missing changes in etc/koha-httpd.conf? > > > > I haven't checked all the places Jonathan mentioned but I have checked this > > one and in light of bug 41167, I'm marking this as Failed QA > > Thank you for bringing my attention to bug 41167, I was not aware of it. > However bug 41167 is not in main. I don't fully agree with FQA due to a bug > not yet in main, I think it opens a less then ideal precedent, though I > understand that it makes sense in this instance. Here is what I did: > 1) Fully rebased the branch on current main > 2) Made it depend on bug 41167 > 3) Added the patch: > https://github.com/openfifth/koha/commit/ > 57c5b64943ab72a744c2f9fcadf4c8b21e9d0b31 That's a good point. Initially I wasn't thinking of depending on bug 41167 but rather just adding the required 1 line to etc/koha-httpd.conf, but then that probably would've made for a merge conflict. Just bad timing, but thanks for taking care of it! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #65 from Jonathan Druart --- (In reply to Pedro Amorim from comment #63) > (In reply to Jonathan Druart from comment #62) > > > Out of scope here? AFAIK the 'dummy' existing config in SIPconfig.xml > > > served > > > only as documentation for all the possible configuration values for > > > accounts > > > + institutions + syspref overrides (which is what is migrated here). > > > Server > > > params and listeners are still read from the SIPconfig.xml file (as per > > > DCook's original QA requirements). > > > > It's a regression for ktd: we are expecting to have a working configuration. > > See https://gitlab.com/koha-community/koha-misc4dev/-/issues/35 and the > > related merge request "Issue #35 - Make SIP work out of the box" > > C4::SIP::Sip::Configuration::get_configuration only fetches accounts, > institutions and syspref_overrides from the database if any exist (in the > database). Otherwise it falls back to the old way: reading that data from > SIPconfig.xml. This was purposely done to have a smooth transition i.e. if > for any reason the data is not in the database, reading from the > SIPconfig.xml is still the fallback (until full deprecation in the > future(?)). > > I'm happy to help/follow-up with whatever is needed, though I've not worked > on misc4dev before and would appreciate guidance, would it be a new > sip_data.sql file under installer/data/mysql/mandatory? Thank you. Open an issue there and we will deal with that later. It seems that we could detect if the dbrev exists, if it exists we can run it and it will populate the DB. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #64 from Pedro Amorim --- Cypress tests failing after following QA feedback entries. Patch updating cypress tests pushed: https://github.com/openfifth/koha/commit/2201bb08a1b644992f840e71e2578efe5e31665d -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #63 from Pedro Amorim --- (In reply to Jonathan Druart from comment #62) > > Out of scope here? AFAIK the 'dummy' existing config in SIPconfig.xml served > > only as documentation for all the possible configuration values for accounts > > + institutions + syspref overrides (which is what is migrated here). Server > > params and listeners are still read from the SIPconfig.xml file (as per > > DCook's original QA requirements). > > It's a regression for ktd: we are expecting to have a working configuration. > See https://gitlab.com/koha-community/koha-misc4dev/-/issues/35 and the > related merge request "Issue #35 - Make SIP work out of the box" C4::SIP::Sip::Configuration::get_configuration only fetches accounts, institutions and syspref_overrides from the database if any exist (in the database). Otherwise it falls back to the old way: reading that data from SIPconfig.xml. This was purposely done to have a smooth transition i.e. if for any reason the data is not in the database, reading from the SIPconfig.xml is still the fallback (until full deprecation in the future(?)). I'm happy to help/follow-up with whatever is needed, though I've not worked on misc4dev before and would appreciate guidance, would it be a new sip_data.sql file under installer/data/mysql/mandatory? Thank you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #62 from Jonathan Druart --- > > 1. There are no cypress tests > > Yes, there are. See t/cypress/integration/SIP2. No idea how I missed that! > > 4. If I upgrade I do have stuffs in the DB (picked from > > /etc/koha/sites/kohadev/SIPconfig.xml) but for new installs the table are > > not populated. > > Maybe we need to patch miscdev(?) > > Out of scope here? AFAIK the 'dummy' existing config in SIPconfig.xml served > only as documentation for all the possible configuration values for accounts > + institutions + syspref overrides (which is what is migrated here). Server > params and listeners are still read from the SIPconfig.xml file (as per > DCook's original QA requirements). It's a regression for ktd: we are expecting to have a working configuration. See https://gitlab.com/koha-community/koha-misc4dev/-/issues/35 and the related merge request "Issue #35 - Make SIP work out of the box" > > 7 Don't we want a config flag to turn off the ability to edit from the UI? > > I don't think so? The ability to access and work with the module is already > governed by the new 'sip2' permission. Yes, but prior to this change only sysops were able to edit it. I would like Kyle and Tomas opinion on this one. Thanks for the other fixes! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Pedro Amorim changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=41215 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Pedro Amorim changed: What|Removed |Added Blocks||41214 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41214 [Bug 41214] Cash register should only show if UseCashRegisters sys pref is enabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Pedro Amorim changed: What|Removed |Added Depends on||41167 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41167 [Bug 41167] Rewrite Rules missing in etc/koha-httpd.conf -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893
Pedro Amorim changed:
What|Removed |Added
Status|Failed QA |Passed QA
--- Comment #61 from Pedro Amorim ---
Thank you Jonathan for the time spent here, as always. I've done my best to
address your feedback below.
(In reply to Jonathan Druart from comment #57)
> There are tons of failures caught by the QA script.
Yes, please read comment 42:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893#c42
I believe most of these are false positives, however the following follow-up
patches fix those that aren't:
1) Set tinyint boolean => 0 for tinyint not boolean fields:
https://github.com/openfifth/koha/commit/521a53224c4d364e2910397a801a1c4af252b9c5
2) Add new line to apache-shared-intranet.conf:
https://github.com/openfifth/koha/commit/ea30ba55dd978c92e33e6f270a8e7931e7d79d69
3) js-patron-format.inc (only shows now after bug 40958):
https://github.com/openfifth/koha/commit/4ee64da97a6e7b7d60cec65131fd3ea925da3365
(In reply to Jonathan Druart from comment #58)
> Quick QA review (not tested SIP)
>
> 1. There are no cypress tests
Yes, there are. See t/cypress/integration/SIP2.
> 2. Only use the plural module is needed
> eg.
> 22 use Koha::SIP2::Account;
> 23 use Koha::SIP2::Accounts;
> same pattern in several places
Patch addressing:
https://github.com/openfifth/koha/commit/c7b1ee47073b6e1e94f92f8cc6a8fa3e4f1ba6b2
> 3. Tests are missing for (at least) Koha/SIP2/Account.pm
> Also get_for_config sub are not covered by tests. Not sure how it would be
> useful however...
Tests added for Koha/SIP2/Account.pm:
https://github.com/openfifth/koha/commit/3a07ee8194eb95a2897afc2c3e44a796c7b70975
get_for_config for all SIP related classes is tested by SIP2ModuleMigration.t.
This test file tests and proves that the configuration read by the SIPServer is
the same before and after the migration from XML to the database, which invokes
get_for_config for each of the classes.
> 4. If I upgrade I do have stuffs in the DB (picked from
> /etc/koha/sites/kohadev/SIPconfig.xml) but for new installs the table are
> not populated.
> Maybe we need to patch miscdev(?)
Out of scope here? AFAIK the 'dummy' existing config in SIPconfig.xml served
only as documentation for all the possible configuration values for accounts +
institutions + syspref overrides (which is what is migrated here). Server
params and listeners are still read from the SIPconfig.xml file (as per DCook's
original QA requirements).
> 5. "Cash register:" shouldn't we hide it if none exists or if the pref is
> off?
Patch submitted to bug 41214.
I agree with this, however I think a wider 'add option for resource attributes
to display based on sys pref' to the VueJS framework is needed here. For this
reason, I think this makes more sense as a follow-up bug, to be addressed and
discussed in bug 41214.
I don't think this should be a blocker here as:
1) The field is optional
2) Information regarding UseCashRegisters sys pref being required is also
included in the field's respective tooltip.
> 6. Framework bugs?
> a. you can enter a letter after a number ("42a") in the numeric input (eg.
> "retries") and submit the form and you get a "400 Something went wrong:
> Error: Expected integer - got string."
> b. you can enter a letter in the number inputs ('x') and it becomes "NaN"
Yes, opened bug 41215, with reproduction instructions using existing vendors
already in main (i.e. unrelated to the patchset here).
> 7 Don't we want a config flag to turn off the ability to edit from the UI?
I don't think so? The ability to access and work with the module is already
governed by the new 'sip2' permission.
> 8. kohastructure.sql has wrong DROP/CREATE statement
>
> +DROP TABLE IF EXISTS `file_transports`;
> +/*!40101 SET @saved_cs_client = @@character_set_client */;
> +/*!40101 SET character_set_client = utf8 */;
> +CREATE TABLE `file_transports` (
Thank you for spotting this. It must've been caused by a failed past rebase.
Fixed here:
https://github.com/openfifth/koha/commit/26438204c16d1deaea2757cdd165de0aacbbdb38
> 9. I think sip2/sip2.tt is wrong about #sip2 being closed in
> intranet-bottom.inc
> It should be and the last closing div removed.
Patch addressing:
https://github.com/openfifth/koha/commit/853f1365103c5ef747d7e136828ce75c21e2bebb
> 10. Breadcrumb start with SIP2, shouldn't it be "Administration"?
Patch addressing:
https://github.com/openfifth/koha/commit/a704e629f5d96b16a284d1e4526de95dcd4c9ce7
(In reply to David Cook from comment #60)
> Nice catches there, Jonathan.
>
> (In reply to Jonathan Druart from comment #59)
> > 11. Missing changes in etc/koha-httpd.conf?
>
> I haven't checked all the places Jonathan mentioned but I have checked this
> one and in light of bug 41167, I'm marking this as Failed QA
Thank you for bringin
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 David Cook changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #60 from David Cook --- Nice catches there, Jonathan. (In reply to Jonathan Druart from comment #59) > 11. Missing changes in etc/koha-httpd.conf? I haven't checked all the places Jonathan mentioned but I have checked this one and in light of bug 41167, I'm marking this as Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #59 from Jonathan Druart --- 11. Missing changes in etc/koha-httpd.conf? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893
--- Comment #58 from Jonathan Druart ---
Quick QA review (not tested SIP)
1. There are no cypress tests
2. Only use the plural module is needed
eg.
22 use Koha::SIP2::Account;
23 use Koha::SIP2::Accounts;
same pattern in several places
3. Tests are missing for (at least) Koha/SIP2/Account.pm
Also get_for_config sub are not covered by tests. Not sure how it would be
useful however...
4. If I upgrade I do have stuffs in the DB (picked from
/etc/koha/sites/kohadev/SIPconfig.xml) but for new installs the table are not
populated.
Maybe we need to patch miscdev(?)
5. "Cash register:" shouldn't we hide it if none exists or if the pref is off?
6. Framework bugs?
a. you can enter a letter after a number ("42a") in the numeric input (eg.
"retries") and submit the form and you get a "400 Something went wrong: Error:
Expected integer - got string."
b. you can enter a letter in the number inputs ('x') and it becomes "NaN"
7 Don't we want a config flag to turn off the ability to edit from the UI?
8. kohastructure.sql has wrong DROP/CREATE statement
+DROP TABLE IF EXISTS `file_transports`;
+/*!40101 SET @saved_cs_client = @@character_set_client */;
+/*!40101 SET character_set_client = utf8 */;
+CREATE TABLE `file_transports` (
9. I think sip2/sip2.tt is wrong about #sip2 being closed in
intranet-bottom.inc
It should be and the last closing div removed.
10. Breadcrumb start with SIP2, shouldn't it be "Administration"?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #57 from Jonathan Druart --- There are tons of failures caught by the QA script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #56 from Kyle M Hall (khall) --- Thank you for the followup bugs and patches! I think this is ready to be pushed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Pedro Amorim changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #55 from Pedro Amorim --- (In reply to Kyle M Hall (khall) from comment #54) Thank you so much for your time looking here, Kyle. > For the institutions editor: > It appears that deleting an institution will delete all accounts connected > to that institution ( which makes sense ) with no warning. It would be best > if the editor either warned that "the following accounts will be deleted: > act1, act2, etc." or simply prevent deletion of institutions with SIP > accounts. Considering this non-blocker, I hope you understand and agree, for the following reasons: 1) A confirmation box already exists. 2) Only authorized staff members with assigned permissions are able to delete institutions in the first place. 3) This needs a framework doResourceDelete change (i.e. may need additional testing / cause a QA delay here). For that, I've opened bug 41178, and provided patches there. I don't think full module should be blocked by this, and ideally bug 41178 is also looked at by Matt+Joubu. > It would also be nice if the institution "name" field were limited to a > branchcode pulldown since Koha can no longer handle institutions that are > not branchcodes. This is a bit out of scope so it's not a blocker. At the > very least the tooltip should state that unexpected behavior can occur if it > is *not* a valid branchcode. Not a blocker. Opened bug 41180 for future enhancement. Patch updating the tooltip pushed to branch: https://github.com/openfifth/koha/commit/3ecf278a05ed4dc96e0d104ce0d91ce6626a98ac > The policy defaults should all default to "yes" in my mind, but I'm open to > arguments against it. Patch submitted: https://github.com/openfifth/koha/commit/0278df6b9575846c4b67fbae0619cbbe4dd56d94 > Retries field should be limited to a max of 999 retries, as the field is 3 > characters long. This is a blocker and a minor fix I think. Patch submitted: https://github.com/openfifth/koha/commit/24393d6d0b46a976f358673ebda9af37f8d059dd > "Staff userid for SIP2 authentication" could be using the patron search in > the same way that circulation does to fill in the userid from a list of > options. Also not a blocker but would be really nice to have. Not a blocker. Opened bug 41179 for future enhancement. > For the accounts editor: > "Convert nonprinting characters" defaults to NULL for imported accounts, but > defaults to empty string for created accounts with no option for NULL. The > only value I've ever used for this is a space, as it is usually used to > convert things like newlines for devices that cannot handle them. This could > be either changed to a text field with a checkbox, or a pulldown with > options for NULL and space ( and could be added to in the future ), or even > a list of authorized values. The simplest solution would be to have empty > string convert to NULL. Any of these solutions is acceptable IMO. Patch ensure empty string is submitted as NULL: https://github.com/openfifth/koha/commit/95e718520f2d9a3bff1f2ed12e2d735b925806c7 > "Format due date" should have a tooltip explaining it will format the due > date in the current DateFormat syspref. Patch updating tooltip: https://github.com/openfifth/koha/commit/6d3373f7ce0565c44a7dda9c78b7ec2fd8e87466 > "Holds get captured" may need a tool tip? Not a blocker, but I'm not sure > how well understood this one will be. Patch updating tooltip: https://github.com/openfifth/koha/commit/8a59f8935ca82975f5a24a2d849d157bb352e2f3 > "Previous checkout block checkout" should read "Block checkout of items > previously or currently checked out by a patron", or maybe "Block previous > checkouts" with a tooltip since that is quite verbose. Patch updating label+tooltip: https://github.com/openfifth/koha/commit/019a5d6a511631f793e083ac292b1772fe04296d > "Send patron home library in AF" can be deprecated but is totally out of > scope for this bug. It was for Overdrive but they no longer use this feature > ( though we'll need to verify they don't have legacy customers using it if > we do ). They now use custom fields of the patron's branchcode. No action made here. I'll leave it up to you if you feel necessary to open a new bug for this or not. > Terminator should default to CRLF. Patch defaulting terminator to CRLF in form: https://github.com/openfifth/koha/commit/412003aeb35d3b5096098d342d0544fa9406ad20 > Patron attribute could use a pulldown of attribute types. Could use a > tooltip at the least. Opened bug 41181 for future enhancement. Patch updating field tooltip in form: https://github.com/openfifth/koha/commit/81408e0c1dfd54d74aa49ed68001a3a4f41c2d5a > It would be nice if delimiter, encoding and terminator had the defaults > inserted into the database instead of being NULL in the database and showing > as empty cells in the accounts table. Patch defaulting delimiter and terminator inserted values in database: https://github.com/openfifth/koha/commit/53670bebfd78bf2eac
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Pedro Amorim changed: What|Removed |Added Blocks||41181 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41181 [Bug 41181] SIP2 module should auto-complete (search) patron attribute types for new patron attribute -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Pedro Amorim changed: What|Removed |Added Blocks||41180 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41180 [Bug 41180] SIP2 module should auto-complete (search) libraries for institutions name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Pedro Amorim changed: What|Removed |Added Blocks||41179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41179 [Bug 41179] SIP2 module should auto-complete (search) patrons for accounts staff userid input -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Pedro Amorim changed: What|Removed |Added Blocks||41178 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 [Bug 41178] SIP2 module does not notify that linked accounts are deleted when deleting an institution -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Lucas Gass (lukeg) changed: What|Removed |Added QA Contact|[email protected] |[email protected] |o.uk| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Lucas Gass (lukeg) changed: What|Removed |Added Keywords||rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Lucas Gass (lukeg) changed: What|Removed |Added CC||[email protected] Keywords||RM_priority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Kyle M Hall (khall) changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #54 from Kyle M Hall (khall) --- For the institutions editor: It appears that deleting an institution will delete all accounts connected to that institution ( which makes sense ) with no warning. It would be best if the editor either warned that "the following accounts will be deleted: act1, act2, etc." or simply prevent deletion of institutions with SIP accounts. It would also be nice if the institution "name" field were limited to a branchcode pulldown since Koha can no longer handle institutions that are not branchcodes. This is a bit out of scope so it's not a blocker. At the very least the tooltip should state that unexpected behavior can occur if it is *not* a valid branchcode. The policy defaults should all default to "yes" in my mind, but I'm open to arguments against it. Retries field should be limited to a max of 999 retries, as the field is 3 characters long. This is a blocker and a minor fix I think. "Staff userid for SIP2 authentication" could be using the patron search in the same way that circulation does to fill in the userid from a list of options. Also not a blocker but would be really nice to have. For the accounts editor: "Convert nonprinting characters" defaults to NULL for imported accounts, but defaults to empty string for created accounts with no option for NULL. The only value I've ever used for this is a space, as it is usually used to convert things like newlines for devices that cannot handle them. This could be either changed to a text field with a checkbox, or a pulldown with options for NULL and space ( and could be added to in the future ), or even a list of authorized values. The simplest solution would be to have empty string convert to NULL. Any of these solutions is acceptable IMO. "Format due date" should have a tooltip explaining it will format the due date in the current DateFormat syspref. "Holds get captured" may need a tool tip? Not a blocker, but I'm not sure how well understood this one will be. "Previous checkout block checkout" should read "Block checkout of items previously or currently checked out by a patron", or maybe "Block previous checkouts" with a tooltip since that is quite verbose. "Send patron home library in AF" can be deprecated but is totally out of scope for this bug. It was for Overdrive but they no longer use this feature ( though we'll need to verify they don't have legacy customers using it if we do ). They now use custom fields of the patron's branchcode. Terminator should default to CRLF. Patron attribute could use a pulldown of attribute types. Could use a tooltip at the least. It would be nice if delimiter, encoding and terminator had the defaults inserted into the database instead of being NULL in the database and showing as empty cells in the accounts table. SIP communication itself appears to work great! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #53 from Pedro Amorim --- (In reply to David Cook from comment #52) > (In reply to David Cook from comment #50) > > > I cannot see this. Can you please provide more information e.g. which > > > page, > > > what browser. > > > > Yep, my bad. I should've been more specific. I can't recall exactly now, but > > I do have one example which I'll explain and provide a screenshot for. > > Looking at this again and I think I see what it means. While many labels > have a "for" attribute, they're not for a single form input, so they're not > actually usable. I see it now as well, yes. This appears to be an issue in the framework itself, if you create a new ERM agreement you get the same errors: http://localhost:8081/cgi-bin/koha/erm/agreements/add I think that's out of scope here, v-select elements seem to trigger this warning, boolean/radio elements also seem to trigger this warning due to the way HTML elements are rendered. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #52 from David Cook --- (In reply to David Cook from comment #50) > > I cannot see this. Can you please provide more information e.g. which page, > > what browser. > > Yep, my bad. I should've been more specific. I can't recall exactly now, but > I do have one example which I'll explain and provide a screenshot for. Looking at this again and I think I see what it means. While many labels have a "for" attribute, they're not for a single form input, so they're not actually usable. "Payment type writeoff" works because it's a simple mapping between the label and the input, but then things like "Holds block checkin" or "Cash register" show up as violations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #51 from David Cook --- Created attachment 188721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188721&action=edit Page issues showing in console -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #50 from David Cook --- That all sounds good, Pedro. Thanks for reviewing my notes. (In reply to Pedro Amorim from comment #49) > > 6. The console is full of "Incorrect use of " page > > errors. The browser says this could negatively affect accessibility tools. > > I cannot see this. Can you please provide more information e.g. which page, > what browser. Yep, my bad. I should've been more specific. I can't recall exactly now, but I do have one example which I'll explain and provide a screenshot for. Steps: 0. Open F12 tools (I'm in Chrome but could be Firefox, Edge, whatever) and go to "Console" tab 1. Go to http://localhost:8081/cgi-bin/koha/sip2/sip2.pl 2. Click "Accounts" 3. Click "Edit" on any of the rows 4. In the upper right hand corner, there should be a little red flag with an X on it and a count of around 28 next to it. These are issues that don't generate console messages but still show up as issues in the browser. I think we often ignore them in Koha (and most web apps tbh), but I thought I'd flag it anyway. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #49 from Pedro Amorim --- (In reply to David Cook from comment #47) > Finally getting around to this... > > Not planning to be a blocker. Just going to share some notes/observations. > If there's anything that needs changing, I figure it can be done in a future > follow-up bug. Thank you for your time here David. > > Notes: > 1. Curious why etc/SIPconfig.xml and debian/templates/SIPconfig.xml have > comments added rather than having their legacy sections removed? Fair, I'm not sure exactly why I decided this way, but I agree that it should be remove, although as you say trivial and non-blocker. > 2. I would've expected to find "Self-service circulation (SIP2)" under > "Additional parameters" rather than "Patrons and circulation" in Admin, but > I suppose it makes a certain conceptual sense. Up for debate I suppose, personally don't feel strongly about this and happy to follow-up if required. > 3. The description in on admin-home.pl still includes "server parameters" > which I think is incorrect. Good spot. Patch provided: https://github.com/openfifth/koha/commit/fa5d3b678123e1f8d5d968923897861006486e2e > 4. Curious why "sip2.pl" went into its own "sip2" directory. Guessing it's > because of imitating "erm". I don't think this is a good move for the > long-term organisation of Koha source code, but c'est la vie I guess. Correct, to adhere to established pattern. > 5. It looks like there is no way to define a password for a SIP2 account in > the web ui, but... that's because it uses the actual borrower account, so > it's no longer required to store the password in plain text. Oh that's very > cool. I can imagine that would confuse some people, but still... very cool. > (I also like how you can update the password for a user and you don't have > to restart the SIP server. Excellent.) > > 6. The console is full of "Incorrect use of " page > errors. The browser says this could negatively affect accessibility tools. I cannot see this. Can you please provide more information e.g. which page, what browser. > 7. There is no validation on the "Staff userid for SIP2 authentication". You > can put anything you like. That one would be cool to be done by a dropdown > menu which only shows users that have appropriate permissions. This is the follow-up suggestion Martin is referring to in his comment. We discussed and agreed that a 'patron search' relationship type of input is required to be added to the framework for this, but a wider discussion with the community is needed to agree on a way of doing (use patron_autocomplete? Use existing patron search modal in vuejs?) > > 9. Hmmm I turned off "Checkin" for the CPL institution but it still let me > checkin... maybe it does require a restart. I'll re-test that... > > Hmm nope... still allows checkin after a restart of the SIP server. > > Although to be fair I don't know if any of those attributes ever worked in > SIPconfig.xml either. I've looked here and these seem to not be working, even before this piece. It doesn't matter if checkin/checkout if 'true', 'false', or non-existent, it always allows for checkin/checkout. I thought it could be because I was testing checkin/checkout for cardnumber '42' (superlibrarian) but using a regular patron produces the same results. I'd consider this to be a bug outside the scope of this work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #48 from David Cook --- Just reiterating that I'm giving this a +1 from me. I think if any issues do pop up... we fix them as they come. This is a good generational shift for Koha's SIP2 server I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #47 from David Cook --- Finally getting around to this... Not planning to be a blocker. Just going to share some notes/observations. If there's anything that needs changing, I figure it can be done in a future follow-up bug. -- Notes: 1. Curious why etc/SIPconfig.xml and debian/templates/SIPconfig.xml have comments added rather than having their legacy sections removed? 2. I would've expected to find "Self-service circulation (SIP2)" under "Additional parameters" rather than "Patrons and circulation" in Admin, but I suppose it makes a certain conceptual sense. 3. The description in on admin-home.pl still includes "server parameters" which I think is incorrect. 4. Curious why "sip2.pl" went into its own "sip2" directory. Guessing it's because of imitating "erm". I don't think this is a good move for the long-term organisation of Koha source code, but c'est la vie I guess. 5. It looks like there is no way to define a password for a SIP2 account in the web ui, but... that's because it uses the actual borrower account, so it's no longer required to store the password in plain text. Oh that's very cool. I can imagine that would confuse some people, but still... very cool. (I also like how you can update the password for a user and you don't have to restart the SIP server. Excellent.) 6. The console is full of "Incorrect use of " page errors. The browser says this could negatively affect accessibility tools. 7. There is no validation on the "Staff userid for SIP2 authentication". You can put anything you like. That one would be cool to be done by a dropdown menu which only shows users that have appropriate permissions. 8. I can't find an easy way to test institutions with the time and data I have at hand right now, so I'm going to just assume they work correctly. It would've been good to have a more comprehensive test plan with things like checkins and checkouts to prove that the change works... Actually I just realised the wiki has some things for this... Hmm... I can't seem to perform SIP checkouts... perl misc/sip_cli_emulator.pl -su koha -sp 1Test1Test -l CPL --host localhost --patron 42 -m checkout --item 301310 Attempting socket connection to localhost:6001...connected! SEND: 9300CNkoha|CO1Test1Test|CPCPL| READ: 941 Trying 'checkout' SEND: 11YN2025103005164020251030 051640AOCPL|AA42|AB301310|AC1Test1Test|BIN| READ: undef Seeing the following in sip-output.log: [2025/10/30 05:17:48] [23774] [WARN] [email protected]: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'branchcode' at row 1 at /kohadevbox/koha/Koha/Object.pm line 174 Try: :Tiny::try /usr/share/perl5/Try/Tiny.pm (123) [2025/10/30 05:17:48] [23774] [ERROR] [email protected]: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'branchcode' at row 1 at /kohadevbox/koha/Koha/Object.pm line 174 C4: :SIP::Trapper::__ANON__ /kohadevbox/koha/C4/SIP/Trapper.pm (70) [2025/10/30 05:17:48] [23774] [ERROR] [email protected]: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Data too long for column 'branchcode' at row 1 at /kohadevbox/koha/Koha/Object.pm line 174 C4: :SIP::Trapper::__ANON__ /kohadevbox/koha/C4/SIP/Trapper.pm (70) [2025/10/30 05:17:48] [23774] [INFO] [email protected]: raw_transport: shutting down C4::SIP::Sip::siplog /kohadevbox/koha/C4/SIP/Sip.pm (327) Ah that's because I'd updated the account to use "kohalibrary" in Accounts which is an invalid institution. Changed it back to CPL and now it's working. 9. Hmmm I turned off "Checkin" for the CPL institution but it still let me checkin... maybe it does require a restart. I'll re-test that... Hmm nope... still allows checkin after a restart of the SIP server. Although to be fair I don't know if any of those attributes ever worked in SIPconfig.xml either. -- Overall, it's looking pretty good I think. I think it's a good move in the right direction for sure. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #46 from Martin Renvoize (ashimema) --- A few tiny QA follow-ups were added to the branch, and signoff and sponsorship lines were added. All in all, I think this is a great piece of work and really moves Koha forward. I have a suggestion for a follow-up which Pedro is aware of for the future, but it more relates to Vue framework than the SIP interfaces here.. my final follow-up notes it and allows for us to move forward without it by adding a trivial tooltip. Passing QA, please grab the branch in your leisure Lucas :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Martin Renvoize (ashimema) changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Martin Renvoize (ashimema) changed: What|Removed |Added QA Contact|[email protected] |[email protected] ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Pedro Amorim changed: What|Removed |Added URL|https://github.com/openfift |https://github.com/openfift |h/koha/commits/new_bug_3789 |h/koha/commits/final_bug_37 |3 |893 Status|Failed QA |Needs Signoff --- Comment #42 from Pedro Amorim --- Hi all, I've revisited this: - A third rewrite has been done on the module to adhere to the patterns introduced by pushed bug 38201 (VueJS composition API, etc) - Server params and listeners have been removed from the UI module and are kept in SIPConfig.xml as per QA comments by David Cook. - Cache is now utilized to check for the last time an account, an institution or a system preference override has been updated. When a new SIP request comes in, it checks if SIP configuration has been updated and does a new read from the database if so. This allows for changes that are made by the UI to reflect on the SIP server without needing a server restart. QA script complaints: - Files were added+removed in the same patch. This refers to the server params+listeners functionality that once existed but has since been purged. - The above happens because I've opted to not squash any patches. This project has gone for over a year (on and off) and contains a patch co-authored by Martin Renvoize and a patch co-authored by Mark Hofstetter. - Some database columns are tinyint but not boolean: lost_block_checkout, lost_block_checkout_value, lost_status_for_missing. These are false positives as these are all intentionally tinyint not boolean. - I believe errors on SIPServer.pm related to pod_coverage are false positives coming from old methods that have non-conformant pod code, not by code added on this patchset. Test plan remains the same. However, because many code changes have happened, I'm asking those who tested before to please test again when convenient. Test plan for the whole module: [MODULE UI TESTING] 1) Checkout the branch and reset_all 2) Run 'updatedatabase'. The contents from /etc/koha/sites/kohadev/SIPConfig.xml have been migrated to the database and should be accessible in the UI. 3) Visit the administration page: http://localhost:8081/cgi-bin/koha/admin/admin-home.pl 4) Notice the new 'Self-service circulation (SIP2)' item under 'Patrons and circulation'. Click it. 5) Notice you are now on the new SIP2 module. Create some institutions, accounts, listeners, etc. Play around with the forms. 6) Confirm all the data has been migrated correctly, and is editable in the UI as expected. [SIP TESTING] 1) On ktd, run the following SIP emulator command: $ perl misc/sip_cli_emulator.pl -su koha -sp koha -l kohalibrary --host localhost --patron 42 -m patron_information 2) Note that the response message contains 'Greetings from Koha'. 3) Using the module UI, visit SIP accounts: http://localhost:8081/cgi-bin/koha/sip2/accounts 4) Find the SIP account that has 'koha' as login. Click edit. 5) Scroll down to 'SIP response mappings' and click 'Add new screen msg regex'. 6) On 'Find', enter 'Greetings from Koha'. On 'Replace', enter 'Hello from 37893 test plan'. Save. 7) Repeat the sip command from 1). Note that 'Greetings from Koha has been replaced with 'Hello from 37893 test plan', without having to restart the SIP server. [OPTIONAL] 1) You can repeat the previous steps in [MODULE UI TESTING] but edit the contents of /etc/koha/sites/kohadev/SIPConfig.xml beforehand with a more complex and thorough configuration (something resembling a real SIPConfig.xml) 2) After updating the contents of SIPConfig.xml, restart SIP: koha-sip --restart 3) Test the module again, verify the contents have been migrated as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Pedro Amorim changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #44 from Pedro Amorim --- (In reply to Andrew Fuerste-Henry from comment #43) > All values from the SIP config imported successfully. > All functionality worked as well with these patches as it does in current > main. We could not get the default example bin sorting rule to work with > this patch, but we couldn't get it to work on current main, either. > > However, failing QA due to test failures in the QA tool. > > Test Summary Report > --- > /kohadevbox/koha/t/db_dependent/api/v1/sip2_accounts.t (Wstat: 512 (exited > 2) Tests: 6 Failed: 2) > Failed tests: 3, 6 > Non-zero exit status: 2 > Files=1, Tests=6, 5 wallclock secs ( 0.01 usr 0.00 sys + 3.73 cusr 0.34 > csys = 4.08 CPU) > Result: FAIL I can't reproduce this, the QA script only comes back with the false positives I mentioned above, nothing about tests files: Running tests (4) * Proving /kohadevbox/koha/t/db_dependent/Koha/SIP2/SIP2ModuleMigration.t PASS * Proving /kohadevbox/koha/t/db_dependent/api/v1/sip2_accounts.t PASS * Proving /kohadevbox/koha/t/db_dependent/api/v1/sip2_institutions.t PASS * Proving /kohadevbox/koha/t/db_dependent/api/v1/sip2_system_preference_overrides.t PASS Can you please check again? With fresh ktd data only. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com, ||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Brendan Lawlor changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #43 from Andrew Fuerste-Henry --- All values from the SIP config imported successfully. All functionality worked as well with these patches as it does in current main. We could not get the default example bin sorting rule to work with this patch, but we couldn't get it to work on current main, either. However, failing QA due to test failures in the QA tool. Test Summary Report --- /kohadevbox/koha/t/db_dependent/api/v1/sip2_accounts.t (Wstat: 512 (exited 2) Tests: 6 Failed: 2) Failed tests: 3, 6 Non-zero exit status: 2 Files=1, Tests=6, 5 wallclock secs ( 0.01 usr 0.00 sys + 3.73 cusr 0.34 csys = 4.08 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Jonathan Field changed: What|Removed |Added CC||[email protected] ||.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #45 from Andrew Fuerste-Henry --- The test failures I was getting cleared up when testing on fresh KTD data. Signing off! TY! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Lisette Scheer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35369 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #41 from Marion Durand --- (In reply to Pedro Amorim from comment #40) > (In reply to Marion Durand from comment #39) > > Just an idea here (but it might be managed in a separate bug after this one > > is pushed), it would be amazing to be able to duplicate all translation > > (screen_msg_regx) from an account to another. And even more to export and > > import all translation for transfer between Koha. > > > > It is currently quite difficult to manage translation when maintaining > > multiple instances which all have multiple login. > > Would a 'duplicate' (full resource) feature address this? The idea being > you'd duplicate an existing SIP2 account (create a new one with values from > previous already filled in), keep the things you want (e.g. screen_msg_regx) > and remove/change the rest? Yes it would definitely be a great help ! Even if a way to export+import screen messages would still be nice as it allows sharing translation across different libraries and instances of Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #40 from Pedro Amorim --- (In reply to Marion Durand from comment #39) > Just an idea here (but it might be managed in a separate bug after this one > is pushed), it would be amazing to be able to duplicate all translation > (screen_msg_regx) from an account to another. And even more to export and > import all translation for transfer between Koha. > > It is currently quite difficult to manage translation when maintaining > multiple instances which all have multiple login. Would a 'duplicate' (full resource) feature address this? The idea being you'd duplicate an existing SIP2 account (create a new one with values from previous already filled in), keep the things you want (e.g. screen_msg_regx) and remove/change the rest? I ask this because bug 38201 (that blocks this one) aims to move development towards a more framework oriented approach. If this 'duplicate' feature is developed at the framework level, every VueJS module would be able to make use of it (including this SIP2 module), as this 'duplicate' functionality would certainly be useful in other modules / use cases (?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #39 from Marion Durand --- Just an idea here (but it might be managed in a separate bug after this one is pushed), it would be amazing to be able to duplicate all translation (screen_msg_regx) from an account to another. And even more to export and import all translation for transfer between Koha. It is currently quite difficult to manage translation when maintaining multiple instances which all have multiple login. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Marion Durand changed: What|Removed |Added CC||[email protected] --- Comment #38 from Marion Durand --- *** Bug 21935 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #37 from David Cook --- (Apologies if it takes me some time to respond. My mail server is blocking Bugzilla so I'm not getting email notifications at this time.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #36 from David Cook --- (In reply to David Cook from comment #34) > table might not be possible when running the SIP server as a non-root user, > since non-root users should have limits on the number of processes they can > run. So it looks like I might be wrong there. > > But you could still create problems even as a non-root user. > > Basically just put the your min_servers, max_servers, and min_spare_servers > to very high values. For instance, max_servers 50 and min_spare_servers > 45. If you wanted to check for the DOS, I'd say up those more to 500 for max_servers and 450 for min_spare_servers. You might need "min_servers" to match "min_spare_servers". I can't quite recall. (Taking a quick look at the code and yeah it looks like min_serves must be more than min_spare_servers at least.) Overall, just try to break stuff. Set log_level to 4 and change log_file to /tmp/hack_file.log or something else writeable by the Koha user (like /etc/koha/sites//hack_file.log) and try to fill up the file system and cause crashes that way. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #35 from David Cook --- (In reply to Pedro Amorim from comment #32) > @David Cook, would a new 'sip2_module' staff permission here help / be > enough? Nope, because these are server-level parameters and not Koha/application-level parameters. The only web user permission that could potentially make sense for this is if we created a new user category like "system_administrator" and not give anyone that category except the system administrator that actually manages that server. These are not things that libraries should be able to manage themselves. Just the person managing the server. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #34 from David Cook --- Sorry my bug mail is broken so I didn't get this. Just noticed your response by chance... (In reply to Pedro Amorim from comment #31) > (In reply to David Cook from comment #29) > > Theoretically, you could DOS > > a server (accidentally or maliciously) by feeding in server-params that fill > > up the process table. > > Can you please provide an example / test plan to reproduce / replicate this > so I can address it? Just looking up the process limits now. It looks like filling up the process table might not be possible when running the SIP server as a non-root user, since non-root users should have limits on the number of processes they can run. So it looks like I might be wrong there. But you could still create problems even as a non-root user. Basically just put the your min_servers, max_servers, and min_spare_servers to very high values. For instance, max_servers 50 and min_spare_servers 45. Keep in mind that the server-params are passed to the SIP server completely un-checked and un-sanitized, and that all parameters listened in the "CONFIGURATION FILE" section of Net::Server::PreFork can be used. It's just way too much control. > (In reply to David Cook from comment #30) > > I agree with the original idea that "accounts" and "institutions" should be > > moved into the DB/web UI, but "listeners" and "server-params" really should > > not be. > > > > "syspref_overrides"... I'm not familiar enough with the use of that in the > > SIP server, so I don't have ready comment on that one. > > You are proposing that only the accounts and institutions part is moved out > of SIPConfig.xml. Everything else related to SIP configuration is kept in > SIPConfig.xml. Is that correct? More or less. Basically, I'm saying "listeners" and "server-params" should stay in SIPConfig.xml. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||40120 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40120 [Bug 40120] Log changes to SIP configuration made through staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #33 from Marion Durand --- I think that syspref_override car also be migrated in the interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #32 from Pedro Amorim --- @David Cook, would a new 'sip2_module' staff permission here help / be enough? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #31 from Pedro Amorim --- (In reply to David Cook from comment #29) > Theoretically, you could DOS > a server (accidentally or maliciously) by feeding in server-params that fill > up the process table. Can you please provide an example / test plan to reproduce / replicate this so I can address it? (In reply to David Cook from comment #30) > I agree with the original idea that "accounts" and "institutions" should be > moved into the DB/web UI, but "listeners" and "server-params" really should > not be. > > "syspref_overrides"... I'm not familiar enough with the use of that in the > SIP server, so I don't have ready comment on that one. You are proposing that only the accounts and institutions part is moved out of SIPConfig.xml. Everything else related to SIP configuration is kept in SIPConfig.xml. Is that correct? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Rebecca Coert changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #28 from [email protected] --- Tested this successfully and I'm signing off on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Lisette Scheer changed: What|Removed |Added CC||[email protected] --- Comment #27 from Lisette Scheer --- *** Bug 33681 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 [email protected] changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #26 from David Cook --- (In reply to Lisette Scheer from comment #25) > This worked great. Andrew and I tested. > As far as listeners go, we would have no problem if community wanted to not > make listeners editable. It seems like the biggest place things could go > wrong with this. It would be nice to see the information, but editing it > could cause big headaches. That's a good point about being able to see the information. It could be useful to let library admins see the information, so that they can have more informed discussions with their IT. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Lisette Scheer changed: What|Removed |Added CC||[email protected] ||m Status|Needs Signoff |Signed Off --- Comment #25 from Lisette Scheer --- This worked great. Andrew and I tested. As far as listeners go, we would have no problem if community wanted to not make listeners editable. It seems like the biggest place things could go wrong with this. It would be nice to see the information, but editing it could cause big headaches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #24 from David Cook --- (In reply to Pedro Amorim from comment #22) > Magnus and David, please take a look at this commit when you have the chance: > https://github.com/openfifth/koha/commit/ > a0a003a5aaec12ac8103c3b4512478ddda1fbb8b Looking at this again, I think you've got a typo for the $addr? You're trying to put the port into that variable? Even with that validation, the user would still be able to define any non-privileged port and any IPv4 address. (Note that the validation would prevent IPv6 addresses.) -- Just to reiterate... I'm not worried about web users being able to successfully bind to an IP address and port. I'm worried about them binding to addresses and ports that they shouldn't. (Of course, a workaround for that could be to have address and port limits in koha-conf.xml with some sensible defaults. Like a limit on ports 6000-6999 although limits on IP address could be trickier because of differing setups.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #23 from David Cook --- (In reply to Pedro Amorim from comment #21) > In relation to the issue of different listeners (from different Koha > instances) using the same port, as far as I can tell this is not > checked/enforced currently, i.e. this is already an issue/possibility before > moving it into the module, though I agree that it may expose / make this > more prone to happening since it'll become editable in the UI. (In reply to Pedro Amorim from comment #22) > Magnus and David, please take a look at this commit when you have the chance: > https://github.com/openfifth/koha/commit/ > a0a003a5aaec12ac8103c3b4512478ddda1fbb8b If you have 1 sysadmin managing N SIPconfig.xml, you have 1 person managing the IP addresses and ports across all the instances though, so conflicts aren't a problem. What I'm trying to say is that - as a vendor sysadmin - I don't want Koha library admins being able to configure the IP address and port number for the listener. There would be some potential for malicious abuse to the underlying host system if a user was able to dictate the IP address and port used. It would probably be somewhat limited since it would be running as the Koha user, so it wouldn't be able to bind to a privileged port, but it's still not great. Realistically, in production, the sysadmin will have likely set up stunnel and have that proxying to specific ports they've defined in SIPconfig.xml. There's also the case of the sysadmin or network admin setting up the firewalls. So I'm not quite sure of the benefit to moving the listener config into the web UI? I can only see the downsides. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 George Williams (NEKLS) changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Pedro Amorim changed: What|Removed |Added URL|https://github.com/PTFS-Eur |https://github.com/openfift |ope/koha/commits/new_bug_37 |h/koha/commits/new_bug_3789 |893/|3 --- Comment #22 from Pedro Amorim --- Magnus and David, please take a look at this commit when you have the chance: https://github.com/openfifth/koha/commit/a0a003a5aaec12ac8103c3b4512478ddda1fbb8b -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #21 from Pedro Amorim --- (In reply to Magnus Enger from comment #20) > I think multi-tenanted here means "more than one instance running on the > same server". You don't want different instances to set up their SIPservers > to listen on the same port. > > Not sure how to solve that in code, though. It might have to require people > from the different instances to just talk to each other? Multiple Koha instances, got it. The migration process is designed to pick up the correct respective SIPconfig.xml for the instance running the upgrade so it should only import it's respective data (including listeners). In relation to the issue of different listeners (from different Koha instances) using the same port, as far as I can tell this is not checked/enforced currently, i.e. this is already an issue/possibility before moving it into the module, though I agree that it may expose / make this more prone to happening since it'll become editable in the UI. I'm chatting with Martin about a possible solution we could try here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #20 from Magnus Enger --- > I'm out of my depth when it comes to the inner workings of SIP, and the > following may be a dumb question, but how does one know if a system is > multi-tenanted or not? The UI configuration of listeners could be tied to > this, i.e. only allow CRUD of listeners if not multi-tenanted. I think multi-tenanted here means "more than one instance running on the same server". You don't want different instances to set up their SIPservers to listen on the same port. Not sure how to solve that in code, though. It might have to require people from the different instances to just talk to each other? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #17 from Pedro Amorim --- Test plan for the whole module: [MODULE UI TESTING] 1) Checkout the branch and reset_all 2) Run 'updatedatabase'. The contents from /etc/koha/sites/kohadev/SIPConfig.xml have been migrated to the database and should be accessible in the UI. 3) Visit the administration page: http://localhost:8081/cgi-bin/koha/admin/admin-home.pl 4) Notice the new 'Self-service circulation (SIP2)' item under 'Patrons and circulation'. Click it. 5) Notice you are now on the new SIP2 module. Create some institutions, accounts, listeners, etc. Play around with the forms. 6) Confirm all the data has been migrated correctly, and is editable in the UI as expected. [SIP TESTING] 1) On ktd, run the following SIP emulator command: $ perl misc/sip_cli_emulator.pl -su koha -sp koha -l kohalibrary --host localhost --patron 42 -m patron_information 2) Note that the response message contains 'Greetings from Koha'. 3) Using the module UI, visit SIP accounts: http://localhost:8081/cgi-bin/koha/sip2/accounts 4) Find the SIP account that has 'koha' as login. Click edit. 5) Scroll down to 'SIP response mappings' and click 'Add new screen msg regex'. 6) On 'Find', enter 'Greetings from Koha'. On 'Replace', enter 'Hello from 37893 test plan'. Save. 7) Repeat the sip command from 1). Note that 'Greetings from Koha has been replaced with 'Hello from 37893 test plan', without having to restart the SIP server. [OPTIONAL] 1) You can repeat the previous steps in [MODULE UI TESTING] but edit the contents of /etc/koha/sites/kohadev/SIPConfig.xml beforehand with a more complex and thorough configuration (something resembling a real SIPConfig.xml) 2) After updating the contents of SIPConfig.xml, restart SIP: koha-sip --restart 3) Test the module again, verify the contents have been migrated as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #19 from Pedro Amorim --- (In reply to David Cook from comment #16) > I could see adding "accounts" and "institutions", but not "listeners". > > I suppose for a Koha system where they don't have sysadmin it would be handy > if they could define "listeners", but for a multi-tenanted system you don't > want Koha instances being able to define the listeners. The idea is to move XML file based configurations into a UI module. I agree that listeners are not quite the same as accounts or institutions, but the alternative would be to end up having half of SIP config in the UI module, and the other half in the XML file. The way this has been implemented is to fully move everything out of the XML file into the new UI module. I'm out of my depth when it comes to the inner workings of SIP, and the following may be a dumb question, but how does one know if a system is multi-tenanted or not? The UI configuration of listeners could be tied to this, i.e. only allow CRUD of listeners if not multi-tenanted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Pedro Amorim changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #18 from Pedro Amorim --- (In reply to John Vinke from comment #14) > Failed QA Hi John, thank you. > At step 4 it is unclear what value should be set in implementation field. I pushed a new commit that should address this: https://github.com/openfifth/koha/commit/871ed139317ea56799909b5af8190b15470a02ee Please let me know. > At step 6, nothing will import if you have created institutions, accounts, > etc. > > Can we please have a more detailed test plan that covers all of the patches? I agree. I've made the previous 2 test plan comments obsolete to avoid causing future confusion. I've updated the test plan on the last tests patch on the branch and also copied here on my previous comment. The revised test plan should no longer cause you to experience this, i.e. first creating manually then import through updatedatabase. However, updatedatabase not adding subsequent data is intentional, as the data being re-inserted will fail due to duplicate keys, but the 'INSERT IGNORE INTO' skips the error. Furthermore, because updatedatabase is intended to run at upgrade time, it is not expected to have database data at that point, only data in the SIPconfig.xml file. If you want to run updatedatabase multiple times to test different setups or SIPconfig.xml files, the data should be removed beforehand to avoid duplicate clashes: delete from sip_accounts; delete from sip_institutions; delete from sip_listeners; delete from sip_server_params; delete from sip_system_preference_overrides; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 David Cook changed: What|Removed |Added CC||[email protected] --- Comment #16 from David Cook --- I could see adding "accounts" and "institutions", but not "listeners". I suppose for a Koha system where they don't have sysadmin it would be handy if they could define "listeners", but for a multi-tenanted system you don't want Koha instances being able to define the listeners. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #15 from John Vinke --- We think this is a really nice feature though! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 John Vinke changed: What|Removed |Added CC||[email protected] Status|Needs Signoff |Failed QA --- Comment #14 from John Vinke --- Failed QA At step 4 it is unclear what value should be set in implementation field. At step 6, nothing will import if you have created institutions, accounts, etc. Can we please have a more detailed test plan that covers all of the patches? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Pedro Amorim changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #13 from Pedro Amorim --- Hi all, hi Andrew. Thank you for your patience here. I've updated the branch to pick up on database changes without having to restart the SIP server. The latest commit as an additional test plan to test this specific functionality: Changes are picked up by SIP without restart: Test plan: 1) Using KTD, after having followed the original test plan, run the following SIP emulator command: $ perl misc/sip_cli_emulator.pl -su koha -sp koha -l kohalibrary --host localhost --patron 42 -m patron_information 2) Note that the response message contains 'Greetings from Koha'. 3) Using the module UI, visit SIP accounts: http://localhost:8081/cgi-bin/koha/sip2/accounts 4) Find the SIP account that has 'koha' as login. Click edit. 5) Scroll down to 'SIP response mappings' and expand 'Add new screen msg regex'. 6) On 'Find', enter 'Greetings from Koha'. On 'Replace', enter 'Hello from 37893 test plan'. Save. 7) Repeat the sip command from 1). Note that 'Greetings from Koha has been replaced with 'Hello from 37893 test plan', without having to restart the SIP server. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Marion Durand changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 --- Comment #12 from Pedro Amorim --- Thank you so much Andrew for your reply and your time. I've taken note of this and there is indeed a problem in the SIP restart logic (it's not working). I've been meaning to come back to this but it's not been possible, yet! I'm aiming to follow-up here by end of this week or during hackfest next week. Thank you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Andrew Fuerste-Henry changed: What|Removed |Added CC||[email protected] Status|Needs Signoff |Failed QA --- Comment #11 from Andrew Fuerste-Henry --- We've been testing this with much success! We've successfully configured connections and run tests of most available options. We have a few things yet to confirm. Right up front, though, we're having trouble with the modal to restart SIP after editing the configuration. SIP did not restart when we selected Yes. Our changes did not save when we selected No. Either way, the modal kept coming back even though we checked the "Don't ask again" checkbox. Less pressingly, it'd be nice to get tooltips in the Institutions setup explaining what's wanted in each field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 37893] Migrate some SIP configuration into the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 Pedro Amorim changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
