[Koha-bugs] [Bug 38012] Remove ispermanent from returns.tt and branchtransfers.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38012 Aude Charillon changed: What|Removed |Added Resolution|--- |FIXED CC||aude.charillon@ptfs-europe. ||com Status|Needs documenting |RESOLVED --- Comment #13 from Aude Charillon --- No need for any updates to the Koha Manual. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38012] Remove ispermanent from returns.tt and branchtransfers.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38012 Fridolin Somers changed: What|Removed |Added Status|Pushed to oldstable |Needs documenting --- Comment #12 from Fridolin Somers --- Found it was removed from perl by : Bug 16735: Remove use of get_categories I prefer not impact 23.11.x for stability -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38012] Remove ispermanent from returns.tt and branchtransfers.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38012 Lucas Gass (lukeg) changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38012] Remove ispermanent from returns.tt and branchtransfers.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38012 Lucas Gass (lukeg) changed: What|Removed |Added Version(s)|24.11.00|24.11.00,24.05.06 released in|| Status|Pushed to main |Pushed to stable --- Comment #11 from Lucas Gass (lukeg) --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38012] Remove ispermanent from returns.tt and branchtransfers.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38012 --- Comment #10 from Katrin Fischer --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38012] Remove ispermanent from returns.tt and branchtransfers.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38012 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||24.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38012] Remove ispermanent from returns.tt and branchtransfers.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38012 --- Comment #9 from Katrin Fischer --- Nice clean-up, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38012] Remove ispermanent from returns.tt and branchtransfers.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38012 Martin Renvoize (ashimema) changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com QA Contact|testo...@bugs.koha-communit |ch...@bigballofwax.co.nz |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38012] Remove ispermanent from returns.tt and branchtransfers.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38012 Chris Cormack changed: What|Removed |Added Attachment #172413|0 |1 is obsolete|| --- Comment #8 from Chris Cormack --- Created attachment 172933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172933&action=edit Bug 38012: Remove ispermanent from returns and branchtransfers To test: There should be no change in behavior, as this code is not referred to elsewhere in Koha. Make sure you can still do checkeckins and transfers. Signed-off-by: Phil Ringnalda Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38012] Remove ispermanent from returns.tt and branchtransfers.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38012 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38012] Remove ispermanent from returns.tt and branchtransfers.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38012 Phil Ringnalda changed: What|Removed |Added Attachment #172412|0 |1 is obsolete|| --- Comment #7 from Phil Ringnalda --- Created attachment 172413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172413&action=edit Bug 38012: Remove ispermanent from returns and branchtransfers To test: There should be no change in behavior, as this code is not referred to elsewhere in Koha. Make sure you can still do checkeckins and transfers. Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38012] Remove ispermanent from returns.tt and branchtransfers.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38012 Phil Ringnalda changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38012] Remove ispermanent from returns.tt and branchtransfers.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38012 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #172114|0 |1 is obsolete|| --- Comment #6 from Andrew Fuerste-Henry --- Comment on attachment 172114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172114 Bug 38012: Remove ispermanent from retuns.tt and branchtransfers.tt >From ca71e8a2a8d66b29eca4b3110bc91b661d053e63 Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste Henry >Date: Fri, 27 Sep 2024 13:44:49 + >Subject: [PATCH] Bug 38012: Remove ispermanent from retuns.tt and > branchtransfers.tt > >No real test plan, exactly. These lines reference an error message that >doesn't exist elsewhere in the code. Apply the patch and confirm checkins >still work? >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 3 --- > 1 file changed, 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 6c132ef2b8..68d48353bc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -326,9 +326,6 @@ > [% IF ( errmsgloo.badbarcode ) %] > No item with barcode: [% errmsgloo.msg | html %] > [% END %] >-[% IF ( errmsgloo.ispermanent ) %] >-Please return item to: [% Branches.GetName( errmsgloo.msg ) | >html %] >-[% END %] > [% IF ( errmsgloo.notissued ) %] > Not checked out. > [% END %] >-- >2.39.5 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38012] Remove ispermanent from returns.tt and branchtransfers.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38012 --- Comment #5 from Andrew Fuerste-Henry --- Created attachment 172412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172412&action=edit Bug 38012: Remove ispermanent from returns and branchtransfers To test: There should be no change in behavior, as this code is not referred to elsewhere in Koha. Make sure you can still do checkeckins and transfers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38012] Remove ispermanent from returns.tt and branchtransfers.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38012 Andrew Fuerste-Henry changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38012] Remove ispermanent from returns.tt and branchtransfers.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38012 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #4 from Andrew Fuerste-Henry --- (In reply to Phil Ringnalda from comment #3) > Did you forget to commit the change to branchtransfers.tt? Oh, yes, I 100% did. Thanks and apologies :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38012] Remove ispermanent from returns.tt and branchtransfers.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38012 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org --- Comment #3 from Phil Ringnalda --- Did you forget to commit the change to branchtransfers.tt? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38012] Remove ispermanent from returns.tt and branchtransfers.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38012 Andrew Fuerste-Henry changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |andre...@dubcolib.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38012] Remove ispermanent from returns.tt and branchtransfers.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38012 --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 172114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172114&action=edit Bug 38012: Remove ispermanent from retuns.tt and branchtransfers.tt No real test plan, exactly. These lines reference an error message that doesn't exist elsewhere in the code. Apply the patch and confirm checkins still work? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38012] Remove ispermanent from returns.tt and branchtransfers.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38012 Andrew Fuerste-Henry changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38012] Remove ispermanent from returns.tt and branchtransfers.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38012 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #1 from Fridolin Somers --- We find a trace in 16.11.x : https://github.com/Koha-Community/Koha/blob/16.11.x/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt#L591 https://github.com/Koha-Community/Koha/blob/16.11.x/C4/Circulation.pm#L283 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38012] Remove ispermanent from returns.tt and branchtransfers.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38012 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
