[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 David Nind changed: What|Removed |Added CC||da...@davidnind.com Text to go in the||This fixes the Koha ESLint release notes||configuration (used for ||finding JavaScript errors) ||so that it is compatible ||with ESLint v9, changes the ||packages used so that ||ESLint and prettier are ||installed by default, and ||tidies some files that ||require updating after the ||prettier upgrade. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 --- Comment #30 from Katrin Fischer --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 --- Comment #29 from Jonathan Druart --- Good to go, I will adjust 38664 on top of this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 --- Comment #27 from Jonathan Druart --- Created attachment 176635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176635&action=edit Bug 38149: Add ESLint & prettier to package.json And upgrade eslint-plugin-prettier Signed-off-by: Paul Derscheid Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 --- Comment #28 from Jonathan Druart --- Created attachment 176636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176636&action=edit Bug 38149: Adjust tidy of some vue and js files after prettier upgrade Fix xt/js_tidy.t and xt/vue_tidy.t Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Jonathan Druart changed: What|Removed |Added Attachment #176193|0 |1 is obsolete|| Attachment #176194|0 |1 is obsolete|| Attachment #176587|0 |1 is obsolete|| --- Comment #26 from Jonathan Druart --- Created attachment 176634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176634&action=edit Bug 38149: Make ESLint config compatible with version 9 Test plan 1. Apply patch 2. Start KTD (to check that stuff is installed automatically) 3. Run this: ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 4. You should see errors from prettier in addition to others QA notes: 1. Run this: yarn why eslint; yarn why prettier; yarn why eslint-config-prettier; yarn why eslint-plugin-prettier 2. See that the version are the latest from NPM website 3. See that they are in devDependencies Signed-off-by: Paul Derscheid Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 --- Comment #25 from Jonathan Druart --- Created attachment 176587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176587&action=edit Bug 38149: Adjust tidy of some vue and js files after prettier upgrade Fix xt/js_tidy.t and xt/vue_tidy.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 --- Comment #24 from Jonathan Druart --- Note: We are here upgrading prettier from 2.7.1 to 3.4.2. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 --- Comment #23 from Jonathan Druart --- Maybe this should wait for bug 38664, I am doing the upgrade of prettier with the needed fixes already. As well as moving the prettier config to .prettierrc.js Maybe join the force there? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #22 from Katrin Fischer --- It looks like this (or 38167) make the tidy tests fail. I need help to resolve this, so holding back on push. Test Summary Report --- xt/js_tidy.t (Wstat: 256 (exited 1) Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 xt/vue_tidy.t (Wstat: 256 (exited 1) Tests: 2 Failed: 1) Failed test: 1 Non-zero exit status: 1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #175425|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize (ashimema) --- Created attachment 176194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176194&action=edit Bug 38149: Add ESLint & prettier to package.json And upgrade eslint-plugin-prettier Signed-off-by: Paul Derscheid Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #175424|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize (ashimema) --- Created attachment 176193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176193&action=edit Bug 38149: Make ESLint config compatible with version 9 Test plan 1. Apply patch 2. Start KTD (to check that stuff is installed automatically) 3. Run this: ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 4. You should see errors from prettier in addition to others QA notes: 1. Run this: yarn why eslint; yarn why prettier; yarn why eslint-config-prettier; yarn why eslint-plugin-prettier 2. See that the version are the latest from NPM website 3. See that they are in devDependencies Signed-off-by: Paul Derscheid Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #175426|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 --- Comment #19 from Victor Grousset/tuxayo --- Updated prettier from 3.3.3 to 3.4.2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #174854|0 |1 is obsolete|| --- Comment #18 from Victor Grousset/tuxayo --- Created attachment 175426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175426&action=edit Bug 38149: [DO NOT PUSH] yarn.lock changes Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #174853|0 |1 is obsolete|| --- Comment #17 from Victor Grousset/tuxayo --- Created attachment 175425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175425&action=edit Bug 38149: Add ESLint & prettier to package.json And upgrade eslint-plugin-prettier Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #174852|0 |1 is obsolete|| --- Comment #16 from Victor Grousset/tuxayo --- Created attachment 175424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175424&action=edit Bug 38149: Make ESLint config compatible with version 9 Test plan 1. Apply patch 2. Start KTD (to check that stuff is installed automatically) 3. Run this: ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 4. You should see errors from prettier in addition to others QA notes: 1. Run this: yarn why eslint; yarn why prettier; yarn why eslint-config-prettier; yarn why eslint-plugin-prettier 2. See that the version are the latest from NPM website 3. See that they are in devDependencies Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #174428|0 |1 is obsolete|| --- Comment #14 from Victor Grousset/tuxayo --- Created attachment 174854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174854&action=edit Bug 38149: [DO NOT PUSH] yarn.lock changes Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 --- Comment #15 from Victor Grousset/tuxayo --- Rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #174427|0 |1 is obsolete|| --- Comment #13 from Victor Grousset/tuxayo --- Created attachment 174853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174853&action=edit Bug 38149: Add ESLint & prettier to package.json And upgrade eslint-plugin-prettier Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #174426|0 |1 is obsolete|| --- Comment #12 from Victor Grousset/tuxayo --- Created attachment 174852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174852&action=edit Bug 38149: Make ESLint config compatible with version 9 Test plan 1. Apply patch 2. Start KTD (to check that stuff is installed automatically) 3. Run this: ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 4. You should see errors from prettier in addition to others QA notes: 1. Run this: yarn why eslint; yarn why prettier; yarn why eslint-config-prettier; yarn why eslint-plugin-prettier 2. See that the version are the latest from NPM website 3. See that they are in devDependencies Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Victor Grousset/tuxayo changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |vic...@tuxayo.net |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Paul Derscheid changed: What|Removed |Added Attachment #173012|0 |1 is obsolete|| --- Comment #11 from Paul Derscheid --- Created attachment 174428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174428&action=edit Bug 38149: [DO NOT PUSH] yarn.lock changes Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Paul Derscheid changed: What|Removed |Added Attachment #173010|0 |1 is obsolete|| --- Comment #9 from Paul Derscheid --- Created attachment 174426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174426&action=edit Bug 38149: Make ESLint config compatible with version 9 Test plan 1. Apply patch 2. Start KTD (to check that stuff is installed automatically) 3. Run this: ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 4. You should see errors from prettier in addition to others QA notes: 1. Run this: yarn why eslint; yarn why prettier; yarn why eslint-config-prettier; yarn why eslint-plugin-prettier 2. See that the version are the latest from NPM website 3. See that they are in devDependencies Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Paul Derscheid changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||paul.dersch...@lmscloud.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Paul Derscheid changed: What|Removed |Added Attachment #173011|0 |1 is obsolete|| --- Comment #10 from Paul Derscheid --- Created attachment 174427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174427&action=edit Bug 38149: Add ESLint & prettier to package.json And upgrade eslint-plugin-prettier Signed-off-by: Paul Derscheid -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 --- Comment #7 from Victor Grousset/tuxayo --- Created attachment 173012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173012&action=edit Bug 38149: [DO NOT PUSH] yarn.lock changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #172683|0 |1 is obsolete|| --- Comment #6 from Victor Grousset/tuxayo --- Created attachment 173011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173011&action=edit Bug 38149: Add ESLint & prettier to package.json And upgrade eslint-plugin-prettier -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 --- Comment #8 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #4) > yarn.lock changes should be in a separate patch. Indeed, thanks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #172682|0 |1 is obsolete|| --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 173010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173010&action=edit Bug 38149: Make ESLint config compatible with version 9 Test plan 1. Apply patch 2. Start KTD (to check that stuff is installed automatically) 3. Run this: ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 4. You should see errors from prettier in addition to others QA notes: 1. Run this: yarn why eslint; yarn why prettier; yarn why eslint-config-prettier; yarn why eslint-plugin-prettier 2. See that the version are the latest from NPM website 3. See that they are in devDependencies -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@gmail.com --- Comment #4 from Jonathan Druart --- yarn.lock changes should be in a separate patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Victor Grousset/tuxayo changed: What|Removed |Added Blocks||38167 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38167 [Bug 38167] ESLint: migrate config to flat format + cleanup some node dependencies -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 Victor Grousset/tuxayo changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 --- Comment #3 from Victor Grousset/tuxayo --- This is the 2nd time I'm really messing with node stuff so I don't know what I'm doing.🙃 Don't trust anything you see! The process was throwing things at the wall and see what stuck. 🫠I don't know if there aren't too much changes in lock files. I did `yarn add prettier eslint --dev` And `yarn upgrade eslint-plugin-prettier` (I think) so package.json still has the old version but the lock has the latest so it's fine. But I don't know if package.json should still be manually updated. Some things I did to double check stuff: Before applying the test plan, deleting the node_modules directory. To avoid keep manually installed stuff and wrongly thinking things worked. .eslintrc.json +], +"prettier/prettier": [ +"error" Sabotaged one and then the other of these lines and see that it errors to confirm it's not dead config. "extends": [ "eslint:recommended", -"prettier" +"eslint-config-prettier" +], +"plugins": [ +"eslint-plugin-prettier" Same here. --- Next steps after this: 1. Migrate to the flat config file to avoid having that ugly ESLINT_USE_FLAT_CONFIG='false' 2. Add the necessary stuff to be able to use ESLint on .vue and .ts files. 3. Open a ticket in QA tools (try to implement, at least partially) about having the same check with ESLint as we have with perltidy. (comparing number of messy line before and after the patches) 4. 5. PROFIT!!! (Finally JS8 will be fully and easily checkable! :D) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 --- Comment #2 from Victor Grousset/tuxayo --- Created attachment 172683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172683&action=edit Bug 38149: Add ESLint & prettier to package.json And upgrade eslint-plugin-prettier -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38149] Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38149 --- Comment #1 from Victor Grousset/tuxayo --- Created attachment 172682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172682&action=edit Bug 38149: Make ESLint config compatible with version 9 Test plan 1. Apply patch 2. Start KTD (to check that stuff is installed automatically) 3. Run this: ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js 4. You should see errors from prettier in addition to others QA notes: 1. Run this: yarn why eslint; yarn why prettier; yarn why eslint-config-prettier; yarn why eslint-plugin-prettier 2. See that the version are the latest from NPM website 3. See that they are in devDependencies -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/