[Koha-bugs] [Bug 38262] Add additional fields to vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 --- Comment #67 from Jonathan Druart --- Last 2 patches pushed to main. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 --- Comment #66 from Jonathan Druart --- Created attachment 195614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195614&action=edit Bug 38262: (follow-up 2) Fix cypress tests 16:40:49 https://on.cypress.io/uncaught-exception-from-application"; type="TypeError">
[Koha-bugs] [Bug 38262] Add additional fields to vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 --- Comment #65 from Jonathan Druart --- Created attachment 195613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195613&action=edit Bug 38262: Do not fail if at least one additional field exists in DB Patch from commit 5563685 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Jonathan Druart changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #64 from Jonathan Druart --- (In reply to Jonathan Druart from comment #62) > Created attachment 192998 [details] [review] > Bug 38262: Fix VueFramework_spec.ts > > Fix the following error: > Error: The following error originated from your application code, not from > Cypress. It was caused by an unhandled promise rejection. > > > JS Warning detected: "[Vue warn]: Unhandled error during execution of > watcher callback" "\n" " at https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Pushed to main |Needs documenting --- Comment #63 from Martin Renvoize (ashimema) --- This bug won't be backported to the 25.11.x branch as it has been deemed an enhancement or new feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 --- Comment #62 from Jonathan Druart --- Created attachment 192998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192998&action=edit Bug 38262: Fix VueFramework_spec.ts Fix the following error: Error: The following error originated from your application code, not from Cypress. It was caused by an unhandled promise rejection. > JS Warning detected: "[Vue warn]: Unhandled error during execution of watcher callback" "\n" " at https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Lucas Gass (lukeg) changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #61 from Lucas Gass (lukeg) --- Thanks for the speedy follow-up Matt! follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 --- Comment #60 from Matt Blenkinsop --- Created attachment 191861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191861&action=edit Bug 38262: (follow-up) Fix cypress tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 --- Comment #59 from Lucas Gass (lukeg) --- There is still 1 cypress test failing due to this patchset, I think: 1) Vendor CRUD operations should edit a vendor: TypeError: The following error originated from your application code, not from Cypress. It was caused by an unhandled promise rejection. > response.filter is not a function When Cypress detects uncaught errors originating from your application it will automatically fail the current test. This behavior is configurable, and you can choose to turn this off by listening to the `uncaught:exception` event. https://on.cypress.io/uncaught-exception-from-application 2) Vendor CRUD operations should delete a vendor: TypeError: The following error originated from your application code, not from Cypress. It was caused by an unhandled promise rejection. > response.filter is not a function When Cypress detects uncaught errors originating from your application it will automatically fail the current test. This behavior is configurable, and you can choose to turn this off by listening to the `uncaught:exception` event. https://on.cypress.io/uncaught-exception-from-application -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 --- Comment #58 from Lucas Gass (lukeg) --- Created attachment 191396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191396&action=edit Bug 38262: (follow-up) Add extended_attributes and _strings when inserting test data -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 --- Comment #57 from Lucas Gass (lukeg) --- some test data seems to now be incorrectly generated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 --- Comment #56 from Lucas Gass (lukeg) --- more to do here. this is also breaking t/cypress/integration/VueFramework_spec.ts: Navigation handling Error: Properties not allowed: extended_attributes. at /kohadevbox/koha/t/cypress/plugins/dist/api-client.cjs.js:303:55 at processTicksAndRejections (node:internal/process/task_queues:95:5) 1) "before each" hook for "Should render a list view" List view features ✓ Should render additional toolbar buttons (4551ms) ✓ Should automatically generate the table columns (4770ms) ✓ Should display the table filters if they are enabled (4202ms) Error: Properties not allowed: extended_attributes. at /kohadevbox/koha/t/cypress/plugins/dist/api-client.cjs.js:303:55 at processTicksAndRejections (node:internal/process/task_queues:95:5) 2) Should allow custom events to be passed to the table action buttons Show view features Error: Properties not allowed: extended_attributes. at /kohadevbox/koha/t/cypress/plugins/dist/api-client.cjs.js:303:55 at processTicksAndRejections (node:internal/process/task_queues:95:5) 3) "before each" hook for "Should allow split screen view" Form features Error: Properties not allowed: extended_attributes. at /kohadevbox/koha/t/cypress/plugins/dist/api-client.cjs.js:303:55 at processTicksAndRejections (node:internal/process/task_queues:95:5) 4) "before each" hook for "Should allow accordion view" 3 passing (19s) 4 failing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Lucas Gass (lukeg) changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 David Nind changed: What|Removed |Added Keywords|release-notes-needed| Text to go in the||This enhancement lets you release notes||add and use additional ||fields for vendors ||(Administration > ||Additional parameters > ||Additional fields > ||Acquisitions > Vendors). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Lucas Gass (lukeg) changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #55 from Lucas Gass (lukeg) --- follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #191370|0 |1 is obsolete|| --- Comment #54 from Lucas Gass (lukeg) --- Created attachment 191372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191372&action=edit Bug 38262: (follow-up) Check for extended attributes before iterating Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 --- Comment #53 from Matt Blenkinsop --- Created attachment 191370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191370&action=edit Bug 38262: (follow-up) Check for extended attributes before iterating -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 --- Comment #52 from Lucas Gass (lukeg) --- prove -v /kohadevbox/koha/t/db_dependent/api/v1/acquisitions_vendors.t Seems like this is causing test to fail on Main now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Lucas Gass (lukeg) changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Katrin Fischer changed: What|Removed |Added Summary|Add additional fields to|Add additional fields to |Vendors |vendors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Lucas Gass (lukeg) changed: What|Removed |Added Keywords|rel_26_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 --- Comment #51 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Lucas Gass (lukeg) changed: What|Removed |Added Version(s)||26.05.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Lucas Gass (lukeg) changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Lucas Gass (lukeg) changed: What|Removed |Added Keywords||rel_26_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Bug 38262 depends on bug 38662, which changed state. Bug 38662 Summary: Additional fields admin page hard to read https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38662 What|Removed |Added Status|Pushed to stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #50 from Martin Renvoize (ashimema) --- Thanks for the follow-up Jonathan, I wasn't aware of bug 38446 Looks good to me and I'm happy with Micheala's testing. Switching back to PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Biblibre Sandboxes changed: What|Removed |Added Attachment #189157|0 |1 is obsolete|| --- Comment #49 from Biblibre Sandboxes --- Created attachment 189169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189169&action=edit Bug 38262: (bug 38446 follow-up) Use a dedicated endpoint Following what has been done on bug 38262 we need a separate endpoint to retrieve additional fields for vendors. We add another proxy for acquisition in acquisition-api-client: we do not want to retrieve all the fields for acquisition as we have more granular permissions than ERM. Signed-off-by: Michaela -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Biblibre Sandboxes changed: What|Removed |Added Attachment #189026|0 |1 is obsolete|| --- Comment #48 from Biblibre Sandboxes --- Created attachment 189168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189168&action=edit Bug 38262: Add additional fields UI support for acquisition vendors Updates staff interface to expose additional fields functionality for vendor records: - Adds "Vendors" (aqbooksellers:vendor) to searchable tables list in additional fields administration page - Configures VendorResource.vue to fetch extended_attributes with proper embeds (+strings for localized values) - Sets extendedAttributesFieldGroup to display fields in "Details" tab - Cleans up _strings computed field during vendor save operations This completes the frontend implementation allowing staff to create, manage, and view custom additional fields on vendor records. Test plan: 1) Go to Administration > Additional fields and add an additional field for Vendors 2) Navigate to 'Acquisitions' and click 'New vendor' 3) Fill out the form, making sure to add something into your new additional field 4) Hit save 5) View and Edit your new Vendor and confirm that the additional field values appear and update as expected Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Michaela -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Biblibre Sandboxes changed: What|Removed |Added Attachment #189025|0 |1 is obsolete|| --- Comment #47 from Biblibre Sandboxes --- Created attachment 189167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189167&action=edit Bug 38262: Enable additional fields support for acquisition vendors Implements backend support for additional fields on vendor records by: - Adding AdditionalFields mixin to Bookseller/Booksellers classes - Defining additional_field_values and extended_attributes relationships in Aqbookseller schema with proper table name filtering - Updating REST API controller to handle extended_attributes during vendor creation and updates - Adding vendor to AdditionalField resource type mapping This provides the ORM-level support needed for vendors to have custom additional fields, matching the existing pattern used for other resource types like agreements, packages, and orders. Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Michaela -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Biblibre Sandboxes changed: What|Removed |Added Attachment #189024|0 |1 is obsolete|| --- Comment #46 from Biblibre Sandboxes --- Created attachment 189166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189166&action=edit Bug 38262: Add extended attributes support to vendors API specification Updates the OpenAPI definitions to support additional fields on vendor records. This adds: - extended_attributes array field to vendor schema definition - _strings field for localized/computed string representations - extended_attributes and +strings to available embed options These changes allow the API to expose and accept additional field data when retrieving or modifying vendor records via the REST API. Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Michaela -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Signed Off Text to go in the|This enhancement enables| release notes|adding additional fields to | |vendors (Koha | |administration > Additional | |parameters > Additional | |fields > Acquisitions > | |Vendors | |(aqbooksellers:vendor)).| --- Comment #45 from Jonathan Druart --- I would like a new QA review for this last patch (follow-up for bug 38446). We also need more tests (I will write some when we agreed on the approach). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 --- Comment #44 from Jonathan Druart --- Created attachment 189157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189157&action=edit Bug 38262: (bug 38446 follow-up) Use a dedicated endpoint Following what has been done on bug 38262 we need a separate endpoint to retrieve additional fields for vendors. We add another proxy for acquisition in acquisition-api-client: we do not want to retrieve all the fields for acquisition as we have more granular permissions than ERM. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Jonathan Druart changed: What|Removed |Added Attachment #188756|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Jonathan Druart changed: What|Removed |Added CC||[email protected] --- Comment #43 from Jonathan Druart --- Resubmitted the patches "Falling back to patching base and 3-way merge..." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 --- Comment #42 from Jonathan Druart --- Created attachment 189026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189026&action=edit Bug 38262: Add additional fields UI support for acquisition vendors Updates staff interface to expose additional fields functionality for vendor records: - Adds "Vendors" (aqbooksellers:vendor) to searchable tables list in additional fields administration page - Configures VendorResource.vue to fetch extended_attributes with proper embeds (+strings for localized values) - Sets extendedAttributesFieldGroup to display fields in "Details" tab - Cleans up _strings computed field during vendor save operations This completes the frontend implementation allowing staff to create, manage, and view custom additional fields on vendor records. Test plan: 1) Go to Administration > Additional fields and add an additional field for Vendors 2) Navigate to 'Acquisitions' and click 'New vendor' 3) Fill out the form, making sure to add something into your new additional field 4) Hit save 5) View and Edit your new Vendor and confirm that the additional field values appear and update as expected Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Jonathan Druart changed: What|Removed |Added Attachment #188755|0 |1 is obsolete|| --- Comment #41 from Jonathan Druart --- Created attachment 189025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189025&action=edit Bug 38262: Enable additional fields support for acquisition vendors Implements backend support for additional fields on vendor records by: - Adding AdditionalFields mixin to Bookseller/Booksellers classes - Defining additional_field_values and extended_attributes relationships in Aqbookseller schema with proper table name filtering - Updating REST API controller to handle extended_attributes during vendor creation and updates - Adding vendor to AdditionalField resource type mapping This provides the ORM-level support needed for vendors to have custom additional fields, matching the existing pattern used for other resource types like agreements, packages, and orders. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Jonathan Druart changed: What|Removed |Added Attachment #188754|0 |1 is obsolete|| --- Comment #40 from Jonathan Druart --- Created attachment 189024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189024&action=edit Bug 38262: Add extended attributes support to vendors API specification Updates the OpenAPI definitions to support additional fields on vendor records. This adds: - extended_attributes array field to vendor schema definition - _strings field for localized/computed string representations - extended_attributes and +strings to available embed options These changes allow the API to expose and accept additional field data when retrieving or modifying vendor records via the REST API. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks||41151 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151 [Bug 41151] Vue Additional Fields UX Improvements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Martin Renvoize (ashimema) changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 --- Comment #39 from Martin Renvoize (ashimema) --- Created attachment 188756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188756&action=edit Bug 38262: Add additional fields UI support for acquisition vendors Updates staff interface to expose additional fields functionality for vendor records: - Adds "Vendors" (aqbooksellers:vendor) to searchable tables list in additional fields administration page - Configures VendorResource.vue to fetch extended_attributes with proper embeds (+strings for localized values) - Sets extendedAttributesFieldGroup to display fields in "Details" tab - Cleans up _strings computed field during vendor save operations This completes the frontend implementation allowing staff to create, manage, and view custom additional fields on vendor records. Test plan: 1) Go to Administration > Additional fields and add an additional field for Vendors 2) Navigate to 'Acquisitions' and click 'New vendor' 3) Fill out the form, making sure to add something into your new additional field 4) Hit save 5) View and Edit your new Vendor and confirm that the additional field values appear and update as expected Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 --- Comment #38 from Martin Renvoize (ashimema) --- Created attachment 188755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188755&action=edit Bug 38262: Enable additional fields support for acquisition vendors Implements backend support for additional fields on vendor records by: - Adding AdditionalFields mixin to Bookseller/Booksellers classes - Defining additional_field_values and extended_attributes relationships in Aqbookseller schema with proper table name filtering - Updating REST API controller to handle extended_attributes during vendor creation and updates - Adding vendor to AdditionalField resource type mapping This provides the ORM-level support needed for vendors to have custom additional fields, matching the existing pattern used for other resource types like agreements, packages, and orders. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #188384|0 |1 is obsolete|| Attachment #188385|0 |1 is obsolete|| Attachment #188386|0 |1 is obsolete|| --- Comment #37 from Martin Renvoize (ashimema) --- Created attachment 188754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188754&action=edit Bug 38262: Add extended attributes support to vendors API specification Updates the OpenAPI definitions to support additional fields on vendor records. This adds: - extended_attributes array field to vendor schema definition - _strings field for localized/computed string representations - extended_attributes and +strings to available embed options These changes allow the API to expose and accept additional field data when retrieving or modifying vendor records via the REST API. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 --- Comment #36 from Martin Renvoize (ashimema) --- I agree with David, whilst the functionality works we have some UX improvements to make/bugs to fix. The 'Clear' and 'New' spacing does look odd and could be improved upon.. I also find that clicking 'New' next to a field clone that field AND it's content to a new field.. I think this should create a new empty repeatable field input instead. I think both of these things should be handled on their own bug however. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 --- Comment #35 from David Nind --- Created attachment 188388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188388&action=edit Screenshots for Bug 38262 – Additional fields for vendors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #34 from David Nind --- Some minor things I noticed during sign off - see screenshots attached separately: 1. When entering repeatable fields for a vendor, there is no spacing between the Clear and + New buttons. 2. In the list of vendors, repeatable fields uses a comma to separate values, instead of listing on separate lines. 3. On the vendor details page, the alignment of the additional field labels and values doesn't look quite right to me. Note for documentation, for repeatable fields it uses the updated select field input form to add multiple values for a field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 David Nind changed: What|Removed |Added Attachment #188377|0 |1 is obsolete|| --- Comment #33 from David Nind --- Created attachment 188386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188386&action=edit Bug 38262: Update UI Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 David Nind changed: What|Removed |Added Attachment #188214|0 |1 is obsolete|| --- Comment #32 from David Nind --- Created attachment 188385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188385&action=edit Bug 38262: Update object classes Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 David Nind changed: What|Removed |Added Attachment #188213|0 |1 is obsolete|| --- Comment #31 from David Nind --- Created attachment 188384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188384&action=edit Bug 38262: Update API specs Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Attachment #188366|0 |1 is obsolete|| --- Comment #30 from Matt Blenkinsop --- Created attachment 188377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188377&action=edit Bug 38262: Update UI Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Attachment #188364|0 |1 is obsolete|| --- Comment #29 from Matt Blenkinsop --- Created attachment 188366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188366&action=edit Bug 38262: Update UI Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Attachment #188215|0 |1 is obsolete|| --- Comment #28 from Matt Blenkinsop --- Created attachment 188364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188364&action=edit Bug 38262: Update UI Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Depends on||41063 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41063 [Bug 41063] Additional fields are broken in Vue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Attachment #183031|0 |1 is obsolete|| --- Comment #27 from Matt Blenkinsop --- Created attachment 188215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188215&action=edit Bug 38262: Update UI Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Attachment #183030|0 |1 is obsolete|| --- Comment #26 from Matt Blenkinsop --- Created attachment 188214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188214&action=edit Bug 38262: Update object classes Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Attachment #183029|0 |1 is obsolete|| --- Comment #25 from Matt Blenkinsop --- Created attachment 188213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188213&action=edit Bug 38262: Update API specs Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Blocks||40192 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40192 [Bug 40192] Add additional fields to ERM titles -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Martin Renvoize (ashimema) changed: What|Removed |Added CC||[email protected] ||o.uk --- Comment #24 from Martin Renvoize (ashimema) --- Can we get a rebase here now that the blocker vue bug is in? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Bug 38262 depends on bug 35287, which changed state. Bug 35287 Summary: Add additional fields support to ERM licenses https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Lucas Gass (lukeg) changed: What|Removed |Added CC||[email protected] Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Katrin Fischer changed: What|Removed |Added CC||[email protected] --- Comment #23 from Katrin Fischer --- *** Bug 28218 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 David Nind changed: What|Removed |Added Attachment #183026|0 |1 is obsolete|| --- Comment #19 from David Nind --- Created attachment 183029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183029&action=edit Bug 38262: Update API specs Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 David Nind changed: What|Removed |Added Attachment #183027|0 |1 is obsolete|| --- Comment #20 from David Nind --- Created attachment 183030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183030&action=edit Bug 38262: Update object classes Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 David Nind changed: What|Removed |Added Attachment #183028|0 |1 is obsolete|| --- Comment #21 from David Nind --- Created attachment 183031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183031&action=edit Bug 38262: Update UI Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 David Nind changed: What|Removed |Added Attachment #182603|0 |1 is obsolete|| --- Comment #17 from David Nind --- Created attachment 183027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183027&action=edit Bug 38262: Update object classes Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 David Nind changed: What|Removed |Added CC||[email protected] Text to go in the||This enhancement enables release notes||adding additional fields to ||vendors (Koha ||administration > Additional ||parameters > Additional ||fields > Acquisitions > ||Vendors ||(aqbooksellers:vendor)). --- Comment #22 from David Nind --- Testing notes (using KTD): 1. Apply the patch 2. Rebuild everything: yarn build 3. Restart everything: restart_all 4. Go to Koha administration > Additional parameters > Additional fields. 5. Under the additional fields for acquisitions, note that there is a new option: Vendors (aqbooksellers:vendor). 6. Add two new fields for vendors: - a text field - a field linked to an authorized value category, for example YES_NO 7. Edit an existing vendor (My Vendor) to add values for the additional fields you created. 8. Note that these are shown in a new section on the vendor details page, "Additional fields". 9. Add a new vendor, and add a value for only one of the additional fields. 10. Note that on the vendor details page, only additional fields that have a value are shown. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 David Nind changed: What|Removed |Added Attachment #182602|0 |1 is obsolete|| --- Comment #16 from David Nind --- Created attachment 183026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183026&action=edit Bug 38262: Update API specs Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 David Nind changed: What|Removed |Added Attachment #182604|0 |1 is obsolete|| --- Comment #18 from David Nind --- Created attachment 183028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183028&action=edit Bug 38262: Update UI Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Attachment #180559|0 |1 is obsolete|| --- Comment #14 from Matt Blenkinsop --- Created attachment 182603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182603&action=edit Bug 38262: Update object classes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Attachment #180560|0 |1 is obsolete|| --- Comment #15 from Matt Blenkinsop --- Created attachment 182604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182604&action=edit Bug 38262: Update UI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Attachment #180558|0 |1 is obsolete|| --- Comment #13 from Matt Blenkinsop --- Created attachment 182602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182602&action=edit Bug 38262: Update API specs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Attachment #175714|0 |1 is obsolete|| --- Comment #11 from Matt Blenkinsop --- Created attachment 180560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180560&action=edit Bug 38262: Update UI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Caroline Cyr La Rose changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #8 from Caroline Cyr La Rose --- Patch doesn't apply Error message says Patch failed at 0001 Bug 38262: Update API specs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 --- Comment #12 from Matt Blenkinsop --- Test plan to follow, updating the bug dependencies first -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Attachment #175713|0 |1 is obsolete|| --- Comment #10 from Matt Blenkinsop --- Created attachment 180559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180559&action=edit Bug 38262: Update object classes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Attachment #175712|0 |1 is obsolete|| --- Comment #9 from Matt Blenkinsop --- Created attachment 180558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180558&action=edit Bug 38262: Update API specs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Mathieu Saby changed: What|Removed |Added CC||[email protected] --- Comment #7 from Mathieu Saby --- Could you add a test plan please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Attachment #175149|0 |1 is obsolete|| --- Comment #6 from Matt Blenkinsop --- Created attachment 175714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175714&action=edit Bug 38262: Update UI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Attachment #175148|0 |1 is obsolete|| --- Comment #5 from Matt Blenkinsop --- Created attachment 175713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175713&action=edit Bug 38262: Update object classes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Attachment #175147|0 |1 is obsolete|| --- Comment #4 from Matt Blenkinsop --- Created attachment 175712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175712&action=edit Bug 38262: Update API specs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Blocks||38290 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38290 [Bug 38290] Add library group limits to vendors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Pedro Amorim changed: What|Removed |Added Blocks|38662 | Depends on||38662 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38662 [Bug 38662] Additional fields admin page hard to read -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Pedro Amorim changed: What|Removed |Added Blocks||38662 Depends on|38662 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38662 [Bug 38662] Additional fields admin page hard to read -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Pedro Amorim changed: What|Removed |Added Depends on||38662 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38662 [Bug 38662] Additional fields admin page hard to read -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 --- Comment #2 from Matt Blenkinsop --- Created attachment 175148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175148&action=edit Bug 38262: Update object classes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 --- Comment #3 from Matt Blenkinsop --- Created attachment 175149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175149&action=edit Bug 38262: Update UI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 --- Comment #1 from Matt Blenkinsop --- Created attachment 175147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175147&action=edit Bug 38262: Update API specs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Depends on||38446 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38446 [Bug 38446] Permission error for additional fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Assignee|[email protected] |matt.blenkinsop@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Depends on||35287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 [Bug 35287] Add additional fields support to ERM licenses -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38262] Add additional fields to Vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 Matt Blenkinsop changed: What|Removed |Added Depends on||38010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 [Bug 38010] Migrate vendors to Vue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
