[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 --- Comment #31 from David Nind --- (In reply to Emily Lamancusa (emlam) from comment #30) > Thanks, David! No developer documentation updates are required either - > these patches don't require any changes to how database updates are coded. Thanks Emily! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 --- Comment #30 from Emily Lamancusa (emlam) --- Thanks, David! No developer documentation updates are required either - these patches don't require any changes to how database updates are coded. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #29 from David Nind --- No updates to the manual required - it is not covered. I'll leave any updates required to the Developer Handbook, to the patch author. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 Lucas Gass (lukeg) changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to main |Needs documenting --- Comment #28 from Lucas Gass (lukeg) --- Merge conflicts with 24.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 --- Comment #27 from Katrin Fischer --- It looks like we caused some bad breakage on Jenkins with this one, because I pushed the "DO NOT PUSH". Will revert. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 --- Comment #26 from Katrin Fischer --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 --- Comment #22 from Jonathan Druart --- Created attachment 174674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174674&action=edit Bug 38299: Use say_failure when printing update errors to the console Bug 35681 added subroutines to print colored output from database updates. Incorporate the subroutine say_failure into the error handling in the upstream code, so that errors caught upstream can take advantage of this new subroutine and display in red. To test: 1. Apply patch for test dbrev 2. From the kshell, run updatedatabase --> The messages for success, info, warning, and failure that were explicitly printed in the dbrev are colored, but the database error is not colored. 3. Apply other patches 4. Run updatedatabase again --> All messages including the database error are now colored Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.dru...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 Katrin Fischer changed: What|Removed |Added Version(s)||24.11.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 --- Comment #25 from Jonathan Druart --- Created attachment 174677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174677&action=edit Bug 38299: (follow-up) (discussion) Move failure into same level Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 --- Comment #24 from Jonathan Druart --- Created attachment 174676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174676&action=edit Bug 38299: (discussion) Move failure into same level This patch adds the failures in at the same level as the rest of the revision output (i.e. indented under the specific database revision) and uses the standard failure coloring instead of the local update_error class. This is a proposal and may need more work to clarify and perhaps remove the duplicated/collected errors at the bottom of the update. Now that we hard stop if an update fails, I'm not sure collecting errors at the bottom makes as much sense as it once did? Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 Jonathan Druart changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 Jonathan Druart changed: What|Removed |Added Attachment #174291|0 |1 is obsolete|| Attachment #174292|0 |1 is obsolete|| Attachment #174293|0 |1 is obsolete|| Attachment #174423|0 |1 is obsolete|| Attachment #174455|0 |1 is obsolete|| --- Comment #21 from Jonathan Druart --- Created attachment 174673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174673&action=edit Bug 38299: Make filehandler optional for colored outputs Allow say_success, say_failure, etc, to omit the filehandler parameter so that they can be used without explicitly opening a filehandler if you are just printing to STDOUT and don't already have one. If a filehandler is passed, the existing behavior is unchanged. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 --- Comment #23 from Jonathan Druart --- Created attachment 174675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174675&action=edit Bug 38299: Update tests To test: prove -v t/Koha/Installer/Output.t Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 --- Comment #20 from Emily Lamancusa (emlam) --- Looks good to me! Thanks for the feedback on this! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 --- Comment #18 from Jonathan Druart --- I think I might have preferred to have the fh as an 'out' option, like we do for 'up', for not blocker. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 --- Comment #19 from Jonathan Druart --- I think I might have preferred to have the fh as an 'out' option, like we do for 'up', but not blocker. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 --- Comment #16 from Jonathan Druart --- Created attachment 174455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174455&action=edit Bug 38299: (follow-up) (discussion) Move failure into same level -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 --- Comment #17 from Jonathan Druart --- (In reply to Martin Renvoize (ashimema) from comment #13) > Created attachment 174423 [details] [review] > Bug 38299: (discussion) Move failure into same level > > This patch adds the failures in at the same level as the rest of the > revision output (i.e. indented under the specific database revision) and > uses the standard failure coloring instead of the local update_error > class. > > This is a proposal and may need more work to clarify and perhaps remove > the duplicated/collected errors at the bottom of the update. Now that we > hard stop if an update fails, I'm not sure collecting errors at the > bottom makes as much sense as it once did? Looks ok to me, Emily can you confirm you agree with this change? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 --- Comment #14 from Martin Renvoize (ashimema) --- Created attachment 174424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174424&action=edit With proper indentation and class -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 --- Comment #15 from Martin Renvoize (ashimema) --- It feels somewhat odd looking to me that we collect some errors separately at the end.. I've added a patch that moves the output up a level into the output block for database revision being run.. I've left the output to stderr in place for now so we're getting both the collected set and the inlined error in the screenshot. Wondering what others think here.. now that we die on error I'm thinking it no longer makes sense to collect such errors separately at the bottom and we could just remove that bit of handling. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 --- Comment #12 from Martin Renvoize (ashimema) --- Created attachment 174421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174421&action=edit Bug 38299: (discussion) Move failure into same level This patch adds the failures in at the same level as the rest of the revision output (i.e. indented under the specific database revision) and uses the standard failure coloring instead of the local update_error class. This is a proposal and may need more work to clarify and perhaps remove the duplicated/collected errors at the bottom of the update. Now that we hard stop if an update fails, I'm not sure collecting errors at the bottom makes as much sense as it once did? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #174421|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize (ashimema) --- Created attachment 174423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174423&action=edit Bug 38299: (discussion) Move failure into same level This patch adds the failures in at the same level as the rest of the revision output (i.e. indented under the specific database revision) and uses the standard failure coloring instead of the local update_error class. This is a proposal and may need more work to clarify and perhaps remove the duplicated/collected errors at the bottom of the update. Now that we hard stop if an update fails, I'm not sure collecting errors at the bottom makes as much sense as it once did? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 David Nind changed: What|Removed |Added Attachment #174259|0 |1 is obsolete|| --- Comment #11 from David Nind --- Created attachment 174293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174293&action=edit Bug 38299: Update tests To test: prove -v t/Koha/Installer/Output.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 David Nind changed: What|Removed |Added Attachment #174256|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 174292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174292&action=edit Bug 38299: Use say_failure when printing update errors to the console Bug 35681 added subroutines to print colored output from database updates. Incorporate the subroutine say_failure into the error handling in the upstream code, so that errors caught upstream can take advantage of this new subroutine and display in red. To test: 1. Apply patch for test dbrev 2. From the kshell, run updatedatabase --> The messages for success, info, warning, and failure that were explicitly printed in the dbrev are colored, but the database error is not colored. 3. Apply other patches 4. Run updatedatabase again --> All messages including the database error are now colored Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 David Nind changed: What|Removed |Added Attachment #174254|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 174290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174290&action=edit Bug 38299: [DO NOT PUSH] Test dbrev Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 David Nind changed: What|Removed |Added Attachment #174255|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 174291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174291&action=edit Bug 38299: Make filehandler optional for colored outputs Allow say_success, say_failure, etc, to omit the filehandler parameter so that they can be used without explicitly opening a filehandler if you are just printing to STDOUT and don't already have one. If a filehandler is passed, the existing behavior is unchanged. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 Emily Lamancusa (emlam) changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 --- Comment #7 from Emily Lamancusa (emlam) --- Created attachment 174259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174259&action=edit Bug 38299: Update tests To test: prove -v t/Koha/Installer/Output.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 --- Comment #2 from Emily Lamancusa (emlam) --- Created attachment 174251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174251&action=edit Bug 38299: Make filehandler optional for colored outputs Allow say_success, say_failure, etc, to omit the filehandler parameter so that they can be used without explicitly opening a filehandler if you are just printing to STDOUT and don't already have one. If a filehandler is passed, the existing behavior is unchanged. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 Emily Lamancusa (emlam) changed: What|Removed |Added Status|ASSIGNED|Needs Signoff See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35681 | Depends on||35681 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35681 [Bug 35681] Add support for colored messages in the output of updatedatabase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 --- Comment #1 from Emily Lamancusa (emlam) --- Created attachment 174250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174250&action=edit Bug 38299: [DO NOT PUSH] Test dbrev -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 --- Comment #3 from Emily Lamancusa (emlam) --- Created attachment 174252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174252&action=edit Bug 38299: Use say_failure when printing update errors to the console Bug 35681 added subroutines to print colored output from database updates. Incorporate the subroutine say_failure into the error handling in the upstream code, so that errors caught upstream can take advantage of this new subroutine and display in red. To test: 1. Apply patch for test dbrev 2. From the kshell, run updatedatabase --> The messages for success, info, warning, and failure that were explicitly printed in the dbrev are colored, but the database error is not colored. 3. Apply other patches 4. Run updatedatabase again --> All messages including the database error are now colored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 Emily Lamancusa (emlam) changed: What|Removed |Added Attachment #174252|0 |1 is obsolete|| --- Comment #6 from Emily Lamancusa (emlam) --- Created attachment 174256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174256&action=edit Bug 38299: Use say_failure when printing update errors to the console Bug 35681 added subroutines to print colored output from database updates. Incorporate the subroutine say_failure into the error handling in the upstream code, so that errors caught upstream can take advantage of this new subroutine and display in red. To test: 1. Apply patch for test dbrev 2. From the kshell, run updatedatabase --> The messages for success, info, warning, and failure that were explicitly printed in the dbrev are colored, but the database error is not colored. 3. Apply other patches 4. Run updatedatabase again --> All messages including the database error are now colored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 Emily Lamancusa (emlam) changed: What|Removed |Added Attachment #174251|0 |1 is obsolete|| --- Comment #5 from Emily Lamancusa (emlam) --- Created attachment 174255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174255&action=edit Bug 38299: Make filehandler optional for colored outputs Allow say_success, say_failure, etc, to omit the filehandler parameter so that they can be used without explicitly opening a filehandler if you are just printing to STDOUT and don't already have one. If a filehandler is passed, the existing behavior is unchanged. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 Emily Lamancusa (emlam) changed: What|Removed |Added Attachment #174250|0 |1 is obsolete|| --- Comment #4 from Emily Lamancusa (emlam) --- Created attachment 174254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174254&action=edit Bug 38299: [DO NOT PUSH] Test dbrev -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=38385 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 Martin Renvoize (ashimema) changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=37895 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 Emily Lamancusa (emlam) changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 Emily Lamancusa (emlam) changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=35681 CC||emily.lamancusa@montgomeryc ||ountymd.gov -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 Emily Lamancusa (emlam) changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |emily.lamancusa@montgomeryc |ity.org |ountymd.gov -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38299] Errors with updates caught in C4::Installer should be colored/highlighted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38299 Martin Renvoize (ashimema) changed: What|Removed |Added Depends on||25078 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 [Bug 25078] Update DB process - wrap each DBRev inside a transaction and better error handling -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
