[Koha-bugs] [Bug 38303] Item's replacement price not set to defaultreplacecost if 0.00

2024-12-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38303

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Status|Pushed to main  |Pushed to stable
 Version(s)|24.11.00|24.11.00,24.05.06
released in||
 CC||lu...@bywatersolutions.com

--- Comment #9 from Lucas Gass (lukeg)  ---
Backported to 24.05.x for upcoming 24.05.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38303] Item's replacement price not set to defaultreplacecost if 0.00

2024-12-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38303

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Status|Pushed to stable|Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38303] Item's replacement price not set to defaultreplacecost if 0.00

2024-11-01 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38303

Katrin Fischer  changed:

   What|Removed |Added

   Keywords|RM_priority |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38303] Item's replacement price not set to defaultreplacecost if 0.00

2024-10-31 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38303

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=37943

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38303] Item's replacement price not set to defaultreplacecost if 0.00

2024-10-31 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38303

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||24.11.00
released in||
 Status|Passed QA   |Pushed to main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38303] Item's replacement price not set to defaultreplacecost if 0.00

2024-10-31 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38303

--- Comment #8 from Katrin Fischer  ---
Pushed for 24.11!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38303] Item's replacement price not set to defaultreplacecost if 0.00

2024-10-31 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38303

--- Comment #7 from Jonathan Druart  ---
(In reply to Tomás Cohen Arazi (tcohen) from comment #5)
> (In reply to Jonathan Druart from comment #4)
> > Yes, because of the discard_changes call.
> 
> Isn't this highlighting something else?

Maybe, but I didn't find anything bad. It highlighted this problem at least.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38303] Item's replacement price not set to defaultreplacecost if 0.00

2024-10-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38303

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz
 QA Contact|testo...@bugs.koha-communit |alei...@catalyst.net.nz
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38303] Item's replacement price not set to defaultreplacecost if 0.00

2024-10-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38303

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #173730|0   |1
is obsolete||

--- Comment #6 from Aleisha Amohia  ---
Created attachment 173746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173746&action=edit
Bug 38303: Set item's replacement price to defaultreplacecost if 0.00

No idea if this is a real bug. This code is fixing the following test
failure:
t/db_dependent/Circulation/CalcFine.t .. 1/7
#   Failed test 'Amount is calculated correctly'
#   at t/db_dependent/Circulation/CalcFine.t line 271.
#  got: '0'
# expected: '6'
# Looks like you failed 1 test of 2.

Signed-off-by: David Nind 
Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38303] Item's replacement price not set to defaultreplacecost if 0.00

2024-10-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38303

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38303] Item's replacement price not set to defaultreplacecost if 0.00

2024-10-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38303

--- Comment #5 from Tomás Cohen Arazi (tcohen)  ---
(In reply to Jonathan Druart from comment #4)
> Yes, because of the discard_changes call.

Isn't this highlighting something else?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38303] Item's replacement price not set to defaultreplacecost if 0.00

2024-10-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38303

--- Comment #4 from Jonathan Druart  ---
Yes, because of the discard_changes call.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38303] Item's replacement price not set to defaultreplacecost if 0.00

2024-10-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38303

Tomás Cohen Arazi (tcohen)  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #3 from Tomás Cohen Arazi (tcohen)  ---
Not sure how, but bisecting pointed to bug 37943.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38303] Item's replacement price not set to defaultreplacecost if 0.00

2024-10-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38303

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38303] Item's replacement price not set to defaultreplacecost if 0.00

2024-10-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38303

David Nind  changed:

   What|Removed |Added

 Attachment #173722|0   |1
is obsolete||

--- Comment #2 from David Nind  ---
Created attachment 173730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173730&action=edit
Bug 38303: Set item's replacement price to defaultreplacecost if 0.00

No idea if this is a real bug. This code is fixing the following test
failure:
t/db_dependent/Circulation/CalcFine.t .. 1/7
#   Failed test 'Amount is calculated correctly'
#   at t/db_dependent/Circulation/CalcFine.t line 271.
#  got: '0'
# expected: '6'
# Looks like you failed 1 test of 2.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38303] Item's replacement price not set to defaultreplacecost if 0.00

2024-10-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38303

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||RM_priority

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38303] Item's replacement price not set to defaultreplacecost if 0.00

2024-10-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38303

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38303] Item's replacement price not set to defaultreplacecost if 0.00

2024-10-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38303

--- Comment #1 from Jonathan Druart  ---
Created attachment 173722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173722&action=edit
Bug 38303: Set item's replacement price to defaultreplacecost if 0.00

No idea if this is a real bug. This code is fixing the following test
failure:
t/db_dependent/Circulation/CalcFine.t .. 1/7
#   Failed test 'Amount is calculated correctly'
#   at t/db_dependent/Circulation/CalcFine.t line 271.
#  got: '0'
# expected: '6'
# Looks like you failed 1 test of 2.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/