[Koha-bugs] [Bug 38309] Cannot delete additional fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38309 David Nind changed: What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #9 from David Nind --- This s a bug fix and no changes to the user interface, so no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38309] Cannot delete additional fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38309 Fridolin Somers changed: What|Removed |Added Status|Pushed to oldstable |Needs documenting CC||fridolin.som...@biblibre.co ||m --- Comment #8 from Fridolin Somers --- Not for 23.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38309] Cannot delete additional fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38309 Lucas Gass (lukeg) changed: What|Removed |Added Version(s)|24.11.00|24.11.00,24.05.06 released in|| Status|Pushed to main |Pushed to stable --- Comment #7 from Lucas Gass (lukeg) --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38309] Cannot delete additional fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38309 Lucas Gass (lukeg) changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38309] Cannot delete additional fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38309 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=38378 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38309] Cannot delete additional fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38309 --- Comment #6 from Katrin Fischer --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38309] Cannot delete additional fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38309 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||24.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38309] Cannot delete additional fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38309 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #173858|0 |1 is obsolete|| --- Comment #5 from Lucas Gass (lukeg) --- Created attachment 173885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173885&action=edit Bug 38309: Cannot delete additional fields Deleting an additional field tries to do a GET of ?op=delete... which no longer works with CSRF protection. It needs to be a POST with op=cud-delete. Test plan: 1. Administration - Additional fields, click any table name 2. New field, fill in a name and Save 3. In the row for your field, click Delete 4. You have a blank page 5. Apply patch, click the browser Back button, refresh the page 6. In the row for your undeleted field, click Delete 7. Your field is deleted Sponsored-by: Chetco Community Public Library Signed-off-by: David Nind Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38309] Cannot delete additional fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38309 Lucas Gass (lukeg) changed: What|Removed |Added Patch complexity|--- |Trivial patch QA Contact|testo...@bugs.koha-communit |lu...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38309] Cannot delete additional fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38309 Lucas Gass (lukeg) changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38309] Cannot delete additional fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38309 Lucas Gass (lukeg) changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #4 from Lucas Gass (lukeg) --- Good to see use of js/form-submit.js here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38309] Cannot delete additional fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38309 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38309] Cannot delete additional fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38309 David Nind changed: What|Removed |Added Attachment #173851|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 173858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173858&action=edit Bug 38309: Cannot delete additional fields Deleting an additional field tries to do a GET of ?op=delete... which no longer works with CSRF protection. It needs to be a POST with op=cud-delete. Test plan: 1. Administration - Additional fields, click any table name 2. New field, fill in a name and Save 3. In the row for your field, click Delete 4. You have a blank page 5. Apply patch, click the browser Back button, refresh the page 6. In the row for your undeleted field, click Delete 7. Your field is deleted Sponsored-by: Chetco Community Public Library Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38309] Cannot delete additional fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38309 David Nind changed: What|Removed |Added Depends on||36192 Text to go in the||This fixes deleting release notes||additional fields ||(Administration - ||Additional parameters > ||Additional fields) - ||deleting fields now works ||as expected. Previously, ||attempting to delete a ||field would generate a ||blank page and the field ||was not deleted. (This is ||related to the CSRF changes ||added in Koha 24.05 to ||improve form security.) CC||da...@davidnind.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38309] Cannot delete additional fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38309 --- Comment #2 from Phil Ringnalda --- Created attachment 173851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173851&action=edit Bug 38309: Cannot delete additional fields Deleting an additional field tries to do a GET of ?op=delete... which no longer works with CSRF protection. It needs to be a POST with op=cud-delete. Test plan: 1. Administration - Additional fields, click any table name 2. New field, fill in a name and Save 3. In the row for your field, click Delete 4. You have a blank page 5. Apply patch, click the browser Back button, refresh the page 6. In the row for your undeleted field, click Delete 7. Your field is deleted Sponsored-by: Chetco Community Public Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38309] Cannot delete additional fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38309 Phil Ringnalda changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |p...@chetcolibrary.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38309] Cannot delete additional fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38309 Phil Ringnalda changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38309] Cannot delete additional fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38309 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org --- Comment #1 from Phil Ringnalda --- Neat, we still have '.pl?op=delete' after all this time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/