[Koha-bugs] [Bug 38329] Remove orphan confirm_deletion() in supplier.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Fridolin Somers changed: What|Removed |Added Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in|| CC||fridolin.som...@biblibre.co ||m Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #6 from Fridolin Somers --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38329] Remove orphan confirm_deletion() in supplier.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Lucas Gass (lukeg) changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38329] Remove orphan confirm_deletion() in supplier.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Lucas Gass (lukeg) changed: What|Removed |Added Version(s)|24.11.00|24.11.00,24.05.06 released in|| Status|Pushed to main |Pushed to stable --- Comment #5 from Lucas Gass (lukeg) --- BAckported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38329] Remove orphan confirm_deletion() in supplier.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 --- Comment #4 from Katrin Fischer --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38329] Remove orphan confirm_deletion() in supplier.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Katrin Fischer changed: What|Removed |Added Version(s)||24.11.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38329] Remove orphan confirm_deletion() in supplier.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #173948|0 |1 is obsolete|| --- Comment #3 from Lucas Gass (lukeg) --- Created attachment 174044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174044&action=edit Bug 38329: Remove orphan confirm_deletion() in supplier.tt The JavaScript function confirm_deletion() in supplier.tt has either been an unused orphan since bug 28082 two years ago, or since the switch from YUI to Bootstrap 12 years ago. Doesn't matter which, nothing calls it, and if it was called, it would fail by trying to GET with op="delete" rather than POST with op="cud-delete". Test plan: 1. Acquisitions - New vendor, enter a name and Save 2. Click the name of your new vendor, so your URL is at supplier.pl 3. Click Delete vendor to verify that deleting still works without this unused code which would fail Sponsored-by: Chetco Community Public Library Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38329] Remove orphan confirm_deletion() in supplier.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Lucas Gass (lukeg) changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38329] Remove orphan confirm_deletion() in supplier.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Lucas Gass (lukeg) changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |lu...@bywatersolutions.com |y.org | CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38329] Remove orphan confirm_deletion() in supplier.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38329] Remove orphan confirm_deletion() in supplier.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Owen Leonard changed: What|Removed |Added Attachment #173890|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 173948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173948&action=edit Bug 38329: Remove orphan confirm_deletion() in supplier.tt The JavaScript function confirm_deletion() in supplier.tt has either been an unused orphan since bug 28082 two years ago, or since the switch from YUI to Bootstrap 12 years ago. Doesn't matter which, nothing calls it, and if it was called, it would fail by trying to GET with op="delete" rather than POST with op="cud-delete". Test plan: 1. Acquisitions - New vendor, enter a name and Save 2. Click the name of your new vendor, so your URL is at supplier.pl 3. Click Delete vendor to verify that deleting still works without this unused code which would fail Sponsored-by: Chetco Community Public Library Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38329] Remove orphan confirm_deletion() in supplier.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Phil Ringnalda changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38329] Remove orphan confirm_deletion() in supplier.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 --- Comment #1 from Phil Ringnalda --- Created attachment 173890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173890&action=edit Bug 38329: Remove orphan confirm_deletion() in supplier.tt The JavaScript function confirm_deletion() in supplier.tt has either been an unused orphan since bug 28082 two years ago, or since the switch from YUI to Bootstrap 12 years ago. Doesn't matter which, nothing calls it, and if it was called, it would fail by trying to GET with op="delete" rather than POST with op="cud-delete". Test plan: 1. Acquisitions - New vendor, enter a name and Save 2. Click the name of your new vendor, so your URL is at supplier.pl 3. Click Delete vendor to verify that deleting still works without this unused code which would fail Sponsored-by: Chetco Community Public Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
