[Koha-bugs] [Bug 38373] Mandatory patron relationship has to be selected twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 --- Comment #9 from David Nind --- Created attachment 182779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182779&action=edit Bug 38373: Check if mandatory relationship is needed for non-patron guarantor This patch makes the non-guarantor relationship field mandatory only if a guarantor surname or first name is entered. Currently, if the relationship field is mandatory, you need to select a value even if there is no guarantor surname or first name. Test plan: 1) Add relationship as mandatory field 2) Add a child patron 3) See that the non-patron guarantor relationship is mandatory (note that it is mandtaory, even if there is no guarantor surname or first name) 4) Apply the patch 5) Add a child patron 6) See that the non-patron guarantor relationship is not mandatory 7) Fill surname or first name for the non-patron guarantor 8) See that the non-patron guarantor relationship turns mandatory Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38373] Mandatory patron relationship has to be selected twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38373] Mandatory patron relationship has to be selected twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Johanna Räisä changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #8 from Johanna Räisä --- (In reply to Lin Wei from comment #7) > # Results before Applying Patch > > - Added "Relationship" to "BorrowerMandatoryField" in "Koha administration." > - When trying to Add patron (kid), Non-patron guarantor > Relationship is > "Required." > > # Results after Applying Patch > > - When trying to Add patron (kid), Non-patron guarantor > Relationship > remains "Required." I tested this again with current main and to me it seems to be working as in test plan. The relationship field on non-patron guarantor should change to required when you fill surname or first name for non-patron guarantor, steps 7 and 8. You probably need to load the page with ctrl+f5, so the browser cache resets. Can you test again, please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38373] Mandatory patron relationship has to be selected twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Martin Renvoize (ashimema) changed: What|Removed |Added Severity|enhancement |normal CC||[email protected] ||o.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38373] Mandatory patron relationship has to be selected twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Lin Wei changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||[email protected] --- Comment #7 from Lin Wei --- # Results before Applying Patch - Added "Relationship" to "BorrowerMandatoryField" in "Koha administration." - When trying to Add patron (kid), Non-patron guarantor > Relationship is "Required." # Results after Applying Patch - When trying to Add patron (kid), Non-patron guarantor > Relationship remains "Required." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38373] Mandatory patron relationship has to be selected twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38373] Mandatory patron relationship has to be selected twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Johanna Räisä changed: What|Removed |Added Attachment #174118|0 |1 is obsolete|| --- Comment #6 from Johanna Räisä --- Created attachment 181000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181000&action=edit Bug 38373: check if mandatory relationship is needed for non-patron guarantor This patch checks if non-patron guarantor is added to the patron and changes the relationship to mandatory if needed. Test plan: 1) Add relationship as mandatory field 2) Add a child patron 3) See that the non-patron guarantor relationship is mandatory 4) Apply the patch 5) Add a child patron 6) See that the non-patron guarantor relationship is not mandatory 7) Fill surname or first name for the non-patron guarantor 8) See that the non-patron guarantor relationship turns mandatory Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38373] Mandatory patron relationship has to be selected twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Jesse Maseto changed: What|Removed |Added CC||[email protected] Status|Needs Signoff |Failed QA --- Comment #5 from Jesse Maseto --- Patch does not apply. Merge conflicts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38373] Mandatory patron relationship has to be selected twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38373] Mandatory patron relationship has to be selected twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Johanna Räisä changed: What|Removed |Added Attachment #174102|0 |1 is obsolete|| --- Comment #4 from Johanna Räisä --- Created attachment 174118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174118&action=edit Bug 38373: check if mandatory relationship is needed for non-patron guarantor This patch checks if non-patron guarantor is added to the patron and changes the relationship to mandatory if needed. Test plan: 1) Add relationship as mandatory field 2) Add a child patron 3) See that the non-patron guarantor relationship is mandatory 4) Apply the patch 5) Add a child patron 6) See that the non-patron guarantor relationship is not mandatory 7) Fill surname or first name for the non-patron guarantor 8) See that the non-patron guarantor relationship turns mandatory Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38373] Mandatory patron relationship has to be selected twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Johanna Räisä changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38373] Mandatory patron relationship has to be selected twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Johanna Räisä changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #3 from Johanna Räisä --- (In reply to Jonathan Druart from comment #2) > Why not applying the same trigger for #contactfirstname? > > I'd say if at least one of them (#contactname or #contactfirstname) is not > empty then the relationship must be required. Yes, should be check that also. I fill fix that and add a patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38373] Mandatory patron relationship has to be selected twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 --- Comment #2 from Jonathan Druart --- Why not applying the same trigger for #contactfirstname? I'd say if at least one of them (#contactname or #contactfirstname) is not empty then the relationship must be required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38373] Mandatory patron relationship has to be selected twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Johanna Räisä changed: What|Removed |Added Change sponsored?|--- |Sponsored Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38373] Mandatory patron relationship has to be selected twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 --- Comment #1 from Johanna Räisä --- Created attachment 174102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174102&action=edit Bug 38373: check if mandatory relationship is needed for non-patron guarantor This patch checks if non-patron guarantor is added to the patron and changes the relationship to mandatory if needed. Test plan: 1) Add relationship as mandatory field 2) Add a child patron 3) See that the non-patron guarantor relationship is mandatory 4) Apply the patch 5) Add a child patron 6) See that the non-patron guarantor relationship is not mandatory 7) Fill a surname for the non-patron guarantor 8) See that the non-patron guarantor relationship turns mandatory Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38373] Mandatory patron relationship has to be selected twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Johanna Räisä changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38373] Mandatory patron relationship has to be selected twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Johanna Räisä changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38373] Mandatory patron relationship has to be selected twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Jonathan Druart changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
