[Koha-bugs] [Bug 38407] Eliminate event handler attributes in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 --- Comment #5 from David Cook --- Like bug 34709 I think this is actually an umbrella/omnibus bug report, since trying to replace all the inline event handlers at once probably isn't realistic. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38407] Eliminate event handler attributes in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 --- Comment #4 from David Cook --- Technically, this is just a best practice in general and even a Koha coding guidelines requirement. Even without Content-Security-Policy. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38407] Eliminate event handler attributes in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 David Cook changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38407] Eliminate event handler attributes in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 --- Comment #3 from David Cook --- On bug 38365, Jonathan has pointed out a few places to check in the cataloguing editor like cloning subfields and using the Tag Editor for fields with linked authorities like 100$a -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38407] Eliminate event handler attributes in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=38365 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38407] Eliminate event handler attributes in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 David Cook changed: What|Removed |Added Status|NEW |CONFIRMED --- Comment #2 from David Cook --- It wouldn't hurt to have a test in the QA scripts to make sure that inline event handler attributes aren't being added, if we don't have one already. Note that we can quote the coding guidelines when we do specific reports for this one: https://wiki.koha-community.org/wiki/Coding_Guidelines#JS9:_Avoid_the_use_of_event_attributes_like_.22onclick.22_to_attach_events -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38407] Eliminate event handler attributes in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 David Cook changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38364 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38407] Eliminate event handler attributes in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=38364 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38407] Eliminate event handler attributes in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34709 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38407] Eliminate event handler attributes in the staff interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 --- Comment #1 from David Cook --- egrep -R " on[a-zA-Z]+=" --exclude-dir="greybox" koha-tmpl/intranet-tmpl/ | wc -l The above shows that there are currently 181 instances of inline event handler attributes in the staff interface templates (Note: There may be other places where inline event handler attributes are added to generated code throughout Koha other than in templates, but I think that Koha/FrameworkPlugin.pm already looks fixed, so those places might be few or non-existent.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
