[Koha-bugs] [Bug 38422] Add data-isbn and data-title to lists for plugin cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38422 David Nind changed: What|Removed |Added Text to go in the|This enhancement displays |This enhancement adds cover release notes|cover images on OPAC lists, |images to OPAC lists, for |for OPAC enabled cover |OPAC enabled cover image |image sources. |sources. | | |(Note: This |(Note: This |currently only displays |currently only displays |nicely with one source of |nicely with one source of |cover images. With multiple |cover images. With multiple |sources enabled, the images |sources enabled, the images |are listed vertically.) |are listed vertically.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38422] Add data-isbn and data-title to lists for plugin cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38422 David Nind changed: What|Removed |Added Text to go in the||This enhancement displays release notes||cover images on OPAC lists, ||for OPAC enabled cover ||image sources. || ||(Note: This ||currently only displays ||nicely with one source of ||cover images. With multiple ||sources enabled, the images ||are listed vertically.) CC||da...@davidnind.com --- Comment #5 from David Nind --- Checking to see if this is an enhancement, rather than a bug. Should I add a bug for displaying multiple images nicely, like we do in other areas of the OPAC and staff interface, instead of running vertically down the page? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38422] Add data-isbn and data-title to lists for plugin cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38422 --- Comment #4 from Katrin Fischer --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38422] Add data-isbn and data-title to lists for plugin cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38422 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38422] Add data-isbn and data-title to lists for plugin cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38422 Martin Renvoize (ashimema) changed: What|Removed |Added Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38422] Add data-isbn and data-title to lists for plugin cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38422 Martin Renvoize (ashimema) changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38422] Add data-isbn and data-title to lists for plugin cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38422 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38422] Add data-isbn and data-title to lists for plugin cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38422 Martin Renvoize (ashimema) changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize (ashimema) --- Trivial, non-invasive, addition of plugin support hook in the OPAC. Going straight for a PQA here.. we're using it in production already in 23.11.x and beyond. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38422] Add data-isbn and data-title to lists for plugin cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38422 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #174401|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize (ashimema) --- Created attachment 175412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175412&action=edit Bug 38422: Allow plugin cover images in OPAC lists This patch updates the template to allow cover images from plugins in the OPAC list page. It adds a data-isbn and data-title attribute to the cover images element and also moves the element below the setting of the title so that we can pass that directly. It also adds the script call to allow the plugin method to work on the page Test plan: 1) View the patch diff and note that the data attributes have been added correctly 2) View the patch diff and note that the tag has been moved below the setting of the img_title template variable 3) View the patch diff and note that the CoverImagePlugins variable has been set correctly (compare to the intranet file detail.tt for reference if needed) 4) Confirm that no changes have been made to any elements beyond adding the data attributes Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38422] Add data-isbn and data-title to lists for plugin cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38422 Matt Blenkinsop changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38422] Add data-isbn and data-title to lists for plugin cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38422 --- Comment #1 from Matt Blenkinsop --- Created attachment 174401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174401&action=edit Bug 38422: Allow plugin cover images in OPAC lists This patch updates the template to allow cover images from plugins in the OPAC list page. It adds a data-isbn and data-title attribute to the cover images element and also moves the element below the setting of the title so that we can pass that directly. It also adds the script call to allow the plugin method to work on the page Test plan: 1) View the patch diff and note that the data attributes have been added correctly 2) View the patch diff and note that the tag has been moved below the setting of the img_title template variable 3) View the patch diff and note that the CoverImagePlugins variable has been set correctly (compare to the intranet file detail.tt for reference if needed) 4) Confirm that no changes have been made to any elements beyond adding the data attributes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38422] Add data-isbn and data-title to lists for plugin cover images
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38422 Matt Blenkinsop changed: What|Removed |Added Assignee|oleon...@myacpl.org |matt.blenkinsop@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
