[Koha-bugs] [Bug 38448] Fix inconsistencies in database update messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38448 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38448] Fix inconsistencies in database update messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38448 --- Comment #8 from Katrin Fischer --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38448] Fix inconsistencies in database update messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38448 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl Keywords|rel_24_11_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38448] Fix inconsistencies in database update messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38448 Marcel de Rooy changed: What|Removed |Added Attachment #176165|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy --- Created attachment 176317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176317&action=edit Bug 38448: Fix inconsistencies in database update messages This fixes some database update messages to improve their consistency with the database update guidelines https://wiki.koha-community.org/wiki/Database_updates Test plan: 1. Apply the patch. 2. Review the differences to make sure the messages make sense and are consistent with the database update guidelines: 2.1 Review the diff attached to the bug or 2.2 Run: git show 3. Sign off D: Signed-off-by: David Nind Signed-off-by: Leo Stoyanov Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38448] Fix inconsistencies in database update messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38448 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38448] Fix inconsistencies in database update messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38448 --- Comment #6 from David Nind --- Thanks Leo for the sign off! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38448] Fix inconsistencies in database update messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38448 Leo Stoyanov changed: What|Removed |Added CC||leo.stoyanov@bywatersolutio ||ns.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38448] Fix inconsistencies in database update messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38448 Leo Stoyanov changed: What|Removed |Added Attachment #175580|0 |1 is obsolete|| --- Comment #5 from Leo Stoyanov --- Created attachment 176165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176165&action=edit Bug 38448: Fix inconsistencies in database update messages This fixes some database update messages to improve their consistency with the database update guidelines https://wiki.koha-community.org/wiki/Database_updates Test plan: 1. Apply the patch. 2. Review the differences to make sure the messages make sense and are consistent with the database update guidelines: 2.1 Review the diff attached to the bug or 2.2 Run: git show 3. Sign off D: Signed-off-by: David Nind Signed-off-by: Leo Stoyanov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38448] Fix inconsistencies in database update messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38448 David Nind changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |da...@davidnind.com |ity.org | Text to go in the||This fixes some database release notes||update messages to improve ||their consistency with the ||database update guidelines. Patch complexity|--- |Trivial patch --- Comment #4 from David Nind --- Here is a list of the changes and the reason: 1. Consistency with other messages and improve wording: From: "list_borrowers added to $count users with XXX" To: "Added permission 'list_borrowers' to $count users with 'XXX' permissions" 2. Changed the type of message from info (blue) to success (green): From: say_info( $out, "Added column 'service_platformerm_usage_data_providers'" ); To:say_success( $out, "Added column 'service_platformerm_usage_data_providers'" ); 3. Changed the type of message from plain (white) to success (green): From: say $out "Added new system preference 'JobsNotificationMethod'"; To:say_success( $out, "Added new system preference 'JobsNotificationMethod'" ); 4. Consistency with other messages: From: "Added BOOKING_CANCELLATION authorised value category" To: "Added new authorized value category 'BOOKING_CANCELLATION'" 5. Removed 'noisy' message that is not required: say_success( $out, "Updated manage_search_targets permission description" ); 6. Consistency with other messages: From: "Added OAI-PMH:HarvestEmailReport system preference To: "Added new system preference 'OAI-PMH:HarvestEmailReport'" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38448] Fix inconsistencies in database update messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38448 David Nind changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38448] Fix inconsistencies in database update messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38448 --- Comment #3 from David Nind --- Created attachment 175580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175580&action=edit Bug 38448: Fix inconsistencies in database update messages This fixes some database update messages to improve their consistency with the database update guidelines https://wiki.koha-community.org/wiki/Database_updates Test plan: 1. Apply the patch. 2. Review the differences to make sure the messages make sense and are consistent with the database update guidelines: 2.1 Review the diff attached to the bug or 2.2 Run: git show 3. Sign off D: Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38448] Fix inconsistencies in database update messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38448 Bug 38448 depends on bug 38394, which changed state. Bug 38394 Summary: Remove try/catch and say_failures for 24.11 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38394 What|Removed |Added Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38448] Fix inconsistencies in database update messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38448 --- Comment #2 from Katrin Fischer --- (In reply to David Nind from comment #1) > I'm happy to have a go at this, if it is just a matter of updating the > individual db_revs. Hi David, yes, the mission would be to make the output messages more standardized. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38448] Fix inconsistencies in database update messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38448 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #1 from David Nind --- I'm happy to have a go at this, if it is just a matter of updating the individual db_revs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38448] Fix inconsistencies in database update messages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38448 Jonathan Druart changed: What|Removed |Added Keywords||rel_24_11_candidate CC||jonathan.dru...@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
