[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 Kathleen L. changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 Jesse Maseto changed: What|Removed |Added CC||[email protected] --- Comment #22 from Jesse Maseto --- Merge conflicts with 24.05.x Please resolve if needed in this version. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 --- Comment #21 from Paul Derscheid --- Nice work everyone! Pushed to 25.05.x for 25.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable --- Comment #20 from Fridolin Somers --- Pushed to 24.11.x for 24.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 Fridolin Somers changed: What|Removed |Added CC||[email protected] ||m Version(s)|25.11.00|25.11.00,25.05.01,24.11.06 released in|| Status|Pushed to main |Pushed to stable --- Comment #19 from Fridolin Somers --- I see in 25.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 Lucas Gass (lukeg) changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 --- Comment #18 from Lucas Gass (lukeg) --- follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 David Nind changed: What|Removed |Added Attachment #182916|0 |1 is obsolete|| --- Comment #17 from David Nind --- Created attachment 182937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182937&action=edit Bug 38477: (follow-up) Correct failing Item.t test prove /kohadevbox/koha/t/db_dependent/Koha/Item.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 --- Comment #16 from Lucas Gass (lukeg) --- Can someone please look at/sign-off my follow up before I push to main? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 Lucas Gass (lukeg) changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 --- Comment #15 from Lucas Gass (lukeg) --- Created attachment 182916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182916&action=edit Bug 38477: (follow-up) Correct failing Item.t test prove /kohadevbox/koha/t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 --- Comment #14 from Lucas Gass (lukeg) --- This seems to be causing 't/db_dependent/Koha/Item.t' tests to fail. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 Lucas Gass (lukeg) changed: What|Removed |Added Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 Lucas Gass (lukeg) changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 --- Comment #13 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 Pedro Amorim changed: What|Removed |Added Attachment #182745|0 |1 is obsolete|| --- Comment #12 from Pedro Amorim --- Created attachment 182828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182828&action=edit Bug 38477: Only charge a new lost fine when the last patron to return the item matches the original fined patron Set these sysprefs: - FinesMode: Calculate and Charge - WhenLostForgiveFine: Forgive - WhenLostChargeReplacementFee: Charge In circ rules: - Have a rule that charges fines - Set Refund lost item replacement fee to "Refund lost item charge and charge new overdue fine" 1 - Have/create item with replacement price 2 - Check item out to patron 1, due date in past 3 - Run fines.pl 4 - confirm fines on patron 1 5 - mark item lost 6 - confirm replacement cost generated and fine forgiven on patron 1 7 - check item in 8 - confirm replacement cost forgiven and new fine generated on patron 1 9 - check item out to patron 2, due date in future 10 - check item in 11 - mark item lost (no replacement fee generated because item is not checked out) 12 - in database, update date_due for checkout to patron 2, set to a date in the past 13 - check item in 14 - confirm patron 2 now has a fine 15 - Apply patches, restart all 16 - Repeat test plan with another item and confirm no fine is added for patron 2 Note: At step 12 we're pushing the date_due of the old issue into the past to make date_due Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 Pedro Amorim changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 Pedro Amorim changed: What|Removed |Added Attachment #182726|0 |1 is obsolete|| --- Comment #11 from Pedro Amorim --- Created attachment 182827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182827&action=edit Bug 38477: Unit test Signed-off-by: Pedro Amorim -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 David Nind changed: What|Removed |Added Text to go in the|Under certain |Under certain release notes|circumstances, the |circumstances, the |existence of a lost charge |existence of a lost charge |for a patron who previously |for a patron that |borrowed an item (which was |previously borrowed an item |later found) could lead to |(which was later found) |creating a new fine for a |could lead to creating a |patron who borrowed and |new fine for a patron that |returned the item with no |borrowed and returned the |issues - if the item was|item with no issues - if |lost and found again after |the item was lost and found |they had returned it. |again after they had | |returned it. |This| |bug adds tests to cover |This adds |this edge case, and fixes |tests to cover this edge |this edge case to ensure|case, and fixes this edge |that a new fine is only |case to ensure that a new |charged if the patron |fine is only charged if the |charged the lost fine |patron charged the lost |matches the patron who most |fine matches the patron who |recently returned the item. |most recently returned the ||item. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 Pedro Amorim changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org |k CC||[email protected] ||k -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 Nick Clemens (kidclamp) changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 David Nind changed: What|Removed |Added Text to go in the|Under certain circumstances |Under certain release notes|the existence a lost fine |circumstances, the |for a patron who previously |existence of a lost charge |borrowed and item which was |for a patron who previously |later found could lead to |borrowed an item (which was |creating a new fine for a |later found) could lead to |patron who borrowed and |creating a new fine for a |returned the item with no |patron who borrowed and |issues if the item was lost |returned the item with no |and found again after they |issues - if the item was |had returned it. |lost and found again after |These |they had returned it. |patches add tests to cover | |this edge case and to |This |ensure that a new fine is |bug adds tests to cover |only charged if the patron |this edge case, and fixes |charged lost fine matches |this edge case to ensure |the patron who most |that a new fine is only |recently returned the item. |charged if the patron ||charged the lost fine ||matches the patron who most ||recently returned the item. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 Lisette Scheer changed: What|Removed |Added CC||[email protected] ||m Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 Nick Clemens (kidclamp) changed: What|Removed |Added Text to go in the||Under certain circumstances release notes||the existence a lost fine ||for a patron who previously ||borrowed and item which was ||later found could lead to ||creating a new fine for a ||patron who borrowed and ||returned the item with no ||issues if the item was lost ||and found again after they ||had returned it. ||These ||patches add tests to cover ||this edge case and to ||ensure that a new fine is ||only charged if the patron ||charged lost fine matches ||the patron who most ||recently returned the item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 David Nind changed: What|Removed |Added Keywords||release-notes-needed --- Comment #10 from David Nind --- Thanks Andrew! Testing notes (using KTD): 1. Rule that charges fines: - Edit the All All rule - Fine amount: 1.00 - Fine charging interval: 5 2. Scroll down to the heading "Default lost item fee refund on return policy" and change: - "Refund lost item charge" to "Refund lost item charge and charge new overdue fine" 3. I used Programming Perl (item 311418): - Set 952$v - Cost, replacement price to 50.00 - First check out to Mary Burton - set due date to 1 May 2025 - Second check out to Lisa Charles - set due date to 4. Running the fines cronjob: misc/cronjobs/fines.pl -v Output: Fines assessment -- 2025-05-22T21:47:57 Number of Overdue Items: counted 1 reported 1 updated 1 5. SQL (using the above patron and item number): - UPDATE old_issues SET old_issues.date_due='2025-01-01 12:00:00' WHERE old_issues.borrowernumber=37 AND old_issues.itemnumber=578; 6. After the patch: - I used CGI programming with Perl (item 300498), set 952$v - Cost, replacement price to 25.00 - SQL = UPDATE old_issues SET old_issues.date_due='2025-01-01 12:00:00' WHERE old_issues.borrowernumber=37 AND old_issues.itemnumber=32; 7. Run the tests, these should pass: prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 David Nind changed: What|Removed |Added Attachment #182727|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 182745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182745&action=edit Bug 38477: Only charge a new lost fine when the last patron to return the item matches the original fined patron Set these sysprefs: - FinesMode: Calculate and Charge - WhenLostForgiveFine: Forgive - WhenLostChargeReplacementFee: Charge In circ rules: - Have a rule that charges fines - Set Refund lost item replacement fee to "Refund lost item charge and charge new overdue fine" 1 - Have/create item with replacement price 2 - Check item out to patron 1, due date in past 3 - Run fines.pl 4 - confirm fines on patron 1 5 - mark item lost 6 - confirm replacement cost generated and fine forgiven on patron 1 7 - check item in 8 - confirm replacement cost forgiven and new fine generated on patron 1 9 - check item out to patron 2, due date in future 10 - check item in 11 - mark item lost (no replacement fee generated because item is not checked out) 12 - in database, update date_due for checkout to patron 2, set to a date in the past 13 - check item in 14 - confirm patron 2 now has a fine 15 - Apply patches, restart all 16 - Repeat test plan with another item and confirm no fine is added for patron 2 Note: At step 12 we're pushing the date_due of the old issue into the past to make date_due -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 --- Comment #8 from Andrew Fuerste-Henry --- (In reply to Andrew Fuerste-Henry from comment #7) > (In reply to David Nind from comment #6) > > SQL for step 12? > > > > Sorry, I'm not familiar enough with the database structure to work out what > > table this data is in. > > UPDATE issues SET issues.date_due='2025-01-01 12:00:00' WHERE > issues.borrowernumber=[your patron] AND issues.itemnumber=[your item]; Oh, wait, sorry, I believe you want to change "issues" to "old_issues" in that. I didn't think about where this checkout was at that point in the test plan. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 --- Comment #7 from Andrew Fuerste-Henry --- (In reply to David Nind from comment #6) > SQL for step 12? > > Sorry, I'm not familiar enough with the database structure to work out what > table this data is in. UPDATE issues SET issues.date_due='2025-01-01 12:00:00' WHERE issues.borrowernumber=[your patron] AND issues.itemnumber=[your item]; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 David Nind changed: What|Removed |Added CC||[email protected] --- Comment #6 from David Nind --- SQL for step 12? Sorry, I'm not familiar enough with the database structure to work out what table this data is in. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #182701|0 |1 is obsolete|| --- Comment #4 from Nick Clemens (kidclamp) --- Created attachment 182726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182726&action=edit Bug 38477: Unit test -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 --- Comment #5 from Nick Clemens (kidclamp) --- Created attachment 182727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182727&action=edit Bug 38477: Only charge a new lost fine when the last patron to return the item matches the original fined patron Set these sysprefs: - FinesMode: Calculate and Charge - WhenLostForgiveFine: Forgive - WhenLostChargeReplacementFee: Charge In circ rules: - Have a rule that charges fines - Set Refund lost item replacement fee to "Refund lost item charge and charge new overdue fine" 1 - Have/create item with replacement price 2 - Check item out to patron 1, due date in past 3 - Run fines.pl 4 - confirm fines on patron 1 5 - mark item lost 6 - confirm replacement cost generated and fine forgiven on patron 1 7 - check item in 8 - confirm replacement cost forgiven and new fine generated on patron 1 9 - check item out to patron 2, due date in future 10 - check item in 11 - mark item lost (no replacement fee generated because item is not checked out) 12 - in database, update date_due for checkout to patron 2, set to a date in the past 13 - check item in 14 - confirm patron 2 now has a fine 15 - Apply patches, restart all 16 - Repeat test plan with another item and confirm no fine is added for patron 2 Note: At step 12 we're pushing the date_due of the old issue into the past to make date_duehttps://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 Nick Clemens (kidclamp) changed: What|Removed |Added Status|CONFIRMED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 --- Comment #3 from Nick Clemens (kidclamp) --- Created attachment 182701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182701&action=edit Bug 38477: UNit test -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 Lucas Gass (lukeg) changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 David Cook changed: What|Removed |Added CC||[email protected] Status|NEW |CONFIRMED --- Comment #2 from David Cook --- Marking as CONFIRMED on behalf of Nick -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 Nick Clemens (kidclamp) changed: What|Removed |Added CC||[email protected] --- Comment #1 from Nick Clemens (kidclamp) --- AddReturn does some stuff, eventually calls Item->store In Koha::Item->store we call _set_found_trigger _set_found_trigger adds a 'lost_charge' message to the item if we have found a previous lost or overdue lost accountline and the rule is set to charge a new fine This gets passed back to AddReturn which looks for the last issue of the item, and charges a new fine from the previous due_date until today I believe what we need to do is: 1 - Verify the lost charge found in _set_found_trigger is the same patron we are charging now 2 - Verify the issue was not returned since the issue Current thoughts: Store the borrowernumber in the item_lost entry in statistics when marking an item lost - then we can verify that current lost is attributed to patron Pass the patroid from the lost fine found in _set_found_trigger back to AddReturn and verify the patron is the same as the one with the issue -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund lost item charge and charge new overdue fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 Katrin Fischer changed: What|Removed |Added Summary|Regression: new overdue |Regression: new overdue |fine applied incorrectly|fine applied incorrectly |when using "Refund Lost |when using "Refund lost |Item Charge and Charge New |item charge and charge new |Overdue Fine" option in |overdue fine" option in |circ rules |circ rules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund Lost Item Charge and Charge New Overdue Fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 Katrin Fischer changed: What|Removed |Added Keywords||RM_priority -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38477] Regression: new overdue fine applied incorrectly when using "Refund Lost Item Charge and Charge New Overdue Fine" option in circ rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38477 Andrew Fuerste-Henry changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
