[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2025-04-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

Jesse Maseto  changed:

   What|Removed |Added

 Status|Pushed to oldoldstable  |RESOLVED
 Resolution|--- |FIXED
 CC||je...@bywatersolutions.com

--- Comment #20 from Jesse Maseto  ---
Patch doesn't apply to 22.11.x. Many merge conflicts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2025-03-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|25.05.00,24.11.02,24.05.08  |25.05.00,24.11.02,24.05.08,
released in||23.11.13
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to oldstable |Pushed to oldoldstable

--- Comment #19 from Fridolin Somers  ---
Pushed to 23.11.x for 23.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2025-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

Alex Buckley  changed:

   What|Removed |Added

 Version(s)|25.05.00,24.11.02   |25.05.00,24.11.02,24.05.08
released in||
 Status|Pushed to stable|Pushed to oldstable

--- Comment #18 from Alex Buckley  ---
Nice work everyone!

Pushed to 24.05.x for 24.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2025-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

--- Comment #17 from Alex Buckley  ---
(In reply to Kyle M Hall (khall) from comment #16)
> > Could you please attach a 24.05.x rebase for the second patch to this bug
> > report?
> 
> Here you go!

Thank you very much!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2025-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

--- Comment #16 from Kyle M Hall (khall)  ---
> Could you please attach a 24.05.x rebase for the second patch to this bug
> report?

Here you go!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2025-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

--- Comment #15 from Kyle M Hall (khall)  ---
Created attachment 179515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179515&action=edit
Bug 38486: [24.05.x] For SIP allow noblock checkouts reguardless of normal
patron checkout blocks

The purpose of no block checkouts in SIP is to indicate that the SIP machine
has made an offline ( "store and forward" ) transaction.
The patron already has the item. As such, the item must be checked out to the
patron or the library risks losing the item do to lack of tracking.
As such, no block checkouts should not be blocked under any circumstances.

The sub C4::SIP::ILS::Transaction::Checkout::do_checkout already honors this,
but it is wrapped by
C4::SIP::ILS::checkout which has additional checks that do not.

Test Plan:
1) Apply the unit test patch
2) prove t/db_dependent/SIP/Transaction.t will fail
3) Apply the second patch
4) prove t/db_dependent/SIP/Transaction.t will pass!

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2025-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

--- Comment #14 from Kyle M Hall (khall)  ---
Created attachment 179514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179514&action=edit
Bug 38486: [24.05.x] Fix unit tests

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2025-03-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz

--- Comment #13 from Alex Buckley  ---
Hi Kyle,

We are testing this patchset for 24.05.x backport.

When we cherry-pick the first patch from 24.11.x onto 24.05.x it applies
cleanly. But the second patch conflicts, see below:

---

kohadev-koha@kohadevbox:koha(24.05.x)$ git cherry-pick
34df58a5b98f8f36e8820666834a76a0bf7167d2
Auto-merging C4/SIP/ILS.pm
CONFLICT (content): Merge conflict in C4/SIP/ILS.pm
error: could not apply 34df58a5b98... Bug 38486: For SIP allow noblock
checkouts reguardless of normal patron checkout blocks
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
kohadev-koha@kohadevbox:koha(24.05.x|CHERRY-PICKING)$ git status
On branch 24.05.x
You are currently cherry-picking commit 34df58a5b98.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add ..." to mark resolution)
both modified:   C4/SIP/ILS.pm

no changes added to commit (use "git add" and/or "git commit -a")
(failed reverse-i-search)`sed': re^Ct_all
kohadev-koha@kohadevbox:koha(24.05.x|CHERRY-PICKING)$

---

Could you please attach a 24.05.x rebase for the second patch to this bug
report?

Thanks in advance,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2025-02-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

Paul Derscheid  changed:

   What|Removed |Added

 CC||paul.dersch...@lmscloud.de
   Keywords|rel_24_11_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2025-02-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

--- Comment #12 from Paul Derscheid  ---
Nice work everyone!

Pushed to 24.11.x for 24.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2025-02-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

Paul Derscheid  changed:

   What|Removed |Added

 Version(s)|25.05.00|25.05.00,24.11.02
released in||
 Status|Pushed to main  |Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2025-01-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com
   Keywords||rel_24_11_candidate

--- Comment #11 from Lucas Gass (lukeg)  ---
Can this be backported to 24.11?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2024-12-23 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

--- Comment #10 from Katrin Fischer  ---
Pushed for 25.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2024-12-23 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||25.05.00
released in||
 Status|Passed QA   |Pushed to main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2024-12-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|This fixes SIP so that it   |This fixes SIP so that it
  release notes|allows noblock checkouts,   |allows noblock checkouts,
   |regardless of normal patron |regardless of normal patron
   |checkout blocks.
   |checkout blocks.
   ||
   |Explanation: The purpose of |Explanation: The purpose of
   |no block checkouts in SIP   |no block checkouts in SIP
   |is to indicate that the SIP |is to indicate that the SIP
   |machine has made an offline |machine has made an offline
   |("store and forward")   |("store and forward")
   |transaction. The patron |transaction. The patron
   |already has the item. As|already has the item. As
   |such, the item must be  |such, the item must be
   |checked out to the patron   |checked out to the patron
   |or the library risks losing |or the library risks losing
   |the item do to lack of  |the item due to lack of
   |tracking. As such, no block |tracking. As such, no block
   |checkouts should not be |checkouts should not be
   |blocked under any   |blocked under any
   |circumstances.  |circumstances.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2024-12-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #9 from Martin Renvoize (ashimema) 
 ---
No regressions found.. sip is always fun :S 

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2024-12-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #175277|0   |1
is obsolete||

--- Comment #8 from Martin Renvoize (ashimema) 
 ---
Created attachment 175313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175313&action=edit
Bug 38486: For SIP allow noblock checkouts reguardless of normal patron
checkout blocks

The purpose of no block checkouts in SIP is to indicate that the SIP machine
has made an offline ( "store and forward" ) transaction.
The patron already has the item. As such, the item must be checked out to the
patron or the library risks losing the item do to lack of tracking.
As such, no block checkouts should not be blocked under any circumstances.

The sub C4::SIP::ILS::Transaction::Checkout::do_checkout already honors this,
but it is wrapped by
C4::SIP::ILS::checkout which has additional checks that do not.

Test Plan:
1) Apply the unit test patch
2) prove t/db_dependent/SIP/Transaction.t will fail
3) Apply the second patch
4) prove t/db_dependent/SIP/Transaction.t will pass!

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2024-12-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Attachment #175276|0   |1
is obsolete||

--- Comment #7 from Martin Renvoize (ashimema) 
 ---
Created attachment 175312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175312&action=edit
Bug 38486: Fix unit tests

Signed-off-by: David Nind 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2024-12-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

David Nind  changed:

   What|Removed |Added

  Text to go in the||This fixes SIP so that it
  release notes||allows noblock checkouts,
   ||regardless of normal patron
   ||checkout blocks.
   ||
   ||Explanation: The purpose of
   ||no block checkouts in SIP
   ||is to indicate that the SIP
   ||machine has made an offline
   ||("store and forward")
   ||transaction. The patron
   ||already has the item. As
   ||such, the item must be
   ||checked out to the patron
   ||or the library risks losing
   ||the item do to lack of
   ||tracking. As such, no block
   ||checkouts should not be
   ||blocked under any
   ||circumstances.
 CC||da...@davidnind.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2024-12-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

David Nind  changed:

   What|Removed |Added

 Attachment #175264|0   |1
is obsolete||

--- Comment #6 from David Nind  ---
Created attachment 175277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175277&action=edit
Bug 38486: For SIP allow noblock checkouts reguardless of normal patron
checkout blocks

The purpose of no block checkouts in SIP is to indicate that the SIP machine
has made an offline ( "store and forward" ) transaction.
The patron already has the item. As such, the item must be checked out to the
patron or the library risks losing the item do to lack of tracking.
As such, no block checkouts should not be blocked under any circumstances.

The sub C4::SIP::ILS::Transaction::Checkout::do_checkout already honors this,
but it is wrapped by
C4::SIP::ILS::checkout which has additional checks that do not.

Test Plan:
1) Apply the unit test patch
2) prove t/db_dependent/SIP/Transaction.t will fail
3) Apply the second patch
4) prove t/db_dependent/SIP/Transaction.t will pass!

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2024-12-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

David Nind  changed:

   What|Removed |Added

 Attachment #175263|0   |1
is obsolete||

--- Comment #5 from David Nind  ---
Created attachment 175276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175276&action=edit
Bug 38486: Fix unit tests

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2024-12-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2024-12-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

Kyle M Hall (khall)  changed:

   What|Removed |Added

 Attachment #174795|0   |1
is obsolete||
 Attachment #174796|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall (khall)  ---
Created attachment 175263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175263&action=edit
Bug 38486: Fix unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2024-12-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

--- Comment #4 from Kyle M Hall (khall)  ---
Created attachment 175264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175264&action=edit
Bug 38486: For SIP allow noblock checkouts reguardless of normal patron
checkout blocks

The purpose of no block checkouts in SIP is to indicate that the SIP machine
has made an offline ( "store and forward" ) transaction.
The patron already has the item. As such, the item must be checked out to the
patron or the library risks losing the item do to lack of tracking.
As such, no block checkouts should not be blocked under any circumstances.

The sub C4::SIP::ILS::Transaction::Checkout::do_checkout already honors this,
but it is wrapped by
C4::SIP::ILS::checkout which has additional checks that do not.

Test Plan:
1) Apply the unit test patch
2) prove t/db_dependent/SIP/Transaction.t will fail
3) Apply the second patch
4) prove t/db_dependent/SIP/Transaction.t will pass!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2024-11-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

--- Comment #2 from Kyle M Hall (khall)  ---
Created attachment 174796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174796&action=edit
Bug 38486: For SIP allow noblock checkouts reguardless of normal patron
checkout blocks

The purpose of no block checkouts in SIP is to indicate that the SIP machine
has made an offline ( "store and forward" ) transaction.
The patron already has the item. As such, the item must be checked out to the
patron or the library risks losing the item do to lack of tracking.
As such, no block checkouts should not be blocked under any circumstances.

The sub C4::SIP::ILS::Transaction::Checkout::do_checkout already honors this,
but it is wrapped by
C4::SIP::ILS::checkout which has additional checks that do not.

Test Plan:
1) Apply the unit test patch
2) prove t/db_dependent/SIP/Transaction.t will fail
3) Apply the second patch
4) prove t/db_dependent/SIP/Transaction.t will pass!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2024-11-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

Kyle M Hall (khall)  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2024-11-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

--- Comment #1 from Kyle M Hall (khall)  ---
Created attachment 174795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174795&action=edit
Bug 38486: Fix unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38486] No block checkouts are still blocked by fines, checkouts, and blocked item types

2024-11-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38486

Kyle M Hall (khall)  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/