[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Aude Charillon changed: What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #16 from Aude Charillon --- No need for any updates to the Koha Manual. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Wainui Witika-Park changed: What|Removed |Added Status|Pushed to oldstable |Needs documenting --- Comment #15 from Wainui Witika-Park --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Fridolin Somers changed: What|Removed |Added CC||[email protected] ||m Version(s)|25.11.00,25.05.04 |25.11.00,25.05.04,24.11.10 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #14 from Fridolin Somers --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 --- Comment #13 from Paul Derscheid --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Paul Derscheid changed: What|Removed |Added Version(s)|25.11.00|25.11.00,25.05.04 released in|| Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Lucas Gass (lukeg) changed: What|Removed |Added Version(s)||25.11.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 --- Comment #12 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Marcel de Rooy changed: What|Removed |Added Version|23.11 |Main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 --- Comment #11 from Marcel de Rooy --- This addresses the problem. Probably the whole Calendar needs more attention though. Handling colliding/clashing holidays in the interface is still awkward. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Marcel de Rooy changed: What|Removed |Added Attachment #186447|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 186612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186612&action=edit Bug 38633: Prevent holidays from being ignored If weekly repeatable holidays are set, Koha ignores these days when other holidays are set using the Holidays repeated yearly on a range option. To test: 1) Navigate to Tools > Calendar 2) Click on a weekend date on the calendar to open the Add New Holiday option 3) Give your holiday a title and select Holiday repeated every same day of the week 4) Click on the calendar again and set a holiday from 20 December 2021 to 06 January 2022 5) Give your holiday a title 6) Select Holidays repeated yearly on a range and click save 7) Using the calendar, navigate forwards to December 2024 and note that there are days that should be highlighted in the holdiay period that are not highlighted 8) Apply Patch 9) Run the reset_all command 10) Repeat the steps above 11) Notice that now when you click forwards through the calendar, all of the dates for your holidays repeated yearly on a range are still selected Signed-off-by: Marion Durand Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 --- Comment #9 from Marcel de Rooy --- Looking here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Marion Durand changed: What|Removed |Added Attachment #186435|0 |1 is obsolete|| --- Comment #8 from Marion Durand --- Created attachment 186447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186447&action=edit Bug 38633: Prevent holidays from being ignored If weekly repeatable holidays are set, Koha ignores these days when other holidays are set using the Holidays repeated yearly on a range option. To test: 1) Navigate to Tools > Calendar 2) Click on a weekend date on the calendar to open the Add New Holiday option 3) Give your holiday a title and select Holiday repeated every same day of the week 4) Click on the calendar again and set a holiday from 20 December 2021 to 06 January 2022 5) Give your holiday a title 6) Select Holidays repeated yearly on a range and click save 7) Using the calendar, navigate forwards to December 2024 and note that there are days that should be highlighted in the holdiay period that are not highlighted 8) Apply Patch 9) Run the reset_all command 10) Repeat the steps above 11) Notice that now when you click forwards through the calendar, all of the dates for your holidays repeated yearly on a range are still selected Signed-off-by: Marion Durand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Marion Durand changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Alexander Blanchard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Alexander Blanchard changed: What|Removed |Added Attachment #186432|0 |1 is obsolete|| --- Comment #7 from Alexander Blanchard --- Created attachment 186435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186435&action=edit Bug 38633: Prevent holidays from being ignored If weekly repeatable holidays are set, Koha ignores these days when other holidays are set using the Holidays repeated yearly on a range option. To test: 1) Navigate to Tools > Calendar 2) Click on a weekend date on the calendar to open the Add New Holiday option 3) Give your holiday a title and select Holiday repeated every same day of the week 4) Click on the calendar again and set a holiday from 20 December 2021 to 06 January 2022 5) Give your holiday a title 6) Select Holidays repeated yearly on a range and click save 7) Using the calendar, navigate forwards to December 2024 and note that there are days that should be highlighted in the holdiay period that are not highlighted 8) Apply Patch 9) Run the reset_all command 10) Repeat the steps above 11) Notice that now when you click forwards through the calendar, all of the dates for your holidays repeated yearly on a range are still selected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Alexander Blanchard changed: What|Removed |Added Attachment #180728|0 |1 is obsolete|| --- Comment #6 from Alexander Blanchard --- Created attachment 186432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186432&action=edit Bug 38633: Prevent holidays from being ignored If weekly repeatable holidays are set, Koha ignores these days when other holidays are set using the Holidays repeated yearly on a range option. To test: 1) Navigate to Tools > Calendar 2) Click on a weekend date on the calendar to open the Add New Holiday option 3) Give your holiday a title and select Holiday repeated every same day of the week 4) Click on the calendar again and set a holiday from 20 December 2021 to 06 January 2022 5) Give your holiday a title 6) Select Holidays repeated yearly on a range and click save 7) Using the calendar, navigate forwards to December 2024 and note that there are days that should be highlighted in the holdiay period that are not highlighted 8) Apply Patch 9) Run the reset_all command 10) Repeat the steps above 11) Notice that now when you click forwards through the calendar, all of the dates for your holidays repeated yearly on a range are still selected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Marcel de Rooy changed: What|Removed |Added CC||[email protected] Status|Signed Off |Failed QA --- Comment #5 from Marcel de Rooy --- Hi Alexander, sub isHoliday { -my ( $self, $day, $month, $year ) = @_; +my ( $self, $day, $month, $year, $is_range_holiday_creation ) = @_; + +return 0 if $is_range_holiday_creation; This does not look very useful at first sight. A new parameter to return false immediately? Probably we should not call the function for the circumstances where you want to pass this new param? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Marcel de Rooy changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Baptiste Wojtkowski (bwoj) changed: What|Removed |Added CC||baptiste.wojtkowski@biblibr ||e.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 --- Comment #4 from Alexander Blanchard --- Updated POD -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Alexander Blanchard changed: What|Removed |Added Attachment #180533|0 |1 is obsolete|| --- Comment #3 from Alexander Blanchard --- Created attachment 180728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180728&action=edit Bug 38633: Prevent holidays from being ignored If weekly repeatable holidays are set, Koha ignores these days when other holidays are set using the Holidays repeated yearly on a range option. To test: 1) Navigate to Tools > Calendar 2) Click on a weekend date on the calendar to open the Add New Holiday option 3) Give your holiday a title and select Holiday repeated every same day of the week 4) Click on the calendar again and set a holiday from 20 December 2021 to 06 January 2022 5) Give your holiday a title 6) Select Holidays repeated yearly on a range and click save 7) Using the calendar, navigate forwards to December 2024 and note that there are days that should be highlighted in the holdiay period that are not highlighted 8) Apply Patch 9) Run the reset_all command 10) Repeat the steps above 11) Notice that now when you click forwards through the calendar, all of the dates for your holidays repeated yearly on a range are still selected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Alexander Blanchard changed: What|Removed |Added CC||alexander.blanchard@openfif ||th.co.uk Status|NEW |Needs Signoff Assignee|[email protected] |alexander.blanchard@openfif |ity.org |th.co.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Marion Durand changed: What|Removed |Added Attachment #180489|0 |1 is obsolete|| --- Comment #2 from Marion Durand --- Created attachment 180533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180533&action=edit Bug 38633: Prevent holidays from being ignored If weekly repeatable holidays are set, Koha ignores these days when other holidays are set using the Holidays repeated yearly on a range option. To test: 1) Navigate to Tools > Calendar 2) Click on a weekend date on the calendar to open the Add New Holiday option 3) Give your holiday a title and select Holiday repeated every same day of the week 4) Click on the calendar again and set a holiday from 20 December 2021 to 06 January 2022 5) Give your holiday a title 6) Select Holidays repeated yearly on a range and click save 7) Using the calendar, navigate forwards to December 2024 and note that there are days that should be highlighted in the holdiay period that are not highlighted 8) Apply Patch 9) Run the reset_all command 10) Repeat the steps above 11) Notice that now when you click forwards through the calendar, all of the dates for your holidays repeated yearly on a range are still selected Signed-off-by: Marion Durand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Marion Durand changed: What|Removed |Added CC||[email protected] Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 --- Comment #1 from Alexander Blanchard --- Created attachment 180489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180489&action=edit Bug 38633: Prevent holidays from being ignored If weekly repeatable holidays are set, Koha ignores these days when other holidays are set using the Holidays repeated yearly on a range option. To test: 1) Navigate to Tools > Calendar 2) Click on a weekend date on the calendar to open the Add New Holiday option 3) Give your holiday a title and select Holiday repeated every same day of the week 4) Click on the calendar again and set a holiday from 20 December 2021 to 06 January 2022 5) Give your holiday a title 6) Select Holidays repeated yearly on a range and click save 7) Using the calendar, navigate forwards to December 2024 and note that there are days that should be highlighted in the holdiay period that are not highlighted 8) Apply Patch 9) Run the reset_all command 10) Repeat the steps above 11) Notice that now when you click forwards through the calendar, all of the dates for your holidays repeated yearly on a range are still selected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Jeremy Evans changed: What|Removed |Added Component|Tools |Holidays -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Aude Charillon changed: What|Removed |Added CC||aude.charillon@ptfs-europe. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38633] Calendar - Weekly closures are ignored when setting a yearly repeating holiday
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38633 Jeremy Evans changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
