[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663
--- Comment #82 from David Nind ---
Error reported in chat on upgrading from 25.11.? to 25.05:
> I’m updating Koha from version 24.11 to 25 and I’m getting this error:
>
> Upgrade to 24.12.00.018 [12:35:45]: Bug 38663
> (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663) - Add
> additional fields to libraries
Converting record_id from int(11) to VARCHAR(11)...
> ERROR: {UNKNOWN}: DBI Exception: DBD::mysql::db do failed:
You have an error in your SQL syntax; check the manual that corresponds to your
MariaDB server version for the right syntax to use near
'COLUMN new_record_id TO record_id' at line 1
at /usr/share/koha/lib/C4/Installer.pm line 825.
> Does anyone know how I can fix this?
https://chat.koha-community.org/koha-community/pl/71tfhdwuniyymc334ac4oqmcra
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 cart...@slolibrary.org changed: What|Removed |Added CC||cart...@slolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Chip Halvorsen changed: What|Removed |Added CC||Chip.Halvorsen@WestlakeLibr ||ary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #81 from Jonathan Druart --- (In reply to Jonathan Druart from comment #79) > Created attachment 181910 [details] [review] > Bug 38663: Fix columns order in db_rev Patch pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #80 from Jonathan Druart --- (In reply to Jonathan Druart from comment #79) > Created attachment 181910 [details] [review] > Bug 38663: Fix columns order in db_rev To fix Koha_Main_MariaDB_update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #79 from Jonathan Druart --- Created attachment 181910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181910&action=edit Bug 38663: Fix columns order in db_rev -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Paul Derscheid changed: What|Removed |Added CC||paul.dersch...@lmscloud.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Katrin Fischer changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #78 from Katrin Fischer --- Double checked: https://git.koha-community.org/Koha-community/Koha/commit/84c5e81b0760ad41d147c4e0e68158f8a7d025f9 :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #77 from Martin Renvoize (ashimema) --- Thanks Katrin, your a star :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #76 from Katrin Fischer --- (In reply to Jonathan Druart from comment #73) > (In reply to Martin Renvoize (ashimema) from comment #72) > > Created attachment 179455 [details] [review] [review] > > Bug 38663: (follow-up) Make database update idempotent > > > > Signed-off-by: Martin Renvoize > > This is wrong > -use Koha::Installer::Output qw(say_warning say_success say_info); > +use Koha::Installer::Output qw(say_warning say_success( $out, say_info); I've fixed it inline, but forgot to save my comment here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #75 from Martin Renvoize (ashimema) --- (In reply to Jonathan Druart from comment #73) > (In reply to Martin Renvoize (ashimema) from comment #72) > > Created attachment 179455 [details] [review] [review] > > Bug 38663: (follow-up) Make database update idempotent > > > > Signed-off-by: Martin Renvoize > > This is wrong > -use Koha::Installer::Output qw(say_warning say_success say_info); > +use Koha::Installer::Output qw(say_warning say_success( $out, say_info); You're right.. no idea how that crept in there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #74 from Katrin Fischer --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #73 from Jonathan Druart --- (In reply to Martin Renvoize (ashimema) from comment #72) > Created attachment 179455 [details] [review] > Bug 38663: (follow-up) Make database update idempotent > > Signed-off-by: Martin Renvoize This is wrong -use Koha::Installer::Output qw(say_warning say_success say_info); +use Koha::Installer::Output qw(say_warning say_success( $out, say_info); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #72 from Martin Renvoize (ashimema) --- Created attachment 179455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179455&action=edit Bug 38663: (follow-up) Make database update idempotent Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Pushed to main |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #71 from Martin Renvoize (ashimema) --- Also, the atomic update isn't idempotent I just discovered.. working on a fix for that -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #67 from Katrin Fischer --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #66 from Katrin Fischer --- 1) Updates heading on administration page from h3 to h2 to match the others. 2) Fixed qa script complaint: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt FAIL forbidden patterns forbidden pattern: tab char (line 619) forbidden pattern: tab char (line 620) forbidden pattern: tab char (line 621) forbidden pattern: tab char (line 622) forbidden pattern: tab char (line 623) forbidden pattern: tab char (line 624) FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Katrin Fischer changed: What|Removed |Added Version(s)||25.05.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663
Jonathan Druart changed:
What|Removed |Added
Keywords||additional_work_needed
--- Comment #70 from Jonathan Druart ---
Still a problem
https://jenkins.koha-community.org/job/Koha_Main_MariaDB_update/78/console
16:08:12 koha_1 |{ data_type => "integer", is_auto_increment => 1,
is_nullable => 0 },
16:08:12 koha_1 |"field_id",
16:08:12 koha_1 |{ data_type => "integer", is_foreign_key => 1,
is_nullable => 0 },
16:08:12 koha_1 | - "record_id",
16:08:12 koha_1 | - { data_type => "varchar", is_nullable => 0, size =>
11 },
16:08:12 koha_1 |"value",
16:08:12 koha_1 |{ data_type => "varchar", default_value => "",
is_nullable => 0, size => 255 },
16:08:12 koha_1 | + "record_id",
16:08:12 koha_1 | + { data_type => "varchar", default_value => "",
is_nullable => 0, size => 11 },
The order is not preserved.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Katrin Fischer changed: What|Removed |Added Keywords|additional_work_needed | --- Comment #69 from Katrin Fischer --- (In reply to Jonathan Druart from comment #68) > (In reply to Katrin Fischer from comment #67) > > Pushed for 25.05! > > > > Well done everyone, thank you! > > DBIC schema commit is missing. Fixed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@gmail.com Keywords||additional_work_needed --- Comment #68 from Jonathan Druart --- (In reply to Katrin Fischer from comment #67) > Pushed for 25.05! > > Well done everyone, thank you! DBIC schema commit is missing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #65 from Martin Renvoize (ashimema) --- Back to PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #64 from Martin Renvoize (ashimema) --- Created attachment 178914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178914&action=edit Bug 38663: (follow-up) Fix new library creation We were attempting to use the a library method prior to saving the library for the first time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #63 from Martin Renvoize (ashimema) --- Reverting to FQA temporarily as I think I've found an issue with the rebase.. adding new libraries is currently broken. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Pedro Amorim changed: What|Removed |Added Attachment #176802|0 |1 is obsolete|| --- Comment #59 from Pedro Amorim --- Created attachment 178847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178847&action=edit Bug 38663: Add AdditionalFields to Library Test plan, k-t-d: 1) Add a new additional field to 'branches': /cgi-bin/koha/admin/additional-fields.pl?tablename=branches 2) Click 'New field'. Add a name. Click Save. 3) Repeat step 2 but repeatable. Repeat again for 2 more of AV category (one repeatable, one not repeatable) 4) Edit a library: /cgi-bin/koha/admin/branches.pl?op=add_form&branchcode=CPL 5) Input various values in the different additional fields. Click 'Submit' 6) Visit the detail page of the library and verify the additional fields data is displayed correctly: /cgi-bin/koha/admin/branches.pl?op=view&branchcode=CPL Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Pedro Amorim changed: What|Removed |Added Attachment #176797|0 |1 is obsolete|| --- Comment #55 from Pedro Amorim --- Created attachment 178843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178843&action=edit Bug 38663: [DONT PUSH] Preparation: Change record_id to varchar: DBIC Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Pedro Amorim changed: What|Removed |Added Attachment #176800|0 |1 is obsolete|| --- Comment #57 from Pedro Amorim --- Created attachment 178845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178845&action=edit Bug 38663: Add libraries table to additional fields admin screen Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Pedro Amorim changed: What|Removed |Added Attachment #176804|0 |1 is obsolete|| --- Comment #61 from Pedro Amorim --- Created attachment 178849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178849&action=edit Bug 38663: (follow-up) Heading - Admin to Administration Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Pedro Amorim changed: What|Removed |Added Attachment #176805|0 |1 is obsolete|| --- Comment #62 from Pedro Amorim --- Created attachment 178850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178850&action=edit Bug 38663: (QA follow-up) Removed superflous IF As requested, I've removed the superflous IF statement in the template.. I'll likely be adding it back in as part of the next patch series, but it makes the history clear this way. Signed-off-by: Martin Renvoize Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Pedro Amorim changed: What|Removed |Added Attachment #176803|0 |1 is obsolete|| --- Comment #60 from Pedro Amorim --- Created attachment 178848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178848&action=edit Bug 38663: (follow-up) Hide additional fields input appropriately This patch hides the additional fields input on the library add/edit page when there are no additional fields defined for libraries. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Pedro Amorim changed: What|Removed |Added Attachment #176801|0 |1 is obsolete|| --- Comment #58 from Pedro Amorim --- Created attachment 178846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178846&action=edit Bug 38663: DBIC: Add AdditionalFields to Library Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Pedro Amorim changed: What|Removed |Added Attachment #176799|0 |1 is obsolete|| --- Comment #56 from Pedro Amorim --- Created attachment 178844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178844&action=edit Bug 38663: Preparation: Change record_id to varchar: database record_if in the additional_field_values is an int(11) This works for most cases, but in the branches case, the id column is actually a varchar (branchcode). This patch updates the column to accomodate for this. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Pedro Amorim changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Patch doesn't apply --- Comment #54 from Katrin Fischer --- Hi Pedro, I am sorry, but this doesn't apply with and without the auto_rebase.pl script, can you please have a look? I am mostly caught up with queue and it will go back on top. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Baptiste Wojtkowski (bwoj) changed: What|Removed |Added Attachment #176788|0 |1 is obsolete|| --- Comment #53 from Baptiste Wojtkowski (bwoj) --- Created attachment 176805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176805&action=edit Bug 38663: (QA follow-up) Removed superflous IF As requested, I've removed the superflous IF statement in the template.. I'll likely be adding it back in as part of the next patch series, but it makes the history clear this way. Signed-off-by: Martin Renvoize Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Baptiste Wojtkowski (bwoj) changed: What|Removed |Added Attachment #176787|0 |1 is obsolete|| --- Comment #52 from Baptiste Wojtkowski (bwoj) --- Created attachment 176804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176804&action=edit Bug 38663: (follow-up) Heading - Admin to Administration Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #51 from Baptiste Wojtkowski (bwoj) --- Created attachment 176803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176803&action=edit Bug 38663: (follow-up) Hide additional fields input appropriately This patch hides the additional fields input on the library add/edit page when there are no additional fields defined for libraries. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #50 from Baptiste Wojtkowski (bwoj) --- Created attachment 176802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176802&action=edit Bug 38663: Add AdditionalFields to Library Test plan, k-t-d: 1) Add a new additional field to 'branches': /cgi-bin/koha/admin/additional-fields.pl?tablename=branches 2) Click 'New field'. Add a name. Click Save. 3) Repeat step 2 but repeatable. Repeat again for 2 more of AV category (one repeatable, one not repeatable) 4) Edit a library: /cgi-bin/koha/admin/branches.pl?op=add_form&branchcode=CPL 5) Input various values in the different additional fields. Click 'Submit' 6) Visit the detail page of the library and verify the additional fields data is displayed correctly: /cgi-bin/koha/admin/branches.pl?op=view&branchcode=CPL Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #49 from Baptiste Wojtkowski (bwoj) --- Created attachment 176801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176801&action=edit Bug 38663: DBIC: Add AdditionalFields to Library Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #48 from Baptiste Wojtkowski (bwoj) --- Created attachment 176800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176800&action=edit Bug 38663: Add libraries table to additional fields admin screen Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #47 from Baptiste Wojtkowski (bwoj) --- Created attachment 176799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176799&action=edit Bug 38663: Preparation: Change record_id to varchar: database record_if in the additional_field_values is an int(11) This works for most cases, but in the branches case, the id column is actually a varchar (branchcode). This patch updates the column to accomodate for this. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Baptiste Wojtkowski (bwoj) changed: What|Removed |Added Attachment #176781|0 |1 is obsolete|| Attachment #176782|0 |1 is obsolete|| Attachment #176783|0 |1 is obsolete|| Attachment #176784|0 |1 is obsolete|| Attachment #176785|0 |1 is obsolete|| Attachment #176786|0 |1 is obsolete|| --- Comment #46 from Baptiste Wojtkowski (bwoj) --- Created attachment 176797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176797&action=edit Bug 38663: [DONT PUSH] Preparation: Change record_id to varchar: DBIC Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Baptiste Wojtkowski (bwoj) changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #45 from Martin Renvoize (ashimema) --- Fancy finishing up the QA here and adding your stamp Baptiste :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #176296|0 |1 is obsolete|| --- Comment #43 from Martin Renvoize (ashimema) --- Created attachment 176787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176787&action=edit Bug 38663: (follow-up) Heading - Admin to Administration Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #44 from Martin Renvoize (ashimema) --- Created attachment 176788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176788&action=edit Bug 38663: (QA follow-up) Removed superflous IF As requested, I've removed the superflous IF statement in the template.. I'll likely be adding it back in as part of the next patch series, but it makes the history clear this way. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #176225|0 |1 is obsolete|| --- Comment #42 from Martin Renvoize (ashimema) --- Created attachment 176786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176786&action=edit Bug 38663: (follow-up) Hide additional fields input appropriately This patch hides the additional fields input on the library add/edit page when there are no additional fields defined for libraries. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #176224|0 |1 is obsolete|| --- Comment #41 from Martin Renvoize (ashimema) --- Created attachment 176785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176785&action=edit Bug 38663: Add AdditionalFields to Library Test plan, k-t-d: 1) Add a new additional field to 'branches': /cgi-bin/koha/admin/additional-fields.pl?tablename=branches 2) Click 'New field'. Add a name. Click Save. 3) Repeat step 2 but repeatable. Repeat again for 2 more of AV category (one repeatable, one not repeatable) 4) Edit a library: /cgi-bin/koha/admin/branches.pl?op=add_form&branchcode=CPL 5) Input various values in the different additional fields. Click 'Submit' 6) Visit the detail page of the library and verify the additional fields data is displayed correctly: /cgi-bin/koha/admin/branches.pl?op=view&branchcode=CPL Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #176222|0 |1 is obsolete|| --- Comment #39 from Martin Renvoize (ashimema) --- Created attachment 176783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176783&action=edit Bug 38663: Add libraries table to additional fields admin screen Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #176223|0 |1 is obsolete|| --- Comment #40 from Martin Renvoize (ashimema) --- Created attachment 176784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176784&action=edit Bug 38663: DBIC: Add AdditionalFields to Library Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #176220|0 |1 is obsolete|| --- Comment #37 from Martin Renvoize (ashimema) --- Created attachment 176781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176781&action=edit Bug 38663: [DONT PUSH] Preparation: Change record_id to varchar: DBIC Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #176221|0 |1 is obsolete|| --- Comment #38 from Martin Renvoize (ashimema) --- Created attachment 176782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176782&action=edit Bug 38663: Preparation: Change record_id to varchar: database record_if in the additional_field_values is an int(11) This works for most cases, but in the branches case, the id column is actually a varchar (branchcode). This patch updates the column to accomodate for this. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #36 from Pedro Amorim --- (In reply to Baptiste Wojtkowski (bwoj) from comment #35) > I understand the reason when you explain it, but I feel like double check > will be weird in the code as long as we don't add multiple options, so I'd > rather say let's not double check as long as we don't need. Makes sense. I agree. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #35 from Baptiste Wojtkowski (bwoj) --- I understand the reason when you explain it, but I feel like double check will be weird in the code as long as we don't add multiple options, so I'd rather say let's not double check as long as we don't need. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #34 from David Nind --- Created attachment 176296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176296&action=edit Bug 38663: (follow-up) Heading - Admin to Administration Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #33 from Pedro Amorim --- (In reply to Baptiste Wojtkowski (bwoj) from comment #32) > Everything works find and QA tool passes. Implementation is the same as for > other additional fields so it makes sense to me. > > Concerning the code I'm wondering why there is a double if here ? > > >[% IF CAN_user_parameters_manage_libraries %] > >Admin > > > >[% IF CAN_user_parameters_manage_libraries %] > >[% WRAPPER table_option value="branches" > > %]Libraries[% END %] > >[% END %] > > > >[% END %] > > I also tested other values to verify nothing is broken by record_id type > changes, looks fine. Hey, that's a good observation. I opted for this pattern approach as the initial IF should be an OR of all child IFs. It's just so happens that in this case there is only 1 child IF, but more entries may be added under 'Admin' in the future. To better understand what I mean here see the 'Acquisitions' section of the code right above it. Having said that, this same pattern is not present on the other subsequent IFs below so, yeah, up for discussion. I agree with either way and don't feel strongly about it, but I believe that was the reason. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Baptiste Wojtkowski (bwoj) changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com CC||baptiste.wojtkowski@biblibr ||e.com --- Comment #32 from Baptiste Wojtkowski (bwoj) --- Everything works find and QA tool passes. Implementation is the same as for other additional fields so it makes sense to me. Concerning the code I'm wondering why there is a double if here ? >[% IF CAN_user_parameters_manage_libraries %] >Admin > >[% IF CAN_user_parameters_manage_libraries %] >[% WRAPPER table_option value="branches" > %]Libraries[% END %] >[% END %] > >[% END %] I also tested other values to verify nothing is broken by record_id type changes, looks fine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 David Nind changed: What|Removed |Added Attachment #176215|0 |1 is obsolete|| --- Comment #26 from David Nind --- Created attachment 176221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176221&action=edit Bug 38663: Preparation: Change record_id to varchar: database record_if in the additional_field_values is an int(11) This works for most cases, but in the branches case, the id column is actually a varchar (branchcode). This patch updates the column to accomodate for this. Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 David Nind changed: What|Removed |Added Text to go in the||This enhancement lets you release notes||add additional fields to ||libraries (Koha ||administration > Additional ||parameters > Additional ||fields ). --- Comment #31 from David Nind --- Added my signoff. Patches apply, works as per the test plan. Testing notes (using KTD): 1. Apply the patches. 2. Update the database: updatedatabase 3. Run DBIC: dbic 4. Restart everything: restart_all -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 David Nind changed: What|Removed |Added Attachment #176219|0 |1 is obsolete|| --- Comment #30 from David Nind --- Created attachment 176225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176225&action=edit Bug 38663: (follow-up) Hide additional fields input appropriately This patch hides the additional fields input on the library add/edit page when there are no additional fields defined for libraries. Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 David Nind changed: What|Removed |Added Attachment #176218|0 |1 is obsolete|| --- Comment #29 from David Nind --- Created attachment 176224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176224&action=edit Bug 38663: Add AdditionalFields to Library Test plan, k-t-d: 1) Add a new additional field to 'branches': /cgi-bin/koha/admin/additional-fields.pl?tablename=branches 2) Click 'New field'. Add a name. Click Save. 3) Repeat step 2 but repeatable. Repeat again for 2 more of AV category (one repeatable, one not repeatable) 4) Edit a library: /cgi-bin/koha/admin/branches.pl?op=add_form&branchcode=CPL 5) Input various values in the different additional fields. Click 'Submit' 6) Visit the detail page of the library and verify the additional fields data is displayed correctly: /cgi-bin/koha/admin/branches.pl?op=view&branchcode=CPL Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 David Nind changed: What|Removed |Added Attachment #176217|0 |1 is obsolete|| --- Comment #28 from David Nind --- Created attachment 176223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176223&action=edit Bug 38663: DBIC: Add AdditionalFields to Library Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 David Nind changed: What|Removed |Added Attachment #176216|0 |1 is obsolete|| --- Comment #27 from David Nind --- Created attachment 176222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176222&action=edit Bug 38663: Add libraries table to additional fields admin screen Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 David Nind changed: What|Removed |Added Attachment #176214|0 |1 is obsolete|| --- Comment #25 from David Nind --- Created attachment 176220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176220&action=edit Bug 38663: [DONT PUSH] Preparation: Change record_id to varchar: DBIC Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Pedro Amorim changed: What|Removed |Added Attachment #175762|0 |1 is obsolete|| --- Comment #24 from Pedro Amorim --- Created attachment 176219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176219&action=edit Bug 38663: (follow-up) Hide additional fields input appropriately This patch hides the additional fields input on the library add/edit page when there are no additional fields defined for libraries. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Pedro Amorim changed: What|Removed |Added Attachment #175761|0 |1 is obsolete|| --- Comment #23 from Pedro Amorim --- Created attachment 176218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176218&action=edit Bug 38663: Add AdditionalFields to Library Test plan, k-t-d: 1) Add a new additional field to 'branches': /cgi-bin/koha/admin/additional-fields.pl?tablename=branches 2) Click 'New field'. Add a name. Click Save. 3) Repeat step 2 but repeatable. Repeat again for 2 more of AV category (one repeatable, one not repeatable) 4) Edit a library: /cgi-bin/koha/admin/branches.pl?op=add_form&branchcode=CPL 5) Input various values in the different additional fields. Click 'Submit' 6) Visit the detail page of the library and verify the additional fields data is displayed correctly: /cgi-bin/koha/admin/branches.pl?op=view&branchcode=CPL Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Pedro Amorim changed: What|Removed |Added Attachment #175760|0 |1 is obsolete|| --- Comment #22 from Pedro Amorim --- Created attachment 176217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176217&action=edit Bug 38663: DBIC: Add AdditionalFields to Library Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Pedro Amorim changed: What|Removed |Added Attachment #175759|0 |1 is obsolete|| --- Comment #21 from Pedro Amorim --- Created attachment 176216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176216&action=edit Bug 38663: Add libraries table to additional fields admin screen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Pedro Amorim changed: What|Removed |Added Attachment #175758|0 |1 is obsolete|| --- Comment #20 from Pedro Amorim --- Created attachment 176215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176215&action=edit Bug 38663: Preparation: Change record_id to varchar: database record_if in the additional_field_values is an int(11) This works for most cases, but in the branches case, the id column is actually a varchar (branchcode). This patch updates the column to accomodate for this. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Pedro Amorim changed: What|Removed |Added Attachment #175757|0 |1 is obsolete|| --- Comment #19 from Pedro Amorim --- Created attachment 176214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176214&action=edit Bug 38663: [DONT PUSH] Preparation: Change record_id to varchar: DBIC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #18 from David Cook --- (In reply to David Cook from comment #17) > If you can fetch the latest upstream and then rebase against that main > branch, that should fix the problem for us. The rebase is necessary, because if you did "git checkout -b bug_38663 origin/main" and then did "git bz apply 38663" it probably would work for you, because you have that ancestor elsewhere in your repo referenced by some other branch, tag, or just a dangling reference that hasn't been garbage collected yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #17 from David Cook --- (In reply to Pedro Amorim from comment #16) > (In reply to David Nind from comment #15) > > The patches no longer apply - sha1/fake ancestor error: > > Hi! Can't reproduce, sorry! Just tested twice on up to date with main > branch, it applies. Can you please double-check? Thanks! Yeah, I have the same problem as David N. You probably won't have that problem, Pedro, as you'll have the git ancestor in your repo while we don't. (In this case, it looks like 62e85cc3eab is the ancestor that you'll have which isn't in the upstream main branch. It might be interesting to see what that hash resolves to in your repo using "git show".) If you can fetch the latest upstream and then rebase against that main branch, that should fix the problem for us. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Pedro Amorim changed: What|Removed |Added Status|Patch doesn't apply |Signed Off CC||pedro.amo...@ptfs-europe.co ||m --- Comment #16 from Pedro Amorim --- (In reply to David Nind from comment #15) > The patches no longer apply - sha1/fake ancestor error: Hi! Can't reproduce, sorry! Just tested twice on up to date with main branch, it applies. Can you please double-check? Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 David Nind changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||da...@davidnind.com --- Comment #15 from David Nind --- The patches no longer apply - sha1/fake ancestor error: git bz apply 38663 Bug 38663 - Add additional fields to libraries 175757 - Bug 38663: [DONT PUSH] Preparation: Change record_id to varchar: DBIC 175758 - Bug 38663: Preparation: Change record_id to varchar: database 175759 - Bug 38663: Add libraries table to additional fields admin screen 175760 - Bug 38663: DBIC: Add AdditionalFields to Library 175761 - Bug 38663: Add AdditionalFields to Library 175762 - Bug 38663: (follow-up) Hide additional fields input appropriately Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 38663: [DONT PUSH] Preparation: Change record_id to varchar: DBIC Applying: Bug 38663: Preparation: Change record_id to varchar: database Applying: Bug 38663: Add libraries table to additional fields admin screen error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/additional-fields.tt). error: could not build fake ancestor Patch failed at 0001 Bug 38663: Add libraries table to additional fields admin screen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #14 from Martin Renvoize (ashimema) --- Created attachment 175762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175762&action=edit Bug 38663: (follow-up) Hide additional fields input appropriately This patch hides the additional fields input on the library add/edit page when there are no additional fields defined for libraries. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #175370|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize (ashimema) --- Created attachment 175761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175761&action=edit Bug 38663: Add AdditionalFields to Library Test plan, k-t-d: 1) Add a new additional field to 'branches': /cgi-bin/koha/admin/additional-fields.pl?tablename=branches 2) Click 'New field'. Add a name. Click Save. 3) Repeat step 2 but repeatable. Repeat again for 2 more of AV category (one repeatable, one not repeatable) 4) Edit a library: /cgi-bin/koha/admin/branches.pl?op=add_form&branchcode=CPL 5) Input various values in the different additional fields. Click 'Submit' 6) Visit the detail page of the library and verify the additional fields data is displayed correctly: /cgi-bin/koha/admin/branches.pl?op=view&branchcode=CPL Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #175358|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize (ashimema) --- Created attachment 175760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175760&action=edit Bug 38663: DBIC: Add AdditionalFields to Library Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #175357|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize (ashimema) --- Created attachment 175759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175759&action=edit Bug 38663: Add libraries table to additional fields admin screen Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #175356|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize (ashimema) --- Created attachment 175758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175758&action=edit Bug 38663: Preparation: Change record_id to varchar: database record_if in the additional_field_values is an int(11) This works for most cases, but in the branches case, the id column is actually a varchar (branchcode). This patch updates the column to accomodate for this. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #175355|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize (ashimema) --- Created attachment 175757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175757&action=edit Bug 38663: [DONT PUSH] Preparation: Change record_id to varchar: DBIC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Martin Renvoize (ashimema) changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks||38457 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38457 [Bug 38457] Add custom field in debit type to allow for external finance system codes to be added -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #8 from David Cook --- One day, it would be cool to switch from autoincrementing integers to UUIDs, which are less prone to enumeration attacks, but that's a whole other story... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #7 from David Cook --- It's a good question. Historically, I think we'd say branches should be converted to have a branch_id. Once upon a time, reserve_id didn't exist (see Bug 7065), but that was a long time ago and a different set of circumstances... (e.g. it didn't have a primary key at all) Technically, I suppose we could keep branchcode as the PK, and maybe just add an autoincrementing branch_id int(11) with a UNIQUE constraint. I don't know enough about additional_field_values to know if that would be workable or not though -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Pedro Amorim changed: What|Removed |Added Attachment #175359|0 |1 is obsolete|| --- Comment #6 from Pedro Amorim --- Created attachment 175370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175370&action=edit Bug 38663: Add AdditionalFields to Library Test plan, k-t-d: 1) Add a new additional field to 'branches': /cgi-bin/koha/admin/additional-fields.pl?tablename=branches 2) Click 'New field'. Add a name. Click Save. 3) Repeat step 2 but repeatable. Repeat again for 2 more of AV category (one repeatable, one not repeatable) 4) Edit a library: /cgi-bin/koha/admin/branches.pl?op=add_form&branchcode=CPL 5) Input various values in the different additional fields. Click 'Submit' 6) Visit the detail page of the library and verify the additional fields data is displayed correctly: /cgi-bin/koha/admin/branches.pl?op=view&branchcode=CPL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #5 from Pedro Amorim --- Created attachment 175359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175359&action=edit Bug 38663: Add AdditionalFields to Library Test plan, k-t-d: 1) Add a new additional field to 'branches': /cgi-bin/koha/admin/additional-fields.pl?tablename=branches 2) Click 'New field'. Add a name. Click Save. 3) Repeat step 2 but repeatable. Repeat again for 2 more of AV category (one repeatable, one not repeatable) 4) Edit a library: /cgi-bin/koha/admin/branches.pl?op=add_form&branchcode=CPL 5) Input various values in the different additional fields. Click 'Submit' 6) Visit the detail page of the library and verify the additional fields data is displayed correctly: /cgi-bin/koha/admin/branches.pl?op=view&branchcode=CPL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #4 from Pedro Amorim --- Created attachment 175358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175358&action=edit Bug 38663: DBIC: Add AdditionalFields to Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #3 from Pedro Amorim --- Created attachment 175357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175357&action=edit Bug 38663: Add libraries table to additional fields admin screen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #2 from Pedro Amorim --- Created attachment 175356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175356&action=edit Bug 38663: Preparation: Change record_id to varchar: database record_if in the additional_field_values is an int(11) This works for most cases, but in the branches case, the id column is actually a varchar (branchcode). This patch updates the column to accomodate for this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 --- Comment #1 from Pedro Amorim --- Created attachment 175355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175355&action=edit Bug 38663: [DONT PUSH] Preparation: Change record_id to varchar: DBIC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38663] Add additional fields to libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38663 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
