[Koha-bugs] [Bug 38685] ILL pages have incomplete breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Pedro Amorim changed: What|Removed |Added Blocks||38441 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38441 [Bug 38441] ILL - Allow for a history check workflow stage -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38685] ILL pages have incomplete breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Martin Renvoize (ashimema) changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38685] ILL pages have incomplete breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38685] ILL pages have incomplete breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #175463|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize (ashimema) --- Created attachment 176276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176276&action=edit Bug 38685: Add missing ops to breadcrumbs Breadcrumbs added to the following op pages: - confirm - delete_confirm - generic_confirm - edititem - edit_action - check_out - cud-cancel - availability Test plan: 1) Enable ILLModule 2) Create a new ILL request: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Try various actions like 'Edit request', 'Confirm request', 'Place request with partners', etc. 4) Notice the breadcrumbs were previously missing. They are now there. 5) If you want to test the breadcrumbs on the batches pages or availability check stage let me know and I'll help setting up the required plugins to have them work. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38685] ILL pages have incomplete breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #175462|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize (ashimema) --- Created attachment 176275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176275&action=edit Bug 38685: Preparation: DRY code This is in preparation of the next patch, to avoid big copy + pastes Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38685] ILL pages have incomplete breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #175461|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize (ashimema) --- Created attachment 176274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176274&action=edit Bug 38685: Only render breadcrumb item if content not empty This ensures the '>' caret is only rendered if there is indeed some breadcrumb content. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38685] ILL pages have incomplete breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #175460|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize (ashimema) --- Created attachment 176273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176273&action=edit Bug 38685: Remove useless batch_create code This is not used and not needed. Noticed when evaluating every potential 'op'. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38685] ILL pages have incomplete breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 --- Comment #8 from Owen Leonard --- Created attachment 175463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175463&action=edit Bug 38685: Add missing ops to breadcrumbs Breadcrumbs added to the following op pages: - confirm - delete_confirm - generic_confirm - edititem - edit_action - check_out - cud-cancel - availability Test plan: 1) Enable ILLModule 2) Create a new ILL request: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Try various actions like 'Edit request', 'Confirm request', 'Place request with partners', etc. 4) Notice the breadcrumbs were previously missing. They are now there. 5) If you want to test the breadcrumbs on the batches pages or availability check stage let me know and I'll help setting up the required plugins to have them work. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38685] ILL pages have incomplete breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 --- Comment #7 from Owen Leonard --- Created attachment 175462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175462&action=edit Bug 38685: Preparation: DRY code This is in preparation of the next patch, to avoid big copy + pastes Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38685] ILL pages have incomplete breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 --- Comment #6 from Owen Leonard --- Created attachment 175461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175461&action=edit Bug 38685: Only render breadcrumb item if content not empty This ensures the '>' caret is only rendered if there is indeed some breadcrumb content. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38685] ILL pages have incomplete breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Owen Leonard changed: What|Removed |Added Attachment #175397|0 |1 is obsolete|| Attachment #175399|0 |1 is obsolete|| Attachment #175400|0 |1 is obsolete|| Attachment #175401|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 175460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175460&action=edit Bug 38685: Remove useless batch_create code This is not used and not needed. Noticed when evaluating every potential 'op'. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38685] ILL pages have incomplete breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38685] ILL pages have incomplete breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Pedro Amorim changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38685] ILL pages have incomplete breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 --- Comment #4 from Pedro Amorim --- Created attachment 175401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175401&action=edit Bug 38685: Add missing ops to breadcrumbs Breadcrumbs added to the following op pages: - confirm - delete_confirm - generic_confirm - edititem - edit_action - check_out - cud-cancel - availability Test plan: 1) Enable ILLModule 2) Create a new ILL request: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Try various actions like 'Edit request', 'Confirm request', 'Place request with partners', etc. 4) Notice the breadcrumbs were previously missing. They are now there. 5) If you want to test the breadcrumbs on the batches pages or availability check stage let me know and I'll help setting up the required plugins to have them work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38685] ILL pages have incomplete breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 --- Comment #3 from Pedro Amorim --- Created attachment 175400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175400&action=edit Bug 38685: Preparation: DRY code This is in preparation of the next patch, to avoid big copy + pastes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38685] ILL pages have incomplete breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 --- Comment #2 from Pedro Amorim --- Created attachment 175399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175399&action=edit Bug 38685: Only render breadcrumb item if content not empty This ensures the '>' caret is only rendered if there is indeed some breadcrumb content. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38685] ILL pages have incomplete breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 --- Comment #1 from Pedro Amorim --- Created attachment 175397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175397&action=edit Bug 38685: Remove useless batch_create code This is not used and not needed. Noticed when evaluating every potential 'op'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38685] ILL pages have incomplete breadcrumbs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38685 Pedro Amorim changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/