[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-10-18 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #42 from Fridolin Somers  ---
It is ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-10-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #41 from Katrin Fischer  ---
(In reply to Fridolin Somers from comment #39)
> (In reply to Katrin Fischer from comment #38)
> > Is this an enhancement that could be considered for backporting?
> 
> Yes looks great, I will look on it

Hi Frido, is this still on your list?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-08-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #40 from Katrin Fischer  ---
Thanks Frido, it could potentially save me some headache in our move to
Elasticsearch!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-08-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Fridolin Somers  changed:

   What|Removed |Added

 CC||[email protected]
   ||m

--- Comment #39 from Fridolin Somers  ---
(In reply to Katrin Fischer from comment #38)
> Is this an enhancement that could be considered for backporting?

Yes looks great, I will look on it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-08-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Fridolin Somers  changed:

   What|Removed |Added

   Keywords||rel_24_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-07-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #38 from Katrin Fischer  ---
Is this an enhancement that could be considered for backporting?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-07-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Chip Halvorsen  changed:

   What|Removed |Added

 CC||Chip.Halvorsen@WestlakeLibr
   ||ary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-07-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Barbara Johnson  changed:

   What|Removed |Added

 CC||[email protected]
   ||ov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-07-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

koha-US bug tracker  changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-06-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Michael Adamyk  changed:

   What|Removed |Added

 CC||michael.adamyk@bywatersolut
   ||ions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-05-30 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Michelle Spinney  changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #37 from Katrin Fischer  ---
Pushed for 25.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to main
 Version(s)||25.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-04-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #36 from Katrin Fischer  ---
Smuggled an ending . into the last patch:
"This will not boost CCL style searches, only standard or advanced searches."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Thomas Klausner  changed:

   What|Removed |Added

 Attachment #180325|0   |1
is obsolete||

--- Comment #33 from Thomas Klausner  ---
Created attachment 181352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181352&action=edit
Bug 38694: Add ESBoostFieldMatch option to Elasticsearch

What this patch does is:
1 - Wraps the existing search code in a a "bool" compound query as a "must".
This should not affect
relevancy or results of the existing searches.
2 - Before we clean/truncate terms, loop through the passed in search terms and
indexes to build a
new 'should' query, using the 'match' on the specified index/field that is
added to the 'bool' query from above.
This means that if a result from the original query is also returned here,
that item will be boosted in the result.
For searches on 'keyword' or 'title', or if no index is set, we use
'title-cover' as the most narrow form of title

This query isn't going to help when users enter CCL (i.e. ti:To die for) and it
won't boost titles from 505, series, etc
when doing a general search. Nor will it have a detrimental effect, it will
only boost field matches

To test:
1 - Add a record with
245 $a novel
2 - Add a record with
245 $a A novel : $b about things / $c by me
3 - Search for: novel
- Above records are returned lower in the list (results #6 and #14 for me)
4 - Search for: a novel
- Above records are returned lower in the list (results #6 and #14 for me)
5 - Apply patch, restart all, enable ESBoostFieldMatch option
6 - Repeat searches, note exact titles are boosted
- For 'novel' record from #1 is #1 result and other is second
- For 'a novel' record form #2 is #1 result and other is third
7 - Disable the new pref and repeat steps 3 and 4 and get results as before
patch
8 - Experiment with other searches, turning pref on and off to verify relevant
titles are boosted when enabled
9 - Search results when disabled should return as before the patch

Signed-off-by: Matthias Meusburger 
Signed-off-by: Thomas Klausner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Thomas Klausner  changed:

   What|Removed |Added

 Attachment #180326|0   |1
is obsolete||

--- Comment #34 from Thomas Klausner  ---
Created attachment 181353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181353&action=edit
Bug 38694: Unit tests

Adjust existing and add new

Signed-off-by: Matthias Meusburger 
Signed-off-by: Thomas Klausner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #35 from Thomas Klausner  ---
Created attachment 181354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181354&action=edit
Bug 38694: (follow-up) Rename syspref from ESBoostFieldMatch to
ElasticsearchBoostFieldMatch

to keep the syspref names consistent with the existings values. Also "ES" is
not as self-documenting as "Elasticsearch".

No code change, so the test plan stays the same.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-04-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Thomas Klausner  changed:

   What|Removed |Added

 Attachment #180057|0   |1
is obsolete||

--- Comment #30 from Thomas Klausner  ---
Created attachment 180325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180325&action=edit
Bug 38694: Add ESBoostFieldMatch option to Elasticsearch

What this patch does is:
1 - Wraps the existing search code in a a "bool" compound query as a "must".
This should not affect
relevancy or results of the existing searches.
2 - Before we clean/truncate terms, loop through the passed in search terms and
indexes to build a
new 'should' query, using the 'match' on the specified index/field that is
added to the 'bool' query from above.
This means that if a result from the original query is also returned here,
that item will be boosted in the result.
For searches on 'keyword' or 'title', or if no index is set, we use
'title-cover' as the most narrow form of title

This query isn't going to help when users enter CCL (i.e. ti:To die for) and it
won't boost titles from 505, series, etc
when doing a general search. Nor will it have a detrimental effect, it will
only boost field matches

To test:
1 - Add a record with
245 $a novel
2 - Add a record with
245 $a A novel : $b about things / $c by me
3 - Search for: novel
- Above records are returned lower in the list (results #6 and #14 for me)
4 - Search for: a novel
- Above records are returned lower in the list (results #6 and #14 for me)
5 - Apply patch, restart all, enable ESBoostFieldMatch option
6 - Repeat searches, note exact titles are boosted
- For 'novel' record from #1 is #1 result and other is second
- For 'a novel' record form #2 is #1 result and other is third
7 - Disable the new pref and repeat steps 3 and 4 and get results as before
patch
8 - Experiment with other searches, turning pref on and off to verify relevant
titles are boosted when enabled
9 - Search results when disabled should return as before the patch

Signed-off-by: Matthias Meusburger 
Signed-off-by: Thomas Klausner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-04-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Matthias Meusburger  changed:

   What|Removed |Added

 Attachment #179969|0   |1
is obsolete||

--- Comment #27 from Matthias Meusburger  ---
Created attachment 180057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180057&action=edit
Bug 38694: Add ESBoostFieldMatch option to Elasticsearch

What this patch does is:
1 - Wraps the existing search code in a a "bool" compound query as a "must".
This should not affect
relevancy or results of the existing searches.
2 - Before we clean/truncate terms, loop through the passed in search terms and
indexes to build a
new 'should' query, using the 'match' on the specified index/field that is
added to the 'bool' query from above.
This means that if a result from the original query is also returned here,
that item will be boosted in the result.
For searches on 'keyword' or 'title', or if no index is set, we use
'title-cover' as the most narrow form of title

This query isn't going to help when users enter CCL (i.e. ti:To die for) and it
won't boost titles from 505, series, etc
when doing a general search. Nor will it have a detrimental effect, it will
only boost field matches

To test:
1 - Add a record with
245 $a novel
2 - Add a record with
245 $a A novel : $b about things / $c by me
3 - Search for: novel
- Above records are returned lower in the list (results #6 and #14 for me)
4 - Search for: a novel
- Above records are returned lower in the list (results #6 and #14 for me)
5 - Apply patch, restart all, enable ESBoostFieldMatch option
6 - Repeat searches, note exact titles are boosted
- For 'novel' record from #1 is #1 result and other is second
- For 'a novel' record form #2 is #1 result and other is third
7 - Disable the new pref and repeat steps 3 and 4 and get results as before
patch
8 - Experiment with other searches, turning pref on and off to verify relevant
titles are boosted when enabled
9 - Search results when disabled should return as before the patch

Signed-off-by: Matthias Meusburger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-04-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Attachment #179940|0   |1
is obsolete||

--- Comment #24 from Nick Clemens (kidclamp)  ---
Created attachment 179969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179969&action=edit
Bug 38694: Add ESBoostFieldMatch option to Elasticsearch

What this patch does is:
1 - Wraps the existing search code in a a "bool" compound query as a "must".
This should not affect
relevancy or results of the existing searches.
2 - Before we clean/truncate terms, loop through the passed in search terms and
indexes to build a
new 'should' query, using the 'match' on the specified index/field that is
added to the 'bool' query from above.
This means that if a result from the original query is also returned here,
that item will be boosted in the result.
For searches on 'keyword' or 'title', or if no index is set, we use
'title-cover' as the most narrow form of title

This query isn't going to help when users enter CCL (i.e. ti:To die for) and it
won't boost titles from 505, series, etc
when doing a general search. Nor will it have a detrimental effect, it will
only boost field matches

To test:
1 - Add a record with
245 $a novel
2 - Add a record with
245 $a A novel : $b about things / $c by me
3 - Search for: novel
- Above records are returned lower in the list (results #6 and #14 for me)
4 - Search for: a novel
- Above records are returned lower in the list (results #6 and #14 for me)
5 - Apply patch, restart all, enable ESBoostFieldMatch option
6 - Repeat searches, note exact titles are boosted
- For 'novel' record from #1 is #1 result and other is second
- For 'a novel' record form #2 is #1 result and other is third
7 - Disable the new pref and repeat steps 3 and 4 and get results as before
patch
8 - Experiment with other searches, turning pref on and off to verify relevant
titles are boosted when enabled
9 - Search results when disabled should return as before the patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-04-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #29 from Thomas Klausner  ---
Everything works as advertised, and I very much like this feature (as we also
had customers complaining about obvious matches not showing up first)

Small nag, which IMO should be another bug: Some sysprefs are called
"Elasticsearch*" (I can find 4 in the DB), and some are called "ES*" (2 in the
DB). Those should probably be unified?

select variable from systempreferences where variable like 'ES%' or variable
like 'Elastic%' order by 1;
+--+
| variable |
+--+
| ElasticsearchCrossFields |
| ElasticsearchIndexStatus_authorities |
| ElasticsearchIndexStatus_biblios |
| ElasticsearchMARCFormat  |
| ESBoostFieldMatch|
| ESPreventAutoTruncate|
+--+

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-04-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #32 from Thomas Klausner  ---
I created bug 39526 for unifying the syspref variable names

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-04-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Thomas Klausner  changed:

   What|Removed |Added

 Attachment #180058|0   |1
is obsolete||

--- Comment #31 from Thomas Klausner  ---
Created attachment 180326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180326&action=edit
Bug 38694: Unit tests

Adjust existing and add new

Signed-off-by: Matthias Meusburger 
Signed-off-by: Thomas Klausner 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-04-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Thomas Klausner  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-04-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Thomas Klausner  changed:

   What|Removed |Added

 QA Contact|[email protected] |[email protected]
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-03-31 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Attachment #179941|0   |1
is obsolete||

--- Comment #25 from Nick Clemens (kidclamp)  ---
Created attachment 179970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179970&action=edit
Bug 38694: Unit tests

Adjust existing and add new

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-03-31 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Matthias Meusburger  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-03-31 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Matthias Meusburger  changed:

   What|Removed |Added

 Attachment #179970|0   |1
is obsolete||

--- Comment #28 from Matthias Meusburger  ---
Created attachment 180058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180058&action=edit
Bug 38694: Unit tests

Adjust existing and add new

Signed-off-by: Matthias Meusburger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-03-31 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Matthias Meusburger  changed:

   What|Removed |Added

 CC||matthias.meusburger@biblibr
   ||e.com

--- Comment #26 from Matthias Meusburger  ---
Works as described in the test plan.

However, please note that biblionumber rank may affect precedence in the first
results.

I'm signing this patch off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-03-31 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #23 from Nick Clemens (kidclamp)  ---
Created attachment 179941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179941&action=edit
Bug 38694: Unit tests

Adjust existing and add new

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-03-31 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Attachment #175840|0   |1
is obsolete||
 Attachment #175841|0   |1
is obsolete||
 Attachment #175842|0   |1
is obsolete||

--- Comment #22 from Nick Clemens (kidclamp)  ---
Created attachment 179940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179940&action=edit
Bug 38694: Add ESBoostFieldMatch option to Elasticsearch

What this patch does is:
1 - Wraps the existing search code in a a "bool" compound query as a "must".
This should not affect
relevancy or results of the existing searches.
2 - Before we clean/truncate terms, loop through the passed in search terms and
indexes to build a
new 'should' query, using the 'match' on the specified index/field that is
added to the 'bool' query from above.
This means that if a result from the original query is also returned here,
that item will be boosted in the result.
For searches on 'keyword' or 'title', or if no index is set, we use
'title-cover' as the most narrow form of title

This query isn't going to help when users enter CCL (i.e. ti:To die for) and it
won't boost titles from 505, series, etc
when doing a general search. Nor will it have a detrimental effect, it will
only boost field matches

To test:
1 - Add a record with
245 $a novel
2 - Add a record with
245 $a A novel : $b about things / $c by me
3 - Search for: novel
4 - Search for: a novel
5 - Apply patch, restart all, enable ESBoostFieldMatch option
6 - Repeat searches, note exact titles are boosted
7 - Experiment with other searches, turniung pref on and off to verify relevant
titles are boosted when enabled
8 - Search results when disabled should not change

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-01-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #21 from Katrin Fischer  ---

> I am happy not to tidy anymore ;-) I think too, separate patches mean the
> devs can provide (to make QA scripts green) and RM can ignore (to make Joubu
> green)

:D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-01-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #20 from Nick Clemens (kidclamp)  ---
(In reply to Jonathan Druart from comment #19)
> (In reply to David Cook from comment #18)
> > (In reply to Katrin Fischer from comment #17)
> > > I think I see Joubu's point. As we plan to do the clean-up this cycle. Do
> > > you see an advantage of continuing?
> > 
> > Until the existing code is tidied, it's going to make patches harder to
> > review. I think that's part of why we have separate tidy patches. 
> > 
> > I guess it all comes down to timing. In theory, if we do the tidy in the
> > main patch, and the existing codebase gets tidied, that would probably yield
> > fewer conflicts.
> >
> > Perhaps hypothetical fewer conflicts would be worth having a harder time
> > reviewing for now...
> 
> Not the place to discuss it but quick reply anyway: I have advised already
> (several times) that I will provide a script to easy rebases and that you
> should not worry about that. The tidy patches hitting main before the global
> tidy will generate conflicts however, as the script won't be ready... Anyway
> not a big deal, just ignore this if you disagree, and hopefully everything
> will be tidy soon ;)

I am happy not to tidy anymore ;-) I think too, separate patches mean the devs
can provide (to make QA scripts green) and RM can ignore (to make Joubu green)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2025-01-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #19 from Jonathan Druart  ---
(In reply to David Cook from comment #18)
> (In reply to Katrin Fischer from comment #17)
> > I think I see Joubu's point. As we plan to do the clean-up this cycle. Do
> > you see an advantage of continuing?
> 
> Until the existing code is tidied, it's going to make patches harder to
> review. I think that's part of why we have separate tidy patches. 
> 
> I guess it all comes down to timing. In theory, if we do the tidy in the
> main patch, and the existing codebase gets tidied, that would probably yield
> fewer conflicts.
>
> Perhaps hypothetical fewer conflicts would be worth having a harder time
> reviewing for now...

Not the place to discuss it but quick reply anyway: I have advised already
(several times) that I will provide a script to easy rebases and that you
should not worry about that. The tidy patches hitting main before the global
tidy will generate conflicts however, as the script won't be ready... Anyway
not a big deal, just ignore this if you disagree, and hopefully everything will
be tidy soon ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-23 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #18 from David Cook  ---
(In reply to Katrin Fischer from comment #17)
> I think I see Joubu's point. As we plan to do the clean-up this cycle. Do
> you see an advantage of continuing?

Until the existing code is tidied, it's going to make patches harder to review.
I think that's part of why we have separate tidy patches. 

I guess it all comes down to timing. In theory, if we do the tidy in the main
patch, and the existing codebase gets tidied, that would probably yield fewer
conflicts.

Perhaps hypothetical fewer conflicts would be worth having a harder time
reviewing for now...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-23 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #17 from Katrin Fischer  ---
(In reply to David Cook from comment #16)
> (In reply to Jonathan Druart from comment #15)
> > (In reply to Nick Clemens (kidclamp) from comment #14)
> > > Created attachment 175842 [details] [review] [review] [review]
> > > Bug 38694: Tidy routines for QA
> > 
> > With the current work on bug 38664 I don't think we should continue to
> > provide such patches.
> 
> Wouldn't it make sense to provide such patches until after that work is done?

I think I see Joubu's point. As we plan to do the clean-up this cycle. Do you
see an advantage of continuing?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #16 from David Cook  ---
(In reply to Jonathan Druart from comment #15)
> (In reply to Nick Clemens (kidclamp) from comment #14)
> > Created attachment 175842 [details] [review] [review]
> > Bug 38694: Tidy routines for QA
> 
> With the current work on bug 38664 I don't think we should continue to
> provide such patches.

Wouldn't it make sense to provide such patches until after that work is done?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #15 from Jonathan Druart  ---
(In reply to Nick Clemens (kidclamp) from comment #14)
> Created attachment 175842 [details] [review]
> Bug 38694: Tidy routines for QA

With the current work on bug 38664 I don't think we should continue to provide
such patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Katrin Fischer  changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #14 from Nick Clemens (kidclamp)  ---
Created attachment 175842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175842&action=edit
Bug 38694: Tidy routines for QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #13 from Nick Clemens (kidclamp)  ---
Created attachment 175841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175841&action=edit
Bug 38694: Unit tests

Adjust existing and add new

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Attachment #175459|0   |1
is obsolete||

--- Comment #12 from Nick Clemens (kidclamp)  ---
Created attachment 175840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175840&action=edit
Bug 38694: Add ESBoostFieldMatch option to Elasticsearch

What this patch does is:
1 - Wraps the existing search code in a a "bool" compound query as a "must".
This should not affect
relevancy or results of the existing searches.
2 - Before we clean/truncate terms, loop through the passed in search terms and
indexes to build a
new 'should' query, using the 'match' on the specified index/field that is
added to the 'bool' query from above.
This means that if a result from the original query is also returned here,
that item will be boosted in the result.
For searches on 'keyword' or 'title', or if no index is set, we use
'title-cover' as the most narrow form of title

This query isn't going to help when users enter CCL (i.e. ti:To die for) and it
won't boost titles from 505, series, etc
when doing a general search. Nor will it have a detrimental effect, it will
only boost field matches

To test:
1 - Add a record with
245 $a novel
2 - Add a record with
245 $a A novel : $b about things / $c by me
3 - Search for: novel
4 - Search for: a novel
5 - Apply patch, restart all, enable ESBoostFieldMatch option
6 - Repeat searches, note exact titles are boosted
7 - Experiment with other searches, turniung pref on and off to verify relevant
titles are boosted when enabled
8 - Search results when disabled should not change

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Katrin Fischer  changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #11 from David Cook  ---
(In reply to Nick Clemens (kidclamp) from comment #8)
> You can also improve things by searching with quotes, or searching
> 'title-cover' directly, but none of this restores the ease of title
> searching that users experienced in Zebra. For libraries that switch this is
> really seen as a loss.

Admittedly I have had this conversation with a few libraries for sure.

> The time I have spent explaining to libraries why this isn't a problem would
> be better spent adding the feature they want ;-)

Also relatable haha.

> I am happy to make this optional, but I do think it is a necessary feature
> based on the amount of requests I have received.

That's for explaining more about the background and the patch. That helps a
lot. 

Yeah, I think making it optional is a good idea. Defaulting to off for existing
installs and maybe even defaulting to on for new installs. 

I'll add this to my list of things to review, as it does sound like it could be
valuable. Most of my libraries are on ES now, but I have a few on Zebra still,
and when they switch over... I suspect I'll get more of these queries again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Phil Ringnalda  changed:

   What|Removed |Added

 CC||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Catrina Berka  changed:

   What|Removed |Added

 CC||[email protected]
   ||m

--- Comment #10 from Catrina Berka  ---
We have several libraries that would like exact title search matches to return
higher in the search results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

   Assignee|[email protected] |[email protected]
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Attachment #175423|0   |1
is obsolete||

--- Comment #9 from Nick Clemens (kidclamp)  ---
Created attachment 175459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175459&action=edit
Bug 38694: Title boost ES (WIP)

This patch is a rough example, will need tests and maybe an on/off switch

What this patch does is:
1 - Wraps the existing search code in a a "bool" compound query as a "must".
This should not affect
relevancy or results of the existing searches.
2 - Before we clean/truncate terms, loop through the passed in search terms and
indexes to build a
new 'should' query, using the 'match' on the specified index/field that is
added to the 'bool' query from above.
This means that if a result from the original query is also returned here,
that item will be boosted in the result.
For searches on 'keyword' or 'title', or if no index is set, we use
'title-cover' as the most narrow form of title

This query isn't going to help when users enter CCL (i.e. ti:To die for) and it
won't boost titles from 505, series, etc
when doing a general search. Nor will it have a detrimental effect, it will
only boost field matches

To test:
1 - Add a record with
245 $a novel
2 - Add a record with
245 $a A novel : $b about things / $c by me
3 - Search for: novel
4 - Search for: a novel
5 - Apply patch, restart all
6 - Repeat searches, note exact titles are boosted

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #8 from Nick Clemens (kidclamp)  ---
The problem comes especially when other titles include the full title that is
being searched for.

This patch adds a second query sent to ES along with the user's original query.
The queries are sent as a 'bool' compound search, such that the original query
is a 'must' - so we will only return results that are in the initial query.
The query the patches add is a 'should' query. This simply serves as an
additional boost - so where the title field matches the terms entered exactly
we will boost that result to the top.

To test:
1 - Add a record with 
245 $a novel
2 - Add a record with
245 $a A novel : $b about things / $c by me
3 - Search for: novel
4 - Search for: a novel
5 - Apply patch, restart all
6 - Repeat searches, note exact titles are boosted

It's not going to affect relevancy outside of exact title matches, though I
will follow up with another patch soon - I think we can apply the same logic to
other indexes - i.e. if I am searching for 'title' or 'kw' index - then add
'title-cover' but if I am searching 'subject' then add an field match for
'subject' so that "Underwater basket weaving" would match an exact subject over
a record with "Underwater sealife" "Basket fish" "Weaving fish" (I know, dumb
example)

As for the why of this:
Example from a partner catalog, searching for 'To Die For' - expecting the
David Baldacci book with exact title I get:
A diet to die for
Antiques to die for
U2, Rattle and Hum (track titles contain the three words)
Upstairs Downstairs
many more results
To Die For by David Baldacci

I tried adding a boost of 128 (exponential above others) to title-cover - and
that can get titles up to 4 or 5 in the results lists, but before 'The Help' we
still get:
How to help the earth
Help for the haunted
Help! I'm a prisoner

You can also improve things by searching with quotes, or searching
'title-cover' directly, but none of this restores the ease of title searching
that users experienced in Zebra. For libraries that switch this is really seen
as a loss.

The time I have spent explaining to libraries why this isn't a problem would be
better spent adding the feature they want ;-)

I am happy to make this optional, but I do think it is a necessary feature
based on the amount of requests I have received.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #7 from Katrin Fischer  ---
(In reply to Janusz Kaczmarek from comment #5)
> I would try putting weight 10 for title-no-punctuation and either disable 
> QueryAutoTruncate of put search string in quotes.  Are than the search
> results satisfactory or still not...?

We don't have a test system with data yet, so I cannot test it at the moment.
But I will keep it in mind.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #6 from Janusz Kaczmarek  ---
(In reply to Janusz Kaczmarek from comment #5)
> I would try putting weight 10 for title-no-punctuation and either disable 
> QueryAutoTruncate of put search string in quotes.  Are than the search
> results satisfactory or still not...?

(NB no reindex is necessary after changing the weights.)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #5 from Janusz Kaczmarek  ---
I would try putting weight 10 for title-no-punctuation and either disable 
QueryAutoTruncate of put search string in quotes.  Are than the search results
satisfactory or still not...?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #4 from Katrin Fischer  ---
I had asked about a way to do exact title searches in the Elasticsearch channel
a while ago. We have a lot of special libraries where searching for a "one word
title" can give a lot of results if it's some common word. "Nature" comes to
mind as a popular serial example. They are currently able to do exact search
with Zebra, so it's something we have missed in Elasticsearch so far.

 Can you tell if field boosting is enough here to make it first result?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-13 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #3 from Janusz Kaczmarek  ---
(In reply to David Cook from comment #2)
> A few of my libraries have wanted more exact titles to float to the top of
> the results, and I've found field weighting the title index has been
> sufficient for my expectations and theirs. 

Exactly, I have the same observations--according to my tests and in real world
installations field weighting makes a good job in this regard.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #2 from David Cook  ---
Personally, I've always disliked the query manipulation we did in Zebra. 

A few of my libraries have wanted more exact titles to float to the top of the
results, and I've found field weighting the title index has been sufficient for
my expectations and theirs. 

Can you explain more about what this patch does?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 CC||[email protected],
   ||[email protected],
   ||[email protected]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38694] Boost exact title matches in Elasticsearch

2024-12-12 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38694

--- Comment #1 from Nick Clemens (kidclamp)  ---
Created attachment 175423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175423&action=edit
Bug 38694: Title boost ES (WIP)

This patch is a rough example, needs work and tests

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/