[Koha-bugs] [Bug 38701] Fix HTML validity errors in invoice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38701 Wainui Witika-Park changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz --- Comment #10 from Wainui Witika-Park --- This is in the commit log for 24.11, though not noted here yet. Not backporting to 24.05.x unless requested -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38701] Fix HTML validity errors in invoice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38701 David Nind changed: What|Removed |Added CC||da...@davidnind.com Text to go in the||This fixes some HTML markup release notes||errors on the Acquisitions ||> Invoices page - it now ||passes W3C HTML validation ||checks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38701] Fix HTML validity errors in invoice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38701 --- Comment #9 from Katrin Fischer --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38701] Fix HTML validity errors in invoice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38701 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38701] Fix HTML validity errors in invoice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38701 Emily Lamancusa (emlam) changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov Status|Signed Off |Passed QA QA Contact|testo...@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov --- Comment #8 from Emily Lamancusa (emlam) --- Awesome, thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38701] Fix HTML validity errors in invoice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38701 Emily Lamancusa (emlam) changed: What|Removed |Added Attachment #175469|0 |1 is obsolete|| --- Comment #7 from Emily Lamancusa (emlam) --- Created attachment 175805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175805&action=edit Bug 38701: Fix HTML validity errors in invoice template This patch makes some markup corrections to acqui/invoice.tt so that it passes an HTML validity check. - Moves incorrectly placed - Change to and remove invalid - Correct instances of "" (th cannot be self-closed) - Add id attribute to inputs to correspond to existing labels - Change "all_fund_dropdown" markup so that it validates but still works with the active/inactive fund display. To test, apply the patch and go to Acquisitions -> Invoices. Perform an invoice search which will return results. In the results click the invoice number to view the invoice. - Test the "show inactive" checkbox corresponding to the "Shipping fund" dropdown. Checking and unchecking it should work correctly to show and hide inactive funds. - Run the page source through https://validator.w3.org and confirm that there are no errors coming from this template. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38701] Fix HTML validity errors in invoice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38701 --- Comment #6 from Phil Ringnalda --- Sigh. Never mind me, I carefully validated aqbudgets.tt after I created an inactive budget, and didn't validate invoice.tt at all. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38701] Fix HTML validity errors in invoice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38701 --- Comment #5 from Phil Ringnalda --- Ah, I didn't look at what the duplicate IDs did, only that they were from includes. Yeah, having duplicate IDs in unused and unshown code isn't severe. And it's been long enough since I last used a screen reader or had one installed that I don't actually know whether they now do a good job with , reading it as "No value selected" or something similar. Might be clear as a bell how to set a budget to the value "Not restricted to one library" or it might be impossible to tell when you have. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38701] Fix HTML validity errors in invoice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38701 --- Comment #4 from Owen Leonard --- (In reply to Phil Ringnalda from comment #3) > we have several > severe validation errors that don't come from "this template." Can you elaborate? I don't get any "severe" validations errors at all. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38701] Fix HTML validity errors in invoice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38701 Phil Ringnalda changed: What|Removed |Added CC||p...@chetcolibrary.org --- Comment #3 from Phil Ringnalda --- TIL an inactive fund is any fund in an inactive budget, and, we have several severe validation errors that don't come from "this template." :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38701] Fix HTML validity errors in invoice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38701 Phil Ringnalda changed: What|Removed |Added Attachment #175457|0 |1 is obsolete|| --- Comment #2 from Phil Ringnalda --- Created attachment 175469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175469&action=edit Bug 38701: Fix HTML validity errors in invoice template This patch makes some markup corrections to acqui/invoice.tt so that it passes an HTML validity check. - Moves incorrectly placed - Change to and remove invalid - Correct instances of "" (th cannot be self-closed) - Add id attribute to inputs to correspond to existing labels - Change "all_fund_dropdown" markup so that it validates but still works with the active/inactive fund display. To test, apply the patch and go to Acquisitions -> Invoices. Perform an invoice search which will return results. In the results click the invoice number to view the invoice. - Test the "show inactive" checkbox corresponding to the "Shipping fund" dropdown. Checking and unchecking it should work correctly to show and hide inactive funds. - Run the page source through https://validator.w3.org and confirm that there are no errors coming from this template. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38701] Fix HTML validity errors in invoice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38701 Phil Ringnalda changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38701] Fix HTML validity errors in invoice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38701 --- Comment #1 from Owen Leonard --- Created attachment 175457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175457&action=edit Bug 38701: Fix HTML validity errors in invoice template This patch makes some markup corrections to acqui/invoice.tt so that it passes an HTML validity check. - Moves incorrectly placed - Change to and remove invalid - Correct instances of "" (th cannot be self-closed) - Add id attribute to inputs to correspond to existing labels - Change "all_fund_dropdown" markup so that it validates but still works with the active/inactive fund display. To test, apply the patch and go to Acquisitions -> Invoices. Perform an invoice search which will return results. In the results click the invoice number to view the invoice. - Test the "show inactive" checkbox corresponding to the "Shipping fund" dropdown. Checking and unchecking it should work correctly to show and hide inactive funds. - Run the page source through https://validator.w3.org and confirm that there are no errors coming from this template. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38701] Fix HTML validity errors in invoice template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38701 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
