[Koha-bugs] [Bug 38714] Adjust templates for prettier

2026-03-23 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Owen Leonard  changed:

   What|Removed |Added

 Blocks||42154


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42154
[Bug 42154] Bug 38714 hid the "New match check" link in record matching rules
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2026-02-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714
Bug 38714 depends on bug 38900, which changed state.

Bug 38900 Summary: Translation script explodes without a meaningful error when 
an "incorrect" structure is found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38900

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-10-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714
Bug 38714 depends on bug 38713, which changed state.

Bug 38713 Summary: Incorrect HTML structures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38713

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-10-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Nick Clemens (kidclamp)  changed:

   What|Removed |Added

 Blocks||41065


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41065
[Bug 41065] Batch patron modification results are no longer displayed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-10-18 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Fridolin Somers  changed:

   What|Removed |Added

 Blocks||40692


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40692
[Bug 40692] Wrong color background in Perl modules page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-10-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||40918


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40918
[Bug 40918] Invoice Adjustment Reason always "No reason" even if report shows a
saved reason
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-10-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to stable|Needs documenting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-10-02 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Jonathan Druart  changed:

   What|Removed |Added

 Version(s)|25.05.00,24.11.05   |25.05.00
released in||

--- Comment #14 from Jonathan Druart  ---
(In reply to Martin Renvoize (ashimema) from comment #13)
> Pushed to 24.11.05

No it has not, see previous comments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-09-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Emily Lamancusa (emlam)  changed:

   What|Removed |Added

 Blocks||40888


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40888
[Bug 40888] and/or/not drop-downs are missing in the Advanced Search form
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-09-24 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Blocks||40870


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40870
[Bug 40870] Fund code is lost when modifying an order in acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-09-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||40743


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40743
[Bug 40743] Unable to select the correct fund when paying invoices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-09-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Emily Lamancusa (emlam)  changed:

   What|Removed |Added

 Blocks||40755


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40755
[Bug 40755] Hold cancellation requests cause error 500 on holds waiting page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-09-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Emily Lamancusa (emlam)  changed:

   What|Removed |Added

 Blocks||40739


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40739
[Bug 40739] Setting TransfersBlockCirc to 'Don't block' does not allow for
scanning to continue
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-08-14 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714
Bug 38714 depends on bug 38832, which changed state.

Bug 38832 Summary: Dead code in catalogue/search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38832

   What|Removed |Added

 Status|Needs documenting   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-07-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Blocks|38664   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664
[Bug 38664] Tidy the whole codebase
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-06-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

--- Comment #13 from Martin Renvoize (ashimema) 
 ---
Pushed to 24.11.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-06-25 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Version(s)|25.05.00|25.05.00,24.11.05
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-06-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Paul Derscheid  changed:

   What|Removed |Added

 Version(s)|25.05.00,24.11.05   |25.05.00
released in||
 CC||[email protected]

--- Comment #12 from Paul Derscheid  ---
I backported a single patch from this bug for an easier backport of Bug 38395. 

Overlooked this when I ran the release-tools.

Removed 24.11.05 from 'Version(s) released in' to avoid future confusion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-06-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Fridolin Somers  changed:

   What|Removed |Added

 CC||[email protected]
   ||m

--- Comment #11 from Fridolin Somers  ---
(In reply to Paul Derscheid from comment #10)
> Nice work everyone!
> 
> Pushed to 24.11.x for 24.11.05

Mheuuu I don't see all commits in 24.11.x, only :
afbf1ea56c Bug 38714: biblio-title.inc [opac]

This is big enhancement so I bet it is normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-05-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Paul Derscheid  changed:

   What|Removed |Added

 Version(s)|25.05.00|25.05.00,24.11.05
released in||
 Status|Pushed to main  |Pushed to stable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-05-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

--- Comment #10 from Paul Derscheid  ---
Nice work everyone!

Pushed to 24.11.x for 24.11.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-05-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Emily Lamancusa (emlam)  changed:

   What|Removed |Added

 Blocks||39864


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39864
[Bug 39864] Cannot save Automatic item modifications by age rules
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-04-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Pedro Amorim  changed:

   What|Removed |Added

 Blocks||39664


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39664
[Bug 39664] Repeatable AV additional fields no longer work
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Owen Leonard  changed:

   What|Removed |Added

 Blocks||39396


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39396
[Bug 39396] Select2 drop-downs in batch item modification are empty
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-02-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Pedro Amorim  changed:

   What|Removed |Added

 Blocks||39178


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39178
[Bug 39178] ILL table does not render when viewing requests of a batch
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-02-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

--- Comment #9 from Katrin Fischer  ---
Pushed for 25.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-02-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||25.05.00
released in||
 Status|Passed QA   |Pushed to main

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-02-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 QA Contact|[email protected] |martin.renvoize@ptfs-europe
   |y.org   |.com
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #8 from Martin Renvoize (ashimema) 
 ---
Looking good, tested well.. I'm happy here.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-02-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-02-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

--- Comment #7 from Jonathan Druart  ---
(In reply to Lucas Gass (lukeg) from comment #5)
> I've tested this with translations and I would add my sign-off line at this
> point.

Added your signed-off-by line to the 225 commits related to this bug that are
on the bug_38664 branch.

Thanks, Lucas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-02-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

--- Comment #6 from Katrin Fischer  ---
(In reply to Lucas Gass (lukeg) from comment #5)
> I've tested this with translations and I would add my sign-off line at this
> point.

Thanks Lucas!

We have some open dependencies here - could you take a look at them as well?
(you might already have tested them with this one. bug 38720 and bug 38838.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-02-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

--- Comment #5 from Lucas Gass (lukeg)  ---
I've tested this with translations and I would add my sign-off line at this
point.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-01-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

--- Comment #4 from Lucas Gass (lukeg)  ---
(In reply to Jonathan Druart from comment #3)
> (In reply to Lucas Gass (lukeg) from comment #2)
> > I did this from outside my k-t-d:
> > 
> > cd /somewhere/outside/your/koha/path
> > git clone https://gitlab.com/joubu/prettier-plugin-jinja-template.git
> > cd /koha-dir
> > yarn install
> > ln -s /path/to/prettier-plugin-jinja-template
> > /path/to/koha/node_modules/prettier-plugin-jinja-template
> > 
> > and then inside my k-t-d:
> > 
> > kohadev-koha@kohadevbox:koha((b54a15b3d6e...))$ prettier
> > koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
> > [error] Cannot find package 'prettier-plugin-jinja-template' imported from
> > /kohadevbox/koha/noop.js
> 
> Yes, within ktd the symlink will be broken.
> 
> BUT! Update:
> 
> I've published our own npm package, see
> https://www.npmjs.com/package/@koha-community/prettier-plugin-template-
> toolkit (README is wrong for 2.0.1, will adjust later, the plugin name is
> prettierrc.js needs to specify the "koha-community" namespace)
> 
> See the following commit on bug_38664:
> Bug 38664: Use our own prettier plugin -
> @koha-community/prettier-plugin-template-toolkit
> 
> 
> I would suggest you to:
> git fetch joubu
> git checkout last commit from bug 38714 on the bug_38664 branch
> git show bug_38664:.prettierrc.js > .prettierrc.js
> git show bug_38664:package.json > package.json
> yarn install
> 
> Now try:
> prettier koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
> 
> => It should return a tidy version of the file.

Thank you, this is working for me using these steps. Now I will test with some
translated interfaces.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-01-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

--- Comment #3 from Jonathan Druart  ---
(In reply to Lucas Gass (lukeg) from comment #2)
> I did this from outside my k-t-d:
> 
> cd /somewhere/outside/your/koha/path
> git clone https://gitlab.com/joubu/prettier-plugin-jinja-template.git
> cd /koha-dir
> yarn install
> ln -s /path/to/prettier-plugin-jinja-template
> /path/to/koha/node_modules/prettier-plugin-jinja-template
> 
> and then inside my k-t-d:
> 
> kohadev-koha@kohadevbox:koha((b54a15b3d6e...))$ prettier
> koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
> [error] Cannot find package 'prettier-plugin-jinja-template' imported from
> /kohadevbox/koha/noop.js

Yes, within ktd the symlink will be broken.

BUT! Update:

I've published our own npm package, see
https://www.npmjs.com/package/@koha-community/prettier-plugin-template-toolkit
(README is wrong for 2.0.1, will adjust later, the plugin name is prettierrc.js
needs to specify the "koha-community" namespace)

See the following commit on bug_38664:
Bug 38664: Use our own prettier plugin -
@koha-community/prettier-plugin-template-toolkit


I would suggest you to:
git fetch joubu
git checkout last commit from bug 38714 on the bug_38664 branch
git show bug_38664:.prettierrc.js > .prettierrc.js
git show bug_38664:package.json > package.json
yarn install

Now try:
prettier koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt

=> It should return a tidy version of the file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-01-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Lucas Gass (lukeg)  changed:

   What|Removed |Added

 CC||[email protected]

--- Comment #2 from Lucas Gass (lukeg)  ---
I did this from outside my k-t-d:

cd /somewhere/outside/your/koha/path
git clone https://gitlab.com/joubu/prettier-plugin-jinja-template.git
cd /koha-dir
yarn install
ln -s /path/to/prettier-plugin-jinja-template
/path/to/koha/node_modules/prettier-plugin-jinja-template

and then inside my k-t-d:

kohadev-koha@kohadevbox:koha((b54a15b3d6e...))$ prettier
koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
[error] Cannot find package 'prettier-plugin-jinja-template' imported from
/kohadevbox/koha/noop.js

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-01-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #1 from Jonathan Druart  ---
This is ready for testing, you can test using the last commit starting with
"Bug 38714" from the branch of bug 38664.

You can test this even if bug 38720 is not in > NSO. We will be able here to
tell if HTML1 is valid or not.

It will be interesting to test the whole translation process:
- generate po files before these patches
- commit koha-10n
- apply patches and generate po files
- compare

- test the UI in translated interfaces

- look at the generated templates and make sure the changes do not break them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-01-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||38900


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38900
[Bug 38900] translation script explodes without meaningful error when
"incorrect" structure is found
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-01-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 38714] Adjust templates for prettier

2025-01-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38714

Jonathan Druart  changed:

   What|Removed |Added

Summary|[OMNIBUS] Adjust templates  |Adjust templates for
   |for prettier|prettier

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/