[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 --- Comment #17 from Katrin Fischer --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Marcel de Rooy changed: What|Removed |Added Attachment #177759|0 |1 is obsolete|| --- Comment #16 from Marcel de Rooy --- Created attachment 178090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178090&action=edit Bug 38767: Add standard class to various statuses in holdings tavle 1. have an item with many statuses including: -checked out -onsite_checkout -in transit -transit requested -lost -damaaged -withdrwan -not for loan -hold waiting at... -recalled -available -in bundle 2. notice when there are multiple statuses the text runs into a single "blob". 3. APPLY PATCH and generate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 4. Statuses are seperated by a break. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Lucas Gass (lukeg) changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #177133|0 |1 is obsolete|| --- Comment #15 from Lucas Gass (lukeg) --- Created attachment 177759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177759&action=edit Bug 38767: Add standard class to various statuses in holdings tavle 1. have an item with many statuses including: -checked out -onsite_checkout -in transit -transit requested -lost -damaaged -withdrwan -not for loan -hold waiting at... -recalled -available -in bundle 2. notice when there are multiple statuses the text runs into a single "blob". 3. APPLY PATCH and generate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 4. Statuses are seperated by a break. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Lucas Gass (lukeg) changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 David Nind changed: What|Removed |Added Text to go in the||This fixes the status release notes||column in the holdings ||table for a record with ||multiple statuses - each ||status is now shown on its ||own line, instead of ||running together. (The CSS ||was updated so that there ||is a holding_status class ||(which is styled as a ||block) and then the ||individual status class, ||for example: Waiting at X ||since Y..) --- Comment #14 from David Nind --- Thanks Phil for the steps to replicate multiple statuses. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 David Nind changed: What|Removed |Added Attachment #176461|0 |1 is obsolete|| --- Comment #13 from David Nind --- Created attachment 177133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177133&action=edit Bug 38767: Add standard class to various statuses in holdings tavle 1. have an item with many statuses including: -checked out -onsite_checkout -in transit -transit requested -lost -damaaged -withdrwan -not for loan -hold waiting at... -recalled -available -in bundle 2. notice when there are multiple statuses the text runs into a single "blob". 3. APPLY PATCH and generate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 4. Statuses are seperated by a break. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 --- Comment #12 from Lucas Gass (lukeg) --- > The affected statuses are intransit, holdonitem, transitrequested, > waitingat, heldfor, bundled, recallwaiting, recalledby, but most of them are > either impossible or more difficult to combine. Thanks Phil, that is a good point to make. You can also check for the existence of the new class and make sure the element is displaying `block`. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 --- Comment #11 from Phil Ringnalda --- For a step 1 that lets you see step 2 without the patch, try: * place an item-specific hold on an item at another branch * check the item in at that branch, giving you intransit+holdonitem * check the item in at the destination, giving you waitingat+heldfor The affected statuses are intransit, holdonitem, transitrequested, waitingat, heldfor, bundled, recallwaiting, recalledby, but most of them are either impossible or more difficult to combine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #176298|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 --- Comment #10 from Lucas Gass (lukeg) --- Created attachment 176461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176461&action=edit Bug 38767: Add standard class to various statuses in holdings tavle 1. have an item with many statuses including: -checked out -onsite_checkout -in transit -transit requested -lost -damaaged -withdrwan -not for loan -hold waiting at... -recalled -available -in bundle 2. notice when there are multiple statuses the text runs into a single "blob". 3. APPLY PATCH and generate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 4. Statuses are seperated by a break. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Lucas Gass (lukeg) changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Lucas Gass (lukeg) changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #9 from Lucas Gass (lukeg) --- (In reply to Owen Leonard from comment #7) > Whether or not the display problem is reproducible, I think we can improve > how the statuses and CSS are handled in order to make simpler and more > flexible. My go-to pattern for this kind of thing is two have one common > class and one specific class. This is what we do in the bibliographic > details on that same page: > > ... > > The "results_summary" class can be used to change the display of all > elements in that "category" (in this case it could be 'display:block'). The > specific class can be used (if necessary) to differentiate that element from > the others in that category. > > Doing it this way means we don't have to keep adding classes to the CSS as > item statuses are created. > > I would suggest something like: > > %s Failing this based on Owen's comment. I'll come back to it ASAP. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 ByWater Sandboxes changed: What|Removed |Added Attachment #176022|0 |1 is obsolete|| --- Comment #8 from ByWater Sandboxes --- Created attachment 176298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176298&action=edit Bug 38767: Add block display for statuses in holdings table 1. have an item with many statuses including: -checked out -onsite_checkout -in transit -transit requested -lost -damaaged -withdrwan -not for loan -hold waiting at... -recalled -available -in bundle 2. notice when there are multiple statuses the text runs into a single "blob". 3. APPLY PATCH and generate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 4. Statuses are seperated by a break. Signed-off-by: William Lavoie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 --- Comment #7 from Owen Leonard --- Whether or not the display problem is reproducible, I think we can improve how the statuses and CSS are handled in order to make simpler and more flexible. My go-to pattern for this kind of thing is two have one common class and one specific class. This is what we do in the bibliographic details on that same page: ... The "results_summary" class can be used to change the display of all elements in that "category" (in this case it could be 'display:block'). The specific class can be used (if necessary) to differentiate that element from the others in that category. Doing it this way means we don't have to keep adding classes to the CSS as item statuses are created. I would suggest something like: %s -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #6 from David Nind --- I had a go at testing, but I was unable to replicate the issue. 1. I set up recalls: - Enable recalls: UseRecalls - Update circulation rules: I used 5 for all of the recall options 2. For a record, changed status to 4- Damaged status: Damaged 3. Checked out an item for the record to a patron 4. Placed a recall on the record (used the koha user in the OPAC to place the recall 5. Checked the item in and confirmed the recall 6. Status column in the holdings table shows as: Damaged Waiting recall at Centerville since 01/02/2025 7. This seems OK to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #175850|0 |1 is obsolete|| --- Comment #5 from Lucas Gass (lukeg) --- Created attachment 176022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176022&action=edit Bug 38767: Add block display for statuses in holdings table 1. have an item with many statuses including: -checked out -onsite_checkout -in transit -transit requested -lost -damaaged -withdrwan -not for loan -hold waiting at... -recalled -available -in bundle 2. notice when there are multiple statuses the text runs into a single "blob". 3. APPLY PATCH and generate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) 4. Statuses are seperated by a break. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 --- Comment #4 from Lucas Gass (lukeg) --- > Could you fix the actual problem ones by just adding their class to the > classes that are set to display: block? Sounds good to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 38767] Statuses in the holdings table should have block display, not inline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38767 Lucas Gass (lukeg) changed: What|Removed |Added Summary|Statuses in the holdings|Statuses in the holdings |table should be divs not|table should have block |spans |display, not inline -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
