[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-09-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

Martin Renvoize (ashimema)  changed:

   What|Removed |Added

  Text to go in the||ILL batch editing has been
  release notes||improved to allow modifying
   ||batch properties (name,
   ||library, status) without
   ||requiring the addition of
   ||new requests to the batch.
   ||
   ||Previously, when editing an
   ||ILL batch, you were unable
   ||to save changes using the
   ||'Continue' or 'Finish and
   ||view batch' buttons until
   ||you had added at least one
   ||new request by processing
   ||identifiers (such as PubMed
   ||IDs). This workflow was
   ||unnecessarily restrictive
   ||when you simply wanted to
   ||update the batch name,
   ||assigned library, or
   ||status.
   ||
   ||With this enhancement, you
   ||can now edit any batch
   ||properties and save your
   ||changes immediately, making
   ||batch management more
   ||flexible and intuitive.
   ||
   ||**Sponsored by:** UK Health
   ||Security Agency
   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-08-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

Fridolin Somers  changed:

   What|Removed |Added

 Status|Pushed to main  |Needs documenting
 CC||[email protected]
   ||m

--- Comment #17 from Fridolin Somers  ---
Enhancement not pushed to 24.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-05-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

--- Comment #16 from Katrin Fischer  ---
Pushed for 25.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-05-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

Katrin Fischer  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to main
 Version(s)||25.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-05-09 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-05-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

--- Comment #15 from Tomás Cohen Arazi (tcohen)  ---
Created attachment 182117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182117&action=edit
Bug 39179: Allow edit batch without having to add new items

Test plan:
BEFORE APPLYING PATCHES:
1) Enabled ILLModule
2) Install a metadata enrichment plugin .e.g:
https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1
3) Visit ILL requests:
http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl
4) Click 'New ILL requests batch' and pick 'Standard'
5) Enter a name 'test', a cardnumber '42' and any library
6) Click "Continue", enter '123' on the identifiers textarea on the right.
7) Click "Process identifiers"
8) Click "Add items to batch"
9) Click "Finish and view batch"
10) Click 'Batch requests' at the top right of the page.
11) Select the batch you just created and click 'edit'
12) Notice you're unable to 'Continue' or 'Finish and view batch' until you add
some pubmedid and click 'Process identifiers'
APPLY ALL PATCHES
13) Repeat test plan
14) Notice the layout and cosmetic changes.
15) Notice you can now edit a batch without having to add new requests. Edit
the batch name or library or status and click 'Finish and view batch'. Notice
it saves the batch.

Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-05-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

--- Comment #14 from Tomás Cohen Arazi (tcohen)  ---
Created attachment 182116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182116&action=edit
Bug 39179: Adjust modal buttons visibility

1) Hide 'continue' button when its no longer needed
2) Dont display 'finish' button until 'continue' is hidden

Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-05-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

--- Comment #13 from Tomás Cohen Arazi (tcohen)  ---
Created attachment 182115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182115&action=edit
Bug 39179: CSS and layout adjustments:

The layout is now vertical, fieldsets should be shown vertically, not
horizontally.
Border inside the modal no longer exists.
Footer has been readjusted to match other modal footers in Koha, both buttons
on aligned to the right, where first button is accept and 2nd button is cancel.
'Process identifiers' button style has been updated.

Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-05-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

--- Comment #12 from Tomás Cohen Arazi (tcohen)  ---
Created attachment 182114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182114&action=edit
Bug 39179: Update style of 'remove' button when adding requests to batch

Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-05-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

Tomás Cohen Arazi (tcohen)  changed:

   What|Removed |Added

 Attachment #178853|0   |1
is obsolete||
 Attachment #178854|0   |1
is obsolete||
 Attachment #178855|0   |1
is obsolete||
 Attachment #178856|0   |1
is obsolete||
 Attachment #178857|0   |1
is obsolete||

--- Comment #11 from Tomás Cohen Arazi (tcohen)  ---
Created attachment 182113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182113&action=edit
Bug 39179: Update batches table icons

Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-05-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

Tomás Cohen Arazi (tcohen)  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-02-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #178433|0   |1
is obsolete||

--- Comment #6 from Pedro Amorim  ---
Created attachment 178853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178853&action=edit
Bug 39179: Update batches table icons

Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-02-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

Pedro Amorim  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-02-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #178436|0   |1
is obsolete||

--- Comment #9 from Pedro Amorim  ---
Created attachment 178856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178856&action=edit
Bug 39179: Adjust modal buttons visibility

1) Hide 'continue' button when its no longer needed
2) Dont display 'finish' button until 'continue' is hidden

Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-02-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #178437|0   |1
is obsolete||

--- Comment #10 from Pedro Amorim  ---
Created attachment 178857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178857&action=edit
Bug 39179: Allow edit batch without having to add new items

Test plan:
BEFORE APPLYING PATCHES:
1) Enabled ILLModule
2) Install a metadata enrichment plugin .e.g:
https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1
3) Visit ILL requests:
http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl
4) Click 'New ILL requests batch' and pick 'Standard'
5) Enter a name 'test', a cardnumber '42' and any library
6) Click "Continue", enter '123' on the identifiers textarea on the right.
7) Click "Process identifiers"
8) Click "Add items to batch"
9) Click "Finish and view batch"
10) Click 'Batch requests' at the top right of the page.
11) Select the batch you just created and click 'edit'
12) Notice you're unable to 'Continue' or 'Finish and view batch' until you add
some pubmedid and click 'Process identifiers'
APPLY ALL PATCHES
13) Repeat test plan
14) Notice the layout and cosmetic changes.
15) Notice you can now edit a batch without having to add new requests. Edit
the batch name or library or status and click 'Finish and view batch'. Notice
it saves the batch.

Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-02-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #178434|0   |1
is obsolete||

--- Comment #7 from Pedro Amorim  ---
Created attachment 178854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178854&action=edit
Bug 39179: Update style of 'remove' button when adding requests to batch

Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-02-28 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

Pedro Amorim  changed:

   What|Removed |Added

 Attachment #178435|0   |1
is obsolete||

--- Comment #8 from Pedro Amorim  ---
Created attachment 178855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178855&action=edit
Bug 39179: CSS and layout adjustments:

The layout is now vertical, fieldsets should be shown vertically, not
horizontally.
Border inside the modal no longer exists.
Footer has been readjusted to match other modal footers in Koha, both buttons
on aligned to the right, where first button is accept and 2nd button is cancel.
'Process identifiers' button style has been updated.

Sponsored-by: UKHSA - UK Health Security Agency
Signed-off-by: Jeremy Evans 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-02-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

--- Comment #1 from Pedro Amorim  ---
Created attachment 178433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178433&action=edit
Bug 39179: Update batches table icons

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-02-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

--- Comment #4 from Pedro Amorim  ---
Created attachment 178436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178436&action=edit
Bug 39179: Adjust modal buttons visibility

1) Hide 'continue' button when its no longer needed
2) Dont display 'finish' button until 'continue' is hidden

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-02-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

--- Comment #5 from Pedro Amorim  ---
Created attachment 178437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178437&action=edit
Bug 39179: Allow edit batch without having to add new items

Test plan:
BEFORE APPLYING PATCHES:
1) Enabled ILLModule
2) Install a metadata enrichment plugin .e.g:
https://github.com/PTFS-Europe/koha-plugin-api-pubmed/releases/tag/1.1.1
3) Visit ILL requests:
http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl
4) Click 'New ILL requests batch' and pick 'Standard'
5) Enter a name 'test', a cardnumber '42' and any library
6) Click "Continue", enter '123' on the identifiers textarea on the right.
7) Click "Process identifiers"
8) Click "Add items to batch"
9) Click "Finish and view batch"
10) Click 'Batch requests' at the top right of the page.
11) Select the batch you just created and click 'edit'
12) Notice you're unable to 'Continue' or 'Finish and view batch' until you add
some pubmedid and click 'Process identifiers'
APPLY ALL PATCHES
13) Repeat test plan
14) Notice the layout and cosmetic changes.
15) Notice you can now edit a batch without having to add new requests. Edit
the batch name or library or status and click 'Finish and view batch'. Notice
it saves the batch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-02-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

--- Comment #3 from Pedro Amorim  ---
Created attachment 178435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178435&action=edit
Bug 39179: CSS and layout adjustments:

The layout is now vertical, fieldsets should be shown vertically, not
horizontally.
Border inside the modal no longer exists.
Footer has been readjusted to match other modal footers in Koha, both buttons
on aligned to the right, where first button is accept and 2nd button is cancel.
'Process identifiers' button style has been updated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-02-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

--- Comment #2 from Pedro Amorim  ---
Created attachment 178434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178434&action=edit
Bug 39179: Update style of 'remove' button when adding requests to batch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39179] ILL batches should allow editing without having to add new requests

2025-02-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39179

Pedro Amorim  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/