[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 David Nind changed: What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #22 from David Nind --- Bug fix, no updates to the manual required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 Wainui Witika-Park changed: What|Removed |Added Status|Pushed to oldstable |Needs documenting CC||[email protected] ||et.nz --- Comment #21 from Wainui Witika-Park --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 Lari Taskula changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=39014 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable Version(s)|25.11.00,25.05.03 |25.11.00,25.05.03,24.11.09 released in|| CC||[email protected] ||m --- Comment #20 from Fridolin Somers --- Pushed to 24.11.x for 24.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 Paul Derscheid changed: What|Removed |Added Keywords|rel_25_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 Paul Derscheid changed: What|Removed |Added Status|Pushed to main |Pushed to stable Version(s)|25.11.00|25.11.00,25.05.03 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 Paul Derscheid changed: What|Removed |Added Keywords||rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 --- Comment #19 from Paul Derscheid --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 Paul Derscheid changed: What|Removed |Added CC||[email protected] Keywords||rel_25_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 Cécile Garcia-Belmonte changed: What|Removed |Added CC||cecilegarciabelmonte@loiref ||orez.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 --- Comment #18 from Baptiste Wojtkowski (bwoj) --- Created attachment 184742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184742&action=edit [24.11] Bug 39180: Unit tests Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 --- Comment #17 from Baptiste Wojtkowski (bwoj) --- Created attachment 184741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184741&action=edit [24.11] Bug 39180: Add a warning on patron missing guaranor To test: 1 - Create a patron in a category that can be a guarantee and do not assign any guarantor 2 - Create a patron in a 'Child' account type and do not assign a guarantor 3 - Enable system preference 'ChildNeedsGuarantor' 4 - View 'Check out' and 'Details' tabs for both patrons, note there is no warning 5 - Apply patch 6 - Repeat 4, note warning on all pages 7 - Add a patron gaurantor on the child - repeat 4 - warning is gone 8 - Add non-patron guarantor information to other patron - repeat 4 - warning is gone Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 --- Comment #16 from Baptiste Wojtkowski (bwoj) --- Created attachment 184740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184740&action=edit [24.11] Bug 39180: Catch exception when updating patron lastseen date This patch adds a catch during circulatoin actions and passes a message back to the caller For checkouts and renewals we don't have a method for passing messages so we simply catch the exception and warn - this seems reasonable, as we have now added a warning on the patron display that they are missing a guarantor To test: 1 - Create a Child type patron with no guarantor 2 - Create a patron in a non-child category that can_be_guarantee with no guarantor 3 - Check out an item to each patron above 4 - Enable system preference 'ChildNeedsGuarantor' and TrackLastPatronActivityTriggers - select all 5 - In mysql UPDATE borrowers SET datelastseen = '2025-01-01'; 6 - Restart all to clear cache (so update last seen will update) 7 - Attempt to checkout a book to either patron - 500 error 8 - Attempt to returnt he books the patrons have checked out - 500 error 9 - Attempt to renew their items - 500 error 10 - Apply patches, restart all 11 - Repeat checkout, renewal, checkin 12 - On checkout and renewal there should be a warning on the patron page, but actions succeed with no additional problems 13 - On return you get a warning letting you know the action succeeded but there is still a problem to resolve Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 --- Comment #15 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 Lucas Gass (lukeg) changed: What|Removed |Added Version(s)||25.11.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 Lucas Gass (lukeg) changed: What|Removed |Added QA Contact|[email protected] |baptiste.wojtkowski@biblibr |y.org |e.com CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 Baptiste Wojtkowski (bwoj) changed: What|Removed |Added Status|Signed Off |Passed QA CC||baptiste.wojtkowski@biblibr ||e.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 --- Comment #14 from Baptiste Wojtkowski (bwoj) --- Created attachment 184635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184635&action=edit Bug 39180: (QA follow-up) Tidy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 Baptiste Wojtkowski (bwoj) changed: What|Removed |Added Attachment #183086|0 |1 is obsolete|| --- Comment #13 from Baptiste Wojtkowski (bwoj) --- Created attachment 184634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184634&action=edit Bug 39180: Unit tests Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 Baptiste Wojtkowski (bwoj) changed: What|Removed |Added Attachment #183085|0 |1 is obsolete|| --- Comment #12 from Baptiste Wojtkowski (bwoj) --- Created attachment 184633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184633&action=edit Bug 39180: Add a warning on patron missing guaranor To test: 1 - Create a patron in a category that can be a guarantee and do not assign any guarantor 2 - Create a patron in a 'Child' account type and do not assign a guarantor 3 - Enable system preference 'ChildNeedsGuarantor' 4 - View 'Check out' and 'Details' tabs for both patrons, note there is no warning 5 - Apply patch 6 - Repeat 4, note warning on all pages 7 - Add a patron gaurantor on the child - repeat 4 - warning is gone 8 - Add non-patron guarantor information to other patron - repeat 4 - warning is gone Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 Baptiste Wojtkowski (bwoj) changed: What|Removed |Added Attachment #183084|0 |1 is obsolete|| --- Comment #11 from Baptiste Wojtkowski (bwoj) --- Created attachment 184632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184632&action=edit Bug 39180: Catch exception when updating patron lastseen date This patch adds a catch during circulatoin actions and passes a message back to the caller For checkouts and renewals we don't have a method for passing messages so we simply catch the exception and warn - this seems reasonable, as we have now added a warning on the patron display that they are missing a guarantor To test: 1 - Create a Child type patron with no guarantor 2 - Create a patron in a non-child category that can_be_guarantee with no guarantor 3 - Check out an item to each patron above 4 - Enable system preference 'ChildNeedsGuarantor' and TrackLastPatronActivityTriggers - select all 5 - In mysql UPDATE borrowers SET datelastseen = '2025-01-01'; 6 - Restart all to clear cache (so update last seen will update) 7 - Attempt to checkout a book to either patron - 500 error 8 - Attempt to returnt he books the patrons have checked out - 500 error 9 - Attempt to renew their items - 500 error 10 - Apply patches, restart all 11 - Repeat checkout, renewal, checkin 12 - On checkout and renewal there should be a warning on the patron page, but actions succeed with no additional problems 13 - On return you get a warning letting you know the action succeeded but there is still a problem to resolve Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 David Nind changed: What|Removed |Added Text to go in the||This fixes checking out, release notes||checking in, and renewing ||items for a patron where a ||guarantor is required, and ||they don't have one (where ||the ChildNeedsGuarantor ||system preference is ||enabled). || ||These actions ||are now completed ||correctly, and a warning ||message is now shown on the ||patron's page where a ||guarantor is required and ||they don't have one: ||"System preference ||'ChildNeedsGuarantor' is ||enabled and this patron ||does not have a ||guarantor.". || ||Previously: ||- ||checking items in or out ||generated a 500 error ||message, even though the ||actions were successfully ||completed ||- attempting to ||renew items generated this ||message "Error: Internal ||Server Error" and the items ||were not renewed ||- no ||message was shown on the ||patron page warning that ||they needed a guarantor CC||[email protected] --- Comment #10 from David Nind --- From my testing, everything seems to work as expected. I've attempted a release note - feel free to improve it! Testing notes (using KTD): 1. Step 1: Child type patron with no guarantor: Lisa Charles 2. Step 2: Changed patron category Patron (PT) so that 'Can be guarantee' is set to 'Yes', use Mary Burton 3. Step 5: The column name is lastseen, not datelastseen, so the correct SQL to run is: UPDATE borrowers SET lastseen = '2025-01-01'; 4. Step 7: I get a 500 error when attempting to check out the item, if I look at the patrons page again the item is actually checked out to them (tested for both Lisa and Mary) 5. Step 8: I get a 500 error when attempting to check in the item, if I look at the the patrons page again the item was checked in (tested for both Lisa and Mary) 6. Step 9: I get an "Error: Internal Server Error" in a yellow information box at the top of the patrons page when trying to renew the item. 7. After the patch: Creating a patron in the Kid category (category type = Child) or a patron category where "Can be guarantee" (Patron > Category type = "Adult"), and don't add a guarantor - you get this message: The following fields are wrong. Please fix them. A child patron needs a guarantor. 8. Error updating patron's last seen date - there are two H3 headings: H3 heading, the title check in message is also an H3: Check in message <--H3 301396: Philippics. Error updating patron's last seen date <-- H3 as well The item has been checked in, but the issue below must be corrected: The system encountered an error when updating the patron's last seen date: [Child patron needs a guarantor] 9. Tests pass: prove t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koh
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 David Nind changed: What|Removed |Added Attachment #182693|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 183086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183086&action=edit Bug 39180: Unit tests Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 David Nind changed: What|Removed |Added Attachment #182692|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 183085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183085&action=edit Bug 39180: Add a warning on patron missing guaranor To test: 1 - Create a patron in a category that can be a guarantee and do not assign any guarantor 2 - Create a patron in a 'Child' account type and do not assign a guarantor 3 - Enable system preference 'ChildNeedsGuarantor' 4 - View 'Check out' and 'Details' tabs for both patrons, note there is no warning 5 - Apply patch 6 - Repeat 4, note warning on all pages 7 - Add a patron gaurantor on the child - repeat 4 - warning is gone 8 - Add non-patron guarantor information to other patron - repeat 4 - warning is gone Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 David Nind changed: What|Removed |Added Attachment #182691|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 183084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183084&action=edit Bug 39180: Catch exception when updating patron lastseen date This patch adds a catch during circulatoin actions and passes a message back to the caller For checkouts and renewals we don't have a method for passing messages so we simply catch the exception and warn - this seems reasonable, as we have now added a warning on the patron display that they are missing a guarantor To test: 1 - Create a Child type patron with no guarantor 2 - Create a patron in a non-child category that can_be_guarantee with no guarantor 3 - Check out an item to each patron above 4 - Enable system preference 'ChildNeedsGuarantor' and TrackLastPatronActivityTriggers - select all 5 - In mysql UPDATE borrowers SET datelastseen = '2025-01-01'; 6 - Restart all to clear cache (so update last seen will update) 7 - Attempt to checkout a book to either patron - 500 error 8 - Attempt to returnt he books the patrons have checked out - 500 error 9 - Attempt to renew their items - 500 error 10 - Apply patches, restart all 11 - Repeat checkout, renewal, checkin 12 - On checkout and renewal there should be a warning on the patron page, but actions succeed with no additional problems 13 - On return you get a warning letting you know the action succeeded but there is still a problem to resolve Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 Nick Clemens (kidclamp) changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #181941|0 |1 is obsolete|| --- Comment #4 from Nick Clemens (kidclamp) --- Created attachment 182691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182691&action=edit Bug 39180: Catch exception when updating patron lastseen date This patch adds a catch during circulatoin actions and passes a message back to the caller For checkouts and renewals we don't have a method for passing messages so we simply catch the exception and warn - this seems reasonable, as we have now added a warning on the patron display that they are missing a guarantor To test: 1 - Create a Child type patron with no guarantor 2 - Create a patron in a non-child category that can_be_guarantee with no guarantor 3 - Check out an item to each patron above 4 - Enable system preference 'ChildNeedsGuarantor' and TrackLastPatronActivityTriggers - select all 5 - In mysql UPDATE borrowers SET datelastseen = '2025-01-01'; 6 - Restart all to clear cache (so update last seen will update) 7 - Attempt to checkout a book to either patron - 500 error 8 - Attempt to returnt he books the patrons have checked out - 500 error 9 - Attempt to renew their items - 500 error 10 - Apply patches, restart all 11 - Repeat checkout, renewal, checkin 12 - On checkout and renewal there should be a warning on the patron page, but actions succeed with no additional problems 13 - On return you get a warning letting you know the action succeeded but there is still a problem to resolve -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 --- Comment #6 from Nick Clemens (kidclamp) --- Created attachment 182693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182693&action=edit Bug 39180: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 --- Comment #5 from Nick Clemens (kidclamp) --- Created attachment 182692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182692&action=edit Bug 39180: Add a warning on patron missing guaranor To test: 1 - Create a patron in a category that can be a guarantee and do not assign any guarantor 2 - Create a patron in a 'Child' account type and do not assign a guarantor 3 - Enable system preference 'ChildNeedsGuarantor' 4 - View 'Check out' and 'Details' tabs for both patrons, note there is no warning 5 - Apply patch 6 - Repeat 4, note warning on all pages 7 - Add a patron gaurantor on the child - repeat 4 - warning is gone 8 - Add non-patron guarantor information to other patron - repeat 4 - warning is gone -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 Nick Clemens (kidclamp) changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 Nick Clemens (kidclamp) changed: What|Removed |Added Depends on||12133 CC||[email protected] See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=37439 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 [Bug 12133] Guarantor requirements when registering a patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 --- Comment #3 from Martin Renvoize (ashimema) --- Are you coming back to this one Nick.. it's still marked as NEW.. I like the direction of travel but it sounds like there's a little more to go before NSO? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 --- Comment #2 from Andrew Fuerste-Henry --- (In reply to Nick Clemens (kidclamp) from comment #1) > Created attachment 181941 [details] [review] > Bug 39180: Catch exception when updating patron lastseen date > > This patch adds a catch during checkin and passes a message back to the > caller > > For checkouts and renewals we don't have a method for passing messages so we > simply catch the exception > and warn - this seems reasonable, I think we should add a warning on the > patron display that a required guarantor > is missing, but not break circulation. > > We will need to add unit tests The general approach here is good, but the popup at checkin should tell the user more specifically what has happened. Something like "This item has been checked-in, but the following warning still needs to be addressed: [Child patron needs a guarantor]." If we put some obvious alert in the patron record, we don't need to give a special message at checkout and renewal. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 Andrew Fuerste-Henry changed: What|Removed |Added CC||[email protected] ||o.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39180] Handle and report exception at checkout/checkin due to missing guarantor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39180 --- Comment #1 from Nick Clemens (kidclamp) --- Created attachment 181941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181941&action=edit Bug 39180: Catch exception when updating patron lastseen date This patch adds a catch during checkin and passes a message back to the caller For checkouts and renewals we don't have a method for passing messages so we simply catch the exception and warn - this seems reasonable, I think we should add a warning on the patron display that a required guarantor is missing, but not break circulation. We will need to add unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
