[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Laura Escamilla changed: What|Removed |Added CC||Laura.escamilla@bywatersolu ||tions.com Status|Pushed to main |Needs documenting --- Comment #207 from Laura Escamilla --- This is an enhancement and will not be backported to the 25.05.x branch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Bug 39190 depends on bug 39488, which changed state. Bug 39488 Summary: Update Koha::Object(s) to allow for polymorphic classing https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39488 What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks|37248 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37248 [Bug 37248] [Omnibus] Power to the user -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=38739 --- Comment #200 from Jonathan Druart --- Please use main-container.inc, see bug 38739. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #199 from Jonathan Druart --- It's not possible to edit "An error occurred trying to open the server for editing. The passed ID is invalid." You passed file_transport_id and retrieve sftp_server_id -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Jonathan Druart changed: What|Removed |Added CC||[email protected] --- Comment #198 from Jonathan Druart --- +unless !$sftp_server_id; Why?? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #203 from Jonathan Druart --- (In reply to Martin Renvoize (ashimema) from comment #202) > (In reply to Jonathan Druart from comment #200) > > Please use main-container.inc, see bug 38739. > > Pretty sure this wasn't introduced in this patchset but rather the one > before it.. either way I'll fix it It's fixed already on bug 38739 ;-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Keywords|release-notes-needed| Text to go in the||The SFTP server release notes||configuration (introduced ||in Bug 35761) has been ||significantly enhanced and ||renamed to 'File ||transports' to support ||multiple transport ||protocols through a ||polymorphic architecture. || ||This enhancement adds full ||transport protocol handling ||for both FTP and SFTP ||connections, including ||connection testing and SSH ||key management for SFTP. ||The system now uses ||polymorphic classes that ||automatically instantiate ||the correct transport ||handler (FTP or SFTP) based ||on the configured protocol ||type. || ||**Key features:** || ||- **Automatic connection ||testing**: When saving a ||transport configuration, ||Koha now tests the ||connection in the ||background and stores ||detailed status information ||- **SFTP key handling**: ||SSH private keys for SFTP ||connections are securely ||stored and automatically ||written to the filesystem ||when needed ||- **Protocol-specific ||methods**: Each transport ||type (FTP/SFTP) has its own ||specialised connection ||handling whilst sharing ||common configuration ||storage ||- **Enhanced status ||reporting**: Connection ||status is now stored as ||detailed JSON data rather ||than simple text ||- **Renamed ||administration**: The admin ||interface and API have been ||renamed from 'sftp_servers' ||to 'file_transports' to ||reflect the multi-protocol ||nature || ||**Technical changes:** || ||- New base class ||`Koha::File::Transport` ||handles configuration ||storage ||- Protocol-specific ||subclasses ||`Koha::File::
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #201 from Martin Renvoize (ashimema) --- (In reply to Jonathan Druart from comment #199) > It's not possible to edit > > "An error occurred trying to open the server for editing. The passed ID is > invalid." > > You passed file_transport_id and retrieve sftp_server_id This is already fixed inline in bug 38489. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Kyle M Hall (khall) changed: What|Removed |Added Blocks||41020 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41020 [Bug 41020] Add ability to use file transports for marc ordering accounts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #187671|0 |1 is obsolete|| --- Comment #205 from Lucas Gass (lukeg) --- Created attachment 187701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187701&action=edit Bug 39190: Fix DB struct diff Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #206 from Lucas Gass (lukeg) --- follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Lucas Gass (lukeg) changed: What|Removed |Added Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Pushed to main |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #204 from Jonathan Druart --- Created attachment 187671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187671&action=edit Bug 39190: Fix DB struct diff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #202 from Martin Renvoize (ashimema) --- (In reply to Jonathan Druart from comment #200) > Please use main-container.inc, see bug 38739. Pretty sure this wasn't introduced in this patchset but rather the one before it.. either way I'll fix it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks|38115 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38115 [Bug 38115] Add FTP support to export_records.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks|33308 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33308 [Bug 33308] Add ability to to use SFTP with runreport.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks|38629 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38629 [Bug 38629] Update sftp_file.pl to support the new SFTP configurations page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks||37248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37248 [Bug 37248] [Omnibus] Power to the user -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks||33308 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33308 [Bug 33308] Add ability to to use SFTP with runreport.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks||38489 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38489 [Bug 38489] EDI should be updated to use the new FTP/SFTP Servers management page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Blocks||38629 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38629 [Bug 38629] Update sftp_file.pl to support the new SFTP configurations page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Lucas Gass (lukeg) changed: What|Removed |Added Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #186 from Tomás Cohen Arazi (tcohen) --- Created attachment 186425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186425&action=edit Bug 39190: Adjust schema to new structure Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Lucas Gass (lukeg) changed: What|Removed |Added Status|Patch doesn't apply |Passed QA --- Comment #194 from Lucas Gass (lukeg) --- OK, I skipped the schema update commit in 35761 and added my own commit for the DBIC update, that is what is making this not apply clean. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #196 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Lucas Gass (lukeg) changed: What|Removed |Added Keywords||release-notes-needed --- Comment #197 from Lucas Gass (lukeg) --- Can you please add some release notes? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Lucas Gass (lukeg) changed: What|Removed |Added Version(s)||25.11.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #195 from Lucas Gass (lukeg) --- Created attachment 186628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186628&action=edit Bug 39190: Fix t/Koha/Auth/Permissions.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Lucas Gass (lukeg) changed: What|Removed |Added Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #193 from Tomás Cohen Arazi (tcohen) --- Created attachment 186619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186619&action=edit Bug 39190: (follow-up) Two QA fixes This patch: * Removes unused logger object instantiation * Adds missing Test::NoWarnings to the API tests Signed-off-by: Tomás Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #183 from Tomás Cohen Arazi (tcohen) --- Created attachment 186422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186422&action=edit Bug 39190: Update API's to reference new classes Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #174 from Tomás Cohen Arazi (tcohen) --- Created attachment 186413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186413&action=edit Bug 39190: Update sftp_servers page to use new objects Similar to the previous commit, this time we're updating the page controller to use the new polymorphic classes Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #182 from Tomás Cohen Arazi (tcohen) --- Created attachment 186421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186421&action=edit Bug 39190: Redirect Schema to new classes Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #175 from Tomás Cohen Arazi (tcohen) --- Created attachment 186414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186414&action=edit Bug 39190: Update status to longtext Update status field to store longtext so we can sore more details information about connection statuses from test connection Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Attachment #185972|0 |1 is obsolete|| --- Comment #169 from Tomás Cohen Arazi (tcohen) --- Created attachment 186408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186408&action=edit Bug 39190: Update polymorhpic base class to identify itself This patch adds _polymorphic_field and _polymorphic_map private methods to the Koha::File::Transports class to more clearly identify this as a polymorphic class base for TestBuilder. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #172 from Tomás Cohen Arazi (tcohen) --- Created attachment 186411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186411&action=edit Bug 39190: Add key handling to SFTP Transports We add triggers to store in the base class and then use them in the SFTP transport class to write out the key file to the filesystem for later use in connect. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #189 from Tomás Cohen Arazi (tcohen) --- Created attachment 186428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186428&action=edit Bug 39190: Regression tests for polymorphic object creation This patch adds comprehensive tests to verify that Koha::File::Transports correctly returns polymorphic objects based on the transport field value. The tests cover: - build_object() polymorphic creation - search() with polymorphic resultset iteration - find() with polymorphic object return To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/File/Transports.t => FAIL: Tests fail - objects return base Koha::File::Transport instead of polymorphic Koha::File::Transport::SFTP/FTP classes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #173 from Tomás Cohen Arazi (tcohen) --- Created attachment 186412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186412&action=edit Bug 39190: Update API to use new Transport classes As the title says, use the new polymorphic classes in the API controllers Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #177 from Tomás Cohen Arazi (tcohen) --- Created attachment 186416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186416&action=edit Bug 39190: Update api tests for status format change Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #184 from Tomás Cohen Arazi (tcohen) --- Created attachment 186423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186423&action=edit Bug 39190: Add transport to test Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #188 from Tomás Cohen Arazi (tcohen) --- Created attachment 186427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186427&action=edit Bug 39190: Fix circular dependency causing C3 MRO failures Resolved circular dependency chain: Transport.pm → TestTransport.pm → Transports.pm → SFTP.pm → Transport.pm Changed 'use Koha::BackgroundJob::TestTransport' to runtime 'require' in the _post_store_trigger method to break the dependency cycle. This fixes the C3 method resolution order failures in Koha::File::Transport::FTP and Koha::File::Transport::SFTP. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #187 from Tomás Cohen Arazi (tcohen) --- Created attachment 186426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186426&action=edit Bug 39190: Adjust permission across the board Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #181 from Tomás Cohen Arazi (tcohen) --- Created attachment 186420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186420&action=edit Bug 39190: Remove replaced test_connection Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #190 from Tomás Cohen Arazi (tcohen) --- Created attachment 186429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186429&action=edit Bug 39190: Rename admin interface from sftp_servers to file_transports Renamed admin interface files and URLs to reflect the evolution from 'SFTP servers' to 'File transports' functionality: - admin/sftp_servers.pl -> admin/file_transports.pl - sftp_servers.tt -> file_transports.tt - Updated all URL references in templates and admin menu - Updated body id from admin_sftp_servers to admin_file_transports The functionality is now future-proof for the addition of new file transports, so the naming should reflect his broader scope. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #178 from Tomás Cohen Arazi (tcohen) --- Created attachment 186417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186417&action=edit Bug 39190: Start of recording status updates from abort Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #192 from Tomás Cohen Arazi (tcohen) --- Created attachment 186431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186431&action=edit Bug 39190: Rename id => file_transport_id and remove mapping Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #191 from Tomás Cohen Arazi (tcohen) --- Created attachment 186430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186430&action=edit Bug 39190: Rename API from sftp_servers to file_transports This patch renames the entire API structure from SFTP-specific to generic file transport terminology to reflect the polymorphic nature of the system. API Changes: - Endpoints: /config/sftp_servers -> /config/file_transports - Parameters: sftp_server_id -> file_transport_id - Definitions: sftp_server -> file_transport - Controller: Config::SFTP::Servers -> Config::File::Transports File Changes: - api/v1/swagger/definitions/sftp_server.yaml -> file_transport.yaml - api/v1/swagger/paths/config_sftp_servers.yaml -> config_file_transports.yaml - Koha/REST/V1/Config/SFTP/Servers.pm -> Koha/REST/V1/Config/File/Transports.pm - t/db_dependent/api/v1/sftp_servers.t -> file_transports.t Updated References: - swagger.yaml: paths, definitions, parameters, tags - Template JavaScript: API URLs and variable names - Controller: package name, variable names, error messages - Tests: endpoints, parameters, descriptions - API mapping: to_api_mapping field name correction To test: 1. Apply this patch 2. Run: yarn api:bundle (to regenerate swagger bundle) 3. Run: prove t/db_dependent/api/v1/file_transports.t 4. All API tests should pass 5. Verify admin interface uses new API endpoints 6. Test CRUD operations work correctly The API now consistently uses 'file_transports' terminology matching the polymorphic file transport system that supports FTP, SFTP, and future transport types. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #185 from Tomás Cohen Arazi (tcohen) --- Created attachment 186424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186424&action=edit Bug 39190: Rename 'sftp_servers' to 'file_transports' Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #180 from Tomás Cohen Arazi (tcohen) --- Created attachment 186419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186419&action=edit Bug 39190: Remove test routine from API Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #179 from Tomás Cohen Arazi (tcohen) --- Created attachment 186418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186418&action=edit Bug 39190: Remove old objects Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #176 from Tomás Cohen Arazi (tcohen) --- Created attachment 186415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186415&action=edit Bug 39190: Re-implement the connection testing We now use background jobs triggered by Transport->store to update the connection status. Status is now a json blob with more details, so we update the api definition to reflect that. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #171 from Tomás Cohen Arazi (tcohen) --- Created attachment 186410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186410&action=edit Bug 39190: Rework (S)FTP into File::Transport classes This patch adds polymorphic transport classes to Koha for FTP and SFTP file transport configurations. We introduce a base class for interacting with the base configuration storage and subclasses to impliment the protocol specific transport handling. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Attachment #185973|0 |1 is obsolete|| Attachment #185974|0 |1 is obsolete|| Attachment #185975|0 |1 is obsolete|| Attachment #185976|0 |1 is obsolete|| Attachment #185977|0 |1 is obsolete|| Attachment #185978|0 |1 is obsolete|| Attachment #185979|0 |1 is obsolete|| Attachment #185980|0 |1 is obsolete|| Attachment #185981|0 |1 is obsolete|| Attachment #185982|0 |1 is obsolete|| Attachment #185983|0 |1 is obsolete|| Attachment #185984|0 |1 is obsolete|| Attachment #185985|0 |1 is obsolete|| Attachment #185986|0 |1 is obsolete|| Attachment #185987|0 |1 is obsolete|| Attachment #185988|0 |1 is obsolete|| Attachment #185989|0 |1 is obsolete|| Attachment #185990|0 |1 is obsolete|| Attachment #185994|0 |1 is obsolete|| Attachment #185995|0 |1 is obsolete|| Attachment #185996|0 |1 is obsolete|| Attachment #185997|0 |1 is obsolete|| Attachment #185998|0 |1 is obsolete|| Attachment #186408|0 |1 is obsolete|| --- Comment #170 from Tomás Cohen Arazi (tcohen) --- Created attachment 186409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186409&action=edit Bug 39190: Update polymorhpic base class to identify itself This patch adds _polymorphic_field and _polymorphic_map private methods to the Koha::File::Transports class to more clearly identify this as a polymorphic class base for TestBuilder. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #168 from Martin Renvoize (ashimema) --- Looking good.. It has my blessing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Kyle M Hall (khall) changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Lucas Gass (lukeg) changed: What|Removed |Added Status|Passed QA |BLOCKED --- Comment #167 from Lucas Gass (lukeg) --- Setting to BLOCKED until Bug 35761 is out of FQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #163 from Tomás Cohen Arazi (tcohen) --- Created attachment 185996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185996&action=edit Bug 39190: Rename admin interface from sftp_servers to file_transports Renamed admin interface files and URLs to reflect the evolution from 'SFTP servers' to 'File transports' functionality: - admin/sftp_servers.pl -> admin/file_transports.pl - sftp_servers.tt -> file_transports.tt - Updated all URL references in templates and admin menu - Updated body id from admin_sftp_servers to admin_file_transports The functionality is now future-proof for the addition of new file transports, so the naming should reflect his broader scope. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #164 from Tomás Cohen Arazi (tcohen) --- Created attachment 185997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185997&action=edit Bug 39190: Rename API from sftp_servers to file_transports This patch renames the entire API structure from SFTP-specific to generic file transport terminology to reflect the polymorphic nature of the system. API Changes: - Endpoints: /config/sftp_servers -> /config/file_transports - Parameters: sftp_server_id -> file_transport_id - Definitions: sftp_server -> file_transport - Controller: Config::SFTP::Servers -> Config::File::Transports File Changes: - api/v1/swagger/definitions/sftp_server.yaml -> file_transport.yaml - api/v1/swagger/paths/config_sftp_servers.yaml -> config_file_transports.yaml - Koha/REST/V1/Config/SFTP/Servers.pm -> Koha/REST/V1/Config/File/Transports.pm - t/db_dependent/api/v1/sftp_servers.t -> file_transports.t Updated References: - swagger.yaml: paths, definitions, parameters, tags - Template JavaScript: API URLs and variable names - Controller: package name, variable names, error messages - Tests: endpoints, parameters, descriptions - API mapping: to_api_mapping field name correction To test: 1. Apply this patch 2. Run: yarn api:bundle (to regenerate swagger bundle) 3. Run: prove t/db_dependent/api/v1/file_transports.t 4. All API tests should pass 5. Verify admin interface uses new API endpoints 6. Test CRUD operations work correctly The API now consistently uses 'file_transports' terminology matching the polymorphic file transport system that supports FTP, SFTP, and future transport types. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #162 from Tomás Cohen Arazi (tcohen) --- Created attachment 185995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185995&action=edit Bug 39190: Fix polymorphic object creation in Koha::Objects This patch fixes polymorphic object creation by ensuring all methods in Koha::Objects that instantiate objects pass the DBIC result to the object_class() method for proper polymorphic resolution. Fixed methods: - find(): Now passes $result to object_class($result) - next(): Now passes $result to object_class($result) - _wrap(): Now passes $_ to object_class($_) in map This enables polymorphic classes like Koha::File::Transports to return the correct subclass (Koha::File::Transport::SFTP, Koha::File::Transport::FTP) based on the transport field value, instead of always returning the base Koha::File::Transport class. To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/File/Transports.t \ t/db_dependent/Koha/File/Transport/SFTP.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #161 from Tomás Cohen Arazi (tcohen) --- Created attachment 185994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185994&action=edit Bug 39190: Regression tests for polymorphic object creation This patch adds comprehensive tests to verify that Koha::File::Transports correctly returns polymorphic objects based on the transport field value. The tests cover: - build_object() polymorphic creation - search() with polymorphic resultset iteration - find() with polymorphic object return To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/File/Transports.t => FAIL: Tests fail - objects return base Koha::File::Transport instead of polymorphic Koha::File::Transport::SFTP/FTP classes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #166 from Tomás Cohen Arazi (tcohen) --- (In reply to Tomás Cohen Arazi (tcohen) from comment #160) > I haven't finished here. The SFTP.t failure hints the class resolution > mechanism is flawed. And I think we should rename all 'sftp*' scripts and > templates right away too. I now finished what I believe this patchset should be like. It is all designed to be pushed in one shot along with bug 35761. RM: please don't push until Martin has given his blessing to the followups. I'm happy to roll back and start over if there's no agreement on some of it. Happy weekend! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #165 from Tomás Cohen Arazi (tcohen) --- Created attachment 185998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185998&action=edit Bug 39190: Rename id => file_transport_id and remove mapping Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #157 from Tomás Cohen Arazi (tcohen) --- Created attachment 185988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185988&action=edit Bug 39190: Adjust schema to new structure Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #145 from Tomás Cohen Arazi (tcohen) --- Created attachment 185976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185976&action=edit Bug 39190: Update sftp_servers page to use new objects Similar to the previous commit, this time we're updating the page controller to use the new polymorphic classes Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #148 from Tomás Cohen Arazi (tcohen) --- Created attachment 185979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185979&action=edit Bug 39190: Update api tests for status format change Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #152 from Tomás Cohen Arazi (tcohen) --- Created attachment 185983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185983&action=edit Bug 39190: Remove replaced test_connection Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #146 from Tomás Cohen Arazi (tcohen) --- Created attachment 185977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185977&action=edit Bug 39190: Update status to longtext Update status field to store longtext so we can sore more details information about connection statuses from test connection Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #160 from Tomás Cohen Arazi (tcohen) --- I haven't finished here. The SFTP.t failure hints the class resolution mechanism is flawed. And I think we should rename all 'sftp*' scripts and templates right away too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #159 from Tomás Cohen Arazi (tcohen) --- Created attachment 185990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185990&action=edit Bug 39190: Fix circular dependency causing C3 MRO failures Resolved circular dependency chain: Transport.pm → TestTransport.pm → Transports.pm → SFTP.pm → Transport.pm Changed 'use Koha::BackgroundJob::TestTransport' to runtime 'require' in the _post_store_trigger method to break the dependency cycle. This fixes the C3 method resolution order failures in Koha::File::Transport::FTP and Koha::File::Transport::SFTP. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #158 from Tomás Cohen Arazi (tcohen) --- Created attachment 185989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185989&action=edit Bug 39190: Adjust permission across the board Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #156 from Tomás Cohen Arazi (tcohen) --- Created attachment 185987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185987&action=edit Bug 39190: Rename 'sftp_servers' to 'file_transports' Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #155 from Tomás Cohen Arazi (tcohen) --- Created attachment 185986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185986&action=edit Bug 39190: Add transport to test Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #153 from Tomás Cohen Arazi (tcohen) --- Created attachment 185984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185984&action=edit Bug 39190: Redirect Schema to new classes Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #154 from Tomás Cohen Arazi (tcohen) --- Created attachment 185985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185985&action=edit Bug 39190: Update API's to reference new classes Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #151 from Tomás Cohen Arazi (tcohen) --- Created attachment 185982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185982&action=edit Bug 39190: Remove test routine from API Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #149 from Tomás Cohen Arazi (tcohen) --- Created attachment 185980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185980&action=edit Bug 39190: Start of recording status updates from abort Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #150 from Tomás Cohen Arazi (tcohen) --- Created attachment 185981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185981&action=edit Bug 39190: Remove old objects Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #147 from Tomás Cohen Arazi (tcohen) --- Created attachment 185978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185978&action=edit Bug 39190: Re-implement the connection testing We now use background jobs triggered by Transport->store to update the connection status. Status is now a json blob with more details, so we update the api definition to reflect that. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #143 from Tomás Cohen Arazi (tcohen) --- Created attachment 185974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185974&action=edit Bug 39190: Add key handling to SFTP Transports We add triggers to store in the base class and then use them in the SFTP transport class to write out the key file to the filesystem for later use in connect. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #144 from Tomás Cohen Arazi (tcohen) --- Created attachment 185975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185975&action=edit Bug 39190: Update API to use new Transport classes As the title says, use the new polymorphic classes in the API controllers Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #142 from Tomás Cohen Arazi (tcohen) --- Created attachment 185973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185973&action=edit Bug 39190: Rework (S)FTP into File::Transport classes This patch adds polymorphic transport classes to Koha for FTP and SFTP file transport configurations. We introduce a base class for interacting with the base configuration storage and subclasses to impliment the protocol specific transport handling. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Attachment #185014|0 |1 is obsolete|| Attachment #185015|0 |1 is obsolete|| Attachment #185016|0 |1 is obsolete|| Attachment #185017|0 |1 is obsolete|| Attachment #185018|0 |1 is obsolete|| Attachment #185019|0 |1 is obsolete|| Attachment #185020|0 |1 is obsolete|| Attachment #185021|0 |1 is obsolete|| Attachment #185022|0 |1 is obsolete|| Attachment #185023|0 |1 is obsolete|| Attachment #185024|0 |1 is obsolete|| Attachment #185025|0 |1 is obsolete|| Attachment #185026|0 |1 is obsolete|| Attachment #185027|0 |1 is obsolete|| Attachment #185028|0 |1 is obsolete|| Attachment #185029|0 |1 is obsolete|| --- Comment #141 from Tomás Cohen Arazi (tcohen) --- Created attachment 185972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185972&action=edit Bug 39190: Update polymorhpic base class to identify itself This patch adds _polymorphic_field and _polymorphic_map private methods to the Koha::File::Transports class to more clearly identify this as a polymorphic class base for TestBuilder. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 --- Comment #140 from Tomás Cohen Arazi (tcohen) --- (In reply to Julian Maurice from comment #123) > I think that polymorphism (at the Koha::Object level) is not the best > solution here. I think the problem is that Koha::File::Transport tries to be > many things at once: it is a database entity and a file transporter. Those > are two very different things. We already have (to some extent) some other classes that could be considered polymorphic: * Background jobs: implement the `_derived_class` method i.e. we search for Koha::BackgroundJob objects then call `->derived_class()` in the caller. This happens in the 'workers' * IdP classes: implement the `upgrade_class` method. Only used for OAuth at the moment but other cases coming (I submitted CAS and Shibboleth classes) * Koha::Account::Line: doesn't implement an upgrade method, Koha::Account can be used with `credits()` and `debits()` to retrieve certain type with the appropriate object type. We might need to revisit them. Will keep thinking about it over the weekend. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #180025|0 |1 is obsolete|| --- Comment #139 from Martin Renvoize (ashimema) --- Created attachment 185029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185029&action=edit Bug 39190: Add transport to test Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #180024|0 |1 is obsolete|| --- Comment #138 from Martin Renvoize (ashimema) --- Created attachment 185028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185028&action=edit Bug 39190: Update API's to reference new classes Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #180023|0 |1 is obsolete|| --- Comment #137 from Martin Renvoize (ashimema) --- Created attachment 185027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185027&action=edit Bug 39190: Redirect Schema to new classes Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #180022|0 |1 is obsolete|| --- Comment #136 from Martin Renvoize (ashimema) --- Created attachment 185026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185026&action=edit Bug 39190: Remove replaced test_connection Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #180021|0 |1 is obsolete|| --- Comment #135 from Martin Renvoize (ashimema) --- Created attachment 185025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185025&action=edit Bug 39190: Remove test routine from API Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #180020|0 |1 is obsolete|| --- Comment #134 from Martin Renvoize (ashimema) --- Created attachment 185024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185024&action=edit Bug 39190: Remove old objects Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #180019|0 |1 is obsolete|| --- Comment #133 from Martin Renvoize (ashimema) --- Created attachment 185023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185023&action=edit Bug 39190: Start of recording status updates from abort Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #180018|0 |1 is obsolete|| --- Comment #132 from Martin Renvoize (ashimema) --- Created attachment 185022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185022&action=edit Bug 39190: Update api tests for status format change Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #180017|0 |1 is obsolete|| --- Comment #131 from Martin Renvoize (ashimema) --- Created attachment 185021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185021&action=edit Bug 39190: Re-implement the connection testing We now use background jobs triggered by Transport->store to update the connection status. Status is now a json blob with more details, so we update the api definition to reflect that. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #180016|0 |1 is obsolete|| --- Comment #130 from Martin Renvoize (ashimema) --- Created attachment 185020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185020&action=edit Bug 39190: DBIC Update Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #180015|0 |1 is obsolete|| --- Comment #129 from Martin Renvoize (ashimema) --- Created attachment 185019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185019&action=edit Bug 39190: Update status to longtext Update status field to store longtext so we can sore more details information about connection statuses from test connection Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39190] Rework new (S)FTP classes to be polymorphic classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39190 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #180014|0 |1 is obsolete|| --- Comment #128 from Martin Renvoize (ashimema) --- Created attachment 185018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185018&action=edit Bug 39190: Update sftp_servers page to use new objects Similar to the previous commit, this time we're updating the page controller to use the new polymorphic classes Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
