[Koha-bugs] [Bug 39258] Remove extra delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258 Fridolin Somers changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Pushed to main |Pushed to stable CC||[email protected] ||m Version(s)|25.05.00|25.05.00,24.11.08 released in|| --- Comment #13 from Fridolin Somers --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39258] Remove extra delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39258] Remove extra delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258 --- Comment #12 from Katrin Fischer --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39258] Remove extra delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258 Phil Ringnalda changed: What|Removed |Added CC||[email protected] --- Comment #11 from Phil Ringnalda --- *** Bug 39586 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39258] Remove extra delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258 David Nind changed: What|Removed |Added Text to go in the||This removes an extra release notes||"Delete" button when ||previewing the SQL for the ||report from the list of ||saved reports page. (The ||duplicate button didn't do ||anything.) CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39258] Remove extra delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258 Andrew Fuerste-Henry changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39258] Remove extra delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258 David Nind changed: What|Removed |Added Attachment #179565|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 179901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179901&action=edit Bug 39258: Remove extra nonfunctional Delete button from report preview modal To test: 1 - save a report 2 - click Preview SQL for that report from the Saved Reports page 3 - see there are two delete buttons 4 - apply patch, reload page 5 - now there is one delete button 6 - confirm that delete button gives a confirmation message and then deletes the report 7 - Install a second language for the intranet 8 - switch to that language and confirm you have just 1 delete button, it is translated, and it works Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39258] Remove extra delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #179499|0 |1 is obsolete|| --- Comment #7 from Andrew Fuerste-Henry --- Created attachment 179565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179565&action=edit Bug 39258: Remove extra nonfunctional Delete button from report preview modal To test: 1 - save a report 2 - click Preview SQL for that report from the Saved Reports page 3 - see there are two delete buttons 4 - apply patch, reload page 5 - now there is one delete button 6 - confirm that delete button gives a confirmation message and then deletes the report 7 - Install a second language for the intranet 8 - switch to that language and confirm you have just 1 delete button, it is translated, and it works -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39258] Remove extra delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258 Emily Lamancusa (emlam) changed: What|Removed |Added QA Contact|baptiste.wojtkowski@biblibr |emily.lamancusa@montgomeryc |e.com |ountymd.gov CC||emily.lamancusa@montgomeryc ||ountymd.gov Status|Signed Off |Passed QA --- Comment #10 from Emily Lamancusa (emlam) --- Looks good, thanks Andrew! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39258] Remove extra delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258 Emily Lamancusa (emlam) changed: What|Removed |Added Attachment #179901|0 |1 is obsolete|| --- Comment #9 from Emily Lamancusa (emlam) --- Created attachment 180530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180530&action=edit Bug 39258: Remove extra nonfunctional Delete button from report preview modal To test: 1 - save a report 2 - click Preview SQL for that report from the Saved Reports page 3 - see there are two delete buttons 4 - apply patch, reload page 5 - now there is one delete button 6 - confirm that delete button gives a confirmation message and then deletes the report 7 - Install a second language for the intranet 8 - switch to that language and confirm you have just 1 delete button, it is translated, and it works Signed-off-by: David Nind Signed-off-by: Emily Lamancusa -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39258] Remove extra delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39258] Remove extra delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258 Katrin Fischer changed: What|Removed |Added Summary|Remove extra Delete button |Remove extra delete button |in report preview modal |in report preview modal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39258] Remove extra delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258 --- Comment #6 from Baptiste Wojtkowski (bwoj) --- Oh sorry for missing that one :O -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39258] Remove extra delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258
Katrin Fischer changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #5 from Katrin Fischer ---
I think you removed the wrong one, the remaining one is not translatable? :)
Delete\
- ' + _("Delete") + '\
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39258] Remove extra Delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258 Baptiste Wojtkowski (bwoj) changed: What|Removed |Added Status|Signed Off |Passed QA CC||baptiste.wojtkowski@biblibr ||e.com QA Contact|[email protected] |baptiste.wojtkowski@biblibr |y.org |e.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39258] Remove extra Delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258 Baptiste Wojtkowski (bwoj) changed: What|Removed |Added Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39258] Remove extra Delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258 Baptiste Wojtkowski (bwoj) changed: What|Removed |Added Attachment #179006|0 |1 is obsolete|| --- Comment #4 from Baptiste Wojtkowski (bwoj) --- Created attachment 179499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179499&action=edit Bug 39258: Delete extra delete button in report preview To test: 1 - save a report 2 - click Preview SQL for that report from the Saved Reports page 3 - see there are two delete buttons 4 - apply patch, reload page 5 - now there is one delete button 6 - confirm that delete button gives a confirmation message and then deletes the report Signed-off-by: Ray Delahunty Signed-off-by: Baptiste Wojtkowski -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39258] Remove extra Delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258 Lisette Scheer changed: What|Removed |Added CC||[email protected] ||m Assignee|[email protected] |[email protected] |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39258] Remove extra Delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258 Ray Delahunty changed: What|Removed |Added CC||[email protected] Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39258] Remove extra Delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #179003|0 |1 is obsolete|| --- Comment #3 from PTFS Europe Sandboxes --- Created attachment 179006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179006&action=edit Bug 39258: Delete extra delete button in report preview To test: 1 - save a report 2 - click Preview SQL for that report from the Saved Reports page 3 - see there are two delete buttons 4 - apply patch, reload page 5 - now there is one delete button 6 - confirm that delete button gives a confirmation message and then deletes the report Signed-off-by: Ray Delahunty -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39258] Remove extra Delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258 --- Comment #1 from Andrew Fuerste-Henry --- Created attachment 179003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179003&action=edit Bug 39258: Delete extra delete button in report preview To test: 1 - save a report 2 - click Preview SQL for that report from the Saved Reports page 3 - see there are two delete buttons 4 - apply patch, reload page 5 - now there is one delete button 6 - confirm that delete button gives a confirmation message and then deletes the report -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39258] Remove extra Delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258 --- Comment #2 from Andrew Fuerste-Henry --- It is perhaps worth noting that the button I remove with this patch doesn't work to begin with :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39258] Remove extra Delete button in report preview modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39258 Andrew Fuerste-Henry changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
