[Koha-bugs] [Bug 39274] HTML bg-* elements are low contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 Wainui Witika-Park changed: What|Removed |Added Status|Pushed to stable|Needs documenting --- Comment #14 from Wainui Witika-Park --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39274] HTML bg-* elements are low contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 Fridolin Somers changed: What|Removed |Added Version(s)|25.05.00|25.05.00,24.11.10 released in|| Status|Pushed to main |Pushed to stable CC||[email protected] ||m --- Comment #13 from Fridolin Somers --- Pushed to 24.11.x for 24.11.10 Thanks a lot for patch ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39274] HTML bg-* elements are low contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 --- Comment #12 from Owen Leonard --- Created attachment 186268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186268&action=edit Bug 39274: [24.11.x] Non public notes are low contrast in the issues table - Previous checkouts This patch reflects some rethinking on my part about how the Bootstrap color classes are meant to be used, and makes some changes which I hope will be more consistent with the Bootstrap 5 documentation while keeping our interface usable. The main difference is in the use of the classes "text-bg-*" and "bg-*-subtle." For example the class "bg-info-subtle" will give an element a subtle colored background. "text-bg-info" will have a more saturated background color. The "text-" part of the class is a reference to the fact that elements with that category of classes will have text color which adapts to provide correct contrast. This patch also makes a minor adjustment to the color used for "warning" type elements (e.g. . I've adjusted the color slightly in order to differentiate it from the "primary" class color we use for submit buttons. To test, apply the patch and rebuil the staff interface CSS. Clear your browser cache if necessary. Checkouts: 1. Have an item with a non-public note. 2. Check it out, it looks fine while under "Today's issues" 3. Set the issuedate to some time in the past `update issues set issuedate = '2025-03-04 15:58:46';` 4. The non-public note should appear in legible red. Return claims: 1. The "Claims" tab on the patron detail and checkout pages already used the "text-bg-*" classes but the "-success" class didn't work well with the tab background color so I removed it. I notice there is a bug in the way the classes change as the tab is activated, but that will have to be dealt with on another bug. Bibliographic details: 1. Place at least one hold and at least one article request on a title. 2. The detail view should show "Holds: 1", and "Article requests: 1" with the numbers in legible Bootstrap badges. Holds: 1. Perform a catalog search which will return multiple titles. 2. Select multiple titles and click "Place hold." 3. Select a patron to place a hold for. 4. Confirm the holds by clicking "Place hold." 5. The holds should now be shown under the heading "Existing holds," with Bootstrap badgets showing the hold count on each. Patrons requesting modification: 1. Submit an update to a patron record via the OPAC. 2. On the patrons home page in the staff interface there should be a "Patrons requesting modifications" link at the top, with a count of pending modifications shown in a Bootstrap badge. Check-ins: 1. Check in an item from a patron account with multiple other checkouts. 2. In the table of checked-in items the patron's remaining checkout count should be shown in a Bootstrap badge. SMTP servers: 1. Go to Administration -> SMTP Servers. 2. Edit at least one server so that debug mode is enabled and it is marked as a default server. 3. In the view of servers, the debug mode and default status should be shown in Bootstrap badges. Plugins: 1. Go to Administration -> Plugins. 2. Upload a plugin if necessary, and check the list of installed plugins when the plugin is disabled and when it is enabled. In both cases the status should appear in a Bootstrap badge. About page: 1. Go to the About page. 2. Under the "Server information" tab, the status of Memcached and Message broker should be shown with a background color--pale blue for okay statuses. Tools home page: 1. If necessary, go to the OPAC and submit at least one comment on a bibliographic record and tag at least one record. 2. In the staff interface, on the Tools home page, the number of tags pending approval and the number of comments awaiting moderation should show in Bootstrap badges. Sponsored-by: Athens County Public Libraries Signed-off-by: Andrew Fuerste Henry Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39274] HTML bg-* elements are low contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 Pedro Amorim changed: What|Removed |Added Keywords||rel_24_11_candidate CC||[email protected] ||k --- Comment #11 from Pedro Amorim --- Any chance for a 24.11.x patch, please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39274] HTML bg-* elements are low contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 Pedro Amorim changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=39000 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39274] HTML bg-* elements are low contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 Owen Leonard changed: What|Removed |Added Blocks||39947 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39947 [Bug 39947] Do not use bg-* Bootstrap classes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39274] HTML bg-* elements are low contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 --- Comment #10 from Katrin Fischer --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39274] HTML bg-* elements are low contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39274] HTML bg-* elements are low contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 Lucas Gass (lukeg) changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39274] HTML bg-* elements are low contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 Lucas Gass (lukeg) changed: What|Removed |Added Attachment #179695|0 |1 is obsolete|| --- Comment #9 from Lucas Gass (lukeg) --- Created attachment 181192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181192&action=edit Bug 39274: Non public notes are low contrast in the issues table - Previous checkouts This patch reflects some rethinking on my part about how the Bootstrap color classes are meant to be used, and makes some changes which I hope will be more consistent with the Bootstrap 5 documentation while keeping our interface usable. The main difference is in the use of the classes "text-bg-*" and "bg-*-subtle." For example the class "bg-info-subtle" will give an element a subtle colored background. "text-bg-info" will have a more saturated background color. The "text-" part of the class is a reference to the fact that elements with that category of classes will have text color which adapts to provide correct contrast. This patch also makes a minor adjustment to the color used for "warning" type elements (e.g. . I've adjusted the color slightly in order to differentiate it from the "primary" class color we use for submit buttons. To test, apply the patch and rebuil the staff interface CSS. Clear your browser cache if necessary. Checkouts: 1. Have an item with a non-public note. 2. Check it out, it looks fine while under "Today's issues" 3. Set the issuedate to some time in the past `update issues set issuedate = '2025-03-04 15:58:46';` 4. The non-public note should appear in legible red. Return claims: 1. The "Claims" tab on the patron detail and checkout pages already used the "text-bg-*" classes but the "-success" class didn't work well with the tab background color so I removed it. I notice there is a bug in the way the classes change as the tab is activated, but that will have to be dealt with on another bug. Bibliographic details: 1. Place at least one hold and at least one article request on a title. 2. The detail view should show "Holds: 1", and "Article requests: 1" with the numbers in legible Bootstrap badges. Holds: 1. Perform a catalog search which will return multiple titles. 2. Select multiple titles and click "Place hold." 3. Select a patron to place a hold for. 4. Confirm the holds by clicking "Place hold." 5. The holds should now be shown under the heading "Existing holds," with Bootstrap badgets showing the hold count on each. Patrons requesting modification: 1. Submit an update to a patron record via the OPAC. 2. On the patrons home page in the staff interface there should be a "Patrons requesting modifications" link at the top, with a count of pending modifications shown in a Bootstrap badge. Check-ins: 1. Check in an item from a patron account with multiple other checkouts. 2. In the table of checked-in items the patron's remaining checkout count should be shown in a Bootstrap badge. SMTP servers: 1. Go to Administration -> SMTP Servers. 2. Edit at least one server so that debug mode is enabled and it is marked as a default server. 3. In the view of servers, the debug mode and default status should be shown in Bootstrap badges. Plugins: 1. Go to Administration -> Plugins. 2. Upload a plugin if necessary, and check the list of installed plugins when the plugin is disabled and when it is enabled. In both cases the status should appear in a Bootstrap badge. About page: 1. Go to the About page. 2. Under the "Server information" tab, the status of Memcached and Message broker should be shown with a background color--pale blue for okay statuses. Tools home page: 1. If necessary, go to the OPAC and submit at least one comment on a bibliographic record and tag at least one record. 2. In the staff interface, on the Tools home page, the number of tags pending approval and the number of comments awaiting moderation should show in Bootstrap badges. Sponsored-by: Athens County Public Libraries Signed-off-by: Andrew Fuerste Henry Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39274] HTML bg-* elements are low contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 Lucas Gass (lukeg) changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39274] HTML bg-* elements are low contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 --- Comment #8 from Lucas Gass (lukeg) --- Firstly, initially this patched seem quite trivial to me but upon review I have more appreciation for the thought and attention to detail needed to get this all working/looking right, so thanks Owen! Every seems to be working great. I have one small nitpick: When checking in items for a patron that has multiple checkouts, you'll see the bg-info-subtle ( light blue ) background with a green link in it. The contrast of this is too low. That is the only instance of this I find. I don't find that to be a big enough blocker to not PQA here. Just wanted to mention it and maybe we can fix in a follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39274] HTML bg-* elements are low contrast
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39274 Lucas Gass (lukeg) changed: What|Removed |Added Summary|HTML text-bg-* elements are |HTML bg-* elements are low |low contrast|contrast -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
