[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Jonathan Druart changed: What|Removed |Added CC||[email protected] --- Comment #12 from Jonathan Druart --- I don't understand this patch. Here is the diff: +[% ELSIF show_priority %] +[% priority | html %] [% END %] Here is the context: [% IF item_level_holds > 0 || show_priority %] [% IF holds_count.defined %][% ITEM_RESULT.holds_count | html %][% END %] [% IF ITEM_RESULT.priority %] [% IF holds_count.defined %] (priority [% ITEM_RESULT.priority | html %]) [% ELSE %] [% ITEM_RESULT.priority | html %] [% END %] [% END %] [% ELSIF show_priority %] [% priority | html %] [% END %] we never reach the ELSIF, we have || show_priority in the first condition. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Jonathan Druart changed: What|Removed |Added Blocks||41010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41010 [Bug 41010] Incorrect show_priority condition in opac-detail -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 --- Comment #13 from Jonathan Druart --- (In reply to Jonathan Druart from comment #12) > I don't understand this patch. > > Here is the diff: > +[% ELSIF show_priority %] > +[% priority | html %] > > [% END %] > > Here is the context: > [% IF item_level_holds > 0 || show_priority %] > > [% IF holds_count.defined %][% > ITEM_RESULT.holds_count | html %][% END %] > [% IF ITEM_RESULT.priority %] > [% IF holds_count.defined %] > (priority [% ITEM_RESULT.priority > | html %]) > [% ELSE %] > [% ITEM_RESULT.priority | html > %] > [% END %] > [% END %] > > [% ELSIF show_priority %] > [% priority | html %] > > [% END %] > > we never reach the ELSIF, we have || show_priority in the first condition. I have opened bug 41010. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Paul Derscheid changed: What|Removed |Added Keywords|rel_24_11_candidate | CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Paul Derscheid changed: What|Removed |Added Status|Pushed to main |Pushed to stable Version(s)|25.05.00|25.05.00,24.11.05 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 --- Comment #11 from Paul Derscheid --- Nice work everyone! Pushed to 24.11.x for 24.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Lucas Gass (lukeg) changed: What|Removed |Added Keywords||rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 --- Comment #10 from Katrin Fischer --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Katrin Fischer changed: What|Removed |Added Version(s)||25.05.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|[email protected] |[email protected] |y.org |o.uk CC||[email protected] ||o.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #181206|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize (ashimema) --- Created attachment 182181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182181&action=edit Bug 39276: Show record level priority in opac detail page To test: 1. Enable Holds history system preference and set the OPACShowHoldQueueDetails to "Show holds and their priority level". 2. Make an item level hold on a record. 3. Make a record level hold on a different record. 4. Login to the OPAC as that patron 5. On the detail page for the item level hold, it works 6. On the detail page for the record level hold, dataTable error 7. APPLY PATCH 8. Try each of the OPAC detail pages again, they should both work. Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 David Nind changed: What|Removed |Added CC||[email protected] --- Comment #8 from David Nind --- Testing notes: 1. Step 1 - Enable the holds history system preference: OPACHoldsHistory -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 David Nind changed: What|Removed |Added Attachment #180996|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 181206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181206&action=edit Bug 39276: Show record level priority in opac detail page To test: 1. Enable Holds history system preference and set the OPACShowHoldQueueDetails to "Show holds and their priority level". 2. Make an item level hold on a record. 3. Make a record level hold on a different record. 4. Login to the OPAC as that patron 5. On the detail page for the item level hold, it works 6. On the detail page for the record level hold, dataTable error 7. APPLY PATCH 8. Try each of the OPAC detail pages again, they should both work. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Lucas Gass (lukeg) changed: What|Removed |Added Assignee|[email protected] |[email protected] Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 --- Comment #6 from Lucas Gass (lukeg) --- Created attachment 180996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180996&action=edit Bug 39276: Show record level priority in opac detail page To test: 1. Enable Holds history system preference and set the OPACShowHoldQueueDetails to "Show holds and their priority level". 2. Make an item level hold on a record. 3. Make a record level hold on a different record. 4. Login to the OPAC as that patron 5. On the detail page for the item level hold, it works 6. On the detail page for the record level hold, dataTable error 7. APPLY PATCH 8. Try each of the OPAC detail pages again, they should both work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Lucas Gass (lukeg) changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276
--- Comment #5 from Lucas Gass (lukeg) ---
(In reply to Lucas Gass (lukeg) from comment #4)
> There seems to be no reason to show the column at all if there are no item
> level holds. You shouldn't be able to mix item level and record level holds.
>
> Then we don't need to pass show_priority to the template either.
Nevermind, we pass priority when the hold is not item level:
623 $hold->itemnumber
624 ? ( $priority{ $hold->itemnumber } = $hold->priority )
625 : ( $template->param( priority => $hold->priority ) );
We just need to show it in the template.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Lucas Gass (lukeg) changed: What|Removed |Added CC||[email protected] --- Comment #4 from Lucas Gass (lukeg) --- There seems to be no reason to show the column at all if there are no item level holds. You shouldn't be able to mix item level and record level holds. Then we don't need to pass show_priority to the template either. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 Michael Adamyk changed: What|Removed |Added CC||michael.adamyk@bywatersolut ||ions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 David Kuhn changed: What|Removed |Added CC||[email protected] --- Comment #3 from David Kuhn --- This error seems to occur on "Next available" holds where there are no item specific holds on the first item shown in the holdings list for the title. Perhaps it's related to the "item hold queue priority" being blank on the first item? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 --- Comment #2 from Owen Leonard --- (In reply to Owen Leonard from comment #1) > This is in main? I'm not seeing an error with any setting of > OPACShowHoldQueueDetails. Whoops never mind, I see it now! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39276] OPACShowHoldQueueDetails datatable warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39276 --- Comment #1 from Owen Leonard --- This is in main? I'm not seeing an error with any setting of OPACShowHoldQueueDetails. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
