[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Fridolin Somers changed: What|Removed |Added Version(s)|25.11.00,25.05.04 |25.11.00,25.05.04,24.11.10 released in|| CC||[email protected] ||m Status|Pushed to stable|Pushed to oldstable --- Comment #52 from Fridolin Somers --- Pushed to 24.11.x for 24.11.10 Thanks a lot for the dedicated patch :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Michaela Sieber changed: What|Removed |Added Keywords|rel_25_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Lauren Denny changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 --- Comment #51 from Michaela Sieber --- Could this please be backported to 24.11.xx ? I think Pedro already provided a patch for 24.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Paul Derscheid changed: What|Removed |Added Version(s)|25.11.00|25.11.00,25.05.04 released in|| Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 --- Comment #50 from Paul Derscheid --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Lucas Gass (lukeg) changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 --- Comment #49 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 --- Comment #48 from Pedro Amorim --- (In reply to Lucas Gass (lukeg) from comment #47) > Pedro, can you double check this test: > > /kohadevbox/koha/t/db_dependent/Koha/ERM/EUsage/CounterFile.t > > It's failing for me locally. Hey, double-checking here, t/db_dependent/Koha/ERM/EUsage/CounterFile.t shouldn't exist anymore, it's been split into 2 different files: t/db_dependent/Koha/ERM/EUsage/COUNTER_5/CounterFile.t t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/CounterFile.t After applying the patchset, all relevant tests (that I'm aware of) are passing for me: prove t/db_dependent/api/v1/erm_usa* prove t/db_dependent/Koha/ERM/EUsage/* prove t/db_dependent/Koha/BackgroundJobs/ErmSushiHarvester.t prove t/db_dependent/api/v1/erm_custom_reports.t prove xt/author/Text_CSV_Various.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Lucas Gass (lukeg) changed: What|Removed |Added CC||[email protected] --- Comment #47 from Lucas Gass (lukeg) --- Pedro, can you double check this test: /kohadevbox/koha/t/db_dependent/Koha/ERM/EUsage/CounterFile.t It's failing for me locally. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 --- Comment #46 from Pedro Amorim --- 24.11.x patch rebased on top of bug 40579 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Pedro Amorim changed: What|Removed |Added Attachment #186044|0 |1 is obsolete|| --- Comment #45 from Pedro Amorim --- Created attachment 186068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186068&action=edit [24.11.x] Bug 39345: 24.11 SQUASH The following tests must pass: prove t/db_dependent/api/v1/erm_usa* prove t/db_dependent/Koha/ERM/EUsage/* prove t/db_dependent/Koha/BackgroundJobs/ErmSushiHarvester.t prove t/db_dependent/api/v1/erm_custom_reports.t prove xt/author/Text_CSV_Various.t Signed-off-by: Eric Phetteplace Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 --- Comment #44 from Pedro Amorim --- Main patches rebased on top bug 40579 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Pedro Amorim changed: What|Removed |Added Attachment #186043|0 |1 is obsolete|| --- Comment #43 from Pedro Amorim --- Created attachment 186067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186067&action=edit Bug 39345: (QA follow-up): Fix erm_custom_reports.t prove t/db_dependent/api/v1/erm_custom_reports.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345
Pedro Amorim changed:
What|Removed |Added
Attachment #185928|0 |1
is obsolete||
--- Comment #42 from Pedro Amorim ---
Created attachment 186066
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186066&action=edit
Bug 39345: (QA follow-up): Add exception handling for unsupported counter
release
To test this on the UI, you can add the following line of code at the beginning
on 'new' in SushiCounter.pm:
->{response}->{Report_Header}->{Release} = 6;
This will force the release to be '6'. Then you can perform a harvest using the
UI. The background job will fail with the error message saying that counter
release 6 is not supported
prove t/db_dependent/Koha/BackgroundJobs/ErmSushiHarvester.t
Signed-off-by: Eric Phetteplace
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Pedro Amorim changed: What|Removed |Added Attachment #185927|0 |1 is obsolete|| --- Comment #41 from Pedro Amorim --- Created attachment 186065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186065&action=edit Bug 39345: (QA follow-up): Fix QA complaints QA script still fails but I believe these are false positives caused by the tests files being moved Signed-off-by: Eric Phetteplace Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Pedro Amorim changed: What|Removed |Added Attachment #185926|0 |1 is obsolete|| --- Comment #40 from Pedro Amorim --- Created attachment 186064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186064&action=edit Bug 39345: (QA follow-up): Fix data provider tests Update original tests to consider COUNTER 5 specifically. Add new test for COUNTER 5.1. Signed-off-by: Eric Phetteplace Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Pedro Amorim changed: What|Removed |Added Attachment #185925|0 |1 is obsolete|| --- Comment #39 from Pedro Amorim --- Created attachment 186063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186063&action=edit Bug 39345: Use data provider report release to establish service URL Signed-off-by: Eric Phetteplace Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Pedro Amorim changed: What|Removed |Added Attachment #185924|0 |1 is obsolete|| --- Comment #38 from Pedro Amorim --- Created attachment 186062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186062&action=edit Bug 39345: Add COUNTER 5.1 Tests JSON data files extracted from sample responses at: https://counter5.cambridge.org/r51/sushi-docs/#/ Additional docs referenced: https://cop5.projectcounter.org/en/5.1/appendices/g-sample-counter-reports-and-standard-views.html Run: prove t/db_dependent/Koha/ERM/EUsage/* Signed-off-by: Eric Phetteplace Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Pedro Amorim changed: What|Removed |Added Attachment #185923|0 |1 is obsolete|| --- Comment #37 from Pedro Amorim --- Created attachment 186061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186061&action=edit Bug 39345: Add COUNTER 5.1 support This moves the original SUSHI COUNTER logic to a new Koha::ERM::EUsage::COUNTER::5 class that extends Koha::ERM::EUsage::SushiCounter. Adds a new Koha::ERM::EUsage::COUNTER::5_1 class with COUNTER 5.1 specific logic. Keeps common logic in Koha::ERM::EUsage::SushiCounter. This ensures we support both COUNTER 5.0 and COUNTER 5.1, but should hopefully help us better maintain COUNTER 5.1 going forward, without having to worry about COUNTER 5.0, as the code is seperated. This should also better set us up for adding support for possible future COUNTER releases. Test plan, k-t-d: 1) Enable ERMModule 2) Add a new usage data provider at: /cgi-bin/koha/erm/eusage/usage_data_providers/add 3) Add the required credential parameters e.g. Customer ID and Requestor ID 4) Update the 'Report release' to '5.1', no single quote. (If you add anything other than '5', it'll default to '5.1') 5) Visit the list of data providers and click the 'Run now' button for your data provider: /cgi-bin/koha/erm/eusage/usage_data_providers 6) Click the background job link at the top. Verify the background job runs as expected. 7) After the successful harvest, run a custom report at, ensure the data is all correct: /cgi-bin/koha/erm/eusage/reports 8) Visit the data provider at: /cgi-bin/koha/erm/eusage/usage_data_providers/ 9) Click the 'Import logs' tab, download the COUNTER 5.1 counter file. Open the file and verify the data is correct. Signed-off-by: Eric Phetteplace Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Pedro Amorim changed: What|Removed |Added Attachment #185922|0 |1 is obsolete|| --- Comment #36 from Pedro Amorim --- Created attachment 186060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186060&action=edit Bug 39345: Preparation: Move original test files We are now considering more than one COUNTER release. Move test files accordingly. prove t/db_dependent/Koha/ERM/EUsage/* Signed-off-by: Eric Phetteplace Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Pedro Amorim changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #31 from Pedro Amorim --- This is causing the following tests to fail: prove t/db_dependent/api/v1/erm_custom_reports.t I'm working on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 David Nind changed: What|Removed |Added Text to go in the||This enhancement adds release notes||support to the ERM module ||for Release 5.1 of the Code ||of Practice for COUNTER ||Metrics that came into ||force in January 2025, with ||a requirement for reports ||to be delivered by the 28th ||of February 2025. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Pedro Amorim changed: What|Removed |Added Attachment #186042|0 |1 is obsolete|| --- Comment #34 from Pedro Amorim --- Created attachment 186044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186044&action=edit [24.11.x] Bug 39345: 24.11 SQUASH prove t/db_dependent/api/v1/erm_usa* prove t/db_dependent/Koha/ERM/EUsage/* prove t/db_dependent/Koha/BackgroundJobs/ErmSushiHarvester.t prove t/db_dependent/api/v1/erm_custom_reports.t Signed-off-by: Eric Phetteplace Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Pedro Amorim changed: What|Removed |Added Attachment #186016|0 |1 is obsolete|| --- Comment #32 from Pedro Amorim --- Created attachment 186042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186042&action=edit [24.11.x] Bug 39345: 24.11 SQUASH prove t/db_dependent/api/v1/erm_usa* prove t/db_dependent/Koha/ERM/EUsage/* prove t/db_dependent/Koha/BackgroundJobs/ErmSushiHarvester.t prove t/db_dependent/api/v1/erm_custom_reports.t Signed-off-by: Eric Phetteplace Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 David Nind changed: What|Removed |Added Keywords||rel_25_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 --- Comment #33 from Pedro Amorim --- Created attachment 186043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186043&action=edit Bug 39345: (QA follow-up): Fix erm_custom_reports.t prove t/db_dependent/api/v1/erm_custom_reports.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Pedro Amorim changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #35 from Pedro Amorim --- Submitted follow up patch for erm_custom_reports.t + added it to the squashed 24.11.x patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 --- Comment #30 from Pedro Amorim --- Created attachment 186016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186016&action=edit [24.11.x] Bug 39345: 24.11 SQUASH prove t/db_dependent/api/v1/erm_usa* prove t/db_dependent/Koha/ERM/EUsage/* prove t/db_dependent/Koha/BackgroundJobs/ErmSushiHarvester.t Signed-off-by: Eric Phetteplace Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Pedro Amorim changed: What|Removed |Added Keywords||rel_24_11_candidate --- Comment #29 from Pedro Amorim --- (In reply to Katrin Fischer from comment #28) > This is marked as enhancement, but please consider for backporting to 24.11 > LTS at least. Thank you! Added the keyword, so that it can be looked at after pushed. Backporting to 24.11 may be annoying due to the tidy stuff but doable ofc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 --- Comment #28 from Katrin Fischer --- This is marked as enhancement, but please consider for backporting to 24.11 LTS at least. Thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345
Nick Clemens (kidclamp) changed:
What|Removed |Added
Attachment #185664|0 |1
is obsolete||
--- Comment #27 from Nick Clemens (kidclamp) ---
Created attachment 185928
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185928&action=edit
Bug 39345: (QA follow-up): Add exception handling for unsupported counter
release
To test this on the UI, you can add the following line of code at the beginning
on 'new' in SushiCounter.pm:
->{response}->{Report_Header}->{Release} = 6;
This will force the release to be '6'. Then you can perform a harvest using the
UI. The background job will fail with the error message saying that counter
release 6 is not supported
prove t/db_dependent/Koha/BackgroundJobs/ErmSushiHarvester.t
Signed-off-by: Eric Phetteplace
Signed-off-by: Nick Clemens
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #185663|0 |1 is obsolete|| --- Comment #26 from Nick Clemens (kidclamp) --- Created attachment 185927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185927&action=edit Bug 39345: (QA follow-up): Fix QA complaints QA script still fails but I believe these are false positives caused by the tests files being moved Signed-off-by: Eric Phetteplace Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #185662|0 |1 is obsolete|| --- Comment #25 from Nick Clemens (kidclamp) --- Created attachment 185926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185926&action=edit Bug 39345: (QA follow-up): Fix data provider tests Update original tests to consider COUNTER 5 specifically. Add new test for COUNTER 5.1. Signed-off-by: Eric Phetteplace Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #185661|0 |1 is obsolete|| --- Comment #24 from Nick Clemens (kidclamp) --- Created attachment 185925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185925&action=edit Bug 39345: Use data provider report release to establish service URL Signed-off-by: Eric Phetteplace Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #185660|0 |1 is obsolete|| --- Comment #23 from Nick Clemens (kidclamp) --- Created attachment 185924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185924&action=edit Bug 39345: Add COUNTER 5.1 Tests JSON data files extracted from sample responses at: https://counter5.cambridge.org/r51/sushi-docs/#/ Additional docs referenced: https://cop5.projectcounter.org/en/5.1/appendices/g-sample-counter-reports-and-standard-views.html Run: prove t/db_dependent/Koha/ERM/EUsage/* Signed-off-by: Eric Phetteplace Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #185659|0 |1 is obsolete|| --- Comment #22 from Nick Clemens (kidclamp) --- Created attachment 185923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185923&action=edit Bug 39345: Add COUNTER 5.1 support This moves the original SUSHI COUNTER logic to a new Koha::ERM::EUsage::COUNTER::5 class that extends Koha::ERM::EUsage::SushiCounter. Adds a new Koha::ERM::EUsage::COUNTER::5_1 class with COUNTER 5.1 specific logic. Keeps common logic in Koha::ERM::EUsage::SushiCounter. This ensures we support both COUNTER 5.0 and COUNTER 5.1, but should hopefully help us better maintain COUNTER 5.1 going forward, without having to worry about COUNTER 5.0, as the code is seperated. This should also better set us up for adding support for possible future COUNTER releases. Test plan, k-t-d: 1) Enable ERMModule 2) Add a new usage data provider at: /cgi-bin/koha/erm/eusage/usage_data_providers/add 3) Add the required credential parameters e.g. Customer ID and Requestor ID 4) Update the 'Report release' to '5.1', no single quote. (If you add anything other than '5', it'll default to '5.1') 5) Visit the list of data providers and click the 'Run now' button for your data provider: /cgi-bin/koha/erm/eusage/usage_data_providers 6) Click the background job link at the top. Verify the background job runs as expected. 7) After the successful harvest, run a custom report at, ensure the data is all correct: /cgi-bin/koha/erm/eusage/reports 8) Visit the data provider at: /cgi-bin/koha/erm/eusage/usage_data_providers/ 9) Click the 'Import logs' tab, download the COUNTER 5.1 counter file. Open the file and verify the data is correct. Signed-off-by: Eric Phetteplace Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Nick Clemens (kidclamp) changed: What|Removed |Added Attachment #185658|0 |1 is obsolete|| --- Comment #21 from Nick Clemens (kidclamp) --- Created attachment 185922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185922&action=edit Bug 39345: Preparation: Move original test files We are now considering more than one COUNTER release. Move test files accordingly. prove t/db_dependent/Koha/ERM/EUsage/* Signed-off-by: Eric Phetteplace Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Nick Clemens (kidclamp) changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Eric Phetteplace changed: What|Removed |Added Attachment #185618|0 |1 is obsolete|| --- Comment #18 from Eric Phetteplace --- Created attachment 185662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185662&action=edit Bug 39345: (QA follow-up): Fix data provider tests Update original tests to consider COUNTER 5 specifically. Add new test for COUNTER 5.1. Signed-off-by: Eric Phetteplace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Eric Phetteplace changed: What|Removed |Added Attachment #185596|0 |1 is obsolete|| --- Comment #17 from Eric Phetteplace --- Created attachment 185661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185661&action=edit Bug 39345: Use data provider report release to establish service URL Signed-off-by: Eric Phetteplace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Eric Phetteplace changed: What|Removed |Added Attachment #185595|0 |1 is obsolete|| --- Comment #16 from Eric Phetteplace --- Created attachment 185660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185660&action=edit Bug 39345: Add COUNTER 5.1 Tests JSON data files extracted from sample responses at: https://counter5.cambridge.org/r51/sushi-docs/#/ Additional docs referenced: https://cop5.projectcounter.org/en/5.1/appendices/g-sample-counter-reports-and-standard-views.html Run: prove t/db_dependent/Koha/ERM/EUsage/* Signed-off-by: Eric Phetteplace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Eric Phetteplace changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345
Eric Phetteplace changed:
What|Removed |Added
Attachment #185621|0 |1
is obsolete||
--- Comment #20 from Eric Phetteplace ---
Created attachment 185664
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185664&action=edit
Bug 39345: (QA follow-up): Add exception handling for unsupported counter
release
To test this on the UI, you can add the following line of code at the beginning
on 'new' in SushiCounter.pm:
->{response}->{Report_Header}->{Release} = 6;
This will force the release to be '6'. Then you can perform a harvest using the
UI. The background job will fail with the error message saying that counter
release 6 is not supported
prove t/db_dependent/Koha/BackgroundJobs/ErmSushiHarvester.t
Signed-off-by: Eric Phetteplace
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Eric Phetteplace changed: What|Removed |Added Attachment #185594|0 |1 is obsolete|| --- Comment #15 from Eric Phetteplace --- Created attachment 185659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185659&action=edit Bug 39345: Add COUNTER 5.1 support This moves the original SUSHI COUNTER logic to a new Koha::ERM::EUsage::COUNTER::5 class that extends Koha::ERM::EUsage::SushiCounter. Adds a new Koha::ERM::EUsage::COUNTER::5_1 class with COUNTER 5.1 specific logic. Keeps common logic in Koha::ERM::EUsage::SushiCounter. This ensures we support both COUNTER 5.0 and COUNTER 5.1, but should hopefully help us better maintain COUNTER 5.1 going forward, without having to worry about COUNTER 5.0, as the code is seperated. This should also better set us up for adding support for possible future COUNTER releases. Test plan, k-t-d: 1) Enable ERMModule 2) Add a new usage data provider at: /cgi-bin/koha/erm/eusage/usage_data_providers/add 3) Add the required credential parameters e.g. Customer ID and Requestor ID 4) Update the 'Report release' to '5.1', no single quote. (If you add anything other than '5', it'll default to '5.1') 5) Visit the list of data providers and click the 'Run now' button for your data provider: /cgi-bin/koha/erm/eusage/usage_data_providers 6) Click the background job link at the top. Verify the background job runs as expected. 7) After the successful harvest, run a custom report at, ensure the data is all correct: /cgi-bin/koha/erm/eusage/reports 8) Visit the data provider at: /cgi-bin/koha/erm/eusage/usage_data_providers/ 9) Click the 'Import logs' tab, download the COUNTER 5.1 counter file. Open the file and verify the data is correct. Signed-off-by: Eric Phetteplace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Eric Phetteplace changed: What|Removed |Added Attachment #185619|0 |1 is obsolete|| --- Comment #19 from Eric Phetteplace --- Created attachment 185663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185663&action=edit Bug 39345: (QA follow-up): Fix QA complaints QA script still fails but I believe these are false positives caused by the tests files being moved Signed-off-by: Eric Phetteplace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Eric Phetteplace changed: What|Removed |Added Attachment #185593|0 |1 is obsolete|| --- Comment #14 from Eric Phetteplace --- Created attachment 185658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185658&action=edit Bug 39345: Preparation: Move original test files We are now considering more than one COUNTER release. Move test files accordingly. prove t/db_dependent/Koha/ERM/EUsage/* Signed-off-by: Eric Phetteplace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345
Pedro Amorim changed:
What|Removed |Added
Attachment #185620|0 |1
is obsolete||
--- Comment #13 from Pedro Amorim ---
Created attachment 185621
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185621&action=edit
Bug 39345: (QA follow-up): Add exception handling for unsupported counter
release
To test this on the UI, you can add the following line of code at the beginning
on 'new' in SushiCounter.pm:
->{response}->{Report_Header}->{Release} = 6;
This will force the release to be '6'. Then you can perform a harvest using the
UI. The background job will fail with the error message saying that counter
release 6 is not supported
prove t/db_dependent/Koha/BackgroundJobs/ErmSushiHarvester.t
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345
--- Comment #12 from Pedro Amorim ---
Created attachment 185620
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185620&action=edit
Bug 39345: (QA follow-up) Add exception handling for unsupported counter
release
To test this on the UI, you can add the following line of code at the beginning
on 'new' in SushiCounter.pm:
->{response}->{Report_Header}->{Release} = 6;
This will force the release to be '6'. Then you can perform a harvest using the
UI. The background job will fail with the error message saying that counter
release 6 is not supported
prove t/db_dependent/Koha/BackgroundJobs/ErmSushiHarvester.t
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Pedro Amorim changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 --- Comment #11 from Pedro Amorim --- Created attachment 185619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185619&action=edit Bug 39345: (QA follow-up): Fix QA complaints QA script still fails but I believe these are false positives caused by the tests files being moved -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 --- Comment #10 from Pedro Amorim --- Created attachment 185618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185618&action=edit Bug 39345: (QA follow-up): Fix data provider tests Update original tests to consider COUNTER 5 specifically. Add new test for COUNTER 5.1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Eric Phetteplace changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #9 from Eric Phetteplace --- Unit tests failed but usage tests succeeded. kohadev-koha@kohadevbox:koha(main)$ prove t/db_dependent/Koha/ERM/EUsage/* t/db_dependent/Koha/ERM/EUsage/COUNTER_5/CounterFile.t . ok t/db_dependent/Koha/ERM/EUsage/COUNTER_5/SushiCounter.t ok t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/CounterFile.t ... ok t/db_dependent/Koha/ERM/EUsage/COUNTER_5.1/SushiCounter.t .. ok t/db_dependent/Koha/ERM/EUsage/CounterLog.t ok t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t . # Failed test at t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t line 73. # got: 'https://service_url.com/r51/reports/tr_j1?customer_id=ID123&requestor_id=REQID123&api_key=APIKEY&begin_date=2023-08&end_date=2023-09' # expected: 'https://service_url.com/reports/tr_j1?customer_id=ID123&requestor_id=REQID123&api_key=APIKEY&begin_date=2023-08&end_date=2023-09' # Failed test at t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t line 106. # got: 'https://service_url.com/r51/reports/tr_j1?customer_id=ID123&requestor_id=REQID123&api_key=APIKEY&begin_date=2023-08&end_date=2023-09&platform=www.whatever.com' # expected: 'https://service_url.com/reports/tr_j1?customer_id=ID123&requestor_id=REQID123&api_key=APIKEY&begin_date=2023-08&end_date=2023-09&platform=www.whatever.com' # Looks like you failed 2 tests of 2. t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t . 1/3 # Failed test '_build_url_query' # at t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t line 113. # Looks like you failed 1 test of 3. t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t . Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report --- t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t (Wstat: 256 (exited 1) Tests: 3 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=6, Tests=47, 8 wallclock secs ( 0.02 usr 0.02 sys + 4.27 cusr 0.73 csys = 5.04 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 --- Comment #8 from Eric Phetteplace --- I will test this today but also with steps to verify no regression to COUNTER v5 providers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 --- Comment #6 from Pedro Amorim --- Created attachment 185595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185595&action=edit Bug 39345: Add COUNTER 5.1 Tests JSON data files extracted from sample responses at: https://counter5.cambridge.org/r51/sushi-docs/#/ Additional docs referenced: https://cop5.projectcounter.org/en/5.1/appendices/g-sample-counter-reports-and-standard-views.html Run: prove t/db_dependent/Koha/ERM/EUsage/* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 --- Comment #7 from Pedro Amorim --- Created attachment 185596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185596&action=edit Bug 39345: Use data provider report release to establish service URL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 --- Comment #5 from Pedro Amorim --- Created attachment 185594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185594&action=edit Bug 39345: Add COUNTER 5.1 support This moves the original SUSHI COUNTER logic to a new Koha::ERM::EUsage::COUNTER::5 class that extends Koha::ERM::EUsage::SushiCounter. Adds a new Koha::ERM::EUsage::COUNTER::5_1 class with COUNTER 5.1 specific logic. Keeps common logic in Koha::ERM::EUsage::SushiCounter. This ensures we support both COUNTER 5.0 and COUNTER 5.1, but should hopefully help us better maintain COUNTER 5.1 going forward, without having to worry about COUNTER 5.0, as the code is seperated. This should also better set us up for adding support for possible future COUNTER releases. Test plan, k-t-d: 1) Enable ERMModule 2) Add a new usage data provider at: /cgi-bin/koha/erm/eusage/usage_data_providers/add 3) Add the required credential parameters e.g. Customer ID and Requestor ID 4) Update the 'Report release' to '5.1', no single quote. (If you add anything other than '5', it'll default to '5.1') 5) Visit the list of data providers and click the 'Run now' button for your data provider: /cgi-bin/koha/erm/eusage/usage_data_providers 6) Click the background job link at the top. Verify the background job runs as expected. 7) After the successful harvest, run a custom report at, ensure the data is all correct: /cgi-bin/koha/erm/eusage/reports 8) Visit the data provider at: /cgi-bin/koha/erm/eusage/usage_data_providers/ 9) Click the 'Import logs' tab, download the COUNTER 5.1 counter file. Open the file and verify the data is correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 --- Comment #4 from Pedro Amorim --- Created attachment 185593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185593&action=edit Bug 39345: Preparation: Move original test files We are now considering more than one COUNTER release. Move test files accordingly. prove t/db_dependent/Koha/ERM/EUsage/* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Pedro Amorim changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 --- Comment #3 from Eric Phetteplace --- Just adding that since some vendors are dropping COUNTER 5 support (EBSCO, for instance) it makes it impossible to pull their usage statistics until Koha supports the 5.1 releases. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 David Nind changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Eric Phetteplace changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Pedro Amorim changed: What|Removed |Added Assignee|[email protected] |[email protected] ||k Status|NEW |ASSIGNED URL||https://github.com/openfift ||h/koha/commits/counter51/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Andrew Fuerste-Henry changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Jeremy Evans changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Aleisha Amohia changed: What|Removed |Added CC||[email protected] Priority|P5 - low|P3 --- Comment #2 from Aleisha Amohia --- Increasing the importance of this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Jessie Zairo changed: What|Removed |Added CC||[email protected] --- Comment #1 from Jessie Zairo --- +1, yes, there are about 175 publishers, data hosts, and platforms that have migrated to R5.1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Emily Lamancusa (emlam) changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Katrin Fischer changed: What|Removed |Added Blocks||40188 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40188 [Bug 40188] SUSHI has been renamed to COUNTER API -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39345] Koha must support COUNTER 5.1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39345 Michaela Sieber changed: What|Removed |Added CC||[email protected], ||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
