[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

--- Comment #24 from Marion Durand  ---
Created attachment 181337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181337&action=edit
Bug 39372: Database changes

Signed-off-by: Marion Durand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

Marion Durand  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

--- Comment #26 from Marion Durand  ---
Created attachment 181339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181339&action=edit
Bug 39372: (follow-up) Add sysprefs to controller scripts

By adding the sysprefs to the controller scripts, we can prevent
accidental creations or malicious creations. In theory, these error
conditions shouldn't be triggered, since only the allowed actions
will be displayed on the UI, but we need to cover all our bases.

The error messages in opac-shelves.pl aren't currently translatable.
The error handling will need some refactoring to make them translatable.
However, in this particular case, it should be OK, since no one but a
pen tester should bump into this message.

Signed-off-by: Marion Durand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

--- Comment #25 from Marion Durand  ---
Created attachment 181338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181338&action=edit
Bug 39372: (follow-up) Fix toolbar and public/private selector

On the lists page, it makes the "New list" link appear on the correct
tab as per the sysprefs regarding Private/Public list creation.

It also fixes the Public/Private "Category" dropdown menu when
creating a new list, so that the options match the sysprefs.

Signed-off-by: Marion Durand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-04-23 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

Marion Durand  changed:

   What|Removed |Added

 Attachment #179497|0   |1
is obsolete||
 Attachment #179566|0   |1
is obsolete||
 Attachment #181333|0   |1
is obsolete||
 Attachment #181334|0   |1
is obsolete||

--- Comment #23 from Marion Durand  ---
Created attachment 181336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181336&action=edit
Bug 39372: Limit OPAC list creation

This change adds a new system preference OpacAllowPrivateListCreation,
which works with the existing system preference OpacAllowPublicListCreation,
to determine when "New list", "Save to lists", "Add to list", "Save to another
list",
and "Add to a list" should appear.

If both sysprefs are disabled, then you cannot do these actions. If one of the
sysprefs
is enabled, then these actions appear, but are limited to the private or public
list type
respective to the syspref.

Test plan:
0. Apply the patch and koha-plack --restart kohadev
1. Perform the following steps using differing combinations of
OpacAllowPrivateListCreation,
or OpacAllowPublicListCreation, or both disabled
2. Click on Lists in masthead nav and note presence of "New list" link
3. Perform a search
4. Note the presence of "Save to lists" and "Add to list" links
5. Go to a record detail page
6. Note the presence of "Save to your lists" on the sidebar
7. Create a list
8. Go to the list
9. Note the presence of "Save to another list" and "New list" links
10. Add a record to the cart
11. Note the presence of "Add to a list" link

Signed-off-by: Marion Durand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

--- Comment #22 from David Cook  ---
(In reply to Marion Durand from comment #16)
> I tested your patch with ktd.
> 
> It worked well for the following combination
>private don't allow; public don't allow
>private allow; public don't allow
>private allow; public allow
> 
> I had a problem with the combination : 
>private don't allow, public allow
> In this case, I was still able to create private lists even with the
> preference system on don't allow.
> 
> Could you provide a follow-up to address this issue?

Thanks again, Marion.

Can you give it another go? It should be better now. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

--- Comment #21 from David Cook  ---
Created attachment 181334
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181334&action=edit
Bug 39372: (follow-up) Add sysprefs to controller scripts

By adding the sysprefs to the controller scripts, we can prevent
accidental creations or malicious creations. In theory, these error
conditions shouldn't be triggered, since only the allowed actions
will be displayed on the UI, but we need to cover all our bases.

The error messages in opac-shelves.pl aren't currently translatable.
The error handling will need some refactoring to make them translatable.
However, in this particular case, it should be OK, since no one but a
pen tester should bump into this message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

--- Comment #20 from David Cook  ---
Created attachment 181333
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181333&action=edit
Bug 39372: (follow-up) Fix toolbar and public/private selector

On the lists page, it makes the "New list" link appear on the correct
tab as per the sysprefs regarding Private/Public list creation.

It also fixes the Public/Private "Category" dropdown menu when
creating a new list, so that the options match the sysprefs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

David Cook  changed:

   What|Removed |Added

   Severity|normal  |enhancement

--- Comment #19 from David Cook  ---
Changing this to enhancement like bug 39374

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

--- Comment #18 from David Cook  ---
(In reply to Marion Durand from comment #16)
> I tested your patch with ktd.
> 
> It worked well for the following combination
>private don't allow; public don't allow
>private allow; public don't allow
>private allow; public allow
> 
> I had a problem with the combination : 
>private don't allow, public allow
> In this case, I was still able to create private lists even with the
> preference system on don't allow.
> 
> Could you provide a follow-up to address this issue?

Sorry for the delay on this one. I think that I see the issue now.

It also looks like when Public is disabled and Private is enabled, there is a
"New list" that appears on the Public tab, but it actually just creates a
Private list. I'll look at that too...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-04-22 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

David Cook  changed:

   What|Removed |Added

 Depends on||39404


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39404
[Bug 39404] Inconsistency due to "Add to list" vs "Add to a list"
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-04-06 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

--- Comment #17 from David Cook  ---
(In reply to Marion Durand from comment #16)
> I had a problem with the combination : 
>private don't allow, public allow
> In this case, I was still able to create private lists even with the
> preference system on don't allow.
> 
> Could you provide a follow-up to address this issue?

Thanks for testing! I'll look at doing a follow-up later this week or next
week.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-04-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

--- Comment #9 from David Cook  ---
Created attachment 179498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179498&action=edit
Bug 39372: Database changes

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-04-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

--- Comment #12 from David Cook  ---
I think there's a few bugs with OpacAllowPublicListCreation before this patch
as well... it's not a comprehensive syspref...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-04-05 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

--- Comment #8 from David Cook  ---
Database changes to follow shortly...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-04-04 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

--- Comment #16 from Marion Durand  ---
I tested your patch with ktd.

It worked well for the following combination
   private don't allow; public don't allow
   private allow; public don't allow
   private allow; public allow

I had a problem with the combination : 
   private don't allow, public allow
In this case, I was still able to create private lists even with the preference
system on don't allow.

Could you provide a follow-up to address this issue?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-04-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

--- Comment #15 from David Cook  ---
(In reply to Marion Durand from comment #14)
> Is this patch ready to be signed off or does it still need work before ?

It should be ready to be tested and signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-04-03 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

Marion Durand  changed:

   What|Removed |Added

 CC||marion.dur...@biblibre.com

--- Comment #14 from Marion Durand  ---
Is this patch ready to be signed off or does it still need work before ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-03-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

David Cook  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=39238   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-03-27 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=39238

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=39376

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

David Cook  changed:

   What|Removed |Added

 Attachment #179498|0   |1
is obsolete||

--- Comment #13 from David Cook  ---
Created attachment 179566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179566&action=edit
Bug 39372: Database changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-03-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

--- Comment #11 from David Cook  ---
I reckon there's probably more work to do here. Lists are a bit of a mess...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-03-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

--- Comment #10 from David Cook  ---
If you already have lists belonging to you, you'll be able to edit or delete
them... but you can't create new lists or add to your existing lists.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-03-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

David Cook  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-03-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=35765

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-03-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

--- Comment #7 from David Cook  ---
Created attachment 179497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179497&action=edit
Bug 39372: Limit OPAC list creation

This change adds a new system preference OpacAllowPrivateListCreation,
which works with the existing system preference OpacAllowPublicListCreation,
to determine when "New list", "Save to lists", "Add to list", "Save to another
list",
and "Add to a list" should appear.

If both sysprefs are disabled, then you cannot do these actions. If one of the
sysprefs
is enabled, then these actions appear, but are limited to the private or public
list type
respective to the syspref.

Test plan:
0. Apply the patch and koha-plack --restart kohadev
1. Perform the following steps using differing combinations of
OpacAllowPrivateListCreation,
or OpacAllowPublicListCreation, or both disabled
2. Click on Lists in masthead nav and note presence of "New list" link
3. Perform a search
4. Note the presence of "Save to lists" and "Add to list" links
5. Go to a record detail page
6. Note the presence of "Save to your lists" on the sidebar
7. Create a list
8. Go to the list
9. Note the presence of "Save to another list" and "New list" links
10. Add a record to the cart
11. Note the presence of "Add to a list" link

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-03-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

--- Comment #6 from David Cook  ---
(In reply to David Cook from comment #4)
> - Masthead : "Lists" dropdown menu

Show "New list" if OpacAllowPrivateListCreation || OpacAllowPublicListCreation

> - Search results : "Add to list", "Save to lists"

Show "Save to lists" if OpacAllowPrivateListCreation ||
OpacAllowPublicListCreation
koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc

Show "Add to list" if OpacAllowPrivateListCreation ||
OpacAllowPublicListCreation
koha-tmpl/opac-tmpl/bootstrap/en/includes/result-batch-controls.inc

> - Detail page : "Save to your lists"

Show "Save to your lists" if OpacAllowPrivateListCreation ||
OpacAllowPublicListCreation

Show new list form only if OpacAllowPrivateListCreation ||
OpacAllowPublicListCreation
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-addbybiblionumber.tt

> - Lists/Shelves : "New list", "Your lists", "Save to another list" and "Add 
> to list"
> (for public lists)

Show "Save to another list" if OpacAllowPrivateListCreation ||
OpacAllowPublicListCreation

Show "New list" if OpacAllowPrivateListCreation || OpacAllowPublicListCreation

> - Cart : "Add to a list"

Show "Add to a list" if OpacAllowPrivateListCreation ||
OpacAllowPublicListCreation

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-03-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

--- Comment #4 from David Cook  ---
- Masthead : "Lists" dropdown menu
- Search results : "Select titles to: Add to...", "Save to lists"
- Detail page : "Save to your lists"
- Lists/Shelves : "Your lists", "Save to another list" and "Add to list" (for
public lists)
- Cart : "Add to a list"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-03-19 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

David Cook  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=39069

--- Comment #5 from David Cook  ---
(In reply to David Cook from comment #4)
> - Masthead : "Lists" dropdown menu

Hidden "Your 

> - Search results : "Select titles to: Add to...", "Save to lists"
> - Detail page : "Save to your lists"
> - Lists/Shelves : "Your lists", "Save to another list" and "Add to list"
> (for public lists)
> - Cart : "Add to a list"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-03-18 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

--- Comment #3 from David Cook  ---
- Masthead : "Lists" dropdown menu
- Search results : "Select titles to: Add to...", "Save to lists"
- Detail page : "Save to your lists"
- Usermenu : "Lists"
- Lists/Shelves : "Your lists", "Save to another list" and "Add to list" (for
public lists)
- Cart : "Add to a list"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-03-18 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

--- Comment #2 from David Cook  ---
There's lots of different locations in Koha to keep in mind... 

- Masthead : "Lists" dropdown menu
- Search results : "Select titles to: Add to...", "Save to lists"
- Detail page : "Save to your lists"
- Usermenu : "Lists"
- Lists/Shelves : "Your lists"
- Cart : "Add to a list"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 39372] No way to restrict OPAC users from creating private lists specifically

2025-03-18 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39372

--- Comment #1 from David Cook  ---
I think by default we'd have to set OpacAllowPrivateListCreation to 1 because
that is the status quo.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/