[Koha-bugs] [Bug 39543] Error modal when trying to add two controlling licences to an agreement duplicates error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39543 Wainui Witika-Park changed: What|Removed |Added Status|Pushed to stable|Needs documenting --- Comment #7 from Wainui Witika-Park --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39543] Error modal when trying to add two controlling licences to an agreement duplicates error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39543 Fridolin Somers changed: What|Removed |Added Status|Pushed to main |Pushed to stable CC||[email protected] ||m Version(s)|25.05.00|25.05.00,24.11.10 released in|| --- Comment #6 from Fridolin Somers --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39543] Error modal when trying to add two controlling licences to an agreement duplicates error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39543 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=40185 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39543] Error modal when trying to add two controlling licences to an agreement duplicates error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39543 --- Comment #5 from Katrin Fischer --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39543] Error modal when trying to add two controlling licences to an agreement duplicates error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39543 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39543] Error modal when trying to add two controlling licences to an agreement duplicates error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39543 Lisette Scheer changed: What|Removed |Added Attachment #180491|0 |1 is obsolete|| --- Comment #4 from Lisette Scheer --- Created attachment 180526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180526&action=edit Bug 39543: Error modal when trying to add two controlling licences to an agreement duplicates error message If you try to add two licences with the status 'controlling' to an agreement record, the error modal duplicates the error message 'Only one controlling license is allowed'. Test Plan: 1) Enable ERMModule sys pref 2) Add an agreement record 3) Add two licence records 4) Edit the agreement record and associate both license records to the agreement 5) Try to set both licenses to status 'controlling' 6) Note error modal duplicates the error message 'Only one controlling license is allowed' 7) Apply the patch, run yarn js:build and then hard refresh the browser 8) Repeat steps 1 to 5 and enjoy the single error message! Signed-off-by: Magnus Enger I took the liberty of fixing up the commit message a bit. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39543] Error modal when trying to add two controlling licences to an agreement duplicates error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39543 Lisette Scheer changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org |m CC||[email protected] ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39543] Error modal when trying to add two controlling licences to an agreement duplicates error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39543 Matt Blenkinsop changed: What|Removed |Added Attachment #180490|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39543] Error modal when trying to add two controlling licences to an agreement duplicates error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39543 Lisette Scheer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39543] Error modal when trying to add two controlling licences to an agreement duplicates error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39543 Magnus Enger changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39543] Error modal when trying to add two controlling licences to an agreement duplicates error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39543 --- Comment #3 from Magnus Enger --- Created attachment 180491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180491&action=edit Bug 39543: Error modal when trying to add two controlling licences to an agreement duplicates error message If you try to add two licences with the status 'controlling' to an agreement record, the error modal duplicates the error message 'Only one controlling license is allowed'. Test Plan: 1) Enable ERMModule sys pref 2) Add an agreement record 3) Add two licence records 4) Edit the agreement record and associate both license records to the agreement 5) Try to set both licenses to status 'controlling' 6) Note error modal duplicates the error message 'Only one controlling license is allowed' 7) Apply the patch, run yarn js:build and then hard refresh the browser 8) Repeat steps 1 to 5 and enjoy the single error message! Signed-off-by: Magnus Enger I took the liberty of fixing up the commit message a bit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39543] Error modal when trying to add two controlling licences to an agreement duplicates error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39543 Andrew Auld changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #2 from Andrew Auld --- Sorry for the duff formatting on the test plan: Test Plan: 1) Enable ERMModule sys pref 2) Add an agreement record 3) Add two licence records 4) Edit the agreement record and associate both license records to the agreement 5) Try to set both licenses to status 'controlling' 6) Note error modal duplicates the error message 'Only one controlling license is allowed' 7) Apply the patch, run yarn js:build and then hard refresh the browser 8) Repeat steps 1 to 5 and enjoy the single error message! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39543] Error modal when trying to add two controlling licences to an agreement duplicates error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39543 --- Comment #1 from Andrew Auld --- Created attachment 180490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180490&action=edit Bug 39543: Remove duplicated code in agreements controlling licence error message Test plan 1) Enable ERMModule sys pref 2) Add an agreement record 3) Add two licence records 4) Edit the agreement record and associate both license records to the agreement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39543] Error modal when trying to add two controlling licences to an agreement duplicates error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39543 Andrew Auld changed: What|Removed |Added Severity|enhancement |trivial Assignee|[email protected] |[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
