[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 --- Comment #18 from Katrin Fischer --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 --- Comment #17 from Martin Renvoize (ashimema) --- Created attachment 182253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182253&action=edit Bug 39679: (QA follow-up) Translation friendly approach As discussed at length on (mattermost)[https://chat.koha-community.org/koha-community/pl/wiopmtr7j3835df3yfi6q64ooy] we need to use the I18N library to properly handle this otherwise we will end up with TT tags inside the translatable strings. We can not use here as we are inside an tag and nesting insdie is against the html standard. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679
--- Comment #16 from Jonathan Druart ---
The correct solution here is to use the I18 TT plugin
[%- IF ( hold.barcodenumber ) -%]
[% tx("Only item {barcode}", {barcode: hold.barcodenumber}) %]
[%- ELSE -%]
[% t("Only item [No barcode]") %]
[%- END -%]
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@gmail.com Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 --- Comment #15 from Andrew Fuerste-Henry --- Thanks everybody for fixing this properly :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 --- Comment #13 from David Nind --- Created attachment 182228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182228&action=edit Bug 39679: (follow-up) Improve consistency This improves the consistency with other areas of Koha: 1. A space before the barcode: "Only item 3999". 2. Where there is no barcode: "Only item [No barcode]". Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 David Nind changed: What|Removed |Added Text to go in the||This fixes the holds table release notes||for a record: ||1. There is ||now a space between "Only ||item" and the barcode for ||specific item holds, for ||example: "Only item ||3999...". ||2. Where there is ||no barcode for the item, it ||now shows as "Item only [No ||barcode]" to improve ||consistency with other ||areas of Koha (instead of ||"Only item No barcode"). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 --- Comment #14 from David Nind --- (In reply to Owen Leonard from comment #12) > This could also be solved in a similar way to Bug 39688: > > > [%- IF ( hold.barcodenumber ) -%] > Only item [%- hold.barcodenumber | html -%] > [%- ELSE -%] > Only item [No barcode] > [%- END -%] > I'm all for consistency! I've added a follow-up with Owen's suggested changes. Have left as Passed QA, QA script is happy. Feel free to change status if it needs another sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 --- Comment #12 from Owen Leonard --- This could also be solved in a similar way to Bug 39688: [%- IF ( hold.barcodenumber ) -%] Only item [%- hold.barcodenumber | html -%] [%- ELSE -%] Only item [No barcode] [%- END -%] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize (ashimema) --- Nice one, thanks David :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #182091|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize (ashimema) --- Created attachment 182092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182092&action=edit Bug 39679: Add space before barcode in holds table To test: 1) Place an item-level hold for an item with a barcode 2) In the holds list on request.pl, see that the Details column for your hold lists "Only item[barcode]" in the dropdown without a space before the barcode 3) Apply patch, restart_all, reload page 4) Confirm your hold has a space before the barcode Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #10 from David Nind --- (In reply to Martin Renvoize (ashimema) from comment #8) > Any chance of a retest here David.. if someone confirms this resolves the > spacing issue then I think we can go strait to PQA here. > > I do wonder what it looks like for an item without a barcode.. feels like it > would read `Only itemNo barcode` to me. It does resolve the spacing. For an item with no barcode, it shows as "Only item No barcode" before and after the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 David Nind changed: What|Removed |Added Attachment #182092|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 182120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182120&action=edit Bug 39679: Add space before barcode in holds table To test: 1) Place an item-level hold for an item with a barcode 2) In the holds list on request.pl, see that the Details column for your hold lists "Only item[barcode]" in the dropdown without a space before the barcode 3) Apply patch, restart_all, reload page 4) Confirm your hold has a space before the barcode Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 --- Comment #5 from Martin Renvoize (ashimema) --- Sorry Andrew, are not allowed inside according to the html spec. I'll post an alternative shortly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 Martin Renvoize (ashimema) changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 --- Comment #8 from Martin Renvoize (ashimema) --- Any chance of a retest here David.. if someone confirms this resolves the spacing issue then I think we can go strait to PQA here. I do wonder what it looks like for an item without a barcode.. feels like it would read `Only itemNo barcode` to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #181204|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize (ashimema) --- Created attachment 182091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182091&action=edit Bug 39679: Add space before barcode in holds table To test: 1) Place an item-level hold for an item with a barcode 2) In the holds list on request.pl, see that the Details column for your hold lists "Only item[barcode]" in the dropdown without a space before the barcode 3) Apply patch, restart_all, reload page 4) Confirm your hold has a space before the barcode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Signed Off |Failed QA CC||martin.renvoize@openfifth.c ||o.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 David Nind changed: What|Removed |Added Attachment #181168|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 181204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181204&action=edit Bug 39679: Add space before barcode in holds table To test: 1 : place an item-level hold for an item with a barcode 2 : in the holds list on request.pl, see that the Details column for your hold lists "Only item[barcode]" in the dropdown without a space before the barcode 3 : apply patch, restart_all, reload page 4 : confirm your hold has a space before the barcode Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 Andrew Fuerste-Henry changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |and...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 --- Comment #3 from Andrew Fuerste-Henry --- Oops, actually the space was not missing when the hold is not able to be changed from item- to bib-level. Updated to remove extraneous edit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #181160|0 |1 is obsolete|| --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 181168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181168&action=edit Bug 39679: Add space before barcode in holds table To test: 1 : place an item-level hold for an item with a barcode 2 : in the holds list on request.pl, see that the Details column for your hold lists "Only item[barcode]" in the dropdown without a space before the barcode 3 : apply patch, restart_all, reload page 4 : confirm your hold has a space before the barcode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 --- Comment #1 from Andrew Fuerste-Henry --- Created attachment 181160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181160&action=edit Bug 39679: Add space before barcode in holds table To test: 1 : place an item-level hold for an item with a barcode 2 : in the holds list on request.pl, see that the Details column for your hold lists "Only item[barcode]" in the dropdown without a space before the barcode 3 : place a second item-level hold for the same patron 4 : back on the holds list, see that the Details column isn't a dropdown anymore but still says "Only item[barcode]" without a space 5 : apply patch, restart_all, reload page 6 : confirm your hold has a space before the barcode while not in a dropdown 7 : cancel your hold from step 3 8 : confirm your hold has a space before the barcode when in a dropdown -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39679] Missing space before barcode in holds table with item-specific hold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39679 Andrew Fuerste-Henry changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
