[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 David Nind changed: What|Removed |Added CC||[email protected] Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #69 from David Nind --- No changes to the manual required (as far as I can tell - more development-related). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 Laura Escamilla changed: What|Removed |Added Status|Pushed to main |Needs documenting CC||Laura.escamilla@bywatersolu ||tions.com --- Comment #68 from Laura Escamilla --- This will not be backported to the 25.05.x branch. Have a great day! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #67 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 Lucas Gass (lukeg) changed: What|Removed |Added Version(s)||25.11.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #65 from Jonathan Druart --- Created attachment 186203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186203&action=edit Bug 39740: Fix adjust_paths_git_install in koha-es-indexer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #59 from Jonathan Druart --- Created attachment 186197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186197&action=edit Bug 39740: Fix a few occurrences of dev_install in code Test plan: Check if git_install is set correctly for your system in koha-conf.xml. Adjust otherwise. cp debian/scripts/koha-functions.sh /usr/share/koha/bin/ cp debian/scripts/koha-* /usr/sbin/ Run koha-shell your_clone. Does that works like expected? Run t/Koha/Config.t. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #62 from Jonathan Druart --- Created attachment 186200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186200&action=edit Bug 39740: Adjust koha-conf.xml Test plan: Look at changes in this patch. Note that we already tested these settings with former patches. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #57 from Jonathan Druart --- Created attachment 186195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186195&action=edit Bug 39740: Rename function to adjust_paths_git_install Logical follow-up for moving away from dev_install to git_install. Result of running git grep -l adjust_paths_dev_install | xargs sed -i -e "s/adjust_paths_dev_install/adjust_paths_git_install/g" Test plan: Read the patch. The scripts will be tested later on. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #64 from Jonathan Druart --- Created attachment 186202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186202&action=edit Bug 39740: (QA follow-up) Adjust debugger for koha-plack and koha-z3950-responder This patch mainly renames var debug_mode in both scripts when it refers to the debugger instead of the instance's debug_mode. Note: Removing $environment from responder, probably copied. Test plan: cp debian/scripts/koha-functions.sh /usr/share/koha/bin/ cp debian/scripts/koha-* /usr/sbin/ cp debian/templates/plack.psgi /etc/koha/plack.psgi Repeat steps from patch: "Replace envvar check by calling..." Repeat steps from patch: "Adjust koha-plack and koha-z3950-responder" Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #61 from Jonathan Druart --- Created attachment 186199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186199&action=edit Bug 39740: Adjust koha-plack and koha-z3950-responder Changes to koha-plack - Check is_test_system and -development for stack trace - Add check on set $environment for debugger - Move export to do_instance, remove three local's NOTE: GIT_INSTALL ie exported for koha-plack ONLY! The debian scripts call is_git_install. Changes to koha-z3950-responder - debugger needs test_system flag - Rearrange exports before calling start_z3950 and friends. Test plan: Check/adjust git_install and test_system in koha-conf.xml for used instances. cp debian/scripts/koha-functions.sh /usr/share/koha/bin/ cp debian/scripts/koha-* /usr/sbin/ cp debian/templates/plack.psgi /etc/koha/plack.psgi Add a die in e.g. opac/opac-main.pl. Set test_system to 1 in koha-conf.xml or export TEST_SYSTEM=1 in your environment. Restart Plack. Hit opac-main. Do you see a stack trace? Export TEST_SYSTEM=0. Restart Plack. Hit opac-main again. You should not see a stack trace. Start koha-z3950-responder with/without debug flag. Works as expected? Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #60 from Jonathan Druart --- Created attachment 186198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186198&action=edit Bug 39740: Replace envvar check by calling is_git_install on instance level Replace the $GIT_INSTALL check by is_git_install. Some scripts did call is_git_install once while potentially looping over multiple instances. Note: koha-reset-passwd only runs on one instance (unlike most). Test plan: Check/adjust git_install and test_system in koha-conf.xml for used instances. cp debian/scripts/koha-functions.sh /usr/share/koha/bin/ cp debian/scripts/koha-* /usr/sbin/ Note: We will still test koha-plack and -z3950-responder later. Test running a few of the other changed koha-* scripts on one or more instances. Verify that things work as expected. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #66 from Jonathan Druart --- Opened https://gitlab.com/koha-community/koha-testing-docker/-/issues/502 and created a merge request. Lucas, we need the merge request to be merged right before you push this! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #63 from Jonathan Druart --- Created attachment 186201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186201&action=edit Bug 39740: (QA follow-up) Rename test_system/TEST_SYSTEM See comment30 and comment36. Result of two sed's: git grep -l test_system | xargs sed -i -e "s/test_system/debug_mode/g" git grep -l TEST_SYSTEM | xargs sed -i -e "s/TEST_SYSTEM/DEBUG_MODE/g" The next patch will take care of the debugger options in the plack and z3950 responder scripts. Test plan: Read the patch. (Testing in next patch.) git grep -i test_system Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #58 from Jonathan Druart --- Created attachment 186196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186196&action=edit Bug 39740: Replace DEV_INSTALL by GIT_INSTALL Resulting from the following sed statement: git grep -l DEV_INSTALL | xargs sed -i -e "s/DEV_INSTALL/GIT_INSTALL/g" Test plan: Read the patch. The scripts will be tested later on. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740
Jonathan Druart changed:
What|Removed |Added
Attachment #184989|0 |1
is obsolete||
Attachment #184990|0 |1
is obsolete||
Attachment #184991|0 |1
is obsolete||
Attachment #184992|0 |1
is obsolete||
Attachment #184993|0 |1
is obsolete||
Attachment #184994|0 |1
is obsolete||
Attachment #184995|0 |1
is obsolete||
Attachment #184996|0 |1
is obsolete||
Attachment #184997|0 |1
is obsolete||
Attachment #184998|0 |1
is obsolete||
--- Comment #56 from Jonathan Druart ---
Created attachment 186194
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186194&action=edit
Bug 39740: Add is_git_install and is_test_system
Test plan:
Copy koha-functions.sh to /usr/share/koha/bin.
Source bin/koha-functions.sh ('. bin/koha-functions.sh')
Test in bash (Yes expected; adjust instance name):
GIT_INSTALL=1; if is_git_install your_instance; then echo Yes; fi
Add/set git_install to 1 in koha-conf.xml.
Test in bash (Yes expected):
unset GIT_INSTALL; if is_git_install your_instance; then echo Yes; fi
Set git_install to 0 in koha-conf.xml.
Test in bash (No expected):
unset GIT_INSTALL; if ! is_git_install your_instance; then echo No; fi
Remove git_install and add/set dev_install to 1 in koha-conf.xml.
Test in bash (Yes expected):
unset GIT_INSTALL; if is_git_install your_instance; then echo Yes; fi
A few similar tests with test_system.
Add/set test_system to 0 in koha-conf.xml.
Test in bash (Yes expected):
TEST_SYSTEM=1; if is_test_system your_instance; then echo Yes; fi
Test in bash (No expected):
unset TEST_SYSTEM; if ! is_test_system your_instance; then echo No; fi
Signed-off-by: Marcel de Rooy
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #55 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi (tcohen) from comment #45) > Signed-off-by: Tomas Cohen Arazi Thx ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #54 from Tomás Cohen Arazi (tcohen) --- Created attachment 184998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184998&action=edit Bug 39740: Fix adjust_paths_git_install in koha-es-indexer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #53 from Tomás Cohen Arazi (tcohen) --- Created attachment 184997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184997&action=edit Bug 39740: (QA follow-up) Adjust debugger for koha-plack and koha-z3950-responder This patch mainly renames var debug_mode in both scripts when it refers to the debugger instead of the instance's debug_mode. Note: Removing $environment from responder, probably copied. Test plan: cp debian/scripts/koha-functions.sh /usr/share/koha/bin/ cp debian/scripts/koha-* /usr/sbin/ cp debian/templates/plack.psgi /etc/koha/plack.psgi Repeat steps from patch: "Replace envvar check by calling..." Repeat steps from patch: "Adjust koha-plack and koha-z3950-responder" Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #52 from Tomás Cohen Arazi (tcohen) --- Created attachment 184996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184996&action=edit Bug 39740: (QA follow-up) Rename test_system/TEST_SYSTEM See comment30 and comment36. Result of two sed's: git grep -l test_system | xargs sed -i -e "s/test_system/debug_mode/g" git grep -l TEST_SYSTEM | xargs sed -i -e "s/TEST_SYSTEM/DEBUG_MODE/g" The next patch will take care of the debugger options in the plack and z3950 responder scripts. Test plan: Read the patch. (Testing in next patch.) git grep -i test_system Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #51 from Tomás Cohen Arazi (tcohen) --- Created attachment 184995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184995&action=edit Bug 39740: Adjust koha-conf.xml Test plan: Look at changes in this patch. Note that we already tested these settings with former patches. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #50 from Tomás Cohen Arazi (tcohen) --- Created attachment 184994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184994&action=edit Bug 39740: Adjust koha-plack and koha-z3950-responder Changes to koha-plack - Check is_test_system and -development for stack trace - Add check on set $environment for debugger - Move export to do_instance, remove three local's NOTE: GIT_INSTALL ie exported for koha-plack ONLY! The debian scripts call is_git_install. Changes to koha-z3950-responder - debugger needs test_system flag - Rearrange exports before calling start_z3950 and friends. Test plan: Check/adjust git_install and test_system in koha-conf.xml for used instances. cp debian/scripts/koha-functions.sh /usr/share/koha/bin/ cp debian/scripts/koha-* /usr/sbin/ cp debian/templates/plack.psgi /etc/koha/plack.psgi Add a die in e.g. opac/opac-main.pl. Set test_system to 1 in koha-conf.xml or export TEST_SYSTEM=1 in your environment. Restart Plack. Hit opac-main. Do you see a stack trace? Export TEST_SYSTEM=0. Restart Plack. Hit opac-main again. You should not see a stack trace. Start koha-z3950-responder with/without debug flag. Works as expected? Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #49 from Tomás Cohen Arazi (tcohen) --- Created attachment 184993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184993&action=edit Bug 39740: Replace envvar check by calling is_git_install on instance level Replace the $GIT_INSTALL check by is_git_install. Some scripts did call is_git_install once while potentially looping over multiple instances. Note: koha-reset-passwd only runs on one instance (unlike most). Test plan: Check/adjust git_install and test_system in koha-conf.xml for used instances. cp debian/scripts/koha-functions.sh /usr/share/koha/bin/ cp debian/scripts/koha-* /usr/sbin/ Note: We will still test koha-plack and -z3950-responder later. Test running a few of the other changed koha-* scripts on one or more instances. Verify that things work as expected. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #48 from Tomás Cohen Arazi (tcohen) --- Created attachment 184992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184992&action=edit Bug 39740: Fix a few occurrences of dev_install in code Test plan: Check if git_install is set correctly for your system in koha-conf.xml. Adjust otherwise. cp debian/scripts/koha-functions.sh /usr/share/koha/bin/ cp debian/scripts/koha-* /usr/sbin/ Run koha-shell your_clone. Does that works like expected? Run t/Koha/Config.t. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #47 from Tomás Cohen Arazi (tcohen) --- Created attachment 184991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184991&action=edit Bug 39740: Replace DEV_INSTALL by GIT_INSTALL Resulting from the following sed statement: git grep -l DEV_INSTALL | xargs sed -i -e "s/DEV_INSTALL/GIT_INSTALL/g" Test plan: Read the patch. The scripts will be tested later on. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #46 from Tomás Cohen Arazi (tcohen) --- Created attachment 184990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184990&action=edit Bug 39740: Rename function to adjust_paths_git_install Logical follow-up for moving away from dev_install to git_install. Result of running git grep -l adjust_paths_dev_install | xargs sed -i -e "s/adjust_paths_dev_install/adjust_paths_git_install/g" Test plan: Read the patch. The scripts will be tested later on. Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740
Tomás Cohen Arazi (tcohen) changed:
What|Removed |Added
Attachment #184798|0 |1
is obsolete||
Attachment #184799|0 |1
is obsolete||
Attachment #184800|0 |1
is obsolete||
Attachment #184801|0 |1
is obsolete||
Attachment #184802|0 |1
is obsolete||
Attachment #184803|0 |1
is obsolete||
Attachment #184804|0 |1
is obsolete||
Attachment #184873|0 |1
is obsolete||
Attachment #184874|0 |1
is obsolete||
Attachment #184920|0 |1
is obsolete||
--- Comment #45 from Tomás Cohen Arazi (tcohen) ---
Created attachment 184989
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184989&action=edit
Bug 39740: Add is_git_install and is_test_system
Test plan:
Copy koha-functions.sh to /usr/share/koha/bin.
Source bin/koha-functions.sh ('. bin/koha-functions.sh')
Test in bash (Yes expected; adjust instance name):
GIT_INSTALL=1; if is_git_install your_instance; then echo Yes; fi
Add/set git_install to 1 in koha-conf.xml.
Test in bash (Yes expected):
unset GIT_INSTALL; if is_git_install your_instance; then echo Yes; fi
Set git_install to 0 in koha-conf.xml.
Test in bash (No expected):
unset GIT_INSTALL; if ! is_git_install your_instance; then echo No; fi
Remove git_install and add/set dev_install to 1 in koha-conf.xml.
Test in bash (Yes expected):
unset GIT_INSTALL; if is_git_install your_instance; then echo Yes; fi
A few similar tests with test_system.
Add/set test_system to 0 in koha-conf.xml.
Test in bash (Yes expected):
TEST_SYSTEM=1; if is_test_system your_instance; then echo Yes; fi
Test in bash (No expected):
unset TEST_SYSTEM; if ! is_test_system your_instance; then echo No; fi
Signed-off-by: Marcel de Rooy
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 Tomás Cohen Arazi (tcohen) changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #44 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #43) > (In reply to Jonathan Druart from comment #41) > > 2. I am wondering if there is an easy way to keep backward compatibility for > > dev_install: for instance ktd images for 25.05 won't be able to test "main". > > And ktd's main won't be able to test older commits. We will always have to > > reset_all or adjust koha-conf. > > I kept a second check for dev_install in the function: > # now check koha-conf; looking at dev_install as historical fallback > if [ "$instancename" != "" ] && is_instance $instancename; then > git_install=$(run_safe_xmlstarlet $instancename git_install) > if [ -z "$git_install" ]; then git_install=$(run_safe_xmlstarlet > $instancename dev_install); fi Perfect, I missed that! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #43 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #41) > 2. I am wondering if there is an easy way to keep backward compatibility for > dev_install: for instance ktd images for 25.05 won't be able to test "main". > And ktd's main won't be able to test older commits. We will always have to > reset_all or adjust koha-conf. I kept a second check for dev_install in the function: # now check koha-conf; looking at dev_install as historical fallback if [ "$instancename" != "" ] && is_instance $instancename; then git_install=$(run_safe_xmlstarlet $instancename git_install) if [ -z "$git_install" ]; then git_install=$(run_safe_xmlstarlet $instancename dev_install); fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #42 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #40) > Created attachment 184920 [details] [review] > Bug 39740: Fix adjust_paths_git_install in koha-es-indexer Patch 2 did change it ;) But another patch restored the old name: +adjust_paths_dev_install $name -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #41 from Jonathan Druart --- 1. We need to adjust koha-conf's koha-testing-docker https://gitlab.com/koha-community/koha-testing-docker/-/blob/main/files/templates/koha-conf-site.xml.in?ref_type=heads replace dev_install with git_install and add debug_mode 2. I am wondering if there is an easy way to keep backward compatibility for dev_install: for instance ktd images for 25.05 won't be able to test "main". And ktd's main won't be able to test older commits. We will always have to reset_all or adjust koha-conf. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #40 from Jonathan Druart --- Created attachment 184920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184920&action=edit Bug 39740: Fix adjust_paths_git_install in koha-es-indexer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 David Cook changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #39 from Marcel de Rooy --- Open for testing again ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #38 from Marcel de Rooy --- Created attachment 184874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184874&action=edit Bug 39740: (QA follow-up) Adjust debugger for koha-plack and koha-z3950-responder This patch mainly renames var debug_mode in both scripts when it refers to the debugger instead of the instance's debug_mode. Note: Removing $environment from responder, probably copied. Test plan: cp debian/scripts/koha-functions.sh /usr/share/koha/bin/ cp debian/scripts/koha-* /usr/sbin/ cp debian/templates/plack.psgi /etc/koha/plack.psgi Repeat steps from patch: "Replace envvar check by calling..." Repeat steps from patch: "Adjust koha-plack and koha-z3950-responder" Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #37 from Marcel de Rooy --- Created attachment 184873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184873&action=edit Bug 39740: (QA follow-up) Rename test_system/TEST_SYSTEM See comment30 and comment36. Result of two sed's: git grep -l test_system | xargs sed -i -e "s/test_system/debug_mode/g" git grep -l TEST_SYSTEM | xargs sed -i -e "s/TEST_SYSTEM/DEBUG_MODE/g" The next patch will take care of the debugger options in the plack and z3950 responder scripts. Test plan: Read the patch. (Testing in next patch.) git grep -i test_system Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39740] [Follow-up of 36932] Split dev_install into git_install and debug_mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 Marcel de Rooy changed: What|Removed |Added Summary|[Follow-up of 36932] Check |[Follow-up of 36932] Split |is_test_system for stack|dev_install into |trace in koha-plack |git_install and debug_mode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
