[Koha-bugs] [Bug 39772] Background jobs page lists unknown job types for jobs implemented by plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39772 David Nind changed: What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #22 from David Nind --- No changes to the manual required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39772] Background jobs page lists unknown job types for jobs implemented by plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39772 David Cook changed: What|Removed |Added Blocks||40547 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 [Bug 40547] Unable to view background job if enable_plugins is 0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39772] Background jobs page lists unknown job types for jobs implemented by plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39772 Wainui Witika-Park changed: What|Removed |Added Status|Pushed to oldstable |Needs documenting Version(s)|25.05.00,24.11.06 |25.05.00,24.11.06,24.05.12 released in|| CC||[email protected] ||et.nz --- Comment #21 from Wainui Witika-Park --- Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39772] Background jobs page lists unknown job types for jobs implemented by plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39772 Jesse Maseto changed: What|Removed |Added CC||[email protected] Status|Pushed to stable|Pushed to oldstable --- Comment #20 from Jesse Maseto --- Will be pushed to 24.05.x for 24.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39772] Background jobs page lists unknown job types for jobs implemented by plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39772 Fridolin Somers changed: What|Removed |Added Version(s)|25.05.00|25.05.00,24.11.06 released in|| CC||[email protected] ||m Status|Pushed to main |Pushed to stable --- Comment #19 from Fridolin Somers --- Pushed to 24.11.x for 24.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39772] Background jobs page lists unknown job types for jobs implemented by plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39772
--- Comment #18 from David Cook ---
(In reply to David Cook from comment #16)
> (In reply to Andrii Nugged from comment #15)
> > in:
> >
> > ```
> > for my $plugin (@plugins) {
> > my $tasks = $plugin->background_tasks;
> > ```
> >
> > probably we should have:
> >
> > ```
> > for my $plugin (@plugins) {
> > next unless $plugin->can('background_tasks');
> > my $tasks = $plugin->background_tasks;
> > ```
> >
> > if plugin does not have background_tasks method.
>
> Strictly speaking, that shouldn't be necessary since only plugins that have
> registered a 'background_tasks' at install time will be in @plugins.
That is, @plugins wasn't being properly populated. But Tad has fixed it in the
other bug report
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39772] Background jobs page lists unknown job types for jobs implemented by plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39772 --- Comment #17 from David Cook --- It looks like this causes a regression. See bug 40033 for the fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39772] Background jobs page lists unknown job types for jobs implemented by plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39772 David Cook changed: What|Removed |Added Blocks||40033 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40033 [Bug 40033] The background jobs page calls GetPlugins incorrectly, resulting in a 500 error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39772] Background jobs page lists unknown job types for jobs implemented by plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39772
--- Comment #16 from David Cook ---
(In reply to Andrii Nugged from comment #15)
> in:
>
> ```
> for my $plugin (@plugins) {
> my $tasks = $plugin->background_tasks;
> ```
>
> probably we should have:
>
> ```
> for my $plugin (@plugins) {
> next unless $plugin->can('background_tasks');
> my $tasks = $plugin->background_tasks;
> ```
>
> if plugin does not have background_tasks method.
Strictly speaking, that shouldn't be necessary since only plugins that have
registered a 'background_tasks' at install time will be in @plugins.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39772] Background jobs page lists unknown job types for jobs implemented by plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39772 Andrii Nugged changed: What|Removed |Added CC||[email protected] --- Comment #15 from Andrii Nugged --- in: ``` for my $plugin (@plugins) { my $tasks = $plugin->background_tasks; ``` probably we should have: ``` for my $plugin (@plugins) { next unless $plugin->can('background_tasks'); my $tasks = $plugin->background_tasks; ``` if plugin does not have background_tasks method. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39772] Background jobs page lists unknown job types for jobs implemented by plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39772 --- Comment #14 from Katrin Fischer --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39772] Background jobs page lists unknown job types for jobs implemented by plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39772 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Pushed to main Version(s)||25.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39772] Background jobs page lists unknown job types for jobs implemented by plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39772 Martin Renvoize (ashimema) changed: What|Removed |Added Severity|minor |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39772] Background jobs page lists unknown job types for jobs implemented by plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39772 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize (ashimema) --- Nice improvement, no regressions, Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39772] Background jobs page lists unknown job types for jobs implemented by plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39772 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #181854|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize (ashimema) --- Created attachment 181867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181867&action=edit Bug 39772: Extend background_tasks API to allow for human-readable job names Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39772] Background jobs page lists unknown job types for jobs implemented by plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39772 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #181853|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize (ashimema) --- Created attachment 181866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181866&action=edit Bug 39772: Display package names for plugin jobs rather than "unknown" messages This slightly improves the current situation, where on background_jobs.pl each plugin job would be displayed as "Unknown job type 'plugin_...'". After this patch, we display the implementing package name (sourced from plugins' background_tasks()), which is slightly more human-friendly and significantly less error-looking. Test plan: 1. In KTD, install a plugin implementing background jobs (e.g. the KitchenSink) 2. On http://localhost:8081/cgi-bin/koha/plugins/plugins-home.pl, enable the plugin and run a tool/report from it 3. Observe ugly job types column on http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl 4. Apply the patch 5. Observe the improved job types on http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39772] Background jobs page lists unknown job types for jobs implemented by plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39772 Martin Renvoize (ashimema) changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org |o.uk CC||[email protected] ||o.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39772] Background jobs page lists unknown job types for jobs implemented by plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39772 David Nind changed: What|Removed |Added Summary|Background Jobs page lists |Background jobs page lists |bogus job types for jobs|unknown job types for jobs |implemented by plugins |implemented by plugins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
