[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Pedro Amorim changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #36 from Pedro Amorim --- Hi Kyle, I want to PQA but, even though my initial comments were addressed, this: 1) Lacks a reproducible test plan 2) Lacks new unit tests for the new config options it's adding 3) Adds a new config option that is 'on' by default? I may very well be missing the reasons why it is the way it is, as I'm not familiar with this particular part of the code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added Attachment #188381|0 |1 is obsolete|| --- Comment #35 from Kyle M Hall (khall) --- Created attachment 188383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188383&action=edit Bug 39789: Display the trusted proxy IP addresses and reverse proxy IP header on about page Signed-off-by: Lin Wei Li -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added Attachment #188380|0 |1 is obsolete|| --- Comment #34 from Kyle M Hall (khall) --- Created attachment 188382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188382&action=edit Bug 39789: Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address Some services ( such as CloudFlare ) use alternative heads to X-Forwarded-For. Koha should be able to use a custom header instead of X-Forwarded-For if needed. This patch updates the feature to allow both the custom header and X-Forwarded-For to work harmoniously For example, CloudFlare has it's own custom header. This patch allows a site to be configured for Cloudflare's proxy before the proxy is enabled. Test Plan: 1) prove t/Koha/Middleware/RealIP.t Signed-off-by: Lin Wei Li -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added Attachment #188379|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added Attachment #183215|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added Attachment #182849|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added Attachment #182848|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 --- Comment #31 from Kyle M Hall (khall) --- Created attachment 188380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188380&action=edit Bug 39789: Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address Some services ( such as CloudFlare ) use alternative heads to X-Forwarded-For. Koha should be able to use a custom header instead of X-Forwarded-For if needed. This patch updates the feature to allow both the custom header and X-Forwarded-For to work harmoniously For example, CloudFlare has it's own custom header. This patch allows a site to be configured for Cloudflare's proxy before the proxy is enabled. Test Plan: 1) prove t/Koha/Middleware/RealIP.t Signed-off-by: Lin Wei Li -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 --- Comment #33 from Kyle M Hall (khall) --- Some services ( such as CloudFlare ) use alternative heads to X-Forwarded-For. Koha should be able to use a custom header instead of X-Forwarded-For if needed. This patch updates the feature to allow both the custom header and X-Forwarded-For to work harmoniously For example, CloudFlare has it's own custom header. This patch allows a site to be configured for Cloudflare's proxy before the proxy is enabled. Test Plan: 1) prove t/Koha/Middleware/RealIP.t Signed-off-by: Lin Wei Li -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 --- Comment #32 from Kyle M Hall (khall) --- Created attachment 188381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188381&action=edit Bug 39789: Display the trusted proxy IP addresses and reverse proxy IP header on about page Signed-off-by: Lin Wei Li -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added Attachment #182847|0 |1 is obsolete|| --- Comment #30 from Kyle M Hall (khall) --- Created attachment 188379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188379&action=edit Bug 39789: Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address Some services ( such as CloudFlare ) use alternative heads to X-Forwarded-For. Koha should be able to use a custom header instead of X-Forwarded-For if needed. This patch updates the feature to allow both the custom header and X-Forwarded-For to work harmoniously For example, CloudFlare has it's own custom header. This patch allows a site to be configured for Cloudflare's proxy before the proxy is enabled. Test Plan: 1) prove t/Koha/Middleware/RealIP.t Signed-off-by: Lin Wei Li -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Pedro Amorim changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #29 from Pedro Amorim --- Hi guys, 1) The 4th patch causes t/Koha/Middleware/RealIP.t to fail. 2) Would it also be okay to squash the 1st and 3rd patches? 3rd patch is effectivelly rewriting 3) 4th patch is checking for a require_trusted_proxy_for_headers config. Should this not be added to debian/templates/koha-conf-site.xml.in and possible about.pl + about.tt? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Pedro Amorim changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org |k CC||[email protected] ||k -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 David Cook changed: What|Removed |Added QA Contact|[email protected]|[email protected] ||y.org --- Comment #28 from David Cook --- Sorry I'm going to have to step back on QA for this one, as I've run out of Bugzilla time for a bit... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Martin Renvoize (ashimema) changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org | CC||[email protected] ||o.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added Status|ASSIGNED|Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 --- Comment #27 from Tristin Stagg --- Created attachment 183215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183215&action=edit Bug 39789: Add new "require_trusted_proxy_for_headers" 1) call will check the remote address against the list of trusted proxies first, if configured to do so, right off the bat. This allows us to not have to do this if we do not want to. Particularly useful if i were to tell an Koha server that it could only receive web requests from Cloudflare, or even if i was able to do that at the reverse proxy level. It's configurable so it can be disabled/enabled. a) If trusted, then it parses the header that was determined (from configuration or default X-Forwarded-For) b) Otherwise, it will fall back to the remote address 2) If not configured to check remote address against a trusted proxy, it will just parse the header that was determined. a) If it does not find a value, it will simply return the remote address. 3) "get_real_ip" no longer checks against trusted proxies, as that is done beforehand. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 --- Comment #26 from David Cook --- Planning to come back and review this next week... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 --- Comment #25 from Kyle M Hall (khall) --- Created attachment 182849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182849&action=edit Bug 39789: Check requests for the custom header with fallback to X-Forwarded-For This patch updates the feature to allow both the custom header and X-Forwarded-For to work harmoniously For example, CloudFlare has it's own custom header. This patch allows a site to be configured for Cloudflare's proxy before the proxy is enabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 --- Comment #24 from Kyle M Hall (khall) --- Created attachment 182848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182848&action=edit Bug 39789: Display the trusted proxy IP addresses and reverse proxy IP header on about page Signed-off-by: Lin Wei Li -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added Attachment #182846|0 |1 is obsolete|| --- Comment #23 from Kyle M Hall (khall) --- Created attachment 182847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182847&action=edit Bug 39789: Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address Some services ( such as CloudFlare ) use alternative heads to X-Forwarded-For. Koha should be able to use a custom header instead of X-Forwarded-For if needed. Test Plan: 1) prove t/Koha/Middleware/RealIP.t Signed-off-by: Lin Wei Li -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added Attachment #182842|0 |1 is obsolete|| Attachment #182843|0 |1 is obsolete|| Attachment #182844|0 |1 is obsolete|| --- Comment #22 from Kyle M Hall (khall) --- Created attachment 182846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182846&action=edit Bug 39789: Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address Some services ( such as CloudFlare ) use alternative heads to X-Forwarded-For. Koha should be able to use a custom header instead of X-Forwarded-For if needed. Test Plan: 1) prove t/Koha/Middleware/RealIP.t Signed-off-by: Lin Wei Li -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 --- Comment #21 from Kyle M Hall (khall) --- Created attachment 182844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182844&action=edit Bug 39789: Check requests for the custom header with fallback to X-Forwarded-For This patch updates the feature to allow both the custom header and X-Forwarded-For to work harmoniously For example, CloudFlare has it's own custom header. This patch allows a site to be configured for Cloudflare's proxy before the proxy is enabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 --- Comment #20 from Kyle M Hall (khall) --- Created attachment 182843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182843&action=edit Bug 39789: Display the trusted proxy IP addresses and reverse proxy IP header on about page Signed-off-by: Lin Wei Li -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added Attachment #182395|0 |1 is obsolete|| Attachment #182396|0 |1 is obsolete|| Attachment #182841|0 |1 is obsolete|| --- Comment #19 from Kyle M Hall (khall) --- Created attachment 182842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182842&action=edit Bug 39789: Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address Some services ( such as CloudFlare ) use alternative heads to X-Forwarded-For. Koha should be able to use a custom header instead of X-Forwarded-For if needed. Test Plan: 1) prove t/Koha/Middleware/RealIP.t Signed-off-by: Lin Wei Li -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added Attachment #182397|0 |1 is obsolete|| --- Comment #18 from Kyle M Hall (khall) --- Created attachment 182841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182841&action=edit Bug 39789: Check requests for the custom header with fallback to X-Forwarded-For This patch updates the feature to allow both the custom header and X-Forwarded-For to work harmoniously For example, CloudFlare has it's own custom header. This patch allows a site to be configured for Cloudflare's proxy before the proxy is enabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real IP address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Katrin Fischer changed: What|Removed |Added Summary|Add ability to specify an |Add ability to specify an |alternative header to |alternative header to |X-Forwarded-For for finding |X-Forwarded-For for finding |the real ip address |the real IP address -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 --- Comment #17 from Kyle M Hall (khall) --- Created attachment 182397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182397&action=edit Bug 39789: Check requests for the custom header with fallback to X-Forwarded-For This patch updates the feature to allow both the custom header and X-Forwarded-For to work harmoniously For example, CloudFlare has it's own custom header. This patch allows a site to be configured for Cloudflare's proxy before the proxy is enabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 --- Comment #16 from Kyle M Hall (khall) --- Created attachment 182396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182396&action=edit Bug 39789: Display the trusted proxy IP addresses and reverse proxy IP header on about page Signed-off-by: Lin Wei Li -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added Attachment #182299|0 |1 is obsolete|| Attachment #182300|0 |1 is obsolete|| --- Comment #15 from Kyle M Hall (khall) --- Created attachment 182395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182395&action=edit Bug 39789: Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address Some services ( such as CloudFlare ) use alternative heads to X-Forwarded-For. Koha should be able to use a custom header instead of X-Forwarded-For if needed. Test Plan: 1) prove t/Koha/Middleware/RealIP.t Signed-off-by: Lin Wei Li -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added Attachment #181920|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Lin Wei changed: What|Removed |Added Attachment #181921|0 |1 is obsolete|| --- Comment #14 from Lin Wei --- Created attachment 182300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182300&action=edit Bug 39789: Display the trusted proxy IP addresses and reverse proxy IP header on about page Signed-off-by: Lin Wei Li -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 --- Comment #13 from Lin Wei --- Created attachment 182299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182299&action=edit Bug 39789: Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address Some services ( such as CloudFlare ) use alternative heads to X-Forwarded-For. Koha should be able to use a custom header instead of X-Forwarded-For if needed. Test Plan: 1) prove t/Koha/Middleware/RealIP.t Signed-off-by: Lin Wei Li -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Lin Wei changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 --- Comment #12 from Kyle M Hall (khall) --- Created attachment 181921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181921&action=edit Bug 39789: Display the trusted proxy IP addresses and reverse proxy IP header on about page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added Attachment #181918|0 |1 is obsolete|| Attachment #181919|0 |1 is obsolete|| --- Comment #11 from Kyle M Hall (khall) --- Created attachment 181920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181920&action=edit Bug 39789: Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address Some services ( such as CloudFlare ) use alternative heads to X-Forwarded-For. Koha should be able to use a custom header instead of X-Forwarded-For if needed. Test Plan: 1) prove t/Koha/Middleware/RealIP.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 --- Comment #10 from Kyle M Hall (khall) --- Created attachment 181919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181919&action=edit Bug 39789: Display the trusted proxy IP addresses and reverse proxy IP header on about page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added Attachment #181915|0 |1 is obsolete|| Attachment #181916|0 |1 is obsolete|| Attachment #181917|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall (khall) --- Created attachment 181918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181918&action=edit Bug 39789: Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address Some services ( such as CloudFlare ) use alternative heads to X-Forwarded-For. Koha should be able to use a custom header instead of X-Forwarded-For if needed. Test Plan: 1) prove t/Koha/Middleware/RealIP.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 --- Comment #8 from Kyle M Hall (khall) --- Created attachment 181917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181917&action=edit Bug 39789: Display the trusted proxy IP addresses and reverse proxy IP header on about page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 --- Comment #7 from Kyle M Hall (khall) --- Created attachment 181916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181916&action=edit Bug 39789: Change syspref to config option -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added Attachment #181720|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall (khall) --- Created attachment 181915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181915&action=edit Bug 39789: Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address Some services ( such as CloudFlare ) use alternative heads to X-Forwarded-For. Koha should be able to use a custom header instead of X-Forwarded-For if needed. Test Plan: 1) prove t/Koha/Middleware/RealIP.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 --- Comment #5 from Kyle M Hall (khall) --- (In reply to David Cook from comment #4) > Wouldn't it make more sense to put this in koha-conf.xml alongside > "koha_trusted_proxies"? Agreed! I will get this fixed up! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 David Cook changed: What|Removed |Added CC||[email protected] --- Comment #4 from David Cook --- Wouldn't it make more sense to put this in koha-conf.xml alongside "koha_trusted_proxies"? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added Attachment #181718|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall (khall) --- Created attachment 181720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181720&action=edit Bug 39789 - Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address Some services ( such as CloudFlare ) use alternative heads to X-Forwarded-For. Koha should be able to use a custom header instead of X-Forwarded-For if needed. Test Plan: 1) prove t/Koha/Middleware/RealIP.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Tristin Stagg changed: What|Removed |Added CC||tristin.stagg@bywatersoluti ||ons.com --- Comment #2 from Tristin Stagg --- This looks great Kyle. This will help out a lot! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 --- Comment #1 from Kyle M Hall (khall) --- Created attachment 181718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181718&action=edit Bug 39789 - Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address Some services ( such as CloudFlare ) use alternative heads to X-Forwarded-For. Koha should be able to use a custom header instead of X-Forwarded-For if needed. Test Plan: 1) prove t/Koha/Middleware/RealIP.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39789] Add ability to specify an alternative header to X-Forwarded-For for finding the real ip address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39789 Kyle M Hall (khall) changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
