[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 David Nind changed: What|Removed |Added Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #16 from David Nind --- No updates to the manual required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 Fridolin Somers changed: What|Removed |Added Status|Pushed to stable|Needs documenting --- Comment #15 from Fridolin Somers --- I prefer not push to 24.11.x because it does not have all tidy, there will be a lot remains tabs even with this patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 Fridolin Somers changed: What|Removed |Added Status|Pushed to main |Pushed to stable CC||[email protected] ||m Version(s)|25.11.00|25.11.00,25.05.01 released in|| --- Comment #14 from Fridolin Somers --- I see in 25.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 David Nind changed: What|Removed |Added Text to go in the||This fixes several files by release notes||replacing tabs with spaces ||and makes the QA script ||happy! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 Lucas Gass (lukeg) changed: What|Removed |Added Keywords|rel_25_11_candidate | CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 --- Comment #13 from Lucas Gass (lukeg) --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 Lucas Gass (lukeg) changed: What|Removed |Added Version(s)||25.11.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 --- Comment #12 from Katrin Fischer --- Joubu suggested to wait for 25.11 - OK for me as this is tidy up :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 --- Comment #11 from Katrin Fischer --- (In reply to Martin Renvoize (ashimema) from comment #10) > I had a bit of a look and could spot any side effects.. it really just just > whitespace fixing. So should we still push? (sorry missed this for email not arriving :( ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 Martin Renvoize (ashimema) changed: What|Removed |Added Severity|normal |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 Martin Renvoize (ashimema) changed: What|Removed |Added Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 --- Comment #10 from Martin Renvoize (ashimema) --- I had a bit of a look and could spot any side effects.. it really just just whitespace fixing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 --- Comment #9 from Katrin Fischer --- Are we worried about side-effects here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 Martin Renvoize (ashimema) changed: What|Removed |Added Attachment #182125|0 |1 is obsolete|| --- Comment #7 from Martin Renvoize (ashimema) --- Created attachment 182162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182162&action=edit Bug 39834: Replace some tabs with spaces In order to remove false positives with the QA script we should replace some tabs with spaces. There are more but I wanted to make sure no regression would be introduced Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 Martin Renvoize (ashimema) changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize (ashimema) --- Passing QA, but also marking with rel_25_11_candidate keyword to highlight it's for early push next cycle. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 Martin Renvoize (ashimema) changed: What|Removed |Added QA Contact|[email protected] |[email protected] |y.org |o.uk Keywords||rel_25_11_candidate CC||[email protected] ||o.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 David Cook changed: What|Removed |Added CC||[email protected] --- Comment #5 from David Cook --- When using "git diff -w origin/main", it seems like there's a bit more than just replacing tabs with spaces, but overall they look minor/reasonable. The only one that is a bit weird is in t/db_dependent/Record/Record.t. I think it's replaced a tab with a \t character which is actually wrong? But it's a comment anyway, so it doesn't matter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 --- Comment #6 from David Cook --- After a quick code review, it doesn't look like any whitespace was changed in a way that would affect output. All seems pretty straightforward. I haven't tested either, but probably OK to QA, although this might be better for the next cycle... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 David Nind changed: What|Removed |Added CC||[email protected] --- Comment #4 from David Nind --- I've signed off, but didn't really do any testing for this. Replacing tabs with spaces makes sense to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 David Nind changed: What|Removed |Added Attachment #181923|0 |1 is obsolete|| --- Comment #3 from David Nind --- Created attachment 182125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182125&action=edit Bug 39834: Replace some tabs with spaces In order to remove false positives with the QA script we should replace some tabs with spaces. There are more but I wanted to make sure no regression would be introduced Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 --- Comment #2 from Jonathan Druart --- Well, it's actually not really needed for the QA script. We can skip it if not considered important. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 Jonathan Druart changed: What|Removed |Added Assignee|[email protected] |[email protected] |ity.org | Severity|enhancement |normal Version|24.11 |unspecified -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 Jonathan Druart changed: What|Removed |Added CC||[email protected] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 --- Comment #1 from Jonathan Druart --- Created attachment 181923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181923&action=edit Bug 39834: Replace some tabs with spaces In order to remove false positives with the QA script we should replace some tabs with spaces. There are more but I wanted to make sure no regression would be introduced -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 39834] Tabs need to be replaced with spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39834 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
